)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"670f388c89faa616ac3e329a526df30df6945931","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Support boot from volume for Kubernetes all nodes (master and worker)"},{"line_number":10,"context_line":"so that user can create a big size root volume, which could be more"},{"line_number":11,"context_line":"flexible than using docker_volume_size. And user can specify the"},{"line_number":12,"context_line":"volume type so that user can leverage high performance storage, e.g."},{"line_number":13,"context_line":"NVMe etc."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"And a new label etcd_volme_type is added as well so that user can"},{"line_number":16,"context_line":"set volume type for etcd volume."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"7faddb67_d3745438","line":13,"range":{"start_line":11,"start_character":40,"end_line":13,"end_character":9},"updated":"2019-08-06 14:30:11.000000000","message":"How does this work? Does a volume of the given type and size get created in cinder first and then passed to the nova server create API with the pre-created volume? Or are you leveraging the 2.67 compute API microversion to tell nova to create the volume with the given type?\n\nhttps://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id60\n\nI\u0027d suggest doing the former since otherwise you have to deal with microversion negotiation and knowing whether or not the compute cluster is upgraded to support that parameter.","commit_id":"1c7891adb7af7bd4ef94be78776084cb202acee2"}],"doc/source/user/index.rst":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"58524bd088b6d504226a89ea5ec6cd1b794a8b4f","unresolved":false,"context_lines":[{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"_`boot_volume_type`"},{"line_number":1122,"context_line":"  This label sets the volume type of a boot volume for instances, this is"},{"line_number":1123,"context_line":"  useful if your flavors are boot from volume only.  The default value is 0,"},{"line_number":1124,"context_line":"  meaning that no volume will be created on boot. If it\u0027s not setting by"},{"line_number":1125,"context_line":"  config option default_boot_volume_type, then Magnum will random select"},{"line_number":1126,"context_line":"  one from the list of Cinder volume types."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7faddb67_1748782c","line":1123,"range":{"start_line":1123,"start_character":74,"end_line":1123,"end_character":75},"updated":"2019-09-12 10:31:07.000000000","message":"the default volume type is not 0, but rather \u0027\u0027 as this is a string","commit_id":"c5aaac8dc6891d9d4b8abc7793017ae02d1a36ac"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"58524bd088b6d504226a89ea5ec6cd1b794a8b4f","unresolved":false,"context_lines":[{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"_`etcd_volume_type`"},{"line_number":1133,"context_line":"  This label sets the volume type of a volume holding the etcd storage data."},{"line_number":1134,"context_line":"  The default value is 0, meaning the etcd data is not persisted (no volume)."},{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":"_`container_infra_prefix`"},{"line_number":1137,"context_line":"  Prefix of all container images used in the cluster (kubernetes components,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7faddb67_f7b91c15","line":1134,"range":{"start_line":1134,"start_character":23,"end_line":1134,"end_character":24},"updated":"2019-09-12 10:31:07.000000000","message":"the default volume type is 0, but rather \u0027\u0027 as this is a string","commit_id":"c5aaac8dc6891d9d4b8abc7793017ae02d1a36ac"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"c39ab5b587cb22b7772a33aa0f1e7ab0718186c0","unresolved":false,"context_lines":[{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"_`boot_volume_size`"},{"line_number":1124,"context_line":"  This label sets the size of a boot volume for instances, this is useful if"},{"line_number":1125,"context_line":"  your flavors are boot from volume only.  The default value is 20, setting"},{"line_number":1126,"context_line":"  by config option default_boot_volume_size"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"_`boot_volume_type`"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3fa7e38b_108a931a","line":1125,"range":{"start_line":1125,"start_character":64,"end_line":1125,"end_character":66},"updated":"2019-09-19 09:55:08.000000000","message":"Didn\u0027t we set this to 0?","commit_id":"bbc4818a066844b4ec0dd9cf1b40cb60f84e2113"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"5d34226e8d68cec49c4d6c05579d38e0e3a5543e","unresolved":false,"context_lines":[{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"_`boot_volume_size`"},{"line_number":1124,"context_line":"  This label sets the size of a boot volume for instances, this is useful if"},{"line_number":1125,"context_line":"  your flavors are boot from volume only.  The default value is 0, setting"},{"line_number":1126,"context_line":"  by config option default_boot_volume_size"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"_`boot_volume_type`"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_1dc5bc5b","line":1125,"range":{"start_line":1125,"start_character":67,"end_line":1125,"end_character":74},"updated":"2019-09-20 04:00:38.000000000","message":"set","commit_id":"841922e52c5640f785ff6daf023276ab3f48cd66"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"5d34226e8d68cec49c4d6c05579d38e0e3a5543e","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"_`boot_volume_size`"},{"line_number":1124,"context_line":"  This label sets the size of a boot volume for instances, this is useful if"},{"line_number":1125,"context_line":"  your flavors are boot from volume only.  The default value is 0, setting"},{"line_number":1126,"context_line":"  by config option default_boot_volume_size"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"_`boot_volume_type`"},{"line_number":1129,"context_line":"  This label sets the volume type of a boot volume for instances, this is"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_bda108ac","line":1126,"range":{"start_line":1126,"start_character":19,"end_line":1126,"end_character":43},"updated":"2019-09-20 04:00:38.000000000","message":"Add full stop","commit_id":"841922e52c5640f785ff6daf023276ab3f48cd66"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"b0c4322bf39a8e5296d72db9e6cc5658c4ad4c6d","unresolved":false,"context_lines":[{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"_`boot_volume_type`"},{"line_number":1129,"context_line":"  This label sets the volume type of a boot volume for instances, this is"},{"line_number":1130,"context_line":"  useful if your flavors are boot from volume only.  The default value is 0,"},{"line_number":1131,"context_line":"  meaning that no volume will be created on boot. If it\u0027s not setting by"},{"line_number":1132,"context_line":"  config option default_boot_volume_type, then Magnum will random select"},{"line_number":1133,"context_line":"  one from the list of Cinder volume types."}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_7d571004","line":1130,"updated":"2019-09-20 03:11:42.000000000","message":"Is the default value here 0 or ‘’?","commit_id":"841922e52c5640f785ff6daf023276ab3f48cd66"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"5d34226e8d68cec49c4d6c05579d38e0e3a5543e","unresolved":false,"context_lines":[{"line_number":1128,"context_line":"_`boot_volume_type`"},{"line_number":1129,"context_line":"  This label sets the volume type of a boot volume for instances, this is"},{"line_number":1130,"context_line":"  useful if your flavors are boot from volume only.  The default value is 0,"},{"line_number":1131,"context_line":"  meaning that no volume will be created on boot. If it\u0027s not setting by"},{"line_number":1132,"context_line":"  config option default_boot_volume_type, then Magnum will random select"},{"line_number":1133,"context_line":"  one from the list of Cinder volume types."},{"line_number":1134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_dda404bc","line":1131,"range":{"start_line":1131,"start_character":62,"end_line":1131,"end_character":69},"updated":"2019-09-20 04:00:38.000000000","message":"set","commit_id":"841922e52c5640f785ff6daf023276ab3f48cd66"}],"magnum/conf/cinder.py":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"c16cde9fd7ad3bdc41f7f4286c5439910bdd31f1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                      \u0027value. Otherwise, Magnum will select random one from \u0027"},{"line_number":46,"context_line":"                      \u0027Cinder volume type list.\u0027)),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027default_boot_volume_size\u0027,"},{"line_number":48,"context_line":"               default\u003d20,"},{"line_number":49,"context_line":"               help\u003d_(\u0027The default volume size to use for volumes \u0027"},{"line_number":50,"context_line":"                      \u0027used for VM of COE.\u0027))"},{"line_number":51,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":18,"id":"3fa7e38b_ca01d5b1","line":48,"range":{"start_line":48,"start_character":23,"end_line":48,"end_character":25},"updated":"2019-09-17 14:36:40.000000000","message":"0","commit_id":"288fcfa0d9994ad7a20626174f32fc57484032b6"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"c16cde9fd7ad3bdc41f7f4286c5439910bdd31f1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                      \u0027value. Otherwise, Magnum will select random one from \u0027"},{"line_number":46,"context_line":"                      \u0027Cinder volume type list.\u0027)),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027default_boot_volume_size\u0027,"},{"line_number":48,"context_line":"               default\u003d20,"},{"line_number":49,"context_line":"               help\u003d_(\u0027The default volume size to use for volumes \u0027"},{"line_number":50,"context_line":"                      \u0027used for VM of COE.\u0027))"},{"line_number":51,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":19,"id":"3fa7e38b_90e8ea16","line":48,"range":{"start_line":48,"start_character":23,"end_line":48,"end_character":25},"updated":"2019-09-17 14:36:40.000000000","message":"With this 0, +2.\n\ntested with or without volume","commit_id":"6a239a87c9a5ffb84cfdd615481e10711d9dd565"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"70ea3542bd86fc25b9d6fb519fd7d28b7f35aaf8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                      \u0027value. Otherwise, Magnum will select random one from \u0027"},{"line_number":46,"context_line":"                      \u0027Cinder volume type list.\u0027)),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027default_boot_volume_size\u0027,"},{"line_number":48,"context_line":"               default\u003d20,"},{"line_number":49,"context_line":"               help\u003d_(\u0027The default volume size to use for volumes \u0027"},{"line_number":50,"context_line":"                      \u0027used for VM of COE.\u0027))"},{"line_number":51,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":19,"id":"3fa7e38b_d6cbb71b","line":48,"range":{"start_line":48,"start_character":23,"end_line":48,"end_character":25},"in_reply_to":"3fa7e38b_90e8ea16","updated":"2019-09-17 19:38:39.000000000","message":"No problem, I will post a new patch set soon.","commit_id":"6a239a87c9a5ffb84cfdd615481e10711d9dd565"}],"magnum/drivers/common/templates/fragments/server_with_root_volume.yaml":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"9af2c99e14887334af97cb66d0dbe36cb755b9b4","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      availability_zone: {get_param: availability_zone}"},{"line_number":59,"context_line":"      block_device_mapping_v2:"},{"line_number":60,"context_line":"        - boot_index: 0"},{"line_number":61,"context_line":"          volume_id: {get_resource: kube_master_volume}"},{"line_number":62,"context_line":"          delete_on_termination: true"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"outputs:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7faddb67_4ac485f5","line":61,"range":{"start_line":61,"start_character":36,"end_line":61,"end_character":54},"updated":"2019-07-31 03:51:25.000000000","message":"It should be kube_node_volume.","commit_id":"110c18bc2bccd3f948e82d5daa034a96b95838be"}],"magnum/drivers/heat/k8s_fedora_template_def.py":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"7f348f125a7bf0539b7add4c122db60c35384078","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            \u0027boot_volume_type\u0027, cinder.get_default_boot_volume_type(context))"},{"line_number":194,"context_line":"        extra_params[\u0027boot_volume_type\u0027] \u003d boot_volume_type"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        # set boot_volume_size"},{"line_number":197,"context_line":"        boot_volume_size \u003d cluster.labels.get("},{"line_number":198,"context_line":"            \u0027boot_volume_size\u0027, CONF.cinder.default_boot_volume_size)"},{"line_number":199,"context_line":"        extra_params[\u0027boot_volume_size\u0027] \u003d boot_volume_size"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def get_env_files(self, cluster_template, cluster):"},{"line_number":202,"context_line":"        env_files \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fb8cfa7_c734c395","line":199,"range":{"start_line":196,"start_character":0,"end_line":199,"end_character":59},"updated":"2019-06-12 09:13:24.000000000","message":"why make this opt-out? let\u0027s make it opt in.","commit_id":"e4869fbabda6595b0ce5cf90d963188809fa889f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"915ecc02388f9db33a10c8929221cd17b6330c7d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self._set_cert_manager_params(cluster, extra_params)"},{"line_number":162,"context_line":"        self._get_keystone_auth_default_policy(extra_params)"},{"line_number":163,"context_line":"        self._set_volumes(context, cluster, extra_params)"},{"line_number":164,"context_line":"        extra_params[\u0027project_id\u0027] \u003d cluster.project_id"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        return super(K8sFedoraTemplateDefinition,"},{"line_number":167,"context_line":"                     self).get_params(context, cluster_template, cluster,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5faad753_da7d7ab2","line":164,"updated":"2019-09-16 09:08:52.000000000","message":"why is this here?\n\nwe have it already\n\nhttps://review.opendev.org/#/c/621734/17/magnum/drivers/heat/k8s_fedora_template_def.py@156","commit_id":"57e532337e401f81ac9a066bfd768fd266adacbe"}],"magnum/drivers/k8s_fedora_atomic_v1/templates/kubemaster.yaml":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"398c873b360ba09089850593188cdb797dfee36c","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        - port: {get_resource: kube_master_eth0}"},{"line_number":684,"context_line":"      scheduler_hints: { group: { get_param: nodes_server_group_id }}"},{"line_number":685,"context_line":"      availability_zone: {get_param: availability_zone}"},{"line_number":686,"context_line":"      block_device_mapping_v2:"},{"line_number":687,"context_line":"        - boot_index: 0"},{"line_number":688,"context_line":"          delete_on_termination: true"},{"line_number":689,"context_line":"          volume_id: {get_resource: boot_volume}"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"  kube_master_eth0:"},{"line_number":692,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fce034c_7f8897c5","line":689,"range":{"start_line":686,"start_character":6,"end_line":689,"end_character":48},"updated":"2019-04-12 13:52:27.000000000","message":"This should be conditional like PS1","commit_id":"40fde4c5f3e58c60e3e34e5b0086747906adff79"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"abb9ab3a9b0b79ff972b07c916338755a54e59a8","unresolved":false,"context_lines":[{"line_number":730,"context_line":"  # do NOT use \"_\" (underscore) in the Nova server name"},{"line_number":731,"context_line":"  # it creates a mismatch between the generated Nova name and its hostname"},{"line_number":732,"context_line":"  # which can lead to weird problems"},{"line_number":733,"context_line":"  kube-master:"},{"line_number":734,"context_line":"    type: OS::Nova::Server"},{"line_number":735,"context_line":"    properties:"},{"line_number":736,"context_line":"      name: {get_param: name}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_bbd35a38","line":733,"updated":"2019-06-05 15:30:01.000000000","message":"The simplest I could think of, is with duplication:\nheat_template_version: queens\n\nparameters:\n  bfv:\n    type: boolean\n    default: false\n\nconditions:\n  bfv:\n    equals:\n    - get_param: bfv\n    - true\n  not_bfv:\n    equals:\n    - get_param: bfv\n    - false\n\nresources:\n  kube-minion:\n    condition: not_bfv\n    type: OS::Nova::Server\n    properties:\n      image: 26666ca8-bda9-4356-982f-4a92845ec361\n      flavor: m2.small\n\n  kube-minion:\n    condition: bfv\n    type: OS::Nova::Server\n    properties:\n      block_device_mapping_v2: [{boot_index: 0, image: 26666ca8-bda9-4356-982f-4a92845ec361, volume_size: 10, delete_on_termination: true}]\n      flavor: m2.small\n\nif fine with it","commit_id":"e4869fbabda6595b0ce5cf90d963188809fa889f"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"52f004eb67b1db789b661a4e5c80d8b9caf86979","unresolved":false,"context_lines":[{"line_number":730,"context_line":"  # do NOT use \"_\" (underscore) in the Nova server name"},{"line_number":731,"context_line":"  # it creates a mismatch between the generated Nova name and its hostname"},{"line_number":732,"context_line":"  # which can lead to weird problems"},{"line_number":733,"context_line":"  kube-master:"},{"line_number":734,"context_line":"    type: OS::Nova::Server"},{"line_number":735,"context_line":"    properties:"},{"line_number":736,"context_line":"      name: {get_param: name}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9fb8cfa7_431a396f","line":733,"in_reply_to":"9fb8cfa7_bbd35a38","updated":"2019-06-10 03:48:41.000000000","message":"Did you test it? In my testing, I got below error:\n\nERROR: InvalidTemplateReference: : resources.kube_masters\u003cnested_stack\u003e.resources.0\u003cfile:///home/feilong/stack/magnum/magnum/drivers/k8s_fedora_atomic_v1/templates/kubemaster.yaml\u003e: : The specified reference \"kube-master\" (in etcd_volume_attach.Properties.instance_uuid) is incorrect.","commit_id":"e4869fbabda6595b0ce5cf90d963188809fa889f"}]}