)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"296ae9523cc3ee14c13d729c5dd755988ef32a4d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bharat Kunwar \u003cb.kunwar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-01-31 12:16:47 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Convert fixed_subnet name to uuid so that OCCM does not error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2002652"},{"line_number":10,"context_line":"Task: 28816"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_c886ef66","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":46},"updated":"2019-02-01 12:33:02.000000000","message":"OCCM?","commit_id":"b3fc599b265840a165d8ec9a572431a4d0122e8a"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"1689e96db35a9bcff1a7f58f58dcaca1ba4fef14","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bharat Kunwar \u003cb.kunwar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-01-31 12:16:47 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Convert fixed_subnet name to uuid so that OCCM does not error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2002652"},{"line_number":10,"context_line":"Task: 28816"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_df61c2d4","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":46},"in_reply_to":"9fdfeff1_c886ef66","updated":"2019-02-01 14:42:24.000000000","message":"Openstack Cloud Controller Manager","commit_id":"b3fc599b265840a165d8ec9a572431a4d0122e8a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"296ae9523cc3ee14c13d729c5dd755988ef32a4d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Convert fixed_subnet name to uuid so that OCCM does not error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2002652"},{"line_number":10,"context_line":"Task: 28816"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie70bc00f5617ef94c39c9faea7d39617ee01b07b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_a87feb63","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":11},"updated":"2019-02-01 12:33:02.000000000","message":"I think these are wrong.","commit_id":"b3fc599b265840a165d8ec9a572431a4d0122e8a"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"7b5ffc10def48e4176b38d4b1f76f021f6f7a220","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Convert fixed_subnet name to uuid so that OCCM does not error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2002652"},{"line_number":10,"context_line":"Task: 28816"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie70bc00f5617ef94c39c9faea7d39617ee01b07b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_df8f8272","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":11},"in_reply_to":"9fdfeff1_a87feb63","updated":"2019-02-01 14:55:49.000000000","message":"I think so too","commit_id":"b3fc599b265840a165d8ec9a572431a4d0122e8a"}],"magnum/common/neutron.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"25f25cf1bec9699d432cecce08c3bb20375fd9a3","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    n_client \u003d clients.OpenStackClients(context).neutron()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    subnets \u003d n_client.list_subnets()"},{"line_number":104,"context_line":"    for net in subnets.get(\u0027subnets\u0027):"},{"line_number":105,"context_line":"        if net.get(source) \u003d\u003d subnet:"},{"line_number":106,"context_line":"            nets.append(net)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_4ad35ad6","line":104,"updated":"2019-10-07 20:59:08.000000000","message":"Instead of listing all subnets, I\u0027m pretty sure neutron client support filter like this:\n\nfilter \u003d {source: subnet}\nsubnets \u003d n_client.list_subnets(**filter).get(\u0027subnets\u0027, [])\n\nSame for network, so it would be nice if you can update the get_network function as well.","commit_id":"62f666d4b54158169d7403e7da1f273f949720d8"}],"magnum/drivers/heat/k8s_template_def.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"d9564081cfacfb306c256cc0c2e4639608b4c4ed","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if cluster_template.fixed_subnet:"},{"line_number":101,"context_line":"            fixed_subnets \u003d osc.neutron().list_subnets("},{"line_number":102,"context_line":"                name\u003dcluster_template.fixed_subnet).get(\u0027subnets\u0027)"},{"line_number":103,"context_line":"            if fixed_subnets:"},{"line_number":104,"context_line":"                cluster_template.fixed_subnet \u003d fixed_subnets.pop().get(\u0027id\u0027)"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_4b90c695","line":102,"updated":"2019-01-31 19:46:12.000000000","message":"From the commit message, I can\u0027t fully understand what\u0027s the problem. So is this only happening when use pass in an existing subnet? And what will happen if the fixed_subnet is  an id already?","commit_id":"b3fc599b265840a165d8ec9a572431a4d0122e8a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"296ae9523cc3ee14c13d729c5dd755988ef32a4d","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if cluster_template.fixed_subnet:"},{"line_number":101,"context_line":"            fixed_subnets \u003d osc.neutron().list_subnets("},{"line_number":102,"context_line":"                name\u003dcluster_template.fixed_subnet).get(\u0027subnets\u0027)"},{"line_number":103,"context_line":"            if fixed_subnets:"},{"line_number":104,"context_line":"                cluster_template.fixed_subnet \u003d fixed_subnets.pop().get(\u0027id\u0027)"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_48b19f46","line":102,"in_reply_to":"9fdfeff1_4b90c695","updated":"2019-02-01 12:33:02.000000000","message":"Good point. How about using oslo_utils.uuidutils.is_uuid_like()?","commit_id":"b3fc599b265840a165d8ec9a572431a4d0122e8a"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"2ec25ba9a4ac84fd71d060ccd3ae26ffdd39d851","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if cluster_template.fixed_subnet:"},{"line_number":101,"context_line":"            fixed_subnets \u003d osc.neutron().list_subnets("},{"line_number":102,"context_line":"                name\u003dcluster_template.fixed_subnet).get(\u0027subnets\u0027)"},{"line_number":103,"context_line":"            if fixed_subnets:"},{"line_number":104,"context_line":"                cluster_template.fixed_subnet \u003d fixed_subnets.pop().get(\u0027id\u0027)"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_6848232c","line":102,"in_reply_to":"9fdfeff1_4b90c695","updated":"2019-02-01 12:41:02.000000000","message":"This is only happening when we are passing in an existing subnet. If the subnet is an id already, the value of fixed_subnet remains unchanged since there will be no match.","commit_id":"b3fc599b265840a165d8ec9a572431a4d0122e8a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"296ae9523cc3ee14c13d729c5dd755988ef32a4d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        if cluster_template.fixed_subnet:"},{"line_number":101,"context_line":"            fixed_subnets \u003d osc.neutron().list_subnets("},{"line_number":102,"context_line":"                name\u003dcluster_template.fixed_subnet).get(\u0027subnets\u0027)"},{"line_number":103,"context_line":"            if fixed_subnets:"},{"line_number":104,"context_line":"                cluster_template.fixed_subnet \u003d fixed_subnets.pop().get(\u0027id\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        if cluster_template.tls_disabled:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_288bfb67","line":103,"range":{"start_line":103,"start_character":12,"end_line":103,"end_character":29},"updated":"2019-02-01 12:33:02.000000000","message":"What should we do if no subnet was found? Or more than one?","commit_id":"b3fc599b265840a165d8ec9a572431a4d0122e8a"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"2ec25ba9a4ac84fd71d060ccd3ae26ffdd39d851","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        if cluster_template.fixed_subnet:"},{"line_number":101,"context_line":"            fixed_subnets \u003d osc.neutron().list_subnets("},{"line_number":102,"context_line":"                name\u003dcluster_template.fixed_subnet).get(\u0027subnets\u0027)"},{"line_number":103,"context_line":"            if fixed_subnets:"},{"line_number":104,"context_line":"                cluster_template.fixed_subnet \u003d fixed_subnets.pop().get(\u0027id\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        if cluster_template.tls_disabled:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fdfeff1_a85b6bf3","line":103,"range":{"start_line":103,"start_character":12,"end_line":103,"end_character":29},"in_reply_to":"9fdfeff1_288bfb67","updated":"2019-02-01 12:41:02.000000000","message":"Same as above, the value of fixed_subnet remains unchanged. If there is more than one, the first subnet is picked.","commit_id":"b3fc599b265840a165d8ec9a572431a4d0122e8a"}]}