)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"6d42d5b099f2ead134fce8b653fb17ad6c2e2017","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Diogo Guerra \u003cdiogo.filipe.tomas.guerra@cern.ch\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-08 14:35:23 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":" [k8s] Update metrics-server"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Magnum allows to use CONTAINER_INFRA_PREFIX to specify a local"},{"line_number":10,"context_line":"repository from which we can pull container images. This repository"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_59ab68d6","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":1},"updated":"2019-11-27 14:30:15.000000000","message":"nit: remove space","commit_id":"1dc2dce48081903283a380c38ade23863bd17753"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"6d42d5b099f2ead134fce8b653fb17ad6c2e2017","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from the specified repo."},{"line_number":17,"context_line":"* Add label metrics_server_tag to allow user to specify container"},{"line_number":18,"context_line":"image"},{"line_number":19,"context_line":"* Add label metrics_Server_enabled to allow enable/disable of"},{"line_number":20,"context_line":"component (defaults: true)"},{"line_number":21,"context_line":"* Updated the release features and added deprecation notice for"},{"line_number":22,"context_line":"heapster"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_997a4075","line":19,"range":{"start_line":19,"start_character":20,"end_line":19,"end_character":21},"updated":"2019-11-27 14:30:15.000000000","message":"small","commit_id":"1dc2dce48081903283a380c38ade23863bd17753"}],"doc/source/user/index.rst":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"ec792847dea026b1c7a326bb937257de291b08b8","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"  metrics_server_enabled is used to enable disable the installation of"},{"line_number":1205,"context_line":"  the metrics server. To use this service tiller_enabled must be true."},{"line_number":1206,"context_line":"  Train default: true"},{"line_number":1207,"context_line":"  Stein default: enabled"},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"_`cloud_provider_tag`"},{"line_number":1210,"context_line":"  This label allows users to select `a specific release for the openstack"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_12d62df4","line":1207,"range":{"start_line":1207,"start_character":17,"end_line":1207,"end_character":24},"updated":"2019-11-28 13:14:21.000000000","message":"true","commit_id":"33611fb83ed99cbbf746e825d19fda54022e9ded"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"ade075504c80d6a20b94b5eecf0081a616597340","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"  metrics_server_enabled is used to enable disable the installation of"},{"line_number":1205,"context_line":"  the metrics server. To use this service tiller_enabled must be true."},{"line_number":1206,"context_line":"  Train default: true"},{"line_number":1207,"context_line":"  Stein default: enabled"},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"_`cloud_provider_tag`"},{"line_number":1210,"context_line":"  This label allows users to select `a specific release for the openstack"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3fa7e38b_6890d497","line":1207,"range":{"start_line":1207,"start_character":17,"end_line":1207,"end_character":24},"in_reply_to":"3fa7e38b_12d62df4","updated":"2019-11-28 14:33:34.000000000","message":"actually, in stein there is no true false. It\u0027s always enable with tiller. Thats why it is enable (i can change if it is confusing?)","commit_id":"33611fb83ed99cbbf746e825d19fda54022e9ded"}],"magnum/drivers/common/templates/fragments/configure-docker-registry.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"71b8e6bf9454fceffb5f4aca8e710d968821859c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":43,"context_line":"EOF"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3fa7e38b_f6959e3e","line":45,"updated":"2019-12-16 11:15:29.000000000","message":"?","commit_id":"5b2fcb06312266b0c4ee7138c8f54bf5192d743b"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"2988f9516a2f4a29d096e5b4f76bab42b11f60cd","unresolved":false,"context_lines":[{"line_number":42,"context_line":"WantedBy\u003dmulti-user.target"},{"line_number":43,"context_line":"EOF"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3fa7e38b_1950ad5f","line":45,"in_reply_to":"3fa7e38b_f6959e3e","updated":"2019-12-16 12:10:03.000000000","message":"This was because the pep8 validation was breaking because a NL was missing here... don\u0027t ask me why but fixind this worked","commit_id":"5b2fcb06312266b0c4ee7138c8f54bf5192d743b"}],"magnum/drivers/common/templates/kubernetes/fragments/install-helm-modules.sh":[{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"2388ca40793ee1542643f78c8c9081e83a029989","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    echo \"Use --labels tiller_enabled\u003dTrue to allow for tiller dependent resources to be installed\""},{"line_number":18,"context_line":"else"},{"line_number":19,"context_line":"    HELM_MODULES_PATH\u003d\"/srv/magnum/kubernetes/helm\""},{"line_number":20,"context_line":"    chmod +x ${HELM_MODULES_PATH}/*"},{"line_number":21,"context_line":"    helm_modules\u003d(${HELM_MODULES_PATH}/*)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    for module in \"${helm_modules[@]}\"; do"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3fa7e38b_743d662a","side":"PARENT","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":35},"updated":"2019-12-11 12:16:44.000000000","message":"this exits with \necho $? \u003d\u003e 1","commit_id":"ef061ce86f50ccb9011c1515a9c6936d29fa265c"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"0aff12580d6ff3cd176c10b07d23708a8c2fbadf","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    echo \"Use --labels tiller_enabled\u003dTrue to allow for tiller dependent resources to be installed\""},{"line_number":18,"context_line":"else"},{"line_number":19,"context_line":"    HELM_MODULES_PATH\u003d\"/srv/magnum/kubernetes/helm\""},{"line_number":20,"context_line":"    chmod +x ${HELM_MODULES_PATH}/*"},{"line_number":21,"context_line":"    helm_modules\u003d(${HELM_MODULES_PATH}/*)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    for module in \"${helm_modules[@]}\"; do"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3fa7e38b_471c1a65","side":"PARENT","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":35},"in_reply_to":"3fa7e38b_6e6cae32","updated":"2019-12-13 11:16:16.000000000","message":"Lets drop it as we do not need +x on yaml files, only need to be able to read them.","commit_id":"ef061ce86f50ccb9011c1515a9c6936d29fa265c"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"60a1f86a8208d007302a698bd359dcb9dfe92337","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    echo \"Use --labels tiller_enabled\u003dTrue to allow for tiller dependent resources to be installed\""},{"line_number":18,"context_line":"else"},{"line_number":19,"context_line":"    HELM_MODULES_PATH\u003d\"/srv/magnum/kubernetes/helm\""},{"line_number":20,"context_line":"    chmod +x ${HELM_MODULES_PATH}/*"},{"line_number":21,"context_line":"    helm_modules\u003d(${HELM_MODULES_PATH}/*)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    for module in \"${helm_modules[@]}\"; do"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3fa7e38b_9466e254","side":"PARENT","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":35},"in_reply_to":"3fa7e38b_743d662a","updated":"2019-12-11 12:18:54.000000000","message":"maybe do this per file?","commit_id":"ef061ce86f50ccb9011c1515a9c6936d29fa265c"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"9bec25ae8738bdec8401c972f700e82e2b2b33da","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    echo \"Use --labels tiller_enabled\u003dTrue to allow for tiller dependent resources to be installed\""},{"line_number":18,"context_line":"else"},{"line_number":19,"context_line":"    HELM_MODULES_PATH\u003d\"/srv/magnum/kubernetes/helm\""},{"line_number":20,"context_line":"    chmod +x ${HELM_MODULES_PATH}/*"},{"line_number":21,"context_line":"    helm_modules\u003d(${HELM_MODULES_PATH}/*)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    for module in \"${helm_modules[@]}\"; do"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3fa7e38b_6e6cae32","side":"PARENT","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":35},"in_reply_to":"3fa7e38b_9466e254","updated":"2019-12-11 20:14:05.000000000","message":"I actually just dropped it\n\nor we use -f","commit_id":"ef061ce86f50ccb9011c1515a9c6936d29fa265c"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"03ec44f08ff4cc8d5ba1b0cb68ae469947b33b39","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    echo \"Use --labels tiller_enabled\u003dTrue to allow for tiller dependent resources to be installed\""},{"line_number":18,"context_line":"else"},{"line_number":19,"context_line":"    HELM_MODULES_PATH\u003d\"/srv/magnum/kubernetes/helm\""},{"line_number":20,"context_line":"    mkdir -p ${HELM_MODULES_PATH}"},{"line_number":21,"context_line":"    helm_modules\u003d(${HELM_MODULES_PATH}/*)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    # Only run kubectl if we have modules to install"},{"line_number":24,"context_line":"    if [ \"$(echo ${helm_modules[@]} | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" !\u003d \"$(echo ${HELM_MODULES_PATH}\"/*\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" ]; then"},{"line_number":25,"context_line":"        for module in \"${helm_modules[@]}\"; do"},{"line_number":26,"context_line":"            echo \"\""},{"line_number":27,"context_line":"            kubectl apply -f ${module}"},{"line_number":28,"context_line":"        done"},{"line_number":29,"context_line":"    fi"},{"line_number":30,"context_line":"fi"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"printf \"Finished running ${step}\\n\""}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_0a405f5f","line":29,"range":{"start_line":20,"start_character":0,"end_line":29,"end_character":6},"updated":"2019-12-13 23:03:33.000000000","message":"This seems overly complicated. Cant we just do something like this:\n\n    # Only run kubectl if we have modules to install\n    if [ \"${helm_modules}\" !\u003d \"${HELM_MODULES_PATH}/*\" ]; then\n        for module in \"${helm_modules[@]}\"; do\n            echo \"Applying ${module}.\"\n            kubectl apply -f ${module}\n        done\n    fi","commit_id":"d62eb4c846b85bce09796f33e8caff918004ed35"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"5a7969adfeb4fb4798d40a5955ddfc910388275b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    echo \"Use --labels tiller_enabled\u003dTrue to allow for tiller dependent resources to be installed\""},{"line_number":18,"context_line":"else"},{"line_number":19,"context_line":"    HELM_MODULES_PATH\u003d\"/srv/magnum/kubernetes/helm\""},{"line_number":20,"context_line":"    mkdir -p ${HELM_MODULES_PATH}"},{"line_number":21,"context_line":"    helm_modules\u003d(${HELM_MODULES_PATH}/*)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    # Only run kubectl if we have modules to install"},{"line_number":24,"context_line":"    if [ \"$(echo ${helm_modules[@]} | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" !\u003d \"$(echo ${HELM_MODULES_PATH}\"/*\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" ]; then"},{"line_number":25,"context_line":"        for module in \"${helm_modules[@]}\"; do"},{"line_number":26,"context_line":"            echo \"\""},{"line_number":27,"context_line":"            kubectl apply -f ${module}"},{"line_number":28,"context_line":"        done"},{"line_number":29,"context_line":"    fi"},{"line_number":30,"context_line":"fi"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"printf \"Finished running ${step}\\n\""}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_8db9c917","line":29,"range":{"start_line":20,"start_character":0,"end_line":29,"end_character":6},"in_reply_to":"3fa7e38b_0a405f5f","updated":"2019-12-13 23:32:18.000000000","message":"It is not obvious to me what purpose `tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027` serves.","commit_id":"d62eb4c846b85bce09796f33e8caff918004ed35"}],"releasenotes/notes/helm-install-metrics-service-cd18be76c4ed0e5f.yaml":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"6d42d5b099f2ead134fce8b653fb17ad6c2e2017","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    heapster as a cluster wide metrics reporting service used by schedulling,"},{"line_number":6,"context_line":"    HPA and others. This service is installed and configured using helm and so"},{"line_number":7,"context_line":"    tiller_enabled flag must be True. Heapster service is maintained active to"},{"line_number":8,"context_line":"    allow compatibility. The label metrics_server_tag can be used to specify the"},{"line_number":9,"context_line":"    metrics-server container tag to be used. The label metrics_server_enabled is"},{"line_number":10,"context_line":"    used to enable disable the installation of the metrics server"},{"line_number":11,"context_line":"    (default: true)."},{"line_number":12,"context_line":"deprecations:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    Heapster marked for deprecation on a future release but enabled by default."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_801df963","line":14,"range":{"start_line":8,"start_character":25,"end_line":14,"end_character":79},"updated":"2019-11-27 14:30:15.000000000","message":"Please generate a new reno","commit_id":"1dc2dce48081903283a380c38ade23863bd17753"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"71b8e6bf9454fceffb5f4aca8e710d968821859c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Installs the metrics-server service that is replacing kubernetes deprecated"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_d6a662ad","side":"PARENT","line":1,"updated":"2019-12-16 11:15:29.000000000","message":"don\u0027t delete release notes. Addd new ones.","commit_id":"3f3b5bfa8adca58307de0484fe5a073606e71c63"}]}