)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"643d6b24041c42dd4c62b26318e5a7370bedb001","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[k8s-fedora-atomic] Security group definition for worker nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Rather than allowing all the inbound traffic to worker nodes, this patch"},{"line_number":10,"context_line":"explicitly defines the security group rules."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Idbc67cb95133d3a4029105e6d4dc92519c816288"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_1e78238d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":61},"updated":"2019-02-23 16:32:49.000000000","message":"this is not needed.\n\nYou can mention only that you create rules for the components you do. eg:\n\nAdd security groups rules for:\n* calico\n* flannel\n* kubelet healthcheck\n* high number ports for kubernetes services","commit_id":"37c9d72ec13354f3252d839e7632de3acb3821f5"}],"magnum/drivers/k8s_fedora_atomic_v1/templates/kubecluster.yaml":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"6078cfffeb94edc366d6a350322af854b2916e9c","unresolved":false,"context_lines":[{"line_number":661,"context_line":"        - protocol: udp"},{"line_number":662,"context_line":"          port_range_min: 8472"},{"line_number":663,"context_line":"          port_range_max: 8472"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"  ######################################################################"},{"line_number":666,"context_line":"  #"},{"line_number":667,"context_line":"  # resources that expose the IPs of either the kube master or a given"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_d2593e5b","line":664,"updated":"2019-02-22 15:59:29.000000000","message":"We probably also need port for Heapster https://github.com/openstack/magnum/blob/master/magnum/drivers/common/templates/kubernetes/fragments/kube-dashboard-service.sh#L398","commit_id":"37c9d72ec13354f3252d839e7632de3acb3821f5"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"dadff8bfa6911912fc26a518b6609f89e460b2d7","unresolved":false,"context_lines":[{"line_number":661,"context_line":"        - protocol: udp"},{"line_number":662,"context_line":"          port_range_min: 8472"},{"line_number":663,"context_line":"          port_range_max: 8472"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"  ######################################################################"},{"line_number":666,"context_line":"  #"},{"line_number":667,"context_line":"  # resources that expose the IPs of either the kube master or a given"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_e0b027e0","line":664,"in_reply_to":"9fdfeff1_8044bb48","updated":"2019-02-22 22:03:54.000000000","message":"Ah, right. I missed it. All good.","commit_id":"37c9d72ec13354f3252d839e7632de3acb3821f5"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"0e8bd8c0b7cde696eaef654e34888c2641382042","unresolved":false,"context_lines":[{"line_number":661,"context_line":"        - protocol: udp"},{"line_number":662,"context_line":"          port_range_min: 8472"},{"line_number":663,"context_line":"          port_range_max: 8472"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"  ######################################################################"},{"line_number":666,"context_line":"  #"},{"line_number":667,"context_line":"  # resources that expose the IPs of either the kube master or a given"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_8044bb48","line":664,"in_reply_to":"9fdfeff1_d2593e5b","updated":"2019-02-22 21:34:21.000000000","message":"The type of `targetPort ` for heapster is not NodePort","commit_id":"37c9d72ec13354f3252d839e7632de3acb3821f5"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"5adde81fc995d0dc02e2af05e2305d11eee8f565","unresolved":false,"context_lines":[{"line_number":637,"context_line":"    type: OS::Neutron::SecurityGroup"},{"line_number":638,"context_line":"    properties:"},{"line_number":639,"context_line":"      rules:"},{"line_number":640,"context_line":"        - protocol: icmp"},{"line_number":641,"context_line":"        - protocol: tcp"},{"line_number":642,"context_line":"        - protocol: udp"},{"line_number":643,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_82d8f651","side":"PARENT","line":640,"range":{"start_line":640,"start_character":20,"end_line":640,"end_character":24},"updated":"2019-02-27 10:33:43.000000000","message":"Can we not remove icmp please? Its useful to be able to ping nodes.","commit_id":"91d84ff01d0772388f415a858ec1cf88c1dd62e8"}]}