)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4b2123ba1c8df55de252df32326387590903cb88","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve floating_ip_enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Never allocate floating IP for etcd service and worker nodes, no"},{"line_number":10,"context_line":"  matter `floating_ip_enabled` is set or not."},{"line_number":11,"context_line":"- Do not allocate floating IP for master nodes if `master_lb_enabled`"},{"line_number":12,"context_line":"  is set."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5fc1f717_8ac7cc64","line":10,"updated":"2019-03-15 07:55:07.000000000","message":"I thought we discussed this. floating_ip_enabled means all nodes have fips.\n\nfloating_ip_enabled\u003dfalse means no vm have fips.\n\n\nfloating_ip_enabled\u003dfalse with master_lb_enabled plus a new label, we have  [\"no vm with fips\", \"LB with a fip\"]","commit_id":"4116676e7f4d115238464bdbc7a55ef841d1db91"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"7d366e467d21007e1f43e5bac7395cdeb8cb7b1f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve floating_ip_enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Never allocate floating IP for etcd service and worker nodes, no"},{"line_number":10,"context_line":"  matter `floating_ip_enabled` is set or not."},{"line_number":11,"context_line":"- Do not allocate floating IP for master nodes if `master_lb_enabled`"},{"line_number":12,"context_line":"  is set."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5fc1f717_ed1f5805","line":10,"in_reply_to":"5fc1f717_8ac7cc64","updated":"2019-03-15 09:54:33.000000000","message":"You are looking at previous patchset :-)","commit_id":"4116676e7f4d115238464bdbc7a55ef841d1db91"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"43cdefc8e928f8cfbb83eaeb4557eabf19567b55","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve floating IP allocation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Never allocate floating IP for etcd service."},{"line_number":10,"context_line":"- Introduce a new label `master_lb_floating_ip_enabled` which controls"},{"line_number":11,"context_line":"  if Magnum allocates floating IP for the master load balancer. This"},{"line_number":12,"context_line":"  label only takes effect when the `master_lb_enabled` is set. The"},{"line_number":13,"context_line":"  default value is the same with `floating_ip_enabled`."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5fc1f717_ad42b0a9","line":10,"range":{"start_line":10,"start_character":25,"end_line":10,"end_character":54},"updated":"2019-03-15 10:03:09.000000000","message":"If master_lb_enabled is true,","commit_id":"af9a879691ac09b0bf97e031c5ce8cc11579b53e"}],"doc/source/user/index.rst":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"43cdefc8e928f8cfbb83eaeb4557eabf19567b55","unresolved":false,"context_lines":[{"line_number":380,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":381,"context_line":"| `tiller_tag`_                         | see below          | \"\"            |"},{"line_number":382,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":383,"context_line":"| `tiller_namespace`_                   | see below          | see below     |"},{"line_number":384,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":385,"context_line":"| `tiller_namespace`_                   | see below          | see below     |"},{"line_number":386,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":387,"context_line":"| `master_lb_floating_ip_enabled`_      | - true             | see below     |"},{"line_number":388,"context_line":"|                                       | - false            |               |"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fc1f717_030c42eb","line":385,"range":{"start_line":383,"start_character":3,"end_line":385,"end_character":19},"updated":"2019-03-15 10:03:09.000000000","message":"duplicates","commit_id":"a39e2dfda3397de7b25bc130cca2b4a0c976e1cd"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"9ce9aeea46452476c98d6e13e880b18e95dfe60a","unresolved":false,"context_lines":[{"line_number":380,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":381,"context_line":"| `tiller_tag`_                         | see below          | \"\"            |"},{"line_number":382,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":383,"context_line":"| `tiller_namespace`_                   | see below          | see below     |"},{"line_number":384,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":385,"context_line":"| `tiller_namespace`_                   | see below          | see below     |"},{"line_number":386,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":387,"context_line":"| `master_lb_floating_ip_enabled`_      | - true             | see below     |"},{"line_number":388,"context_line":"|                                       | - false            |               |"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fc1f717_2da1e046","line":385,"range":{"start_line":383,"start_character":3,"end_line":385,"end_character":19},"in_reply_to":"5fc1f717_030c42eb","updated":"2019-03-15 10:11:40.000000000","message":"you are also looking at the old patchset.","commit_id":"a39e2dfda3397de7b25bc130cca2b4a0c976e1cd"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"8c90104c34fd18076ce82d4c2a42236856b4abf0","unresolved":false,"context_lines":[{"line_number":382,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":383,"context_line":"| `tiller_namespace`_                   | see below          | see below     |"},{"line_number":384,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":385,"context_line":"| `tiller_namespace`_                   | see below          | see below     |"},{"line_number":386,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":387,"context_line":"| `master_lb_floating_ip_enabled`_      | - true             | see below     |"},{"line_number":388,"context_line":"|                                       | - false            |               |"},{"line_number":389,"context_line":"+---------------------------------------+--------------------+---------------+"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fc1f717_f459a08d","line":386,"range":{"start_line":385,"start_character":0,"end_line":386,"end_character":78},"updated":"2019-03-12 22:31:12.000000000","message":"copy pasta error?","commit_id":"a39e2dfda3397de7b25bc130cca2b4a0c976e1cd"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"10efccc29ca98c3230bf53d69e63429d54cca5ed","unresolved":false,"context_lines":[{"line_number":382,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":383,"context_line":"| `tiller_namespace`_                   | see below          | see below     |"},{"line_number":384,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":385,"context_line":"| `tiller_namespace`_                   | see below          | see below     |"},{"line_number":386,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":387,"context_line":"| `master_lb_floating_ip_enabled`_      | - true             | see below     |"},{"line_number":388,"context_line":"|                                       | - false            |               |"},{"line_number":389,"context_line":"+---------------------------------------+--------------------+---------------+"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5fc1f717_1f648549","line":386,"range":{"start_line":385,"start_character":0,"end_line":386,"end_character":78},"in_reply_to":"5fc1f717_f459a08d","updated":"2019-03-12 22:46:12.000000000","message":"hah, yes, will fix, thanks!","commit_id":"a39e2dfda3397de7b25bc130cca2b4a0c976e1cd"}],"magnum/drivers/common/templates/lb.yaml":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4b2123ba1c8df55de252df32326387590903cb88","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: 2016-10-14"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"parameters:"},{"line_number":4,"context_line":"  fixed_subnet:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_4a8c8435","line":1,"updated":"2019-03-15 07:55:07.000000000","message":"This will break old heats. Shall we add a not somewhere?","commit_id":"af9a879691ac09b0bf97e031c5ce8cc11579b53e"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"7d366e467d21007e1f43e5bac7395cdeb8cb7b1f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: 2016-10-14"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"parameters:"},{"line_number":4,"context_line":"  fixed_subnet:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_8dc49441","line":1,"in_reply_to":"5fc1f717_4a8c8435","updated":"2019-03-15 09:54:33.000000000","message":"2016-10-14 is for Newton, it\u0027s actually End Of Life. Do we really need a note?","commit_id":"af9a879691ac09b0bf97e031c5ce8cc11579b53e"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"5b2a0f4ee6e6fc63cf448daff9eebe2d1509d438","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: 2016-10-14"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"parameters:"},{"line_number":4,"context_line":"  fixed_subnet:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_5c92cd58","line":1,"in_reply_to":"5fc1f717_59109f4e","updated":"2019-03-16 19:05:59.000000000","message":"I would prefer there to be consistency. We were until recently running Mitaka Heat with a much newer version of Magnum. So not worth bumping unless there is a good reason.","commit_id":"af9a879691ac09b0bf97e031c5ce8cc11579b53e"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"55f42563d2a2d39292a981d7c10ccd00046725dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: 2016-10-14"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"parameters:"},{"line_number":4,"context_line":"  fixed_subnet:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_5fa07f90","line":1,"in_reply_to":"5fc1f717_5c92cd58","updated":"2019-03-17 03:32:10.000000000","message":"Hi, do you know both Mitaka and Newton were both EOL[1]?\n\n[1]: https://releases.openstack.org/","commit_id":"af9a879691ac09b0bf97e031c5ce8cc11579b53e"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"5c56ece4288c3e58d527d77b94377532f472a2ac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: 2016-10-14"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"parameters:"},{"line_number":4,"context_line":"  fixed_subnet:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_780b1f29","line":1,"in_reply_to":"5fc1f717_68d8367a","updated":"2019-03-20 01:32:48.000000000","message":"I can see Spyros\u0027 concern. Though keeping the compatibility with very old Heat version is good, but we also need to move to new Heat version to leverage those nice new features in Heat to make our cluster orchestration easily. Could we add an upgrade release note to highlight this?","commit_id":"af9a879691ac09b0bf97e031c5ce8cc11579b53e"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"754380fde5d90462fe9f5bccd8fc3540009adb49","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: 2016-10-14"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"parameters:"},{"line_number":4,"context_line":"  fixed_subnet:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_59109f4e","line":1,"in_reply_to":"5fc1f717_68d8367a","updated":"2019-03-16 11:17:29.000000000","message":"The `conditions` support was introduced since Newton, that\u0027s why I changed the version here. If we have concerns that other templates should also be changed, we could do that in a separate patch.","commit_id":"af9a879691ac09b0bf97e031c5ce8cc11579b53e"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"1e91af4c9489323c576da183ff2a34f496da8231","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: 2016-10-14"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"parameters:"},{"line_number":4,"context_line":"  fixed_subnet:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_68d8367a","line":1,"in_reply_to":"5fc1f717_8dc49441","updated":"2019-03-15 10:31:46.000000000","message":"The others templates are juno. Is it a good idea to ignore that?","commit_id":"af9a879691ac09b0bf97e031c5ce8cc11579b53e"}],"magnum/drivers/heat/template_def.py":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"80cde2fedab9cab97e4f56f4c0dee53ee24d4233","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"def add_fip_env_file(env_files, cluster_template):"},{"line_number":390,"context_line":"    lb_fip_enabled \u003d cluster_template.labels.get("},{"line_number":391,"context_line":"        \"master_lb_floating_ip_enabled\","},{"line_number":392,"context_line":"        cluster_template.floating_ip_enabled"},{"line_number":393,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":12,"id":"5fc1f717_78a99a8e","line":390,"range":{"start_line":390,"start_character":21,"end_line":390,"end_character":37},"updated":"2019-03-20 00:59:24.000000000","message":"cluster","commit_id":"4bfbae46d9c900ef09471e19d8f68946b77f340b"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"fc3cd88f2bf27bf095235904a26ca373ec47f0eb","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"def add_etcd_volume_env_file(env_files, cluster_template):"},{"line_number":383,"context_line":"    if int(cluster_template.labels.get(\u0027etcd_volume_size\u0027, 0)) \u003c 1:"},{"line_number":384,"context_line":"        env_files.append(COMMON_ENV_PATH + \u0027no_etcd_volume.yaml\u0027)"},{"line_number":385,"context_line":"    else:"},{"line_number":386,"context_line":"        env_files.append(COMMON_ENV_PATH + \u0027with_etcd_volume.yaml\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5fc1f717_9811e6af","line":383,"range":{"start_line":383,"start_character":11,"end_line":383,"end_character":27},"updated":"2019-03-20 01:06:51.000000000","message":"this is a bug.\n\nhttps://storyboard.openstack.org/#!/story/2005143","commit_id":"b9cc4ad61ccfb76afb3184dc6816187b8fad9e4d"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a8ff396e789265a491a8cfe7af8514cf6e783d04","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"def add_fip_env_file(env_files, cluster_template):"},{"line_number":390,"context_line":"    lb_fip_enabled \u003d cluster.labels.get("},{"line_number":391,"context_line":"        \"master_lb_floating_ip_enabled\","},{"line_number":392,"context_line":"        cluster_template.floating_ip_enabled"},{"line_number":393,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":13,"id":"5fc1f717_939c695e","line":390,"updated":"2019-03-20 02:04:44.000000000","message":"We have to pass in the cluster before we use it.","commit_id":"b9cc4ad61ccfb76afb3184dc6816187b8fad9e4d"}],"magnum/tests/unit/drivers/test_template_definition.py":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"4da9aab87fac02465d3d61657a16078ee5999ca1","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            ],"},{"line_number":255,"context_line":"            env_files"},{"line_number":256,"context_line":"        )"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    @mock.patch(\u0027magnum.drivers.common.driver.Driver.get_driver\u0027)"},{"line_number":259,"context_line":"    def test_base_get_scale_params(self, mock_driver):"},{"line_number":260,"context_line":"        mock_context \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_3fe4e1e0","line":257,"updated":"2019-03-12 22:36:54.000000000","message":"do we need a test for\n floating_ip_enabled\u003dTrue,\n master_lb_enabled\u003dTrue,\n labels\u003d{\"master_lb_floating_ip_enabled\": \"false\"}","commit_id":"a39e2dfda3397de7b25bc130cca2b4a0c976e1cd"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"10efccc29ca98c3230bf53d69e63429d54cca5ed","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            ],"},{"line_number":255,"context_line":"            env_files"},{"line_number":256,"context_line":"        )"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    @mock.patch(\u0027magnum.drivers.common.driver.Driver.get_driver\u0027)"},{"line_number":259,"context_line":"    def test_base_get_scale_params(self, mock_driver):"},{"line_number":260,"context_line":"        mock_context \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_9f571559","line":257,"in_reply_to":"5fc1f717_3fe4e1e0","updated":"2019-03-12 22:46:12.000000000","message":"Absolutely, already uploaded a new patchset. Thanks!","commit_id":"a39e2dfda3397de7b25bc130cca2b4a0c976e1cd"}],"releasenotes/notes/k8s-improve-floating-ip-enabled-84cd00224d6b7bc1.yaml":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"6418999b3c2e8b86ab2ae430a9155f7ac0f5a4c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"upgrade:"},{"line_number":2,"context_line":"  - The etcd service for Kubernetes cluster is no long allocated a floating"},{"line_number":3,"context_line":"    IP."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - A new label named ``master_lb_floating_ip_enabled`` is introduced which"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5fc1f717_3a694f20","line":2,"range":{"start_line":2,"start_character":50,"end_line":2,"end_character":54},"updated":"2019-03-12 23:53:23.000000000","message":"longer","commit_id":"2531877d3b7cbe5bcbeab6994549db9183e149fc"}]}