)]}'
{"magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-master.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"cf718ca7f07a394e2d3c471bf03010929a99e1e0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"_prefix\u003d${CONTAINER_INFRA_PREFIX:-docker.io/openstackmagnum/}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"mkdir -p /opt/cni"},{"line_number":22,"context_line":"_addtl_mounts\u003d\u0027,{\"type\":\"bind\",\"source\":\"/opt/cni\",\"destination\":\"/opt/cni\",\"options\":[\"bind\",\"rw\",\"slave\",\"mode\u003d777\"]},{\"type\":\"bind\",\"source\":\"/var/lib/docker\",\"destination\":\"/var/lib/docker\",\"options\":[\"bind\",\"rw\",\"slave\",\"mode\u003d777\"]}\u0027"},{"line_number":23,"context_line":"atomic install --storage ostree --system --set\u003dADDTL_MOUNTS\u003d${_addtl_mounts} --system-package\u003dno --name\u003dkubelet ${_prefix}kubernetes-kubelet:${KUBE_TAG}"},{"line_number":24,"context_line":"atomic install --storage ostree --system --system-package\u003dno --name\u003dkube-apiserver ${_prefix}kubernetes-apiserver:${KUBE_TAG}"},{"line_number":25,"context_line":"atomic install --storage ostree --system --system-package\u003dno --name\u003dkube-controller-manager ${_prefix}kubernetes-controller-manager:${KUBE_TAG}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_5fc111e4","line":22,"range":{"start_line":22,"start_character":231,"end_line":22,"end_character":234},"updated":"2019-04-02 10:49:01.000000000","message":"do we need 777? does 755 work?","commit_id":"c915e2cbadb9f0e522ad44a10f6a0583d5115e0f"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"21b7657bde8ec1f1e2b78cb94de59330a76d020e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"_prefix\u003d${CONTAINER_INFRA_PREFIX:-docker.io/openstackmagnum/}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"mkdir -p /opt/cni"},{"line_number":22,"context_line":"_addtl_mounts\u003d\u0027,{\"type\":\"bind\",\"source\":\"/opt/cni\",\"destination\":\"/opt/cni\",\"options\":[\"bind\",\"rw\",\"slave\",\"mode\u003d777\"]},{\"type\":\"bind\",\"source\":\"/var/lib/docker\",\"destination\":\"/var/lib/docker\",\"options\":[\"bind\",\"rw\",\"slave\",\"mode\u003d777\"]}\u0027"},{"line_number":23,"context_line":"atomic install --storage ostree --system --set\u003dADDTL_MOUNTS\u003d${_addtl_mounts} --system-package\u003dno --name\u003dkubelet ${_prefix}kubernetes-kubelet:${KUBE_TAG}"},{"line_number":24,"context_line":"atomic install --storage ostree --system --system-package\u003dno --name\u003dkube-apiserver ${_prefix}kubernetes-apiserver:${KUBE_TAG}"},{"line_number":25,"context_line":"atomic install --storage ostree --system --system-package\u003dno --name\u003dkube-controller-manager ${_prefix}kubernetes-controller-manager:${KUBE_TAG}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_eb32765e","line":22,"range":{"start_line":22,"start_character":231,"end_line":22,"end_character":234},"in_reply_to":"5fc1f717_5fc111e4","updated":"2019-04-02 16:31:54.000000000","message":"I don\u0027t know. Need to test before answering.","commit_id":"c915e2cbadb9f0e522ad44a10f6a0583d5115e0f"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"91abe397f99ad07ade139c893a2291e923ecc4f3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"_prefix\u003d${CONTAINER_INFRA_PREFIX:-docker.io/openstackmagnum/}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"mkdir -p /opt/cni"},{"line_number":22,"context_line":"_addtl_mounts\u003d\u0027,{\"type\":\"bind\",\"source\":\"/opt/cni\",\"destination\":\"/opt/cni\",\"options\":[\"bind\",\"rw\",\"slave\",\"mode\u003d777\"]},{\"type\":\"bind\",\"source\":\"/var/lib/docker\",\"destination\":\"/var/lib/docker\",\"options\":[\"bind\",\"rw\",\"slave\",\"mode\u003d777\"]}\u0027"},{"line_number":23,"context_line":"atomic install --storage ostree --system --set\u003dADDTL_MOUNTS\u003d${_addtl_mounts} --system-package\u003dno --name\u003dkubelet ${_prefix}kubernetes-kubelet:${KUBE_TAG}"},{"line_number":24,"context_line":"atomic install --storage ostree --system --system-package\u003dno --name\u003dkube-apiserver ${_prefix}kubernetes-apiserver:${KUBE_TAG}"},{"line_number":25,"context_line":"atomic install --storage ostree --system --system-package\u003dno --name\u003dkube-controller-manager ${_prefix}kubernetes-controller-manager:${KUBE_TAG}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fce034c_395d21e9","line":22,"range":{"start_line":22,"start_character":231,"end_line":22,"end_character":234},"in_reply_to":"5fc1f717_eb32765e","updated":"2019-04-15 21:52:54.000000000","message":"Tested, 755 works. I will propose a new patchset. Cheers.","commit_id":"c915e2cbadb9f0e522ad44a10f6a0583d5115e0f"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"68d7a0a60230685c45aa087cd3b834a414f54a57","unresolved":false,"context_lines":[{"line_number":19,"context_line":"_prefix\u003d${CONTAINER_INFRA_PREFIX:-docker.io/openstackmagnum/}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"mkdir -p /opt/cni"},{"line_number":22,"context_line":"_addtl_mounts\u003d\u0027,{\"type\":\"bind\",\"source\":\"/opt/cni\",\"destination\":\"/opt/cni\",\"options\":[\"bind\",\"rw\",\"slave\",\"mode\u003d777\"]},{\"type\":\"bind\",\"source\":\"/var/lib/docker\",\"destination\":\"/var/lib/docker\",\"options\":[\"bind\",\"rw\",\"slave\",\"mode\u003d755\"]}\u0027"},{"line_number":23,"context_line":"atomic install --storage ostree --system --set\u003dADDTL_MOUNTS\u003d${_addtl_mounts} --system-package\u003dno --name\u003dkubelet ${_prefix}kubernetes-kubelet:${KUBE_TAG}"},{"line_number":24,"context_line":"atomic install --storage ostree --system --system-package\u003dno --name\u003dkube-apiserver ${_prefix}kubernetes-apiserver:${KUBE_TAG}"},{"line_number":25,"context_line":"atomic install --storage ostree --system --system-package\u003dno --name\u003dkube-controller-manager ${_prefix}kubernetes-controller-manager:${KUBE_TAG}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fce034c_60b42c36","line":22,"range":{"start_line":22,"start_character":218,"end_line":22,"end_character":223},"updated":"2019-04-17 07:13:09.000000000","message":"rshared\n\nSince kubelet needs to write (per commit message), don\u0027t the changes need to be visible in dockerD?","commit_id":"f20686e27c58fb49c48633c84b963560e0588dca"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"c310caca63572962fe1d5aac8fbe87c427dedf37","unresolved":false,"context_lines":[{"line_number":19,"context_line":"_prefix\u003d${CONTAINER_INFRA_PREFIX:-docker.io/openstackmagnum/}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"mkdir -p /opt/cni"},{"line_number":22,"context_line":"_addtl_mounts\u003d\u0027,{\"type\":\"bind\",\"source\":\"/opt/cni\",\"destination\":\"/opt/cni\",\"options\":[\"bind\",\"rw\",\"slave\",\"mode\u003d777\"]},{\"type\":\"bind\",\"source\":\"/var/lib/docker\",\"destination\":\"/var/lib/docker\",\"options\":[\"bind\",\"rw\",\"slave\",\"mode\u003d755\"]}\u0027"},{"line_number":23,"context_line":"atomic install --storage ostree --system --set\u003dADDTL_MOUNTS\u003d${_addtl_mounts} --system-package\u003dno --name\u003dkubelet ${_prefix}kubernetes-kubelet:${KUBE_TAG}"},{"line_number":24,"context_line":"atomic install --storage ostree --system --system-package\u003dno --name\u003dkube-apiserver ${_prefix}kubernetes-apiserver:${KUBE_TAG}"},{"line_number":25,"context_line":"atomic install --storage ostree --system --system-package\u003dno --name\u003dkube-controller-manager ${_prefix}kubernetes-controller-manager:${KUBE_TAG}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dfbec78f_688668de","line":22,"range":{"start_line":22,"start_character":218,"end_line":22,"end_character":223},"in_reply_to":"3fce034c_230aae89","updated":"2019-05-08 17:34:45.000000000","message":"Based on my testing, this change is enough.","commit_id":"f20686e27c58fb49c48633c84b963560e0588dca"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"0b929353c797b8c68aeac477c8973c967e8dd82c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"_prefix\u003d${CONTAINER_INFRA_PREFIX:-docker.io/openstackmagnum/}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"mkdir -p /opt/cni"},{"line_number":22,"context_line":"_addtl_mounts\u003d\u0027,{\"type\":\"bind\",\"source\":\"/opt/cni\",\"destination\":\"/opt/cni\",\"options\":[\"bind\",\"rw\",\"slave\",\"mode\u003d777\"]},{\"type\":\"bind\",\"source\":\"/var/lib/docker\",\"destination\":\"/var/lib/docker\",\"options\":[\"bind\",\"rw\",\"slave\",\"mode\u003d755\"]}\u0027"},{"line_number":23,"context_line":"atomic install --storage ostree --system --set\u003dADDTL_MOUNTS\u003d${_addtl_mounts} --system-package\u003dno --name\u003dkubelet ${_prefix}kubernetes-kubelet:${KUBE_TAG}"},{"line_number":24,"context_line":"atomic install --storage ostree --system --system-package\u003dno --name\u003dkube-apiserver ${_prefix}kubernetes-apiserver:${KUBE_TAG}"},{"line_number":25,"context_line":"atomic install --storage ostree --system --system-package\u003dno --name\u003dkube-controller-manager ${_prefix}kubernetes-controller-manager:${KUBE_TAG}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fce034c_63fe76af","line":22,"range":{"start_line":22,"start_character":218,"end_line":22,"end_character":223},"in_reply_to":"3fce034c_60b42c36","updated":"2019-04-17 08:11:52.000000000","message":"Sorry, not sure if I understand the question correctly. Do you mean the dockerD running on host?","commit_id":"f20686e27c58fb49c48633c84b963560e0588dca"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"80d4e1e6e87aa482b754433d7aff301ccb9f6e2b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"_prefix\u003d${CONTAINER_INFRA_PREFIX:-docker.io/openstackmagnum/}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"mkdir -p /opt/cni"},{"line_number":22,"context_line":"_addtl_mounts\u003d\u0027,{\"type\":\"bind\",\"source\":\"/opt/cni\",\"destination\":\"/opt/cni\",\"options\":[\"bind\",\"rw\",\"slave\",\"mode\u003d777\"]},{\"type\":\"bind\",\"source\":\"/var/lib/docker\",\"destination\":\"/var/lib/docker\",\"options\":[\"bind\",\"rw\",\"slave\",\"mode\u003d755\"]}\u0027"},{"line_number":23,"context_line":"atomic install --storage ostree --system --set\u003dADDTL_MOUNTS\u003d${_addtl_mounts} --system-package\u003dno --name\u003dkubelet ${_prefix}kubernetes-kubelet:${KUBE_TAG}"},{"line_number":24,"context_line":"atomic install --storage ostree --system --system-package\u003dno --name\u003dkube-apiserver ${_prefix}kubernetes-apiserver:${KUBE_TAG}"},{"line_number":25,"context_line":"atomic install --storage ostree --system --system-package\u003dno --name\u003dkube-controller-manager ${_prefix}kubernetes-controller-manager:${KUBE_TAG}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fce034c_230aae89","line":22,"range":{"start_line":22,"start_character":218,"end_line":22,"end_character":223},"in_reply_to":"3fce034c_63fe76af","updated":"2019-04-17 08:32:16.000000000","message":"yes, docker daemon that run on the host","commit_id":"f20686e27c58fb49c48633c84b963560e0588dca"}]}