)]}'
{"magnum/drivers/common/templates/kubernetes/fragments/enable-auto-healing.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"33b4de28e27ea8d90444f5b4f2beeac0f7af3d8e","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"_gcr_prefix\u003d${CONTAINER_INFRA_PREFIX:-k8s.gcr.io/}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Either auto scaling or auto healing we need CA to be deployed"},{"line_number":11,"context_line":"if [ \"$(echo $AUTO_HEALING_ENABLED | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" || \"$(echo $NPD_ENABLED | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\"]; then"},{"line_number":12,"context_line":"    # Generate Node Problem Detector manifest file"},{"line_number":13,"context_line":"    NPD_DEPLOY\u003d/srv/magnum/kubernetes/manifests/npd.yaml"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fb8cfa7_34aa0785","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":145},"updated":"2019-06-21 07:08:45.000000000","message":"we can move this if statement under the creation of the file. I think it is ok to have the file written even if it is not used. At line 111","commit_id":"10a5996e3231cb681e68016165940ea6898161ce"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"51e04c1baa34ad3bc0a25883fb9198a638f53a95","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"_gcr_prefix\u003d${CONTAINER_INFRA_PREFIX:-k8s.gcr.io/}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Either auto scaling or auto healing we need CA to be deployed"},{"line_number":11,"context_line":"if [ \"$(echo $AUTO_HEALING_ENABLED | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" || \"$(echo $NPD_ENABLED | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\"]; then"},{"line_number":12,"context_line":"    # Generate Node Problem Detector manifest file"},{"line_number":13,"context_line":"    NPD_DEPLOY\u003d/srv/magnum/kubernetes/manifests/npd.yaml"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fb8cfa7_74ef1f87","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":145},"in_reply_to":"9fb8cfa7_34aa0785","updated":"2019-06-21 07:39:38.000000000","message":"This is how it is currently done in other places. For the sake of consistency i think it should be like this. Or we change everything\n\nif [ \"$(echo $KEYSTONE_AUTH_ENABLED | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" !\u003d \"false\" ]; then\nif [ \"$NETWORK_DRIVER\" \u003d \"flannel\" ]; then\nif [ -n \"${TRUST_ID}\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then\nif [ \"$(echo $AUTO_HEALING_ENABLED | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then\nif [ \"$(echo $AUTO_HEALING_ENABLED | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" || \"$(echo $AUTO_SCALING_ENABLED | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\"]; then","commit_id":"10a5996e3231cb681e68016165940ea6898161ce"}]}