)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"8a65667cba96e9bc9de3f717d10aed8bbadd10dd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[WIP] ng-6: Add new fields to nodegroup objects"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since each nodegroup will be one independent stack, we have to add"},{"line_number":10,"context_line":"more fields to the table and object in order to track each stack in"},{"line_number":11,"context_line":"contained in the cluster. This adds the stack_id, version, status,"},{"line_number":12,"context_line":"status_reason and version fields to the nodegroup object."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5faad753_553d1cc2","line":10,"range":{"start_line":10,"start_character":65,"end_line":10,"end_character":67},"updated":"2019-09-18 18:04:11.000000000","message":"nit: delete","commit_id":"05c29563cfb527a69ffacd5e7ddf76b0b230bfad"}],"magnum/db/api.py":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"8a65667cba96e9bc9de3f717d10aed8bbadd10dd","unresolved":false,"context_lines":[{"line_number":627,"context_line":"        \"\"\""},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"    @abc.abstractmethod"},{"line_number":630,"context_line":"    def list_cluster_nodegroups(self, context, cluster_id\u003dNone, filters\u003dNone,"},{"line_number":631,"context_line":"                                limit\u003dNone, marker\u003dNone, sort_key\u003dNone,"},{"line_number":632,"context_line":"                                sort_dir\u003dNone):"},{"line_number":633,"context_line":"        \"\"\"Get matching nodegroups in a given cluster."}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_9554f4ff","line":630,"range":{"start_line":630,"start_character":58,"end_line":630,"end_character":62},"updated":"2019-09-18 18:04:11.000000000","message":"cluster_id is not an optional argument here right?","commit_id":"05c29563cfb527a69ffacd5e7ddf76b0b230bfad"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"2b542ba3b0b3b69ff75bc1b55c91d47370a71db5","unresolved":false,"context_lines":[{"line_number":627,"context_line":"        \"\"\""},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"    @abc.abstractmethod"},{"line_number":630,"context_line":"    def list_cluster_nodegroups(self, context, cluster_id\u003dNone, filters\u003dNone,"},{"line_number":631,"context_line":"                                limit\u003dNone, marker\u003dNone, sort_key\u003dNone,"},{"line_number":632,"context_line":"                                sort_dir\u003dNone):"},{"line_number":633,"context_line":"        \"\"\"Get matching nodegroups in a given cluster."}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_0e0c6feb","line":630,"updated":"2019-09-24 07:33:06.000000000","message":"Why the cluster_id is optional now?","commit_id":"af4289528543b7b1e8cfaf3ca613d6a60b86c10a"}],"magnum/db/sqlalchemy/api.py":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"8a65667cba96e9bc9de3f717d10aed8bbadd10dd","unresolved":false,"context_lines":[{"line_number":886,"context_line":"        query \u003d model_query(models.NodeGroup)"},{"line_number":887,"context_line":"        if not context.is_admin:"},{"line_number":888,"context_line":"            query \u003d query.filter_by(project_id\u003dcontext.project_id)"},{"line_number":889,"context_line":"        # FIXME: cluster_id can be None only if admin context"},{"line_number":890,"context_line":"        if cluster_id:"},{"line_number":891,"context_line":"            query \u003d query.filter_by(cluster_id\u003dcluster_id)"},{"line_number":892,"context_line":"        query \u003d self._add_nodegoup_filters(query, filters)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_dd6661ee","line":889,"range":{"start_line":889,"start_character":10,"end_line":889,"end_character":15},"updated":"2019-09-18 18:04:11.000000000","message":"I am slightly confused by why cluster_id is optional. I did not think it would be possible to list nodegroups without specifying cluster ID. How would we ever get here?","commit_id":"af4289528543b7b1e8cfaf3ca613d6a60b86c10a"}],"magnum/db/sqlalchemy/models.py":[{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"12da97668b0f7124da797ef219aa74ff4109d29a","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    node_addresses \u003d Column(JSONEncodedList, nullable\u003dTrue)"},{"line_number":282,"context_line":"    node_count \u003d Column(Integer())"},{"line_number":283,"context_line":"    role \u003d Column(String(255))"},{"line_number":284,"context_line":"    # NOTE(ttsiouts) We have to define the min and"},{"line_number":285,"context_line":"    # max number of nodes for each nodegroup"},{"line_number":286,"context_line":"    max_node_count \u003d Column(Integer())"},{"line_number":287,"context_line":"    min_node_count \u003d Column(Integer())"},{"line_number":288,"context_line":"    is_default \u003d Column(Boolean, default\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_473d4a8c","line":285,"range":{"start_line":284,"start_character":0,"end_line":285,"end_character":44},"updated":"2019-06-26 11:37:06.000000000","message":"I think this is fairly obvious. You can drop it","commit_id":"141e9b4d2d98900f361343bcc5495f5c7933a755"}]}