)]}'
{"magnum/drivers/heat/k8s_template_def.py":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"8a6e65fa21fc9f4c21fc6afafb102bb4485be06b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.add_output(\u0027kube_masters_private\u0027,"},{"line_number":87,"context_line":"                        cluster_attr\u003dNone)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def add_nodegroup_params(self, cluster, nodegroups\u003dNone):"},{"line_number":90,"context_line":"        super(K8sTemplateDefinition,"},{"line_number":91,"context_line":"              self).add_nodegroup_params(cluster, nodegroups\u003dnodegroups)"},{"line_number":92,"context_line":"        nodegroups \u003d nodegroups or [cluster.default_ng_worker,"},{"line_number":93,"context_line":"                                    cluster.default_ng_master]"},{"line_number":94,"context_line":"        for nodegroup in nodegroups:"},{"line_number":95,"context_line":"            if nodegroup.role \u003d\u003d \u0027master\u0027:"},{"line_number":96,"context_line":"                self.add_parameter("},{"line_number":97,"context_line":"                    \u0027master_flavor\u0027,"},{"line_number":98,"context_line":"                    nodegroup_attr\u003d\u0027flavor_id\u0027,"},{"line_number":99,"context_line":"                    nodegroup_uuid\u003dnodegroup.uuid,"},{"line_number":100,"context_line":"                    param_class\u003dtemplate_def.NodeGroupParameterMapping)"},{"line_number":101,"context_line":"                self.add_parameter("},{"line_number":102,"context_line":"                    \u0027master_image\u0027, nodegroup_attr\u003d\u0027image_id\u0027,"},{"line_number":103,"context_line":"                    nodegroup_uuid\u003dnodegroup.uuid,"},{"line_number":104,"context_line":"                    param_class\u003dtemplate_def.NodeGroupParameterMapping)"},{"line_number":105,"context_line":"            else:"},{"line_number":106,"context_line":"                self.add_parameter("},{"line_number":107,"context_line":"                    \u0027number_of_minions\u0027,"},{"line_number":108,"context_line":"                    nodegroup_attr\u003d\u0027node_count\u0027,"},{"line_number":109,"context_line":"                    nodegroup_uuid\u003dnodegroup.uuid,"},{"line_number":110,"context_line":"                    param_class\u003dtemplate_def.NodeGroupParameterMapping)"},{"line_number":111,"context_line":"                self.add_parameter("},{"line_number":112,"context_line":"                    \u0027minion_flavor\u0027,"},{"line_number":113,"context_line":"                    nodegroup_attr\u003d\u0027flavor_id\u0027,"},{"line_number":114,"context_line":"                    nodegroup_uuid\u003dnodegroup.uuid,"},{"line_number":115,"context_line":"                    param_class\u003dtemplate_def.NodeGroupParameterMapping)"},{"line_number":116,"context_line":"                self.add_parameter("},{"line_number":117,"context_line":"                    \u0027minion_image\u0027, nodegroup_attr\u003d\u0027image_id\u0027,"},{"line_number":118,"context_line":"                    nodegroup_uuid\u003dnodegroup.uuid,"},{"line_number":119,"context_line":"                    param_class\u003dtemplate_def.NodeGroupParameterMapping)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def update_outputs(self, stack, cluster_template, cluster,"},{"line_number":122,"context_line":"                       nodegroups\u003dNone):"},{"line_number":123,"context_line":"        nodegroups \u003d nodegroups or [cluster.default_ng_worker]"},{"line_number":124,"context_line":"        for nodegroup in nodegroups:"},{"line_number":125,"context_line":"            if nodegroup.role !\u003d \u0027master\u0027:"},{"line_number":126,"context_line":"                self.add_output("},{"line_number":127,"context_line":"                    \u0027number_of_minions\u0027,  nodegroup_attr\u003d\u0027node_count\u0027,"},{"line_number":128,"context_line":"                    nodegroup_uuid\u003dnodegroup.uuid, is_stack_param\u003dTrue,"},{"line_number":129,"context_line":"                    mapping_type\u003dtemplate_def.NodeGroupOutputMapping)"},{"line_number":130,"context_line":"        super(K8sTemplateDefinition,"},{"line_number":131,"context_line":"              self).update_outputs(stack, cluster_template, cluster,"},{"line_number":132,"context_line":"                                   nodegroups\u003dnodegroups)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def get_params(self, context, cluster_template, cluster, **kwargs):"},{"line_number":135,"context_line":"        extra_params \u003d kwargs.pop(\u0027extra_params\u0027, {})"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_f5d569ba","line":132,"range":{"start_line":89,"start_character":3,"end_line":132,"end_character":57},"updated":"2019-09-19 09:21:03.000000000","message":"hmm, is there a way that we could reduce the repetition of this code?","commit_id":"8f6301c6e745df38b36cebae28a28ea16c0ffb1a"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"80b260948939b65be6e4079ce41fce37b59fb5c2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.add_output(\u0027kube_masters_private\u0027,"},{"line_number":87,"context_line":"                        cluster_attr\u003dNone)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def add_nodegroup_params(self, cluster, nodegroups\u003dNone):"},{"line_number":90,"context_line":"        super(K8sTemplateDefinition,"},{"line_number":91,"context_line":"              self).add_nodegroup_params(cluster, nodegroups\u003dnodegroups)"},{"line_number":92,"context_line":"        nodegroups \u003d nodegroups or [cluster.default_ng_worker,"},{"line_number":93,"context_line":"                                    cluster.default_ng_master]"},{"line_number":94,"context_line":"        for nodegroup in nodegroups:"},{"line_number":95,"context_line":"            if nodegroup.role \u003d\u003d \u0027master\u0027:"},{"line_number":96,"context_line":"                self.add_parameter("},{"line_number":97,"context_line":"                    \u0027master_flavor\u0027,"},{"line_number":98,"context_line":"                    nodegroup_attr\u003d\u0027flavor_id\u0027,"},{"line_number":99,"context_line":"                    nodegroup_uuid\u003dnodegroup.uuid,"},{"line_number":100,"context_line":"                    param_class\u003dtemplate_def.NodeGroupParameterMapping)"},{"line_number":101,"context_line":"                self.add_parameter("},{"line_number":102,"context_line":"                    \u0027master_image\u0027, nodegroup_attr\u003d\u0027image_id\u0027,"},{"line_number":103,"context_line":"                    nodegroup_uuid\u003dnodegroup.uuid,"},{"line_number":104,"context_line":"                    param_class\u003dtemplate_def.NodeGroupParameterMapping)"},{"line_number":105,"context_line":"            else:"},{"line_number":106,"context_line":"                self.add_parameter("},{"line_number":107,"context_line":"                    \u0027number_of_minions\u0027,"},{"line_number":108,"context_line":"                    nodegroup_attr\u003d\u0027node_count\u0027,"},{"line_number":109,"context_line":"                    nodegroup_uuid\u003dnodegroup.uuid,"},{"line_number":110,"context_line":"                    param_class\u003dtemplate_def.NodeGroupParameterMapping)"},{"line_number":111,"context_line":"                self.add_parameter("},{"line_number":112,"context_line":"                    \u0027minion_flavor\u0027,"},{"line_number":113,"context_line":"                    nodegroup_attr\u003d\u0027flavor_id\u0027,"},{"line_number":114,"context_line":"                    nodegroup_uuid\u003dnodegroup.uuid,"},{"line_number":115,"context_line":"                    param_class\u003dtemplate_def.NodeGroupParameterMapping)"},{"line_number":116,"context_line":"                self.add_parameter("},{"line_number":117,"context_line":"                    \u0027minion_image\u0027, nodegroup_attr\u003d\u0027image_id\u0027,"},{"line_number":118,"context_line":"                    nodegroup_uuid\u003dnodegroup.uuid,"},{"line_number":119,"context_line":"                    param_class\u003dtemplate_def.NodeGroupParameterMapping)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def update_outputs(self, stack, cluster_template, cluster,"},{"line_number":122,"context_line":"                       nodegroups\u003dNone):"},{"line_number":123,"context_line":"        nodegroups \u003d nodegroups or [cluster.default_ng_worker]"},{"line_number":124,"context_line":"        for nodegroup in nodegroups:"},{"line_number":125,"context_line":"            if nodegroup.role !\u003d \u0027master\u0027:"},{"line_number":126,"context_line":"                self.add_output("},{"line_number":127,"context_line":"                    \u0027number_of_minions\u0027,  nodegroup_attr\u003d\u0027node_count\u0027,"},{"line_number":128,"context_line":"                    nodegroup_uuid\u003dnodegroup.uuid, is_stack_param\u003dTrue,"},{"line_number":129,"context_line":"                    mapping_type\u003dtemplate_def.NodeGroupOutputMapping)"},{"line_number":130,"context_line":"        super(K8sTemplateDefinition,"},{"line_number":131,"context_line":"              self).update_outputs(stack, cluster_template, cluster,"},{"line_number":132,"context_line":"                                   nodegroups\u003dnodegroups)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def get_params(self, context, cluster_template, cluster, **kwargs):"},{"line_number":135,"context_line":"        extra_params \u003d kwargs.pop(\u0027extra_params\u0027, {})"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_08d31962","line":132,"range":{"start_line":89,"start_character":3,"end_line":132,"end_character":57},"in_reply_to":"3fa7e38b_f5d569ba","updated":"2019-09-23 08:37:45.000000000","message":"what I mean by this is... could all classes that inherit from K8sTemplateDefinition reuse this block of code?","commit_id":"8f6301c6e745df38b36cebae28a28ea16c0ffb1a"}],"magnum/drivers/heat/swarm_fedora_template_def.py":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"25dcc8423a6ef31d557ca78a761c6fb9ed0c01b1","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.add_output(\u0027discovery_url\u0027,"},{"line_number":79,"context_line":"                        cluster_attr\u003d\u0027discovery_url\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def get_nodegroup_param_maps(self, master_params\u003dNone, worker_params\u003dNone):"},{"line_number":82,"context_line":"        master_params \u003d dict() if master_params is None else master_params"},{"line_number":83,"context_line":"        worker_params \u003d dict() if worker_params is None else worker_params"},{"line_number":84,"context_line":"        master_params.update({"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_adef411c","line":81,"range":{"start_line":81,"start_character":53,"end_line":81,"end_character":57},"updated":"2019-09-25 13:32:29.000000000","message":"any reason why we cant have dict() here?","commit_id":"2feb3b887bf283113808f8c78d1489b1d96a3900"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"25dcc8423a6ef31d557ca78a761c6fb9ed0c01b1","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                        cluster_attr\u003d\u0027discovery_url\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def get_nodegroup_param_maps(self, master_params\u003dNone, worker_params\u003dNone):"},{"line_number":82,"context_line":"        master_params \u003d dict() if master_params is None else master_params"},{"line_number":83,"context_line":"        worker_params \u003d dict() if worker_params is None else worker_params"},{"line_number":84,"context_line":"        master_params.update({"},{"line_number":85,"context_line":"            \u0027master_flavor\u0027: \u0027flavor_id\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_f2a51448","line":82,"range":{"start_line":82,"start_character":24,"end_line":82,"end_character":74},"updated":"2019-09-25 13:32:29.000000000","message":"nit: could do master params or dict()","commit_id":"2feb3b887bf283113808f8c78d1489b1d96a3900"}]}