)]}'
{"magnum/drivers/common/k8s_monitor.py":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"f535f82e26d2f41821a89a45bd3e75a7d437c1a3","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def poll_health_status(self):"},{"line_number":52,"context_line":"        k8s_api \u003d k8s.create_k8s_api(self.context, self.cluster)"},{"line_number":53,"context_line":"        lb_fip \u003d self.cluster.labels.get(\"master_lb_floating_ip_enabled\")"},{"line_number":54,"context_line":"        lb_fip_enabled \u003d strutils.bool_from_string(lb_fip)"},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            # NOTE(flwang): This is for making a testable code"},{"line_number":57,"context_line":"            cluster_template \u003d self.cluster.cluster_template"},{"line_number":58,"context_line":"        except Exception:"},{"line_number":59,"context_line":"            cluster_template \u003d None"},{"line_number":60,"context_line":"        if (self.cluster.floating_ip_enabled or"},{"line_number":61,"context_line":"                (lb_fip_enabled and cluster_template and"},{"line_number":62,"context_line":"                 cluster_template.master_lb_enabled)):"},{"line_number":63,"context_line":"            status, reason \u003d self._poll_health_status(k8s_api)"},{"line_number":64,"context_line":"        else:"},{"line_number":65,"context_line":"            status \u003d m_fields.ClusterHealthStatus.UNKNOWN"},{"line_number":66,"context_line":"            reason \u003d \"The cluster %s is not reachable.\" % self.cluster.name"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self.data[\u0027health_status\u0027] \u003d status"},{"line_number":69,"context_line":"        self.data[\u0027health_status_reason\u0027] \u003d reason"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_baff7200","line":66,"range":{"start_line":53,"start_character":0,"end_line":66,"end_character":75},"updated":"2019-08-16 17:49:05.000000000","message":"Can\u0027t we just move this out to a seperate fucntion (i.e. `_is_reachable` to clean up the logic and make it easier to unit test (avoiding the \u0027testable code\u0027 segment too).","commit_id":"e9806b89ddb4958cca0b25c291bddb5c6836e707"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"33a0210f343c6e7eefb22bb44911aa328c98f677","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def poll_health_status(self):"},{"line_number":52,"context_line":"        k8s_api \u003d k8s.create_k8s_api(self.context, self.cluster)"},{"line_number":53,"context_line":"        lb_fip \u003d self.cluster.labels.get(\"master_lb_floating_ip_enabled\")"},{"line_number":54,"context_line":"        lb_fip_enabled \u003d strutils.bool_from_string(lb_fip)"},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            # NOTE(flwang): This is for making a testable code"},{"line_number":57,"context_line":"            cluster_template \u003d self.cluster.cluster_template"},{"line_number":58,"context_line":"        except Exception:"},{"line_number":59,"context_line":"            cluster_template \u003d None"},{"line_number":60,"context_line":"        if (self.cluster.floating_ip_enabled or"},{"line_number":61,"context_line":"                (lb_fip_enabled and cluster_template and"},{"line_number":62,"context_line":"                 cluster_template.master_lb_enabled)):"},{"line_number":63,"context_line":"            status, reason \u003d self._poll_health_status(k8s_api)"},{"line_number":64,"context_line":"        else:"},{"line_number":65,"context_line":"            status \u003d m_fields.ClusterHealthStatus.UNKNOWN"},{"line_number":66,"context_line":"            reason \u003d \"The cluster %s is not reachable.\" % self.cluster.name"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self.data[\u0027health_status\u0027] \u003d status"},{"line_number":69,"context_line":"        self.data[\u0027health_status_reason\u0027] \u003d reason"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_d05b2d1f","line":66,"range":{"start_line":53,"start_character":0,"end_line":66,"end_character":75},"in_reply_to":"7faddb67_baff7200","updated":"2019-08-16 19:01:22.000000000","message":"Yep, that\u0027s a good point. Will do in the next PS.","commit_id":"e9806b89ddb4958cca0b25c291bddb5c6836e707"}],"magnum/objects/fields.py":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"39e4c7a03f0ead2ce7ac6c83a096141571e3ef24","unresolved":false,"context_lines":[{"line_number":52,"context_line":"class ClusterHealthStatus(fields.Enum):"},{"line_number":53,"context_line":"    HEALTHY \u003d \u0027HEALTHY\u0027"},{"line_number":54,"context_line":"    UNHEALTHY \u003d \u0027UNHEALTHY\u0027"},{"line_number":55,"context_line":"    UNKNOWN \u003d \u0027UNKNOWN\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    ALL \u003d (HEALTHY, UNHEALTHY, UNKNOWN)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_58c123e4","line":55,"range":{"start_line":55,"start_character":15,"end_line":55,"end_character":22},"updated":"2019-08-09 09:15:44.000000000","message":"lets call it UNREACHABLE?","commit_id":"e9806b89ddb4958cca0b25c291bddb5c6836e707"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"7ea41fbb58f1dce1f59347b099de14029a056868","unresolved":false,"context_lines":[{"line_number":52,"context_line":"class ClusterHealthStatus(fields.Enum):"},{"line_number":53,"context_line":"    HEALTHY \u003d \u0027HEALTHY\u0027"},{"line_number":54,"context_line":"    UNHEALTHY \u003d \u0027UNHEALTHY\u0027"},{"line_number":55,"context_line":"    UNKNOWN \u003d \u0027UNKNOWN\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    ALL \u003d (HEALTHY, UNHEALTHY, UNKNOWN)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_43827ca7","line":55,"range":{"start_line":55,"start_character":15,"end_line":55,"end_character":22},"in_reply_to":"7faddb67_58c123e4","updated":"2019-08-11 21:44:30.000000000","message":"hmm... I would prefer \"unknown\", because in this case it\u0027s really unknown from a magnum control plane view. And I don\u0027t think \u0027unreachable\u0027 is a health status option :)","commit_id":"e9806b89ddb4958cca0b25c291bddb5c6836e707"}]}