)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9cd978be2427b766bc2d9bfb5666a5f9af20da1d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"At the moment, cluster deployment fails when cluster_user_trust\u003dFalse."},{"line_number":10,"context_line":"This patch fixes this by not exiting the script when TRUST_ID is not"},{"line_number":11,"context_line":"defined which is a side-effect of this."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also do not set --cloud-provider\u003dexternal when TRUST_ID is not defined"},{"line_number":14,"context_line":"in minion kubelet."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5faad753_1b5fb872","line":11,"updated":"2019-09-13 11:18:36.000000000","message":"Might be nice to explain that exit prevents subsequent scripts from running.","commit_id":"00e66e6b0b0c875bd9542d298381a008c092c950"}],"magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-minion.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9cd978be2427b766bc2d9bfb5666a5f9af20da1d","unresolved":false,"context_lines":[{"line_number":145,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --volume-plugin-dir\u003d/var/lib/kubelet/volumeplugins\""},{"line_number":146,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} ${KUBELET_OPTIONS}\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":149,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cloud-provider\u003dexternal\""},{"line_number":150,"context_line":"fi"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"5faad753_9b71680f","line":148,"range":{"start_line":148,"start_character":3,"end_line":148,"end_character":24},"updated":"2019-09-13 11:18:36.000000000","message":"Alternative: set CLOUD_PROVIDER_ENABLED to False when trust is disabled.","commit_id":"00e66e6b0b0c875bd9542d298381a008c092c950"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b966f5c2ba2872791f3913cbf8a257b1f1712454","unresolved":false,"context_lines":[{"line_number":145,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --volume-plugin-dir\u003d/var/lib/kubelet/volumeplugins\""},{"line_number":146,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} ${KUBELET_OPTIONS}\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":149,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cloud-provider\u003dexternal\""},{"line_number":150,"context_line":"fi"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"5faad753_36f2cb71","line":148,"range":{"start_line":148,"start_character":3,"end_line":148,"end_character":24},"in_reply_to":"5faad753_36c96b25","updated":"2019-09-13 12:35:14.000000000","message":"Is it a misconfiguration to have CLOUD_PROVIDER_ENABLED without trust enabled?\n\nI\u0027m just thinking if the user has asked for a cloud provider but we cannot do it due to trusts, we could catch that case and provide an error?","commit_id":"00e66e6b0b0c875bd9542d298381a008c092c950"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"e184eacb34c54edd253948b4537113d2145531f0","unresolved":false,"context_lines":[{"line_number":145,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --volume-plugin-dir\u003d/var/lib/kubelet/volumeplugins\""},{"line_number":146,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} ${KUBELET_OPTIONS}\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":149,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cloud-provider\u003dexternal\""},{"line_number":150,"context_line":"fi"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"5faad753_39595b8d","line":148,"range":{"start_line":148,"start_character":3,"end_line":148,"end_character":24},"in_reply_to":"5faad753_36f2cb71","updated":"2019-09-13 14:09:30.000000000","message":"CLOUD_PROVIDER_ENABLED is true by default. Its only when cluster_user_trust is True that CLOUD_PROVIDER_ENABLED becomes usable.","commit_id":"00e66e6b0b0c875bd9542d298381a008c092c950"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"d6554d0b72c1476705ed44895d53eff6de3f6510","unresolved":false,"context_lines":[{"line_number":145,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --volume-plugin-dir\u003d/var/lib/kubelet/volumeplugins\""},{"line_number":146,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} ${KUBELET_OPTIONS}\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":149,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cloud-provider\u003dexternal\""},{"line_number":150,"context_line":"fi"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"5faad753_31017506","line":148,"range":{"start_line":148,"start_character":3,"end_line":148,"end_character":24},"in_reply_to":"5faad753_36f2cb71","updated":"2019-09-13 12:45:03.000000000","message":"That is an edge case which would lead to problems. Probably a good idea to catch it and fail early before the cluster even gets created.","commit_id":"00e66e6b0b0c875bd9542d298381a008c092c950"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"a97be999b8e15596ef00fa640c9e9c10b59934f8","unresolved":false,"context_lines":[{"line_number":145,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --volume-plugin-dir\u003d/var/lib/kubelet/volumeplugins\""},{"line_number":146,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} ${KUBELET_OPTIONS}\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":149,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cloud-provider\u003dexternal\""},{"line_number":150,"context_line":"fi"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"5faad753_36c96b25","line":148,"range":{"start_line":148,"start_character":3,"end_line":148,"end_character":24},"in_reply_to":"5faad753_9b71680f","updated":"2019-09-13 12:32:32.000000000","message":"CLOUD_PROVIDER_ENABLED flag is passed in using labels, TRUST_ID comes in when cluster_user_trust\u003dTrue. At the moment, /etc/sysconfig/heat-params has a snapshot of all the cluster params. The danger with overriding CLOUD_PROVIDER_ENABLED is that it may make things more difficult to debug but happy to hear what others too have to say on the matter.","commit_id":"00e66e6b0b0c875bd9542d298381a008c092c950"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"194d770196982aaba209cd8ed87eb1017ba140e2","unresolved":false,"context_lines":[{"line_number":145,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --volume-plugin-dir\u003d/var/lib/kubelet/volumeplugins\""},{"line_number":146,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} ${KUBELET_OPTIONS}\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":149,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cloud-provider\u003dexternal\""},{"line_number":150,"context_line":"fi"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5faad753_dcbfd5a7","line":148,"range":{"start_line":148,"start_character":3,"end_line":148,"end_character":24},"updated":"2019-09-13 14:44:52.000000000","message":"Is this possible now?","commit_id":"0cf8950107cfd91d6e5d8cf7f782d7ab48bf73b3"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"1d8a4f78f5bc1343d06f9e2fd5c0cd071a93c3e2","unresolved":false,"context_lines":[{"line_number":145,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --volume-plugin-dir\u003d/var/lib/kubelet/volumeplugins\""},{"line_number":146,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} ${KUBELET_OPTIONS}\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"if [ -n \"$TRUST_ID\" ] \u0026\u0026 [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"},{"line_number":149,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cloud-provider\u003dexternal\""},{"line_number":150,"context_line":"fi"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5faad753_3f6dbbcb","line":148,"range":{"start_line":148,"start_character":3,"end_line":148,"end_character":24},"in_reply_to":"5faad753_dcbfd5a7","updated":"2019-09-16 22:54:04.000000000","message":"Yes, I agree with you, makes the TRUST_ID check redundant.","commit_id":"0cf8950107cfd91d6e5d8cf7f782d7ab48bf73b3"}],"magnum/drivers/heat/k8s_fedora_template_def.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e7c116e2d4d659d150cbe0dfbe6281905451f771","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # check cloud provider and cinder options. If cinder is selected,"},{"line_number":111,"context_line":"        # the cloud provider needs to be enabled."},{"line_number":112,"context_line":"\tcloud_provider_enabled \u003d cluster.labels.get("},{"line_number":113,"context_line":"            \u0027cloud_provider_enabled\u0027,"},{"line_number":114,"context_line":"            \u0027true\u0027 if CONF.trust.cluster_user_trust else \u0027false\u0027).lower()"},{"line_number":115,"context_line":"\tif (not CONF.trust.cluster_user_trust"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_fcf971c7","line":112,"updated":"2019-09-13 14:39:16.000000000","message":"tabs","commit_id":"44fa43898b53c48d2a24bc1f76189402f038c88f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e7c116e2d4d659d150cbe0dfbe6281905451f771","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                and cloud_provider_enabled \u003d\u003d \u0027true\u0027):"},{"line_number":117,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":118,"context_line":"\t\t\u0027\"cluster_user_trust\" must be set to True in magnum.conf when \u0027"},{"line_number":119,"context_line":"                \u0027\"cloud_provider_enabled\" label is set to true.\u0027))"},{"line_number":120,"context_line":"        if (cluster_template.volume_driver \u003d\u003d \u0027cinder\u0027"},{"line_number":121,"context_line":"                and cloud_provider_enabled \u003d\u003d \u0027false\u0027):"},{"line_number":122,"context_line":"            raise exception.InvalidParameterValue(_("}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_1c932d5d","line":119,"updated":"2019-09-13 14:39:16.000000000","message":"This logic seems reasonable - if explicitly cloud provider requested and not possible, error out.","commit_id":"44fa43898b53c48d2a24bc1f76189402f038c88f"}]}