)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"9cd15c0116e8d31d02e9bca255976ee706833cdd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Theodoros Tsioutsias \u003ctheodoros.tsioutsias@cern.ch\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-29 16:48:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix cluster template conditions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The new worker_only condition should be true for all roles except for"},{"line_number":10,"context_line":"master. Also this adds the new params in the cluster templates of all"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_31a5a3a2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":31},"updated":"2019-09-30 11:33:34.000000000","message":"would you mind adding [ng-10] here for consistency?","commit_id":"bc56097fb47922265ad41a8f1655a72cc9dc1424"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"9d4664f6d9fcb0765b025620b3231dd793b19ac1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Theodoros Tsioutsias \u003ctheodoros.tsioutsias@cern.ch\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-29 16:48:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix cluster template conditions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The new worker_only condition should be true for all roles except for"},{"line_number":10,"context_line":"master. Also this adds the new params in the cluster templates of all"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_4c1f6807","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":31},"in_reply_to":"3fa7e38b_31a5a3a2","updated":"2019-09-30 12:32:55.000000000","message":"Done","commit_id":"bc56097fb47922265ad41a8f1655a72cc9dc1424"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"b184822789405e0e2efe4c79c7dffc6b1025f443","unresolved":false,"context_lines":[{"line_number":11,"context_line":"worker_only condition should be true for all roles except for master."},{"line_number":12,"context_line":"On k8s we label the nodes of each nodegroup with the role of the"},{"line_number":13,"context_line":"nodegroup where they belong in the following way:"},{"line_number":14,"context_line":"* --node-labels\u003dmagnum.openstack.org/role\u003d${NODEGROUP_ROLE}"},{"line_number":15,"context_line":"Finally, adds the missing is_cluster_stack param to all templates."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ie0799373fe492c2e0a0cad903ed6e8c93e6266b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_c239aaf2","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":59},"updated":"2019-10-03 09:58:27.000000000","message":"also seems to be what ng-12 is doing...","commit_id":"dba173b74ca8057e9213ee0ec9f8b742dbff27b8"}],"magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-master.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"b184822789405e0e2efe4c79c7dffc6b1025f443","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --network-plugin\u003dcni --cni-conf-dir\u003d/etc/cni/net.d --cni-bin-dir\u003d/opt/cni/bin\""},{"line_number":220,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --register-with-taints\u003dCriticalAddonsOnly\u003dTrue:NoSchedule,dedicated\u003dmaster:NoSchedule\""},{"line_number":221,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --node-labels\u003dmagnum.openstack.org/role\u003d${NODEGROUP_ROLE}\""},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"KUBELET_KUBECONFIG\u003d/etc/kubernetes/kubelet-config.yaml"},{"line_number":224,"context_line":"cat \u003c\u003c EOF \u003e\u003e ${KUBELET_KUBECONFIG}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3fa7e38b_a25b4e52","line":221,"range":{"start_line":221,"start_character":0,"end_line":221,"end_character":88},"updated":"2019-10-03 09:58:27.000000000","message":"makes sense to move this to ng-12","commit_id":"dba173b74ca8057e9213ee0ec9f8b742dbff27b8"}],"magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-minion.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"b184822789405e0e2efe4c79c7dffc6b1025f443","unresolved":false,"context_lines":[{"line_number":143,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --address\u003d${KUBE_NODE_IP} --port\u003d10250 --read-only-port\u003d0 --anonymous-auth\u003dfalse --authorization-mode\u003dWebhook --authentication-token-webhook\u003dtrue\""},{"line_number":144,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cluster_dns\u003d${DNS_SERVICE_IP} --cluster_domain\u003d${DNS_CLUSTER_DOMAIN}\""},{"line_number":145,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --volume-plugin-dir\u003d/var/lib/kubelet/volumeplugins\""},{"line_number":146,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --node-labels\u003dmagnum.openstack.org/role\u003d${NODEGROUP_ROLE}\""},{"line_number":147,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} ${KUBELET_OPTIONS}\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"if [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3fa7e38b_6255561d","line":146,"range":{"start_line":146,"start_character":0,"end_line":146,"end_character":88},"updated":"2019-10-03 09:58:27.000000000","message":"same","commit_id":"dba173b74ca8057e9213ee0ec9f8b742dbff27b8"}]}