)]}'
{"magnum/drivers/heat/k8s_template_def.py":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f667f941fb433b790faef4ad98ec18ecc23efd89","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        if fixed_network:"},{"line_number":192,"context_line":"            extra_params[\u0027fixed_network_name\u0027] \u003d \\"},{"line_number":193,"context_line":"                neutron.get_fixed_network_name(context, fixed_network)"},{"line_number":194,"context_line":"        else:"},{"line_number":195,"context_line":"            fixed_network \u003d \"private\""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # NOTE(brtknr): Convert fixed subnet name to UUID. If fixed_subnet"},{"line_number":198,"context_line":"        # is not specified in cluster template use \u0027private\u0027 as the default"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b17af3ed","line":195,"range":{"start_line":194,"start_character":7,"end_line":195,"end_character":37},"updated":"2019-10-16 13:48:17.000000000","message":"this should be removed","commit_id":"6aa0817156e7f1106c504fc431716ed32d550cc3"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f667f941fb433b790faef4ad98ec18ecc23efd89","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        if fixed_subnet:"},{"line_number":203,"context_line":"            extra_params[\u0027fixed_subnet\u0027] \u003d \\"},{"line_number":204,"context_line":"                neutron.get_fixed_subnet_id(context, fixed_subnet)"},{"line_number":205,"context_line":"        else:"},{"line_number":206,"context_line":"            fixed_subnet \u003d \"private\""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        label_list \u003d [\u0027flannel_network_cidr\u0027, \u0027flannel_backend\u0027,"},{"line_number":209,"context_line":"                      \u0027flannel_network_subnetlen\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d17d2fe7","line":206,"range":{"start_line":205,"start_character":8,"end_line":206,"end_character":36},"updated":"2019-10-16 13:48:17.000000000","message":"this should be removed","commit_id":"6aa0817156e7f1106c504fc431716ed32d550cc3"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f7cfdd6b75a903735f7b9ec6e0622c2dd97a1b80","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        # accepts a name as an argument to internal-network-name in the"},{"line_number":187,"context_line":"        # cloud-config file provided to it. The default fixed network name is"},{"line_number":188,"context_line":"        # the same as that defined in the heat template."},{"line_number":189,"context_line":"        fixed_network \u003d (cluster.fixed_network or"},{"line_number":190,"context_line":"                         cluster_template.fixed_network)"},{"line_number":191,"context_line":"        extra_params[\u0027fixed_network_name\u0027] \u003d \\"},{"line_number":192,"context_line":"            (neutron.get_fixed_network_name(context, fixed_network)"},{"line_number":193,"context_line":"                if fixed_network else None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_485c267c","line":190,"range":{"start_line":189,"start_character":24,"end_line":190,"end_character":56},"updated":"2019-10-17 09:42:42.000000000","message":"the \u0027or\u0027 is not required, the cluster will always have the correct value.\nhttps://github.com/openstack/magnum/blob/master/magnum/api/controllers/v1/cluster.py#L482-L487","commit_id":"1709d85849f21571496f8b60702806368736aa2e"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"a32898afff463ba89ea6d45656e2db194cdeadab","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        # field name is confused. If external_network_id is not specified in"},{"line_number":178,"context_line":"        # cluster template use \u0027public\u0027 as the default value, which is the same"},{"line_number":179,"context_line":"        # with the heat template default value as before."},{"line_number":180,"context_line":"        external_network \u003d cluster_template.external_network_id"},{"line_number":181,"context_line":"        extra_params[\u0027external_network\u0027] \u003d \\"},{"line_number":182,"context_line":"            neutron.get_external_network_id(context, external_network)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        # NOTE(brtknr): Convert fixed network UUID to name if the given network"},{"line_number":185,"context_line":"        # name is UUID like because OpenStack Cloud Controller Manager only"},{"line_number":186,"context_line":"        # accepts a name as an argument to internal-network-name in the"},{"line_number":187,"context_line":"        # cloud-config file provided to it. The default fixed network name is"},{"line_number":188,"context_line":"        # the same as that defined in the heat template."},{"line_number":189,"context_line":"        fixed_network \u003d (cluster.fixed_network or"},{"line_number":190,"context_line":"                         cluster_template.fixed_network)"},{"line_number":191,"context_line":"        extra_params[\u0027fixed_network_name\u0027] \u003d \\"},{"line_number":192,"context_line":"            (neutron.get_fixed_network_name(context, fixed_network)"},{"line_number":193,"context_line":"                if fixed_network else None)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        # NOTE(brtknr): Convert fixed subnet name to UUID. If fixed_subnet"},{"line_number":196,"context_line":"        # is not specified in cluster template use \u0027private\u0027 as the default"},{"line_number":197,"context_line":"        # value, which is the same as the heat template default value."},{"line_number":198,"context_line":"        fixed_subnet \u003d (cluster.fixed_subnet or"},{"line_number":199,"context_line":"                        cluster_template.fixed_subnet)"},{"line_number":200,"context_line":"        extra_params[\u0027fixed_subnet\u0027] \u003d \\"},{"line_number":201,"context_line":"            (neutron.get_fixed_subnet_id(context, fixed_subnet)"},{"line_number":202,"context_line":"                if fixed_subnet else None)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        label_list \u003d [\u0027flannel_network_cidr\u0027, \u0027flannel_backend\u0027,"},{"line_number":205,"context_line":"                      \u0027flannel_network_subnetlen\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_a8735a15","line":202,"range":{"start_line":180,"start_character":0,"end_line":202,"end_character":42},"updated":"2019-10-17 09:40:50.000000000","message":"IMO, verbosity for the exact same path is good:\n        external_network \u003d cluster_template.external_network_id\n        e_net_id \u003d neutron.get_external_network_id(context, external_network)\n        extra_params[\u0027external_network\u0027] \u003d e_net_id\n\n        # NOTE(brtknr): Convert fixed network UUID to name if the given network\n        # name is UUID like because OpenStack Cloud Controller Manager only\n        # accepts a name as an argument to internal-network-name in the\n        # cloud-config file provided to it. The default fixed network name is\n        # the same as that defined in the heat template.\n        if cluster.fixed_network:\n            fixed_network \u003d cluster.fixed_network\n            net_name \u003d neutron.get_fixed_network_name(context, fixed_network)\n            extra_params[\u0027fixed_network_name\u0027] \u003d net_name\n\n        # NOTE(brtknr): Convert fixed subnet name to UUID. If fixed_subnet\n        # is not specified in cluster template use \u0027private\u0027 as the default\n        # value, which is the same as the heat template default value.\n        if cluster.fixed_subnet:\n            fixed_subnet \u003d cluster.fixed_subnet\n            subnet_id \u003d neutron.get_fixed_subnet_id(context, fixed_subnet)\n            extra_params[\u0027fixed_subnet\u0027] \u003d subnet_id","commit_id":"1709d85849f21571496f8b60702806368736aa2e"}],"magnum/tests/unit/drivers/test_template_definition.py":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"2397c97a67e015ede11a2156187866ce295b13b2","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        mock_cluster_template.network_driver \u003d \u0027flannel\u0027"},{"line_number":442,"context_line":"        external_network_id \u003d \u002717e4e301-b7f3-4996-b3dd-97b3a700174b\u0027"},{"line_number":443,"context_line":"        mock_cluster_template.external_network_id \u003d external_network_id"},{"line_number":444,"context_line":"        mock_cluster \u003d mock.MagicMock()"},{"line_number":445,"context_line":"        fixed_network_name \u003d \u0027fixed_network\u0027"},{"line_number":446,"context_line":"        mock_get_fixed_network_name.return_value \u003d fixed_network_name"},{"line_number":447,"context_line":"        fixed_network \u003d \u00275d12f6fd-a196-4bf0-ae4c-1f639a523a52\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_aa010b09","line":444,"updated":"2019-10-17 15:16:35.000000000","message":"I added the test case here","commit_id":"2afd1638b9f39daa57e44f6c9687d587675f339e"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"87a82d96df712bc4ce41097ec990a27627eeb5bc","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        mock_cluster_template.network_driver \u003d \u0027flannel\u0027"},{"line_number":442,"context_line":"        external_network_id \u003d \u002717e4e301-b7f3-4996-b3dd-97b3a700174b\u0027"},{"line_number":443,"context_line":"        mock_cluster_template.external_network_id \u003d external_network_id"},{"line_number":444,"context_line":"        mock_cluster \u003d mock.MagicMock()"},{"line_number":445,"context_line":"        fixed_network_name \u003d \u0027fixed_network\u0027"},{"line_number":446,"context_line":"        mock_get_fixed_network_name.return_value \u003d fixed_network_name"},{"line_number":447,"context_line":"        fixed_network \u003d \u00275d12f6fd-a196-4bf0-ae4c-1f639a523a52\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_adfcc5b5","line":444,"in_reply_to":"3fa7e38b_aa010b09","updated":"2019-10-17 15:29:48.000000000","message":"I must have clicked one of the previous runs of zuul. My apologies.","commit_id":"2afd1638b9f39daa57e44f6c9687d587675f339e"}]}