)]}'
{"doc/source/user/index.rst":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"5809b920fef379f6d4d072dde4edc7f921dab11d","unresolved":false,"context_lines":[{"line_number":311,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":312,"context_line":"| `prometheus_operator_chart_tag`_      | see below          | see below     |"},{"line_number":313,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":314,"context_line":"| `prometheus_adapter_enabled`_         | - true             | true          |"},{"line_number":315,"context_line":"|                                       | - false            |               |"},{"line_number":316,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":317,"context_line":"| `prometheus_adapter_chart_tag`_       | see below          | see below     |"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_51ae3ce4","line":314,"range":{"start_line":314,"start_character":63,"end_line":314,"end_character":67},"updated":"2019-12-11 10:30:31.000000000","message":"This should be the same as monitoring_enabled, not enabled by default.","commit_id":"354575804f216fa24716a7f5256ceaf3241ba512"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"09d5d3a113cb1ad04812a370fd17a3dbf3b59242","unresolved":false,"context_lines":[{"line_number":311,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":312,"context_line":"| `prometheus_operator_chart_tag`_      | see below          | see below     |"},{"line_number":313,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":314,"context_line":"| `prometheus_adapter_enabled`_         | - true             | true          |"},{"line_number":315,"context_line":"|                                       | - false            |               |"},{"line_number":316,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":317,"context_line":"| `prometheus_adapter_chart_tag`_       | see below          | see below     |"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_f4db961d","line":314,"range":{"start_line":314,"start_character":63,"end_line":314,"end_character":67},"in_reply_to":"3fa7e38b_51ae3ce4","updated":"2019-12-11 12:07:27.000000000","message":"I don\u0027t agree on setting this the same as monitoring_enabled as they do different things, and this actually consumes some resources.\n\nAlso i never tried to scale this. \nAs it is only installed if monitoring_enabled exists, if the user wants to deactivate it because has no use to it it\u0027s ok.\n\nI would live this as it is. Also it follows the rule of enable/disable.","commit_id":"354575804f216fa24716a7f5256ceaf3241ba512"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"5809b920fef379f6d4d072dde4edc7f921dab11d","unresolved":false,"context_lines":[{"line_number":1323,"context_line":"  Enable installation of cluster custom metrics provided by the"},{"line_number":1324,"context_line":"  stable/prometheus-adapter helm chart. This service depends on"},{"line_number":1325,"context_line":"  monitoring_enabled."},{"line_number":1326,"context_line":"  Default: true"},{"line_number":1327,"context_line":""},{"line_number":1328,"context_line":"_`prometheus_adapter_chart_tag`"},{"line_number":1329,"context_line":"  The stable/prometheus-adapter helm chart version to use."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_f182c851","line":1326,"range":{"start_line":1326,"start_character":11,"end_line":1326,"end_character":15},"updated":"2019-12-11 10:30:31.000000000","message":"ditto","commit_id":"354575804f216fa24716a7f5256ceaf3241ba512"}],"magnum/drivers/common/templates/kubernetes/helm/prometheus-adapter.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"d0a60b63430fed1aa36698ae15dd27c5a9d3f17f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"### Configuration"},{"line_number":11,"context_line":"###############################################################################"},{"line_number":12,"context_line":"CHART_NAME\u003d\"prometheus-adapter\""},{"line_number":13,"context_line":"CHART_VERSION\u003d${PROMETHEUS_ADAPTER_CHART_TAG}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if [ \"$(echo ${MONITORING_ENABLED} | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ] \u0026\u0026 \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_9a31f20d","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":13},"updated":"2019-11-26 22:03:19.000000000","message":"this feels unnecessary","commit_id":"9aeda241d6c5a994211215598c3c508bb59de49c"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"8241c0ca0f7344b8eaf803d0bed9b2ee22e380c0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"### Configuration"},{"line_number":11,"context_line":"###############################################################################"},{"line_number":12,"context_line":"CHART_NAME\u003d\"prometheus-adapter\""},{"line_number":13,"context_line":"CHART_VERSION\u003d${PROMETHEUS_ADAPTER_CHART_TAG}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if [ \"$(echo ${MONITORING_ENABLED} | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ] \u0026\u0026 \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_4aa085f4","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":13},"in_reply_to":"3fa7e38b_9a31f20d","updated":"2019-11-27 09:43:00.000000000","message":"Will change","commit_id":"9aeda241d6c5a994211215598c3c508bb59de49c"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"8241c0ca0f7344b8eaf803d0bed9b2ee22e380c0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"      url: http://web.tcp.prometheus-prometheus.kube-system.svc.cluster.local"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    rules:"},{"line_number":64,"context_line":"      existing: ${PROMETHEUS_ADAPTER_CONFIGMAP:-\"\"}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    # tls:"},{"line_number":67,"context_line":"    #   enable: true"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_6aa54103","line":64,"range":{"start_line":64,"start_character":16,"end_line":64,"end_character":51},"updated":"2019-11-27 09:43:00.000000000","message":"i will also change this to ${PROMETHEUS_ADAPTER_CONFIGMAP}","commit_id":"9aeda241d6c5a994211215598c3c508bb59de49c"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"5809b920fef379f6d4d072dde4edc7f921dab11d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    priorityClassName: \"system-cluster-critical\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    prometheus:"},{"line_number":60,"context_line":"      url: http://web.tcp.prometheus-prometheus.kube-system.svc.cluster.local"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    resources:"},{"line_number":63,"context_line":"      requests:"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_31e1402c","line":60,"range":{"start_line":60,"start_character":11,"end_line":60,"end_character":77},"updated":"2019-12-11 10:30:31.000000000","message":"This assumes that the prometheus-operator is installed as prometheus, correct? Not an issue, just a clarification.","commit_id":"354575804f216fa24716a7f5256ceaf3241ba512"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"09d5d3a113cb1ad04812a370fd17a3dbf3b59242","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    priorityClassName: \"system-cluster-critical\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    prometheus:"},{"line_number":60,"context_line":"      url: http://web.tcp.prometheus-prometheus.kube-system.svc.cluster.local"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    resources:"},{"line_number":63,"context_line":"      requests:"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_949ca25b","line":60,"range":{"start_line":60,"start_character":11,"end_line":60,"end_character":77},"in_reply_to":"3fa7e38b_31e1402c","updated":"2019-12-11 12:07:27.000000000","message":"This only works with the monitoring_enabled current way of installing prometheus, yes","commit_id":"354575804f216fa24716a7f5256ceaf3241ba512"}],"magnum/drivers/k8s_fedora_atomic_v1/templates/kubecluster.yaml":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"5809b920fef379f6d4d072dde4edc7f921dab11d","unresolved":false,"context_lines":[{"line_number":669,"context_line":"  prometheus_adapter_enabled:"},{"line_number":670,"context_line":"    type: boolean"},{"line_number":671,"context_line":"    description: Enable or disable prometheus-adapter custom metrics."},{"line_number":672,"context_line":"    default: true"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"  prometheus_adapter_chart_tag:"},{"line_number":675,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_d1c9ccaa","line":672,"range":{"start_line":672,"start_character":13,"end_line":672,"end_character":17},"updated":"2019-12-11 10:30:31.000000000","message":"ditto","commit_id":"354575804f216fa24716a7f5256ceaf3241ba512"}],"magnum/drivers/k8s_fedora_coreos_v1/templates/kubecluster.yaml":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"d0a60b63430fed1aa36698ae15dd27c5a9d3f17f","unresolved":false,"context_lines":[{"line_number":676,"context_line":"    description: The stable/prometheus-adapter chart version to use."},{"line_number":677,"context_line":"    default: 1.4.0"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"  prometheus_adapter_configmap:"},{"line_number":680,"context_line":"    type: string"},{"line_number":681,"context_line":"    description: The prometheus adapter rules ConfigMap name to use as overwrite."},{"line_number":682,"context_line":"    default: \"\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_5a3b7ae9","line":679,"range":{"start_line":679,"start_character":2,"end_line":679,"end_character":30},"updated":"2019-11-26 22:03:19.000000000","message":"why do we have this? it doesnt exist when the cluster is created.","commit_id":"9aeda241d6c5a994211215598c3c508bb59de49c"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"8241c0ca0f7344b8eaf803d0bed9b2ee22e380c0","unresolved":false,"context_lines":[{"line_number":676,"context_line":"    description: The stable/prometheus-adapter chart version to use."},{"line_number":677,"context_line":"    default: 1.4.0"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"  prometheus_adapter_configmap:"},{"line_number":680,"context_line":"    type: string"},{"line_number":681,"context_line":"    description: The prometheus adapter rules ConfigMap name to use as overwrite."},{"line_number":682,"context_line":"    default: \"\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_aa76d9a2","line":679,"range":{"start_line":679,"start_character":2,"end_line":679,"end_character":30},"in_reply_to":"3fa7e38b_5a3b7ae9","updated":"2019-11-27 09:43:00.000000000","message":"This is in the case the user wants to use their own config map. We had a request for this specifically. \n\nWhat happens when you specify a configMap to be used, the prometheus-adapter will use this one which will override all the other defined rules.\n\nFrom https://github.com/helm/charts/tree/master/stable/prometheus-adapter\n\nrules.existing\t- The name of an existing configMap with rules. Overrides default, custom and external.","commit_id":"9aeda241d6c5a994211215598c3c508bb59de49c"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"5809b920fef379f6d4d072dde4edc7f921dab11d","unresolved":false,"context_lines":[{"line_number":669,"context_line":"  prometheus_adapter_enabled:"},{"line_number":670,"context_line":"    type: boolean"},{"line_number":671,"context_line":"    description: Enable or disable prometheus-adapter custom metrics."},{"line_number":672,"context_line":"    default: true"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"  prometheus_adapter_chart_tag:"},{"line_number":675,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_71c49892","line":672,"range":{"start_line":672,"start_character":13,"end_line":672,"end_character":17},"updated":"2019-12-11 10:30:31.000000000","message":"ditto","commit_id":"354575804f216fa24716a7f5256ceaf3241ba512"}],"releasenotes/notes/prometheus-adapter-15fba9d739676e70.yaml":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"5809b920fef379f6d4d072dde4edc7f921dab11d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added custom.metrics.k8s.io API installer by means of stable/prometheus-adapter"},{"line_number":5,"context_line":"    helm chart. The label prometheus_adapter_enabled (default: true) controls"},{"line_number":6,"context_line":"    configuration. You can also use prometheus_adapter_chart_tag to select helm"},{"line_number":7,"context_line":"    chart version, and prometheus_adapter_configmap if you would like to setup"},{"line_number":8,"context_line":"    your own metrics (specifying this other than default overwrites default"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_91bfd4fa","line":5,"range":{"start_line":5,"start_character":63,"end_line":5,"end_character":67},"updated":"2019-12-11 10:30:31.000000000","message":"ditto","commit_id":"354575804f216fa24716a7f5256ceaf3241ba512"}]}