)]}'
{"magnum/drivers/common/templates/kubernetes/helm/ingress-nginx.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"8383b00e7caa8ae5f603cc5ac048bdde7ad72cc9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        echo \"${CHART_NAME} already installed on server. Continue...\""},{"line_number":46,"context_line":"        exit 0"},{"line_number":47,"context_line":"    else"},{"line_number":48,"context_line":"        helm install stable/${CHART_NAME} --namespace kube-system --name ${CHART_NAME} --version v${NGINX_INGRESS_CONTROLLER_CHART_TAG} --values /opt/magnum/install-${CHART_NAME}-values.yaml"},{"line_number":49,"context_line":"    fi"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  install-${CHART_NAME}-values.yaml:  |"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_9a64c0e6","side":"PARENT","line":48,"range":{"start_line":48,"start_character":97,"end_line":48,"end_character":98},"updated":"2019-11-22 15:52:28.000000000","message":"lets leave this v here","commit_id":"12ae3412b9c38f1fcc1b9ef678834f9010017a5d"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"dbbf64e7081433d73e436334ff74a6a4aed3c5bd","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        echo \"${CHART_NAME} already installed on server. Continue...\""},{"line_number":46,"context_line":"        exit 0"},{"line_number":47,"context_line":"    else"},{"line_number":48,"context_line":"        helm install stable/${CHART_NAME} --namespace kube-system --name ${CHART_NAME} --version v${NGINX_INGRESS_CONTROLLER_CHART_TAG} --values /opt/magnum/install-${CHART_NAME}-values.yaml"},{"line_number":49,"context_line":"    fi"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  install-${CHART_NAME}-values.yaml:  |"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_fa1374b6","side":"PARENT","line":48,"range":{"start_line":48,"start_character":97,"end_line":48,"end_character":98},"in_reply_to":"3fa7e38b_9a64c0e6","updated":"2019-11-22 16:18:20.000000000","message":"Not a good idea, because the version then is appended an extra v. \nIf i use a label with v1.0.0 the result will be vv1.0.0 which wont work","commit_id":"12ae3412b9c38f1fcc1b9ef678834f9010017a5d"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"6de97527a84a8fb4bcd9d27c91ec5cd991893f69","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        echo \"${CHART_NAME} already installed on server. Continue...\""},{"line_number":46,"context_line":"        exit 0"},{"line_number":47,"context_line":"    else"},{"line_number":48,"context_line":"        helm install stable/${CHART_NAME} --namespace kube-system --name ${CHART_NAME} --version v${NGINX_INGRESS_CONTROLLER_CHART_TAG} --values /opt/magnum/install-${CHART_NAME}-values.yaml"},{"line_number":49,"context_line":"    fi"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  install-${CHART_NAME}-values.yaml:  |"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_dd4f8832","side":"PARENT","line":48,"range":{"start_line":48,"start_character":97,"end_line":48,"end_character":98},"in_reply_to":"3fa7e38b_fa1374b6","updated":"2019-11-24 11:21:17.000000000","message":"either way, this change is unrelated to the commit message. i can deal with it in  the previous commit we can deal with it separately.","commit_id":"12ae3412b9c38f1fcc1b9ef678834f9010017a5d"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"8c3bd964980ec9a3d1519e79331dcdbe2fe9b0ad","unresolved":false,"context_lines":[{"line_number":161,"context_line":"          enabled: ${MONITORING_ENABLED}"},{"line_number":162,"context_line":"          additionalLabels:"},{"line_number":163,"context_line":"            release: prometheus-operator"},{"line_number":164,"context_line":"          namespace: kube-system"},{"line_number":165,"context_line":"      lifecycle: {}"},{"line_number":166,"context_line":"      priorityClassName: \"\""},{"line_number":167,"context_line":"    revisionHistoryLimit: 10"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_6e5ef945","line":164,"range":{"start_line":164,"start_character":10,"end_line":164,"end_character":32},"updated":"2019-12-11 10:10:56.000000000","message":"Isn\u0027t this true?\nnamespace: \"\"   # defaults to .Release.Namespace\nhttps://review.opendev.org/#/c/695681/4/magnum/drivers/common/templates/kubernetes/helm/ingress-nginx.sh@48","commit_id":"6703cbddfa881492b39eccf5c8754af5cacbe2dd"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"435ea2ea465f5824cb8ddf10457da4c3ede3e00b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"          enabled: ${MONITORING_ENABLED}"},{"line_number":162,"context_line":"          additionalLabels:"},{"line_number":163,"context_line":"            release: prometheus-operator"},{"line_number":164,"context_line":"          namespace: kube-system"},{"line_number":165,"context_line":"      lifecycle: {}"},{"line_number":166,"context_line":"      priorityClassName: \"\""},{"line_number":167,"context_line":"    revisionHistoryLimit: 10"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_37685086","line":164,"range":{"start_line":164,"start_character":10,"end_line":164,"end_character":32},"in_reply_to":"3fa7e38b_173994a1","updated":"2019-12-11 12:56:31.000000000","message":"wherever you think it is easier?","commit_id":"6703cbddfa881492b39eccf5c8754af5cacbe2dd"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"46378b9e24bfd93111b839b13eddb921ac8d6c42","unresolved":false,"context_lines":[{"line_number":161,"context_line":"          enabled: ${MONITORING_ENABLED}"},{"line_number":162,"context_line":"          additionalLabels:"},{"line_number":163,"context_line":"            release: prometheus-operator"},{"line_number":164,"context_line":"          namespace: kube-system"},{"line_number":165,"context_line":"      lifecycle: {}"},{"line_number":166,"context_line":"      priorityClassName: \"\""},{"line_number":167,"context_line":"    revisionHistoryLimit: 10"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_b11c5066","line":164,"range":{"start_line":164,"start_character":10,"end_line":164,"end_character":32},"in_reply_to":"3fa7e38b_6e5ef945","updated":"2019-12-11 10:17:53.000000000","message":"Bharat ^^","commit_id":"6703cbddfa881492b39eccf5c8754af5cacbe2dd"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"6800a910e4385fec0a5c6d3b97c01e8f83c4f156","unresolved":false,"context_lines":[{"line_number":161,"context_line":"          enabled: ${MONITORING_ENABLED}"},{"line_number":162,"context_line":"          additionalLabels:"},{"line_number":163,"context_line":"            release: prometheus-operator"},{"line_number":164,"context_line":"          namespace: kube-system"},{"line_number":165,"context_line":"      lifecycle: {}"},{"line_number":166,"context_line":"      priorityClassName: \"\""},{"line_number":167,"context_line":"    revisionHistoryLimit: 10"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_71f7b8d5","line":164,"range":{"start_line":164,"start_character":10,"end_line":164,"end_character":32},"in_reply_to":"3fa7e38b_6e5ef945","updated":"2019-12-11 10:34:07.000000000","message":"I guess it does. Is this redundant in that case?","commit_id":"6703cbddfa881492b39eccf5c8754af5cacbe2dd"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"cf92a958fa12717db445706a5a9f7c36c7f612f6","unresolved":false,"context_lines":[{"line_number":161,"context_line":"          enabled: ${MONITORING_ENABLED}"},{"line_number":162,"context_line":"          additionalLabels:"},{"line_number":163,"context_line":"            release: prometheus-operator"},{"line_number":164,"context_line":"          namespace: kube-system"},{"line_number":165,"context_line":"      lifecycle: {}"},{"line_number":166,"context_line":"      priorityClassName: \"\""},{"line_number":167,"context_line":"    revisionHistoryLimit: 10"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_747c861f","line":164,"range":{"start_line":164,"start_character":10,"end_line":164,"end_character":32},"in_reply_to":"3fa7e38b_71f7b8d5","updated":"2019-12-11 12:02:36.000000000","message":"This is the namespace for the service selection by the serviceMonitor \nThis is not the namespace of the serviceMonitor manifest.","commit_id":"6703cbddfa881492b39eccf5c8754af5cacbe2dd"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"6308daffb5ac143729e8cb2de5d5d18773d68b32","unresolved":false,"context_lines":[{"line_number":161,"context_line":"          enabled: ${MONITORING_ENABLED}"},{"line_number":162,"context_line":"          additionalLabels:"},{"line_number":163,"context_line":"            release: prometheus-operator"},{"line_number":164,"context_line":"          namespace: kube-system"},{"line_number":165,"context_line":"      lifecycle: {}"},{"line_number":166,"context_line":"      priorityClassName: \"\""},{"line_number":167,"context_line":"    revisionHistoryLimit: 10"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_173994a1","line":164,"range":{"start_line":164,"start_character":10,"end_line":164,"end_character":32},"in_reply_to":"3fa7e38b_740c8641","updated":"2019-12-11 12:53:23.000000000","message":"This is how the operator works.\n\nhttps://imgur.com/emLI9j7\n\nAll the documentation is in the upstream stable/nginx-ingress... \nAnd this is tied to the monitoring_enabled way of installing prometheus... \nWhat we can do is add in the helm chart installer notes of dependable changes, so that if you change the prometheus-operator (namespace, or chart name) you don forget to change these ones too??","commit_id":"6703cbddfa881492b39eccf5c8754af5cacbe2dd"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4c9c0fe62683c3dc90aa03ae7a8c0eadd9c1c7c9","unresolved":false,"context_lines":[{"line_number":161,"context_line":"          enabled: ${MONITORING_ENABLED}"},{"line_number":162,"context_line":"          additionalLabels:"},{"line_number":163,"context_line":"            release: prometheus-operator"},{"line_number":164,"context_line":"          namespace: kube-system"},{"line_number":165,"context_line":"      lifecycle: {}"},{"line_number":166,"context_line":"      priorityClassName: \"\""},{"line_number":167,"context_line":"    revisionHistoryLimit: 10"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_740c8641","line":164,"range":{"start_line":164,"start_character":10,"end_line":164,"end_character":32},"in_reply_to":"3fa7e38b_747c861f","updated":"2019-12-11 12:34:23.000000000","message":"ok, this means prometheus-operator must be installed in kube-system and the release named \"prometheus-operator\", right?\nMany assumptions, shouldn\u0027t we mention these things maybe as as comment in this file? thoughts?","commit_id":"6703cbddfa881492b39eccf5c8754af5cacbe2dd"}]}