)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"65bcff24dfd30f2c2959e2f7440058ceddd1acee","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Install traefik with helm"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Upgrade to traefik helm chart tag v10.0.0"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"task: 37707"},{"line_number":12,"context_line":"story: 2005286"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"fc81bc68_93e6d2b5","line":9,"range":{"start_line":9,"start_character":34,"end_line":9,"end_character":41},"updated":"2021-08-10 18:26:59.000000000","message":"please update and add reno","commit_id":"c9826fd7aca3e3eb50032624b7b8d1bfe974aed7"}],"doc/source/user/index.rst":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"aab0dc344820e39e5b22c8cdae684896529f6f4e","unresolved":true,"context_lines":[{"line_number":411,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":412,"context_line":"| `traefik_ingress_controller_tag`_     | see below          | see below     |"},{"line_number":413,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":414,"context_line":"| `traefik_chart_tag`_                  | see below          | see below     |"},{"line_number":415,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":416,"context_line":"| `kubelet_options`_                    | extra kubelet args | \"\"            |"},{"line_number":417,"context_line":"+---------------------------------------+--------------------+---------------+"}],"source_content_type":"text/x-rst","patch_set":11,"id":"c8f23a85_05eb48b3","line":414,"range":{"start_line":414,"start_character":3,"end_line":414,"end_character":20},"updated":"2021-08-03 13:50:37.000000000","message":"traefik_ingress_controller_chart_tag would be more consistent with nginx_ingress_controller_chart_tag","commit_id":"d73b98bc31a8f1eb4448a34784d09eeae30b46a4"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"9764fe2106e990a37f3cc224ac78b2871c6dcb92","unresolved":false,"context_lines":[{"line_number":411,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":412,"context_line":"| `traefik_ingress_controller_tag`_     | see below          | see below     |"},{"line_number":413,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":414,"context_line":"| `traefik_chart_tag`_                  | see below          | see below     |"},{"line_number":415,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":416,"context_line":"| `kubelet_options`_                    | extra kubelet args | \"\"            |"},{"line_number":417,"context_line":"+---------------------------------------+--------------------+---------------+"}],"source_content_type":"text/x-rst","patch_set":11,"id":"20e0b647_00fc03ce","line":414,"range":{"start_line":414,"start_character":3,"end_line":414,"end_character":20},"in_reply_to":"1a9f034e_3ced9c59","updated":"2021-08-11 11:25:19.000000000","message":"Done","commit_id":"d73b98bc31a8f1eb4448a34784d09eeae30b46a4"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"c2e169641cb88035f31f035c4a6a172243b6d546","unresolved":true,"context_lines":[{"line_number":411,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":412,"context_line":"| `traefik_ingress_controller_tag`_     | see below          | see below     |"},{"line_number":413,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":414,"context_line":"| `traefik_chart_tag`_                  | see below          | see below     |"},{"line_number":415,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":416,"context_line":"| `kubelet_options`_                    | extra kubelet args | \"\"            |"},{"line_number":417,"context_line":"+---------------------------------------+--------------------+---------------+"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1a9f034e_3ced9c59","line":414,"range":{"start_line":414,"start_character":3,"end_line":414,"end_character":20},"in_reply_to":"79e10a7e_c7e2e419","updated":"2021-08-03 14:09:37.000000000","message":"Yes I actually do, please ignore my last comment. We should have renamed the other value tbh. Wonder if there is a way we can rename it and make it backward compatible somehow.","commit_id":"d73b98bc31a8f1eb4448a34784d09eeae30b46a4"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"4cf6452c5ca640e64bfe56dcd8515275821a6f83","unresolved":true,"context_lines":[{"line_number":411,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":412,"context_line":"| `traefik_ingress_controller_tag`_     | see below          | see below     |"},{"line_number":413,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":414,"context_line":"| `traefik_chart_tag`_                  | see below          | see below     |"},{"line_number":415,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":416,"context_line":"| `kubelet_options`_                    | extra kubelet args | \"\"            |"},{"line_number":417,"context_line":"+---------------------------------------+--------------------+---------------+"}],"source_content_type":"text/x-rst","patch_set":11,"id":"79e10a7e_c7e2e419","line":414,"range":{"start_line":414,"start_character":3,"end_line":414,"end_character":20},"in_reply_to":"c8f23a85_05eb48b3","updated":"2021-08-03 14:06:06.000000000","message":"\u003e traefik_ingress_controller_chart_tag would be more consistent with nginx_ingress_controller_chart_tag\n\ntraefik_chart_tag is consistent how all the tags (but this one) for the helm charts are used \u003cChartName\u003e_chart_tag\n\nusing traefik_ingress_controller_chart_tag requires the entire doc table to be rewritten. I thought you would prefer this way...\n\nPlease see:\n* prometheus_operator_chart_tag\n* prometheus_adapter_chart_tag\n* metrics_server_chart_tag","commit_id":"d73b98bc31a8f1eb4448a34784d09eeae30b46a4"}],"magnum/drivers/common/templates/kubernetes/helm/ingress-traefik.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"392170676f9a0d362f8e2126d68b098e30dab0ad","unresolved":true,"context_lines":[{"line_number":68,"context_line":"      - TLS_RSA_WITH_AES_256_CBC_SHA"},{"line_number":69,"context_line":"      - TLS_RSA_WITH_AES_128_CBC_SHA"},{"line_number":70,"context_line":"  service:"},{"line_number":71,"context_line":"    type: NodePort"},{"line_number":72,"context_line":"  hostNetwork: true"},{"line_number":73,"context_line":"  podSecurityPolicy:"},{"line_number":74,"context_line":"    enabled: true"}],"source_content_type":"text/x-sh","patch_set":8,"id":"62b050a9_1cf76728","line":71,"updated":"2021-07-27 13:36:03.000000000","message":"Since we expose with hostNetwork this is redundant, let\u0027s remove this. (In other places it is redundant as well).","commit_id":"d974aafc926bda33310424b8f28960b827abf31d"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"299f81f9015883ad2f1b9e4afe7da68dc2d88932","unresolved":true,"context_lines":[{"line_number":68,"context_line":"      - TLS_RSA_WITH_AES_256_CBC_SHA"},{"line_number":69,"context_line":"      - TLS_RSA_WITH_AES_128_CBC_SHA"},{"line_number":70,"context_line":"  service:"},{"line_number":71,"context_line":"    type: NodePort"},{"line_number":72,"context_line":"  hostNetwork: true"},{"line_number":73,"context_line":"  podSecurityPolicy:"},{"line_number":74,"context_line":"    enabled: true"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ea5baaa1_b98118ed","line":71,"in_reply_to":"3a1448cf_7d4b254e","updated":"2021-07-28 12:26:14.000000000","message":"What about ClusterIP?","commit_id":"d974aafc926bda33310424b8f28960b827abf31d"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"15f708b67d4a0d787022390b7eaee45003421e60","unresolved":true,"context_lines":[{"line_number":68,"context_line":"      - TLS_RSA_WITH_AES_256_CBC_SHA"},{"line_number":69,"context_line":"      - TLS_RSA_WITH_AES_128_CBC_SHA"},{"line_number":70,"context_line":"  service:"},{"line_number":71,"context_line":"    type: NodePort"},{"line_number":72,"context_line":"  hostNetwork: true"},{"line_number":73,"context_line":"  podSecurityPolicy:"},{"line_number":74,"context_line":"    enabled: true"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3a1448cf_7d4b254e","line":71,"in_reply_to":"62b050a9_1cf76728","updated":"2021-07-28 12:08:27.000000000","message":"The service must be set, otherwise it will default to type: LoadBalancer\nhttps://github.com/traefik/traefik-helm-chart/blob/47240bbfdf2d5355c800946d0055bfac85cdebf4/traefik/values.yaml#L330","commit_id":"d974aafc926bda33310424b8f28960b827abf31d"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"6b9107033daffb2d2a8811e603e4c5a3096fa9e3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"      - TLS_RSA_WITH_AES_256_CBC_SHA"},{"line_number":69,"context_line":"      - TLS_RSA_WITH_AES_128_CBC_SHA"},{"line_number":70,"context_line":"  service:"},{"line_number":71,"context_line":"    type: NodePort"},{"line_number":72,"context_line":"  hostNetwork: true"},{"line_number":73,"context_line":"  podSecurityPolicy:"},{"line_number":74,"context_line":"    enabled: true"}],"source_content_type":"text/x-sh","patch_set":8,"id":"5cf68a2c_1c2f5575","line":71,"in_reply_to":"ea5baaa1_b98118ed","updated":"2021-07-28 13:06:15.000000000","message":"ClusterIP can work.","commit_id":"d974aafc926bda33310424b8f28960b827abf31d"}],"magnum/drivers/common/templates/kubernetes/helm/traefik.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"77e0c512ee750b79f7346374543ea8c93cb4bc4f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# TODO: Use the existent label for which kind of ingress to install (like nginx)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"CHART_NAME\u003d\"traefik\""},{"line_number":10,"context_line":"TRAEFIK_CHART_TAG\u003d\"1.79.0\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"HELM_MODULE_CONFIG_FILE\u003d\"/srv/magnum/kubernetes/helm/${CHART_NAME}.yaml\""},{"line_number":13,"context_line":"[ -f ${HELM_MODULE_CONFIG_FILE} ] || {"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_399bde17","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":17},"updated":"2019-12-03 14:55:23.000000000","message":"this should be a configurable label","commit_id":"933fc0462aad7f509730b9c449f06fb2848f82dc"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"666e1896b8683c3aa4e87d33740ac69477498d99","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# TODO: Use the existent label for which kind of ingress to install (like nginx)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"CHART_NAME\u003d\"traefik\""},{"line_number":10,"context_line":"TRAEFIK_CHART_TAG\u003d\"1.79.0\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"HELM_MODULE_CONFIG_FILE\u003d\"/srv/magnum/kubernetes/helm/${CHART_NAME}.yaml\""},{"line_number":13,"context_line":"[ -f ${HELM_MODULE_CONFIG_FILE} ] || {"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_7120184a","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":17},"in_reply_to":"3fa7e38b_399bde17","updated":"2019-12-11 10:42:32.000000000","message":"+1","commit_id":"933fc0462aad7f509730b9c449f06fb2848f82dc"}]}
