)]}'
{"magnum/drivers/heat/driver.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"66b01162d1b91309c5c3e166287d289c3b10c937","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        return heat_params"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    @staticmethod"},{"line_number":362,"context_line":"    def get_new_labels(nodegroup, cluster_template):"},{"line_number":363,"context_line":"        new_labels \u003d nodegroup.labels.copy()"},{"line_number":364,"context_line":"        if \u0027kube_tag\u0027 in cluster_template.labels:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_ae283898","line":361,"updated":"2019-12-15 20:54:01.000000000","message":"Could you please let me know what\u0027s the value to extact this logic as a static method?","commit_id":"357e6cc351de37ca6e68ee5df59b0f75bc0d35f0"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"c2a025c0b29e8951a8bc2510d534a7fd5a87e947","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        return heat_params"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    @staticmethod"},{"line_number":362,"context_line":"    def get_new_labels(nodegroup, cluster_template):"},{"line_number":363,"context_line":"        new_labels \u003d nodegroup.labels.copy()"},{"line_number":364,"context_line":"        if \u0027kube_tag\u0027 in cluster_template.labels:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a115a9e8","line":361,"in_reply_to":"3fa7e38b_ae283898","updated":"2019-12-16 00:39:57.000000000","message":"Because it is not using any self derived variables","commit_id":"357e6cc351de37ca6e68ee5df59b0f75bc0d35f0"},{"author":{"_account_id":27057,"name":"Theodoros Tsioutsias","email":"theodoros.tsioutsias@cern.ch","username":"ttsiouts"},"change_message_id":"fa26723d459b21ff4adc7678b3efb2838b0cd7f1","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    def upgrade_cluster(self, context, cluster, cluster_template,"},{"line_number":370,"context_line":"                        max_batch_size, nodegroup, scale_manager\u003dNone,"},{"line_number":371,"context_line":"                        rollback\u003dFalse):"},{"line_number":372,"context_line":"        \"\"\"For Train release we are going to upgrade only the kube tag\"\"\""},{"line_number":373,"context_line":"        osc \u003d clients.OpenStackClients(context)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        # Use this just to check that we are not downgrading."}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_b5a63fac","line":372,"range":{"start_line":372,"start_character":8,"end_line":372,"end_character":73},"updated":"2019-12-16 09:34:45.000000000","message":"we should drop this also","commit_id":"357e6cc351de37ca6e68ee5df59b0f75bc0d35f0"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"4edb5adbeb95aadbd39b376ada2625742ab703a4","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    def upgrade_cluster(self, context, cluster, cluster_template,"},{"line_number":370,"context_line":"                        max_batch_size, nodegroup, scale_manager\u003dNone,"},{"line_number":371,"context_line":"                        rollback\u003dFalse):"},{"line_number":372,"context_line":"        \"\"\"For Train release we are going to upgrade only the kube tag\"\"\""},{"line_number":373,"context_line":"        osc \u003d clients.OpenStackClients(context)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        # Use this just to check that we are not downgrading."}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_f66efe62","line":372,"range":{"start_line":372,"start_character":8,"end_line":372,"end_character":73},"in_reply_to":"3fa7e38b_168f1a30","updated":"2019-12-16 11:08:37.000000000","message":"Done","commit_id":"357e6cc351de37ca6e68ee5df59b0f75bc0d35f0"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"d06e3f2c0dd4e7f63cf72bed52b478286b7c2862","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    def upgrade_cluster(self, context, cluster, cluster_template,"},{"line_number":370,"context_line":"                        max_batch_size, nodegroup, scale_manager\u003dNone,"},{"line_number":371,"context_line":"                        rollback\u003dFalse):"},{"line_number":372,"context_line":"        \"\"\"For Train release we are going to upgrade only the kube tag\"\"\""},{"line_number":373,"context_line":"        osc \u003d clients.OpenStackClients(context)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        # Use this just to check that we are not downgrading."}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_168f1a30","line":372,"range":{"start_line":372,"start_character":8,"end_line":372,"end_character":73},"in_reply_to":"3fa7e38b_b5a63fac","updated":"2019-12-16 11:05:56.000000000","message":"+1","commit_id":"357e6cc351de37ca6e68ee5df59b0f75bc0d35f0"}]}
