)]}'
{"magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-master.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"d0ed349d8a8592577539c640dde86d7d36eaed8e","unresolved":false,"context_lines":[{"line_number":245,"context_line":"EOF"},{"line_number":246,"context_line":"    KUBE_SHA256\u003d$(podman image inspect hyperkube --format \"{{.Digest}}\")"},{"line_number":247,"context_line":"    if [ -n \"${KUBE_TAG_SHA256}\"  ] \u0026\u0026 [ \"${KUBE_TAG_SHA256}\" !\u003d \"${KUBE_SHA256}\" ]; then"},{"line_number":248,"context_line":"        printf \"The sha256 ${KUBE_SHA256} of current hyperkube image cannot match the given one: ${KUBE_TAG_SHA256}.\""},{"line_number":249,"context_line":"        exit 1"},{"line_number":250,"context_line":"    fi"},{"line_number":251,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_bf92f5fa","line":248,"updated":"2019-12-09 23:00:55.000000000","message":"Nit: KUBE_SHA256 looks too similar to KUBE_TAG_SHA256. can we think of a better name? I would prefer it as just SHA256 or DIGEST.","commit_id":"09c2a487bf4bf41b023641397c0d0176a7c74027"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"b8277a485e6c77b4d4709d3702811ac5e2fd6fce","unresolved":false,"context_lines":[{"line_number":245,"context_line":"EOF"},{"line_number":246,"context_line":"    KUBE_SHA256\u003d$(podman image inspect hyperkube --format \"{{.Digest}}\")"},{"line_number":247,"context_line":"    if [ -n \"${KUBE_TAG_SHA256}\"  ] \u0026\u0026 [ \"${KUBE_TAG_SHA256}\" !\u003d \"${KUBE_SHA256}\" ]; then"},{"line_number":248,"context_line":"        printf \"The sha256 ${KUBE_SHA256} of current hyperkube image cannot match the given one: ${KUBE_TAG_SHA256}.\""},{"line_number":249,"context_line":"        exit 1"},{"line_number":250,"context_line":"    fi"},{"line_number":251,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_0a8986c5","line":248,"in_reply_to":"3fa7e38b_bf92f5fa","updated":"2019-12-10 08:22:37.000000000","message":"I hear you and I know it\u0027s not a perfect name. I would avoid just using SHA256 because it\u0027s too blur because the sha256 is only for the k8s image(s). How about k8s_image_sha256 or k8s_image_digest?","commit_id":"09c2a487bf4bf41b023641397c0d0176a7c74027"}],"magnum/drivers/common/templates/kubernetes/fragments/enable-services-master.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"cbf936dd39b21f95959411b25cf6fb9d30892689","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    sleep 5s"},{"line_number":33,"context_line":"done"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"KUBE_DIGEST\u003d$($ssh_cmd podman image inspect hyperkube:${KUBE_TAG} --format \"{{.Digest}}\")"},{"line_number":36,"context_line":"if [ -n \"${KUBE_IMAGE_DIGEST}\"  ] \u0026\u0026 [ \"${KUBE_IMAGE_DIGEST}\" !\u003d \"${KUBE_DIGEST}\" ]; then"},{"line_number":37,"context_line":"    printf \"The sha256 ${KUBE_DIGEST} of current hyperkube image cannot match the given one: ${KUBE_IMAGE_DIGEST}.\""},{"line_number":38,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3fa7e38b_18d8c7ed","line":35,"updated":"2020-01-10 09:12:50.000000000","message":"Don\u0027t we need this in enable-services-minion too?","commit_id":"a943756aeab2a6f54485da39be0d986660cd7db0"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"f2fa741b5a00908adb5b3ebe0a7f3fb64842355b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    sleep 5s"},{"line_number":33,"context_line":"done"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"KUBE_DIGEST\u003d$($ssh_cmd podman image inspect hyperkube:${KUBE_TAG} --format \"{{.Digest}}\")"},{"line_number":36,"context_line":"if [ -n \"${KUBE_IMAGE_DIGEST}\"  ] \u0026\u0026 [ \"${KUBE_IMAGE_DIGEST}\" !\u003d \"${KUBE_DIGEST}\" ]; then"},{"line_number":37,"context_line":"    printf \"The sha256 ${KUBE_DIGEST} of current hyperkube image cannot match the given one: ${KUBE_IMAGE_DIGEST}.\""},{"line_number":38,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3fa7e38b_38449173","line":35,"in_reply_to":"3fa7e38b_18d8c7ed","updated":"2020-01-13 00:58:24.000000000","message":"Good point. But because Magnum will bootstrap master node before worker node, so if the image digest doesn\u0027t match, the the cluster will fail when booting master.","commit_id":"a943756aeab2a6f54485da39be0d986660cd7db0"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"22225dc1d6ec095b39ff4e438b9402daa4af007c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    sleep 5s"},{"line_number":33,"context_line":"done"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"KUBE_DIGEST\u003d$($ssh_cmd podman image inspect hyperkube:${KUBE_TAG} --format \"{{.Digest}}\")"},{"line_number":36,"context_line":"if [ -n \"${KUBE_IMAGE_DIGEST}\"  ] \u0026\u0026 [ \"${KUBE_IMAGE_DIGEST}\" !\u003d \"${KUBE_DIGEST}\" ]; then"},{"line_number":37,"context_line":"    printf \"The sha256 ${KUBE_DIGEST} of current hyperkube image cannot match the given one: ${KUBE_IMAGE_DIGEST}.\""},{"line_number":38,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3fa7e38b_5ec055fa","line":35,"in_reply_to":"3fa7e38b_38449173","updated":"2020-01-13 08:03:57.000000000","message":"It would be useful for nodegroups. We can merge without it. I don\u0027t mind.","commit_id":"a943756aeab2a6f54485da39be0d986660cd7db0"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"86d3c3247164d957a85b97ce3e5b861ec0562399","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    sleep 5s"},{"line_number":33,"context_line":"done"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"KUBE_DIGEST\u003d$($ssh_cmd podman image inspect hyperkube:${KUBE_TAG} --format \"{{.Digest}}\")"},{"line_number":36,"context_line":"if [ -n \"${KUBE_IMAGE_DIGEST}\"  ] \u0026\u0026 [ \"${KUBE_IMAGE_DIGEST}\" !\u003d \"${KUBE_DIGEST}\" ]; then"},{"line_number":37,"context_line":"    printf \"The sha256 ${KUBE_DIGEST} of current hyperkube image cannot match the given one: ${KUBE_IMAGE_DIGEST}.\""},{"line_number":38,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3fa7e38b_36bc9606","line":35,"in_reply_to":"3fa7e38b_5ec055fa","updated":"2020-01-13 18:47:03.000000000","message":"That\u0027s a very good point. I can add it later. Thanks.","commit_id":"a943756aeab2a6f54485da39be0d986660cd7db0"}]}