)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"4cd4222797fb86d27ba5211a0a2c20507ecbc435","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xinliang Liu \u003cxinliang.liu@linaro.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-12-25 06:56:41 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent k8s heat software config scripts from exiting when there is no error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is a partial fix of bug:"},{"line_number":10,"context_line":"\"k8s atomic/cores driver is not working when tls_disabled\u003d\u0027true\u0027\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1fa4df85_055fbbe2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":76},"updated":"2020-02-26 15:07:53.000000000","message":"This title is too long!","commit_id":"611b386575f15a60dcd808cb9fc22bbb635e83bc"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"b4c7ceb3e06bb82f47b9f49afcce4dc7dcfa9c57","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent scripts from exiting when there is no error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is a partial fix of bug:"},{"line_number":10,"context_line":"\"k8s atomic/cores driver is not working when tls_disabled\u003d\u0027true\u0027\""},{"line_number":11,"context_line":"https://storyboard.openstack.org/#!/story/2007039"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_9fbc4bdd","line":9,"updated":"2020-02-27 06:08:23.000000000","message":"Why is this a partial fix? What is missing to fully fix this?","commit_id":"07eba2a078ec8c83fca3819c242c26992c28d161"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"2c71be5fb9d54a1e364bfe5b3c6542a7e6619c00","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent scripts from exiting when there is no error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is a partial fix of bug:"},{"line_number":10,"context_line":"\"k8s atomic/cores driver is not working when tls_disabled\u003d\u0027true\u0027\""},{"line_number":11,"context_line":"https://storyboard.openstack.org/#!/story/2007039"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_7fd4efbd","line":9,"in_reply_to":"1fa4df85_9fbc4bdd","updated":"2020-02-27 07:04:39.000000000","message":"More work to be done to handle certs related things, which is a little out of my knowledge. I\u0027ve added a comment about this on the story:\nhttps://storyboard.openstack.org/#!/story/2007039#comment-149292","commit_id":"07eba2a078ec8c83fca3819c242c26992c28d161"}],"magnum/drivers/common/templates/fragments/enable-docker-registry.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"2b08e21e372e2465848dea8b8790798153753493","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":". /etc/sysconfig/heat-params"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [ \"$REGISTRY_ENABLED\" \u003d \"True\" ]; then"},{"line_number":6,"context_line":"    ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    echo \"starting docker registry ...\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_ff742a9d","line":5,"range":{"start_line":5,"start_character":7,"end_line":5,"end_character":23},"updated":"2019-12-24 09:53:14.000000000","message":"it is better to pipe this into tr [:upper:] [:lower:]\neg. \"$(echo $REGISTRY_ENABLED | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d\u003d \"true\"","commit_id":"564d327c4a83b47de4a2839185c4bf675ace8c4e"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"958c79508ee8b96e14d90125994891a3c6af57d6","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":". /etc/sysconfig/heat-params"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [ \"$REGISTRY_ENABLED\" \u003d \"True\" ]; then"},{"line_number":6,"context_line":"    ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    echo \"starting docker registry ...\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_5fe21e04","line":5,"range":{"start_line":5,"start_character":7,"end_line":5,"end_character":23},"in_reply_to":"3fa7e38b_ff742a9d","updated":"2019-12-24 10:40:24.000000000","message":"OK, will update the patch soon.","commit_id":"564d327c4a83b47de4a2839185c4bf675ace8c4e"}],"magnum/drivers/common/templates/kubernetes/fragments/configure-etcd.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"28e7f366ab2553f5ba3d13ba0020636f76e0409d","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"fi"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"$ssh_cmd mkdir -p /etc/etcd"},{"line_number":54,"context_line":"if [ \"$(echo $USE_PODMAN | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d\u003d \"true\" ]; then"},{"line_number":55,"context_line":"    cat \u003e /etc/systemd/system/etcd.service \u003c\u003cEOF"},{"line_number":56,"context_line":"[Unit]"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_336f8ffc","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":27},"updated":"2020-02-20 17:08:25.000000000","message":"Why is this here?","commit_id":"611b386575f15a60dcd808cb9fc22bbb635e83bc"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"139452c0513bd6f6cdf5e7fd98398d1f80290b1b","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"fi"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"$ssh_cmd mkdir -p /etc/etcd"},{"line_number":54,"context_line":"if [ \"$(echo $USE_PODMAN | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d\u003d \"true\" ]; then"},{"line_number":55,"context_line":"    cat \u003e /etc/systemd/system/etcd.service \u003c\u003cEOF"},{"line_number":56,"context_line":"[Unit]"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1fa4df85_fbb7b3d7","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":27},"in_reply_to":"3fa7e38b_336f8ffc","updated":"2020-02-25 15:31:18.000000000","message":"Because bellow part use this dir.\nif TLS_DISABLE\u003dtrue this dir will not be generated at script make-cert.sh","commit_id":"611b386575f15a60dcd808cb9fc22bbb635e83bc"}],"magnum/drivers/common/templates/kubernetes/fragments/make-cert-client.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"2b08e21e372e2465848dea8b8790798153753493","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    CA_CERT\u003d$cert_dir/ca.crt"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    function generate_certificates {"},{"line_number":46,"context_line":"        _CERT\u003d$cert_dir/${1}.crt"},{"line_number":47,"context_line":"        _CSR\u003d$cert_dir/${1}.csr"},{"line_number":48,"context_line":"        _KEY\u003d$cert_dir/${1}.key"},{"line_number":49,"context_line":"        _CONF\u003d$2"},{"line_number":50,"context_line":"        #Get a token by user credentials and trust"},{"line_number":51,"context_line":"        auth_json\u003d$(cat \u003c\u003c EOF"},{"line_number":52,"context_line":"{"},{"line_number":53,"context_line":"    \"auth\": {"},{"line_number":54,"context_line":"        \"identity\": {"},{"line_number":55,"context_line":"            \"methods\": ["}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_5f653ee1","line":52,"range":{"start_line":45,"start_character":0,"end_line":52,"end_character":1},"updated":"2019-12-24 09:53:14.000000000","message":"the function can be defined outside of the if statement.","commit_id":"564d327c4a83b47de4a2839185c4bf675ace8c4e"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"958c79508ee8b96e14d90125994891a3c6af57d6","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    CA_CERT\u003d$cert_dir/ca.crt"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    function generate_certificates {"},{"line_number":46,"context_line":"        _CERT\u003d$cert_dir/${1}.crt"},{"line_number":47,"context_line":"        _CSR\u003d$cert_dir/${1}.csr"},{"line_number":48,"context_line":"        _KEY\u003d$cert_dir/${1}.key"},{"line_number":49,"context_line":"        _CONF\u003d$2"},{"line_number":50,"context_line":"        #Get a token by user credentials and trust"},{"line_number":51,"context_line":"        auth_json\u003d$(cat \u003c\u003c EOF"},{"line_number":52,"context_line":"{"},{"line_number":53,"context_line":"    \"auth\": {"},{"line_number":54,"context_line":"        \"identity\": {"},{"line_number":55,"context_line":"            \"methods\": ["}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_3fe72212","line":52,"range":{"start_line":45,"start_character":0,"end_line":52,"end_character":1},"in_reply_to":"3fa7e38b_5f653ee1","updated":"2019-12-24 10:40:24.000000000","message":"Sure, will put it before the if statement in update patch.","commit_id":"564d327c4a83b47de4a2839185c4bf675ace8c4e"}]}