)]}'
{"magnum/drivers/common/templates/kubernetes/fragments/enable-prometheus-monitoring.sh":[{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"4fa538284ae64609f5ec997ce3575643a92546f5","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":". /etc/sysconfig/heat-params"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"if [ ! -z \"$HTTP_PROXY\" ]; then"},{"line_number":9,"context_line":"    export HTTP_PROXY"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [ ! -z \"$HTTPS_PROXY\" ]; then"},{"line_number":13,"context_line":"    export HTTPS_PROXY"},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if [ ! -z \"$NO_PROXY\" ]; then"},{"line_number":17,"context_line":"    export NO_PROXY"},{"line_number":18,"context_line":"fi"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"function writeFile {"},{"line_number":21,"context_line":"    # $1 is filename"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_cd705676","line":18,"range":{"start_line":8,"start_character":0,"end_line":18,"end_character":2},"updated":"2020-01-27 10:16:21.000000000","message":"This is not used here....\n\nCould we run this in the end of the parameters script? (common place)","commit_id":"4346d776e5887af71e33748212bf4dcc2a220b66"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"b6bcb9d364bcc24403ef4753a6f3bfee538d9073","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":". /etc/sysconfig/heat-params"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"if [ ! -z \"$HTTP_PROXY\" ]; then"},{"line_number":9,"context_line":"    export HTTP_PROXY"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [ ! -z \"$HTTPS_PROXY\" ]; then"},{"line_number":13,"context_line":"    export HTTPS_PROXY"},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if [ ! -z \"$NO_PROXY\" ]; then"},{"line_number":17,"context_line":"    export NO_PROXY"},{"line_number":18,"context_line":"fi"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"function writeFile {"},{"line_number":21,"context_line":"    # $1 is filename"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_f852a410","line":18,"range":{"start_line":8,"start_character":0,"end_line":18,"end_character":2},"in_reply_to":"3fa7e38b_cd705676","updated":"2020-01-27 21:37:30.000000000","message":"Hi Diogo, thanks for the review. I understand that the proxy is not used just here but later, however, I think it makes sense because it\u0027s setting the environment variables and all the following script will be able to use those variables. So I think it\u0027s not necessary to put the proxy just the place where uses those proxies. Same as all the other scripts.","commit_id":"4346d776e5887af71e33748212bf4dcc2a220b66"}]}