)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"816d5602f716680d230e2209446fc754a9780984","unresolved":false,"context_lines":[{"line_number":7,"context_line":"k8s-fedora: Set max-size to 10m for containers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set the max-size for container/pod logs to 10m"},{"line_number":10,"context_line":"and max of 5 rotated files. The values relay"},{"line_number":11,"context_line":"the default of kubernetes when it is using"},{"line_number":12,"context_line":"a remote container runtime [0] (container-log-max-files"},{"line_number":13,"context_line":"and container-log-max-size) This defaults cover the"},{"line_number":14,"context_line":"case of containerd."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1fa4df85_823aef95","line":12,"range":{"start_line":10,"start_character":28,"end_line":12,"end_character":30},"updated":"2020-03-11 15:45:21.000000000","message":"@bharat, here","commit_id":"5d69b86044d6dc919a108a59637ccd7098280615"}],"magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-master.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"c8599b480aa092357caaa411901a3f83a5a41407","unresolved":false,"context_lines":[{"line_number":418,"context_line":""},{"line_number":419,"context_line":"# For using default log-driver, other options should be ignored"},{"line_number":420,"context_line":"sed -i \u0027s/\\-\\-log\\-driver\\\u003djournald//g\u0027 /etc/sysconfig/docker"},{"line_number":421,"context_line":"# json-file is required for conformance. 50 megabytes per container, max 3 files rotated."},{"line_number":422,"context_line":"sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--log-driver\u003djson-file --log-opt max-size\u003d10m --log-opt max-file\u003d5 /\u0027 /etc/sysconfig/docker"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"if [ -n \"${INSECURE_REGISTRY_URL}\" ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1fa4df85_4fb500cd","line":421,"range":{"start_line":421,"start_character":41,"end_line":421,"end_character":89},"updated":"2020-03-11 15:22:34.000000000","message":"50 m? 3 files? below its 10m 5 files? what is true?","commit_id":"659c06ebdeb8b7e19349b0dc7730dd0bd78acfa2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"c8599b480aa092357caaa411901a3f83a5a41407","unresolved":false,"context_lines":[{"line_number":419,"context_line":"# For using default log-driver, other options should be ignored"},{"line_number":420,"context_line":"sed -i \u0027s/\\-\\-log\\-driver\\\u003djournald//g\u0027 /etc/sysconfig/docker"},{"line_number":421,"context_line":"# json-file is required for conformance. 50 megabytes per container, max 3 files rotated."},{"line_number":422,"context_line":"sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--log-driver\u003djson-file --log-opt max-size\u003d10m --log-opt max-file\u003d5 /\u0027 /etc/sysconfig/docker"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"if [ -n \"${INSECURE_REGISTRY_URL}\" ]; then"},{"line_number":425,"context_line":"    echo \"INSECURE_REGISTRY\u003d\u0027--insecure-registry ${INSECURE_REGISTRY_URL}\u0027\" \u003e\u003e /etc/sysconfig/docker"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1fa4df85_afaa746e","line":422,"range":{"start_line":422,"start_character":98,"end_line":422,"end_character":108},"updated":"2020-03-11 15:22:34.000000000","message":"this says 5 whereas your comment says 3?","commit_id":"659c06ebdeb8b7e19349b0dc7730dd0bd78acfa2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"84fb71d6710fafa2748aea87036d359d0300f336","unresolved":false,"context_lines":[{"line_number":416,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cloud-provider\u003dexternal\""},{"line_number":417,"context_line":"fi"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"# For using default log-driver, other options should be ignored"},{"line_number":420,"context_line":"sed -i \u0027s/\\-\\-log\\-driver\\\u003djournald//g\u0027 /etc/sysconfig/docker"},{"line_number":421,"context_line":"# json-file is required for conformance."},{"line_number":422,"context_line":"# https://docs.docker.com/config/containers/logging/json-file/"},{"line_number":423,"context_line":"sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--log-driver\u003djson-file --log-opt max-size\u003d10m --log-opt max-file\u003d5 /\u0027 /etc/sysconfig/docker"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"if [ -n \"${INSECURE_REGISTRY_URL}\" ]; then"},{"line_number":426,"context_line":"    echo \"INSECURE_REGISTRY\u003d\u0027--insecure-registry ${INSECURE_REGISTRY_URL}\u0027\" \u003e\u003e /etc/sysconfig/docker"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_05c12981","line":423,"range":{"start_line":419,"start_character":0,"end_line":423,"end_character":133},"updated":"2020-03-11 16:10:26.000000000","message":"should we move these to the else scope of if container_runtime is not containerd?","commit_id":"5d69b86044d6dc919a108a59637ccd7098280615"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"e838ce85c43a2b47cb8695cf0c16dbc07166bf13","unresolved":false,"context_lines":[{"line_number":420,"context_line":"sed -i \u0027s/\\-\\-log\\-driver\\\u003djournald//g\u0027 /etc/sysconfig/docker"},{"line_number":421,"context_line":"# json-file is required for conformance."},{"line_number":422,"context_line":"# https://docs.docker.com/config/containers/logging/json-file/"},{"line_number":423,"context_line":"sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--log-driver\u003djson-file --log-opt max-size\u003d10m --log-opt max-file\u003d5 /\u0027 /etc/sysconfig/docker"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"if [ -n \"${INSECURE_REGISTRY_URL}\" ]; then"},{"line_number":426,"context_line":"    echo \"INSECURE_REGISTRY\u003d\u0027--insecure-registry ${INSECURE_REGISTRY_URL}\u0027\" \u003e\u003e /etc/sysconfig/docker"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_42cf17b0","line":423,"range":{"start_line":423,"start_character":0,"end_line":423,"end_character":133},"updated":"2020-03-11 15:44:43.000000000","message":"why are we passing this here and not as kubelet arg?","commit_id":"5d69b86044d6dc919a108a59637ccd7098280615"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"107cf56ab5c28328233f7971bf18f43fa4507863","unresolved":false,"context_lines":[{"line_number":420,"context_line":"sed -i \u0027s/\\-\\-log\\-driver\\\u003djournald//g\u0027 /etc/sysconfig/docker"},{"line_number":421,"context_line":"# json-file is required for conformance."},{"line_number":422,"context_line":"# https://docs.docker.com/config/containers/logging/json-file/"},{"line_number":423,"context_line":"sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--log-driver\u003djson-file --log-opt max-size\u003d10m --log-opt max-file\u003d5 /\u0027 /etc/sysconfig/docker"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"if [ -n \"${INSECURE_REGISTRY_URL}\" ]; then"},{"line_number":426,"context_line":"    echo \"INSECURE_REGISTRY\u003d\u0027--insecure-registry ${INSECURE_REGISTRY_URL}\u0027\" \u003e\u003e /etc/sysconfig/docker"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_625ed3ea","line":423,"range":{"start_line":423,"start_character":0,"end_line":423,"end_character":133},"in_reply_to":"1fa4df85_42cf17b0","updated":"2020-03-11 15:45:51.000000000","message":"because docker is not a remote runtime","commit_id":"5d69b86044d6dc919a108a59637ccd7098280615"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"d40635aa81349887fa0317244af6f1ce5835f0fd","unresolved":false,"context_lines":[{"line_number":420,"context_line":"sed -i \u0027s/\\-\\-log\\-driver\\\u003djournald//g\u0027 /etc/sysconfig/docker"},{"line_number":421,"context_line":"# json-file is required for conformance."},{"line_number":422,"context_line":"# https://docs.docker.com/config/containers/logging/json-file/"},{"line_number":423,"context_line":"sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--log-driver\u003djson-file --log-opt max-size\u003d10m --log-opt max-file\u003d5 /\u0027 /etc/sysconfig/docker"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"if [ -n \"${INSECURE_REGISTRY_URL}\" ]; then"},{"line_number":426,"context_line":"    echo \"INSECURE_REGISTRY\u003d\u0027--insecure-registry ${INSECURE_REGISTRY_URL}\u0027\" \u003e\u003e /etc/sysconfig/docker"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_22b45bf2","line":423,"range":{"start_line":423,"start_character":0,"end_line":423,"end_character":133},"in_reply_to":"1fa4df85_625ed3ea","updated":"2020-03-11 15:50:11.000000000","message":"docs https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/\ncode: https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/logs/container_log_manager.go\n\nSet the maximum number of container log files that can be present for a container. The number must be \u003e\u003d 2. This flag can only be used with --container-runtime\u003dremote. (default 5)\n\n\nthis part: \"This flag can only be used with --container-runtime\u003dremote.\" We don\u0027t use docker as remote (it was like this since the start of kubernetes)","commit_id":"5d69b86044d6dc919a108a59637ccd7098280615"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"3de5059d909cc90b85668b00fca065cdd11b16fc","unresolved":false,"context_lines":[{"line_number":475,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --container-runtime\u003dremote\""},{"line_number":476,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --runtime-request-timeout\u003d15m\""},{"line_number":477,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --container-runtime-endpoint\u003dunix:///run/containerd/containerd.sock\""},{"line_number":478,"context_line":"fi"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"if [ -z \"${KUBE_NODE_IP}\" ]; then"},{"line_number":481,"context_line":"    KUBE_NODE_IP\u003d$(curl -s http://169.254.169.254/latest/meta-data/local-ipv4)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_c5455145","line":478,"updated":"2020-03-11 16:06:32.000000000","message":"else\n    sed docker stuff?\nfi","commit_id":"5d69b86044d6dc919a108a59637ccd7098280615"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"13df6cbe5a8a88029e1f1e0af3cbefdc2c974bfa","unresolved":false,"context_lines":[{"line_number":416,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cloud-provider\u003dexternal\""},{"line_number":417,"context_line":"fi"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"if [ -f /etc/sysconfig/docker ] ; then"},{"line_number":420,"context_line":"    # For using default log-driver, other options should be ignored"},{"line_number":421,"context_line":"    sed -i \u0027s/\\-\\-log\\-driver\\\u003djournald//g\u0027 /etc/sysconfig/docker"},{"line_number":422,"context_line":"    # json-file is required for conformance."},{"line_number":423,"context_line":"    # https://docs.docker.com/config/containers/logging/json-file/"},{"line_number":424,"context_line":"    sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--log-driver\u003djson-file --log-opt max-size\u003d10m --log-opt max-file\u003d5 /\u0027 /etc/sysconfig/docker"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    if [ -n \"${INSECURE_REGISTRY_URL}\" ]; then"},{"line_number":427,"context_line":"        echo \"INSECURE_REGISTRY\u003d\u0027--insecure-registry ${INSECURE_REGISTRY_URL}\u0027\" \u003e\u003e /etc/sysconfig/docker"},{"line_number":428,"context_line":"    fi"},{"line_number":429,"context_line":"fi"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --network-plugin\u003dcni --cni-conf-dir\u003d/etc/cni/net.d --cni-bin-dir\u003d/opt/cni/bin\""},{"line_number":432,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --register-with-taints\u003dCriticalAddonsOnly\u003dTrue:NoSchedule,dedicated\u003dmaster:NoSchedule\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"1fa4df85_c8e0f4cf","line":429,"range":{"start_line":419,"start_character":0,"end_line":429,"end_character":2},"updated":"2020-03-12 15:20:09.000000000","message":"Ah thanks for this!","commit_id":"af74b326d01f6e64eec1bebb28f227a6917ef35b"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"13b12b8e838f411934432e9154cb083540ce36f6","unresolved":false,"context_lines":[{"line_number":416,"context_line":"    KUBELET_ARGS\u003d\"${KUBELET_ARGS} --cloud-provider\u003dexternal\""},{"line_number":417,"context_line":"fi"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"if [ -f /etc/sysconfig/docker ] ; then"},{"line_number":420,"context_line":"    # For using default log-driver, other options should be ignored"},{"line_number":421,"context_line":"    sed -i \u0027s/\\-\\-log\\-driver\\\u003djournald//g\u0027 /etc/sysconfig/docker"},{"line_number":422,"context_line":"    # json-file is required for conformance."},{"line_number":423,"context_line":"    # https://docs.docker.com/config/containers/logging/json-file/"},{"line_number":424,"context_line":"    sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--log-driver\u003djson-file --log-opt max-size\u003d10m --log-opt max-file\u003d5 /\u0027 /etc/sysconfig/docker"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    if [ -n \"${INSECURE_REGISTRY_URL}\" ]; then"},{"line_number":427,"context_line":"        echo \"INSECURE_REGISTRY\u003d\u0027--insecure-registry ${INSECURE_REGISTRY_URL}\u0027\" \u003e\u003e /etc/sysconfig/docker"},{"line_number":428,"context_line":"    fi"},{"line_number":429,"context_line":"fi"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --network-plugin\u003dcni --cni-conf-dir\u003d/etc/cni/net.d --cni-bin-dir\u003d/opt/cni/bin\""},{"line_number":432,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --register-with-taints\u003dCriticalAddonsOnly\u003dTrue:NoSchedule,dedicated\u003dmaster:NoSchedule\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"1fa4df85_e8d8501f","line":429,"range":{"start_line":419,"start_character":0,"end_line":429,"end_character":2},"in_reply_to":"1fa4df85_c8e0f4cf","updated":"2020-03-12 15:20:55.000000000","message":":)","commit_id":"af74b326d01f6e64eec1bebb28f227a6917ef35b"}],"magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-minion.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"75f35a8fb766994c0b83da258604c0290af9e2d9","unresolved":false,"context_lines":[{"line_number":261,"context_line":"sed -i \u0027s/\\-\\-log\\-driver\\\u003djournald//g\u0027 /etc/sysconfig/docker"},{"line_number":262,"context_line":"# json-file is required for conformance."},{"line_number":263,"context_line":"# https://docs.docker.com/config/containers/logging/json-file/"},{"line_number":264,"context_line":"sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--log-driver\u003djson-file --log-opt max-size\u003d10m --log-opt max-file\u003d5 /\u0027 /etc/sysconfig/docker"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --pod-infra-container-image\u003d${CONTAINER_INFRA_PREFIX:-gcr.io/google_containers/}pause:3.1\""},{"line_number":267,"context_line":"if [ -n \"${INSECURE_REGISTRY_URL}\" ]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_023cbfbd","line":264,"range":{"start_line":264,"start_character":107,"end_line":264,"end_character":108},"updated":"2020-03-11 15:41:45.000000000","message":"docs says 3","commit_id":"5d69b86044d6dc919a108a59637ccd7098280615"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"b7cdb19215b368c3d56a9c35114faf3e2b10f4ec","unresolved":false,"context_lines":[{"line_number":261,"context_line":"sed -i \u0027s/\\-\\-log\\-driver\\\u003djournald//g\u0027 /etc/sysconfig/docker"},{"line_number":262,"context_line":"# json-file is required for conformance."},{"line_number":263,"context_line":"# https://docs.docker.com/config/containers/logging/json-file/"},{"line_number":264,"context_line":"sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--log-driver\u003djson-file --log-opt max-size\u003d10m --log-opt max-file\u003d5 /\u0027 /etc/sysconfig/docker"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"KUBELET_ARGS\u003d\"${KUBELET_ARGS} --pod-infra-container-image\u003d${CONTAINER_INFRA_PREFIX:-gcr.io/google_containers/}pause:3.1\""},{"line_number":267,"context_line":"if [ -n \"${INSECURE_REGISTRY_URL}\" ]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_a2b60b3e","line":264,"range":{"start_line":264,"start_character":107,"end_line":264,"end_character":108},"in_reply_to":"1fa4df85_023cbfbd","updated":"2020-03-11 15:42:34.000000000","message":"wrong docs... see commit message.","commit_id":"5d69b86044d6dc919a108a59637ccd7098280615"}]}