)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"50b0c1a374224657bcd8827a8a9a9822d593e8b5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Hepster has been deprecated for a while and the new k8s dashboard"},{"line_number":10,"context_line":"2.0.0 version starts to support metrics-server now. So it\u0027s time"},{"line_number":11,"context_line":"to upgrade the default k8s dashboard to v2.0.0."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Task: 39101"},{"line_number":14,"context_line":"Story: 2007256"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_4b91edf0","line":11,"range":{"start_line":11,"start_character":40,"end_line":11,"end_character":46},"updated":"2020-04-02 10:32:24.000000000","message":"this doesn\u0027t exists yet","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"8d53f5d7472de87988e5682d150df1ab9faf317f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Hepster has been deprecated for a while and the new k8s dashboard"},{"line_number":10,"context_line":"2.0.0 version starts to support metrics-server now. So it\u0027s time"},{"line_number":11,"context_line":"to upgrade the default k8s dashboard to v2.0.0."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Task: 39101"},{"line_number":14,"context_line":"Story: 2007256"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_a7eeb388","line":11,"range":{"start_line":11,"start_character":40,"end_line":11,"end_character":46},"in_reply_to":"df33271e_4b91edf0","updated":"2020-04-05 05:32:48.000000000","message":"Yes, I know that. That\u0027s why I tagged this as WIP. I have checked with the k8s dashboard team, I was told it would be GA in the next couple of weeks. So let\u0027s see if we can get this in U cycle.","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"de4595ba79e06c4bcf251d3f8772f8e0ae6f55f4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Feilong Wang \u003cflwang@catalyst.net.nz\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-04-23 17:19:58 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[k8s] Update k8s dashboard verstion to v2.0.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Hepster has been deprecated for a while and the new k8s dashboard"},{"line_number":10,"context_line":"2.0.0 version starts to support metrics-server now. So it\u0027s time"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_a25dd8ea","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":12},"updated":"2020-04-23 10:14:50.000000000","message":"Upgrade","commit_id":"6c09d0d76c5a6bd40f2876cf3af759bfaf5eabd2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"de4595ba79e06c4bcf251d3f8772f8e0ae6f55f4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Feilong Wang \u003cflwang@catalyst.net.nz\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-04-23 17:19:58 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[k8s] Update k8s dashboard verstion to v2.0.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Hepster has been deprecated for a while and the new k8s dashboard"},{"line_number":10,"context_line":"2.0.0 version starts to support metrics-server now. So it\u0027s time"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_c25aa4f1","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":35},"updated":"2020-04-23 10:14:50.000000000","message":"version","commit_id":"6c09d0d76c5a6bd40f2876cf3af759bfaf5eabd2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"de4595ba79e06c4bcf251d3f8772f8e0ae6f55f4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[k8s] Update k8s dashboard verstion to v2.0.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Hepster has been deprecated for a while and the new k8s dashboard"},{"line_number":10,"context_line":"2.0.0 version starts to support metrics-server now. So it\u0027s time"},{"line_number":11,"context_line":"to upgrade the default k8s dashboard to v2.0.0."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_4255f4c5","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":7},"updated":"2020-04-23 10:14:50.000000000","message":"Heapster","commit_id":"6c09d0d76c5a6bd40f2876cf3af759bfaf5eabd2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"de4595ba79e06c4bcf251d3f8772f8e0ae6f55f4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[k8s] Update k8s dashboard verstion to v2.0.0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Hepster has been deprecated for a while and the new k8s dashboard"},{"line_number":10,"context_line":"2.0.0 version starts to support metrics-server now. So it\u0027s time"},{"line_number":11,"context_line":"to upgrade the default k8s dashboard to v2.0.0."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Task: 39101"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_6263d0b2","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":31},"updated":"2020-04-23 10:14:50.000000000","message":"supports","commit_id":"6c09d0d76c5a6bd40f2876cf3af759bfaf5eabd2"}],"doc/source/user/index.rst":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"de4595ba79e06c4bcf251d3f8772f8e0ae6f55f4","unresolved":false,"context_lines":[{"line_number":1531,"context_line":"_`kube_dashboard_version`"},{"line_number":1532,"context_line":"  Default version of Kubernetes dashboard."},{"line_number":1533,"context_line":"  Train-default: v1.8.3"},{"line_number":1534,"context_line":"  Ussuri-default: v2.0.0"},{"line_number":1535,"context_line":""},{"line_number":1536,"context_line":"_`metrics_scraper_tag`"},{"line_number":1537,"context_line":"  The version of metrics-scraper used by kubernetes dashboard."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f493fa4_fc7dc51c","line":1534,"range":{"start_line":1534,"start_character":8,"end_line":1534,"end_character":9},"updated":"2020-04-23 10:14:50.000000000","message":"lets drop all the dashes please :)","commit_id":"6c09d0d76c5a6bd40f2876cf3af759bfaf5eabd2"}],"magnum/drivers/common/templates/kubernetes/fragments/kube-dashboard-service.sh":[{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"d29d66a68103b6329f9de845436227e22d3c5235","unresolved":false,"context_lines":[{"line_number":12,"context_line":"done"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"if [ \"$(echo $KUBE_DASHBOARD_ENABLED | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d\u003d \"true\" ]; then"},{"line_number":15,"context_line":"    KUBE_DASH_IMAGE\u003d\"${CONTAINER_INFRA_PREFIX:-kubernetesui/}dashboard:${KUBE_DASHBOARD_VERSION}\""},{"line_number":16,"context_line":"    HEAPSTER_IMAGE\u003d\"${CONTAINER_INFRA_PREFIX:-gcr.io/google_containers/}heapster-${ARCH}:v1.4.2\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    KUBE_DASH_DEPLOY\u003d/srv/magnum/kubernetes/kubernetes-dashboard.yaml"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_4a2a8cda","line":15,"range":{"start_line":15,"start_character":22,"end_line":15,"end_character":96},"updated":"2020-04-02 07:07:30.000000000","message":"can you update image:tag on user docs?","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"0759d82b2ea58304b1c6e8c66383cdf780447095","unresolved":false,"context_lines":[{"line_number":12,"context_line":"done"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"if [ \"$(echo $KUBE_DASHBOARD_ENABLED | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d\u003d \"true\" ]; then"},{"line_number":15,"context_line":"    KUBE_DASH_IMAGE\u003d\"${CONTAINER_INFRA_PREFIX:-kubernetesui/}dashboard:${KUBE_DASHBOARD_VERSION}\""},{"line_number":16,"context_line":"    HEAPSTER_IMAGE\u003d\"${CONTAINER_INFRA_PREFIX:-gcr.io/google_containers/}heapster-${ARCH}:v1.4.2\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    KUBE_DASH_DEPLOY\u003d/srv/magnum/kubernetes/kubernetes-dashboard.yaml"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_253e5bb7","line":15,"range":{"start_line":15,"start_character":22,"end_line":15,"end_character":96},"in_reply_to":"df33271e_4a2a8cda","updated":"2020-04-02 07:30:22.000000000","message":"Will do.","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"50b0c1a374224657bcd8827a8a9a9822d593e8b5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":36,"context_line":"# limitations under the License."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"apiVersion: v1"},{"line_number":39,"context_line":"kind: Namespace"},{"line_number":40,"context_line":"metadata:"},{"line_number":41,"context_line":"  name: kubernetes-dashboard"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_cbe85d7d","line":38,"updated":"2020-04-02 10:32:24.000000000","message":"what about https://github.com/helm/charts/tree/master/stable/kubernetes-dashboard\n\n?","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"3ceacf1b8acd909b6e0c8dcf4aecb2a1be722187","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":36,"context_line":"# limitations under the License."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"apiVersion: v1"},{"line_number":39,"context_line":"kind: Namespace"},{"line_number":40,"context_line":"metadata:"},{"line_number":41,"context_line":"  name: kubernetes-dashboard"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_a30182b2","line":38,"in_reply_to":"df33271e_07ff9f34","updated":"2020-04-05 19:44:11.000000000","message":"The only references I found for heapster are in rbac:\n $ git grep -i heapster\n templates/role.yaml:  # Allow Dashboard to get metrics from heapster.\n templates/role.yaml:    - heapster\n templates/role.yaml:    - heapster\n templates/role.yaml:    - \"http:heapster:\"\n templates/role.yaml:    - \"https:heapster:\"\n values.yaml:  ## This allows an override of the heapster service name\n\nThe last part in values, overrides the name for some reason. Nothing related to heapster in the manifest.\n\nI get:\n panic: secrets \"kubernetes-dashboard-csrf\" is forbidden: User \"system:serviceaccount:kube-system:kubernetes-dashboard\" cannot get resource \"secrets\" in API group \"\" in the namespace \"kube-system\"\n\nIssues:\n* The role needs to be updated.\n https://github.com/helm/charts/blob/master/stable/kubernetes-dashboard/templates/role.yaml\n* The default image.repository is wrong.\n\nIt doesn\u0027t work, so, do it like this or we fix the chart.","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"e664c258c58b0250e142b25882a16cbe19f6aaaf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":36,"context_line":"# limitations under the License."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"apiVersion: v1"},{"line_number":39,"context_line":"kind: Namespace"},{"line_number":40,"context_line":"metadata:"},{"line_number":41,"context_line":"  name: kubernetes-dashboard"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_fa44c41d","line":38,"in_reply_to":"df33271e_a30182b2","updated":"2020-04-06 12:09:31.000000000","message":"It seems it will take some time? https://github.com/kubernetes/dashboard/pull/4502/files\n\nAlthough it is close.","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"fa247113003a038f4603dc2c065025d098f98158","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":36,"context_line":"# limitations under the License."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"apiVersion: v1"},{"line_number":39,"context_line":"kind: Namespace"},{"line_number":40,"context_line":"metadata:"},{"line_number":41,"context_line":"  name: kubernetes-dashboard"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_f9d9bb82","line":38,"in_reply_to":"df33271e_cbe85d7d","updated":"2020-04-02 11:34:52.000000000","message":"+1","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"8738cbe3e0b2557b831f1d8c571dc508cffd638b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":36,"context_line":"# limitations under the License."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"apiVersion: v1"},{"line_number":39,"context_line":"kind: Namespace"},{"line_number":40,"context_line":"metadata:"},{"line_number":41,"context_line":"  name: kubernetes-dashboard"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f4c43b2_b88ade66","line":38,"in_reply_to":"df33271e_dec1e2e6","updated":"2020-04-20 10:51:19.000000000","message":"I don\u0027t expect it to. Unhappy with the non-helm option, but I don\u0027t see another option atm.","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"8d53f5d7472de87988e5682d150df1ab9faf317f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":36,"context_line":"# limitations under the License."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"apiVersion: v1"},{"line_number":39,"context_line":"kind: Namespace"},{"line_number":40,"context_line":"metadata:"},{"line_number":41,"context_line":"  name: kubernetes-dashboard"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_07ff9f34","line":38,"in_reply_to":"df33271e_f9d9bb82","updated":"2020-04-05 05:32:48.000000000","message":"Based on my understanding, v1.10.1 is still using heapster. Please correct me if I\u0027m wrong.\n\nI\u0027m happy to use helm if it can support v2.0.0.","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"b0f1b66ca5e0aa4f56d2b4f3e6443915df079eae","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":36,"context_line":"# limitations under the License."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"apiVersion: v1"},{"line_number":39,"context_line":"kind: Namespace"},{"line_number":40,"context_line":"metadata:"},{"line_number":41,"context_line":"  name: kubernetes-dashboard"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_dec1e2e6","line":38,"in_reply_to":"df33271e_fa44c41d","updated":"2020-04-07 05:17:45.000000000","message":"I think we have about one month before the Ussuri final release. Do you think the chart can GA before that?","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"d29d66a68103b6329f9de845436227e22d3c5235","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  labels:"},{"line_number":49,"context_line":"    k8s-app: kubernetes-dashboard"},{"line_number":50,"context_line":"  name: kubernetes-dashboard"},{"line_number":51,"context_line":"  namespace: kubernetes-dashboard"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"---"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_aae238d3","line":51,"range":{"start_line":51,"start_character":13,"end_line":51,"end_character":33},"updated":"2020-04-02 07:07:30.000000000","message":"Do we really want to add a new namespace?\nIs this a security thing?","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"0759d82b2ea58304b1c6e8c66383cdf780447095","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  labels:"},{"line_number":49,"context_line":"    k8s-app: kubernetes-dashboard"},{"line_number":50,"context_line":"  name: kubernetes-dashboard"},{"line_number":51,"context_line":"  namespace: kubernetes-dashboard"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"---"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_c5784f91","line":51,"range":{"start_line":51,"start_character":13,"end_line":51,"end_character":33},"in_reply_to":"df33271e_aae238d3","updated":"2020-04-02 07:30:22.000000000","message":"Good point. I will keep it in kube-system.","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"d29d66a68103b6329f9de845436227e22d3c5235","unresolved":false,"context_lines":[{"line_number":248,"context_line":"          emptyDir: {}"},{"line_number":249,"context_line":"      serviceAccountName: kubernetes-dashboard"},{"line_number":250,"context_line":"      nodeSelector:"},{"line_number":251,"context_line":"        \"beta.kubernetes.io/os\": linux"},{"line_number":252,"context_line":"      # Comment the following tolerations if Dashboard must not be deployed on master"},{"line_number":253,"context_line":"      tolerations:"},{"line_number":254,"context_line":"        - key: node-role.kubernetes.io/master"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_4ad3ac04","line":251,"range":{"start_line":251,"start_character":14,"end_line":251,"end_character":28},"updated":"2020-04-02 07:07:30.000000000","message":"here to","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"0759d82b2ea58304b1c6e8c66383cdf780447095","unresolved":false,"context_lines":[{"line_number":248,"context_line":"          emptyDir: {}"},{"line_number":249,"context_line":"      serviceAccountName: kubernetes-dashboard"},{"line_number":250,"context_line":"      nodeSelector:"},{"line_number":251,"context_line":"        \"beta.kubernetes.io/os\": linux"},{"line_number":252,"context_line":"      # Comment the following tolerations if Dashboard must not be deployed on master"},{"line_number":253,"context_line":"      tolerations:"},{"line_number":254,"context_line":"        - key: node-role.kubernetes.io/master"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_e57113aa","line":251,"range":{"start_line":251,"start_character":14,"end_line":251,"end_character":28},"in_reply_to":"df33271e_4ad3ac04","updated":"2020-04-02 07:30:22.000000000","message":"Will do","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"d29d66a68103b6329f9de845436227e22d3c5235","unresolved":false,"context_lines":[{"line_number":292,"context_line":"      annotations:"},{"line_number":293,"context_line":"        seccomp.security.alpha.kubernetes.io/pod: \u0027runtime/default\u0027"},{"line_number":294,"context_line":"    spec:"},{"line_number":295,"context_line":"      containers:"},{"line_number":296,"context_line":"        - name: dashboard-metrics-scraper"},{"line_number":297,"context_line":"          image: kubernetesui/metrics-scraper:v1.0.4"},{"line_number":298,"context_line":"          ports:"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_aa1998d7","line":295,"range":{"start_line":295,"start_character":6,"end_line":295,"end_character":17},"updated":"2020-04-02 07:07:30.000000000","message":"is there a reason why this is not part of the other deployment?","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"0759d82b2ea58304b1c6e8c66383cdf780447095","unresolved":false,"context_lines":[{"line_number":292,"context_line":"      annotations:"},{"line_number":293,"context_line":"        seccomp.security.alpha.kubernetes.io/pod: \u0027runtime/default\u0027"},{"line_number":294,"context_line":"    spec:"},{"line_number":295,"context_line":"      containers:"},{"line_number":296,"context_line":"        - name: dashboard-metrics-scraper"},{"line_number":297,"context_line":"          image: kubernetesui/metrics-scraper:v1.0.4"},{"line_number":298,"context_line":"          ports:"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_456c3fcd","line":295,"range":{"start_line":295,"start_character":6,"end_line":295,"end_character":17},"in_reply_to":"df33271e_aa1998d7","updated":"2020-04-02 07:30:22.000000000","message":"I don\u0027t know, I got this from upstream recommended yaml.","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"d29d66a68103b6329f9de845436227e22d3c5235","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    spec:"},{"line_number":295,"context_line":"      containers:"},{"line_number":296,"context_line":"        - name: dashboard-metrics-scraper"},{"line_number":297,"context_line":"          image: kubernetesui/metrics-scraper:v1.0.4"},{"line_number":298,"context_line":"          ports:"},{"line_number":299,"context_line":"            - containerPort: 8000"},{"line_number":300,"context_line":"              protocol: TCP"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_4a41eca8","line":297,"range":{"start_line":297,"start_character":17,"end_line":297,"end_character":52},"updated":"2020-04-02 07:07:30.000000000","message":"can you add image:tag to user docs?","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"0759d82b2ea58304b1c6e8c66383cdf780447095","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    spec:"},{"line_number":295,"context_line":"      containers:"},{"line_number":296,"context_line":"        - name: dashboard-metrics-scraper"},{"line_number":297,"context_line":"          image: kubernetesui/metrics-scraper:v1.0.4"},{"line_number":298,"context_line":"          ports:"},{"line_number":299,"context_line":"            - containerPort: 8000"},{"line_number":300,"context_line":"              protocol: TCP"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_e5a6330f","line":297,"range":{"start_line":297,"start_character":17,"end_line":297,"end_character":52},"in_reply_to":"df33271e_4a41eca8","updated":"2020-04-02 07:30:22.000000000","message":"That\u0027s the part I\u0027m still thinking, i don\u0027t really want to introduce another label for this. I will address this later.","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"f94c2c449c27596edbfdadef35e174766898414b","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    spec:"},{"line_number":295,"context_line":"      containers:"},{"line_number":296,"context_line":"        - name: dashboard-metrics-scraper"},{"line_number":297,"context_line":"          image: kubernetesui/metrics-scraper:v1.0.4"},{"line_number":298,"context_line":"          ports:"},{"line_number":299,"context_line":"            - containerPort: 8000"},{"line_number":300,"context_line":"              protocol: TCP"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_058b56c2","line":297,"range":{"start_line":297,"start_character":17,"end_line":297,"end_character":52},"in_reply_to":"df33271e_e5a6330f","updated":"2020-04-02 08:58:06.000000000","message":"I think @Diogo is right, we should add a new label for this and document this. It doesn\u0027t make sense to have anything like this hard coded.","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"d29d66a68103b6329f9de845436227e22d3c5235","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            runAsGroup: 2001"},{"line_number":316,"context_line":"      serviceAccountName: kubernetes-dashboard"},{"line_number":317,"context_line":"      nodeSelector:"},{"line_number":318,"context_line":"        \"beta.kubernetes.io/os\": linux"},{"line_number":319,"context_line":"      # Comment the following tolerations if Dashboard must not be deployed on master"},{"line_number":320,"context_line":"      tolerations:"},{"line_number":321,"context_line":"        - key: node-role.kubernetes.io/master"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_2ac90858","line":318,"range":{"start_line":318,"start_character":8,"end_line":318,"end_character":30},"updated":"2020-04-02 07:07:30.000000000","message":"fix the beta here","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"0759d82b2ea58304b1c6e8c66383cdf780447095","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            runAsGroup: 2001"},{"line_number":316,"context_line":"      serviceAccountName: kubernetes-dashboard"},{"line_number":317,"context_line":"      nodeSelector:"},{"line_number":318,"context_line":"        \"beta.kubernetes.io/os\": linux"},{"line_number":319,"context_line":"      # Comment the following tolerations if Dashboard must not be deployed on master"},{"line_number":320,"context_line":"      tolerations:"},{"line_number":321,"context_line":"        - key: node-role.kubernetes.io/master"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df33271e_25ac9beb","line":318,"range":{"start_line":318,"start_character":8,"end_line":318,"end_character":30},"in_reply_to":"df33271e_2ac90858","updated":"2020-04-02 07:30:22.000000000","message":"Done","commit_id":"e15b751c34cff02bcb6935ea1212d80413886256"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"3c159a993c37961d35fcd101186e06ca2005a588","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        \"kubernetes.io/os\": linux"},{"line_number":248,"context_line":"      # Comment the following tolerations if Dashboard must not be deployed on master"},{"line_number":249,"context_line":"      tolerations:"},{"line_number":250,"context_line":"        - key: node-role.kubernetes.io/master"},{"line_number":251,"context_line":"          effect: NoSchedule"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"---"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"1f493fa4_338d8131","line":251,"range":{"start_line":250,"start_character":0,"end_line":251,"end_character":28},"updated":"2020-04-30 12:57:31.000000000","message":"Do we really want to allow scheduling dashboard to master? I would prefer not to.","commit_id":"b4965416b145c741fa344110ae27a2536458135c"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"74688e8ebe061b78615e48116d01087a03098605","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        \"kubernetes.io/os\": linux"},{"line_number":248,"context_line":"      # Comment the following tolerations if Dashboard must not be deployed on master"},{"line_number":249,"context_line":"      tolerations:"},{"line_number":250,"context_line":"        - key: node-role.kubernetes.io/master"},{"line_number":251,"context_line":"          effect: NoSchedule"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"---"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"1f493fa4_9fa04a44","line":251,"range":{"start_line":250,"start_character":0,"end_line":251,"end_character":28},"in_reply_to":"1f493fa4_24980f73","updated":"2020-04-30 20:48:28.000000000","message":"It makes sense to me to have as few non-critical componetns running on master as possible. However, I don\u0027t mind if you guys prefer to leave this here. But please address my other comment.","commit_id":"b4965416b145c741fa344110ae27a2536458135c"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"a6b4f775024880c6683dba32673baae38efc4120","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        \"kubernetes.io/os\": linux"},{"line_number":248,"context_line":"      # Comment the following tolerations if Dashboard must not be deployed on master"},{"line_number":249,"context_line":"      tolerations:"},{"line_number":250,"context_line":"        - key: node-role.kubernetes.io/master"},{"line_number":251,"context_line":"          effect: NoSchedule"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"---"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"1f493fa4_aa5d137a","line":251,"range":{"start_line":250,"start_character":0,"end_line":251,"end_character":28},"in_reply_to":"1f493fa4_338d8131","updated":"2020-04-30 13:08:55.000000000","message":"arguments against dashboard on master?","commit_id":"b4965416b145c741fa344110ae27a2536458135c"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"4f6f37343e0b585bf87d834bd155c284af284658","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        \"kubernetes.io/os\": linux"},{"line_number":248,"context_line":"      # Comment the following tolerations if Dashboard must not be deployed on master"},{"line_number":249,"context_line":"      tolerations:"},{"line_number":250,"context_line":"        - key: node-role.kubernetes.io/master"},{"line_number":251,"context_line":"          effect: NoSchedule"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"---"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"1f493fa4_24980f73","line":251,"range":{"start_line":250,"start_character":0,"end_line":251,"end_character":28},"in_reply_to":"1f493fa4_aa5d137a","updated":"2020-04-30 19:58:52.000000000","message":"Why do you prefer not to?","commit_id":"b4965416b145c741fa344110ae27a2536458135c"}],"magnum/drivers/k8s_fedora_atomic_v1/templates/kubecluster.yaml":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"de4595ba79e06c4bcf251d3f8772f8e0ae6f55f4","unresolved":false,"context_lines":[{"line_number":888,"context_line":"    type: string"},{"line_number":889,"context_line":"    description: \u003e"},{"line_number":890,"context_line":"      Tag of metrics-scraper for kubernetes dashboard."},{"line_number":891,"context_line":"    default: \u0027v1.0.4\u0027"},{"line_number":892,"context_line":""},{"line_number":893,"context_line":"resources:"},{"line_number":894,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_822edc40","line":891,"range":{"start_line":891,"start_character":13,"end_line":891,"end_character":21},"updated":"2020-04-23 10:14:50.000000000","message":"this does not need to be in quotes","commit_id":"6c09d0d76c5a6bd40f2876cf3af759bfaf5eabd2"}],"magnum/drivers/k8s_fedora_coreos_v1/templates/kubecluster.yaml":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"de4595ba79e06c4bcf251d3f8772f8e0ae6f55f4","unresolved":false,"context_lines":[{"line_number":890,"context_line":"    type: string"},{"line_number":891,"context_line":"    description: \u003e"},{"line_number":892,"context_line":"      Tag of metrics-scraper for kubernetes dashboard."},{"line_number":893,"context_line":"    default: \u0027v1.0.4\u0027"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"resources:"},{"line_number":896,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_623110a3","line":893,"range":{"start_line":893,"start_character":13,"end_line":893,"end_character":21},"updated":"2020-04-23 10:14:50.000000000","message":"no need for quotes","commit_id":"6c09d0d76c5a6bd40f2876cf3af759bfaf5eabd2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"b6c2ebdc304665178324c7d990f3098031c291d3","unresolved":false,"context_lines":[{"line_number":890,"context_line":"    type: string"},{"line_number":891,"context_line":"    description: \u003e"},{"line_number":892,"context_line":"      Tag of metrics-scraper for kubernetes dashboard."},{"line_number":893,"context_line":"    default: \u0027v1.0.4\u0027"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"resources:"},{"line_number":896,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_a7b83376","line":893,"range":{"start_line":893,"start_character":13,"end_line":893,"end_character":21},"in_reply_to":"1f493fa4_623110a3","updated":"2020-04-24 04:16:43.000000000","message":"Let’s put this right after dashboard tag","commit_id":"6c09d0d76c5a6bd40f2876cf3af759bfaf5eabd2"}]}