)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"3ba18a3f530e4d3d997e6d5905d2742202d42074","unresolved":false,"context_lines":[{"line_number":13,"context_line":"With this patch, Kubelet handles the correct labelling automatically"},{"line_number":14,"context_line":"when a Cinder PV is attached to a pod."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"PS: The default behaviour in Fedora Atomic was to mount the rootfs [1]"},{"line_number":17,"context_line":"but we dropped it for some reason in Fedora CoreOS. However, it seems"},{"line_number":18,"context_line":"like we really need it."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] https://github.com/openstack/magnum/blob/master/dockerfiles/kubernetes-kubelet/config.json.template#L335"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_74d08d20","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":23},"updated":"2020-03-27 10:31:18.000000000","message":"The default behaviour in Fedora Atomic is to mount the rootfs [1].","commit_id":"3b07382e067c105df24c40c9e24e2be282c11c4c"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"ae71ebad6fc49852e9147cf10a3d71ba5c25304b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"With this patch, Kubelet handles the correct labelling automatically"},{"line_number":14,"context_line":"when a Cinder PV is attached to a pod."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"PS: The default behaviour in Fedora Atomic was to mount the rootfs [1]"},{"line_number":17,"context_line":"but we dropped it for some reason in Fedora CoreOS. However, it seems"},{"line_number":18,"context_line":"like we really need it."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] https://github.com/openstack/magnum/blob/master/dockerfiles/kubernetes-kubelet/config.json.template#L335"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_94727110","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":23},"in_reply_to":"df33271e_74d08d20","updated":"2020-03-27 10:51:58.000000000","message":"The default behaviour using system containers in Fedora Atomic is to mount rootfs [1].","commit_id":"3b07382e067c105df24c40c9e24e2be282c11c4c"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"3ececd76e1a5f2a1ccfd4ebde091e0490e083e16","unresolved":false,"context_lines":[{"line_number":14,"context_line":"when a Cinder PV is attached to a pod."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The default behaviour using system containers in Fedora Atomic is to"},{"line_number":17,"context_line":"mount rootfs [1] but we did not implement the same behaviour in Fedora"},{"line_number":18,"context_line":"CoreOS. However, it looks like we really need it."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1] https://github.com/openstack/magnum/blob/master/dockerfiles/kubernetes-kubelet/config.json.template#L335"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_495b2753","line":18,"range":{"start_line":17,"start_character":16,"end_line":18,"end_character":49},"updated":"2020-03-27 17:11:12.000000000","message":"I won\u0027t hold it for this. But let\u0027s describe why it should not be here.\n1. This patch introduces some code what is clearly missing. The fact that was not added was a undeniable mistake and if we are looking for blame that patch can help.\n2. We have added code for unimportant reasons and convenience and those patches required an explanation. This patch is important and the \u0027why\u0027 is clearly stated in the sentences above.","commit_id":"893851aac233165b44f91aba001a08b2a2cb16d9"}]}