)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"918861f1f2fa950522436217eff8e64a82b51309","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Feilong Wang \u003cflwang@catalyst.net.nz\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-04 09:22:44 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[k8s] Adding label \u0027master_lb_allowed_cidrs\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A new label named `master_lb_allowed_cidrs` is added to control"},{"line_number":10,"context_line":"the IP range which can access the k8s api and etcd load balancers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1f493fa4_deb578cf","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":12},"updated":"2020-05-05 08:10:02.000000000","message":"Can you use imperative and not gerund?\n\nAdd label master_lb_allowed_cidrs","commit_id":"fd4282be57e5fcee46f9c24b3ffce2e862e8140a"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"f41414a8d3055376319a2776ac976422af02ee3e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Feilong Wang \u003cflwang@catalyst.net.nz\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-04 09:22:44 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[k8s] Adding label \u0027master_lb_allowed_cidrs\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A new label named `master_lb_allowed_cidrs` is added to control"},{"line_number":10,"context_line":"the IP range which can access the k8s api and etcd load balancers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1f493fa4_367e056b","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":12},"in_reply_to":"1f493fa4_deb578cf","updated":"2020-05-07 23:54:17.000000000","message":"Done","commit_id":"fd4282be57e5fcee46f9c24b3ffce2e862e8140a"}],"doc/source/user/index.rst":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"7f68834a7e732ba281240bcfb13e801ec9ebc9be","unresolved":false,"context_lines":[{"line_number":457,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":458,"context_line":"| `containerd_tarball_sha256`_          | see below          | see below     |"},{"line_number":459,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":460,"context_line":"| `master_lb_allowed_cidrs`_            | see below          | []            |"},{"line_number":461,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":".. _cluster:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df33271e_13449773","line":460,"range":{"start_line":460,"start_character":3,"end_line":460,"end_character":26},"updated":"2020-04-01 09:34:08.000000000","message":"can we put this next to the master_lb_floating_ip_enabled so that it is near a contextually similar part of the docs?","commit_id":"d3e8af1deffd0d8dc8870b2c06e3334b4e427b4e"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"7f68834a7e732ba281240bcfb13e801ec9ebc9be","unresolved":false,"context_lines":[{"line_number":1526,"context_line":"  sha256 of the tarball fetched with containerd_tarball_url or from"},{"line_number":1527,"context_line":"  https://storage.googleapis.com/cri-containerd-release/."},{"line_number":1528,"context_line":""},{"line_number":1529,"context_line":"_`master_lb_allowed_cidrs`"},{"line_number":1530,"context_line":"  A CIDR list which can be used to control the access for the load balancer of"},{"line_number":1531,"context_line":"  master nodes."},{"line_number":1532,"context_line":""},{"line_number":1533,"context_line":"External load balancer for services"},{"line_number":1534,"context_line":"-----------------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df33271e_5361ff04","line":1531,"range":{"start_line":1529,"start_character":0,"end_line":1531,"end_character":15},"updated":"2020-04-01 09:34:08.000000000","message":"same","commit_id":"d3e8af1deffd0d8dc8870b2c06e3334b4e427b4e"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"7f68834a7e732ba281240bcfb13e801ec9ebc9be","unresolved":false,"context_lines":[{"line_number":457,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":458,"context_line":"| `containerd_tarball_sha256`_          | see below          | see below     |"},{"line_number":459,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":460,"context_line":"| `master_lb_allowed_cidrs`_            | see below          | []            |"},{"line_number":461,"context_line":"+---------------------------------------+--------------------+---------------+"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":".. _cluster:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df33271e_32b51eef","line":460,"range":{"start_line":460,"start_character":2,"end_line":460,"end_character":28},"updated":"2020-04-01 09:34:08.000000000","message":"pelase move this near master_lb_floating_ip_enabled label.","commit_id":"4da4d5a014e1812c061a357fe8179b12b866f9fa"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"7f68834a7e732ba281240bcfb13e801ec9ebc9be","unresolved":false,"context_lines":[{"line_number":1526,"context_line":"  sha256 of the tarball fetched with containerd_tarball_url or from"},{"line_number":1527,"context_line":"  https://storage.googleapis.com/cri-containerd-release/."},{"line_number":1528,"context_line":""},{"line_number":1529,"context_line":"_`master_lb_allowed_cidrs`"},{"line_number":1530,"context_line":"  A CIDR list which can be used to control the access for the load balancer of"},{"line_number":1531,"context_line":"  master nodes."},{"line_number":1532,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"df33271e_12b8dae2","line":1529,"range":{"start_line":1529,"start_character":2,"end_line":1529,"end_character":25},"updated":"2020-04-01 09:34:08.000000000","message":"pelase move this near master_lb_floating_ip_enabled label.","commit_id":"4da4d5a014e1812c061a357fe8179b12b866f9fa"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"3212b6ebf55e582d708b50a00c25356cbfe3939e","unresolved":false,"context_lines":[{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"_`master_lb_allowed_cidrs`"},{"line_number":1493,"context_line":"  A CIDR list which can be used to control the access for the load balancer of"},{"line_number":1494,"context_line":"  master nodes."},{"line_number":1495,"context_line":""},{"line_number":1496,"context_line":"_`auto_healing_enabled`"},{"line_number":1497,"context_line":"  If set to true, auto healing feature will be enabled. Defaults to false."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f493fa4_fea95490","line":1494,"updated":"2020-05-05 07:59:20.000000000","message":"Can you explain what \"[]\" means? It means no restriction?","commit_id":"fd4282be57e5fcee46f9c24b3ffce2e862e8140a"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"f41414a8d3055376319a2776ac976422af02ee3e","unresolved":false,"context_lines":[{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"_`master_lb_allowed_cidrs`"},{"line_number":1493,"context_line":"  A CIDR list which can be used to control the access for the load balancer of"},{"line_number":1494,"context_line":"  master nodes."},{"line_number":1495,"context_line":""},{"line_number":1496,"context_line":"_`auto_healing_enabled`"},{"line_number":1497,"context_line":"  If set to true, auto healing feature will be enabled. Defaults to false."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f493fa4_1681494b","line":1494,"in_reply_to":"1f493fa4_fea95490","updated":"2020-05-07 23:54:17.000000000","message":"No problem. Will do.","commit_id":"fd4282be57e5fcee46f9c24b3ffce2e862e8140a"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"3ce0f861385c1fc4d99d7077b1c608228d572767","unresolved":false,"context_lines":[{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"_`master_lb_allowed_cidrs`"},{"line_number":1493,"context_line":"  A CIDR list which can be used to control the access for the load balancer of"},{"line_number":1494,"context_line":"  master nodes. Value [] means opening to 0.0.0.0/0."},{"line_number":1495,"context_line":""},{"line_number":1496,"context_line":"_`auto_healing_enabled`"},{"line_number":1497,"context_line":"  If set to true, auto healing feature will be enabled. Defaults to false."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1f493fa4_4ca97ddb","line":1494,"range":{"start_line":1494,"start_character":16,"end_line":1494,"end_character":52},"updated":"2020-05-08 11:17:45.000000000","message":"This is misleading, please describe the input as a comma separated list.","commit_id":"4fbedec7269daaaeec6b529d4941cf0e4935d792"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"f787439067cb1ce06eea2aa1512bd24b8403336d","unresolved":false,"context_lines":[{"line_number":1491,"context_line":""},{"line_number":1492,"context_line":"_`master_lb_allowed_cidrs`"},{"line_number":1493,"context_line":"  A CIDR list which can be used to control the access for the load balancer of"},{"line_number":1494,"context_line":"  master nodes. Value [] means opening to 0.0.0.0/0."},{"line_number":1495,"context_line":""},{"line_number":1496,"context_line":"_`auto_healing_enabled`"},{"line_number":1497,"context_line":"  If set to true, auto healing feature will be enabled. Defaults to false."}],"source_content_type":"text/x-rst","patch_set":10,"id":"ff570b3c_1d0a7789","line":1494,"range":{"start_line":1494,"start_character":16,"end_line":1494,"end_character":52},"in_reply_to":"1f493fa4_4ca97ddb","updated":"2020-05-08 20:18:31.000000000","message":"Will do. Thanks.","commit_id":"4fbedec7269daaaeec6b529d4941cf0e4935d792"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"b8e9427f2a1f62dec927b25632b5b4754dc4b5c1","unresolved":false,"context_lines":[{"line_number":1492,"context_line":"_`master_lb_allowed_cidrs`"},{"line_number":1493,"context_line":"  A CIDR list which can be used to control the access for the load balancer of"},{"line_number":1494,"context_line":"  master nodes. The input format is comma delimited list. For example,"},{"line_number":1495,"context_line":"  192.168.0.0/16,10.0.0.0/24. Default value is \"\" wihch means opening to"},{"line_number":1496,"context_line":"  0.0.0.0/0."},{"line_number":1497,"context_line":""},{"line_number":1498,"context_line":"_`auto_healing_enabled`"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ff570b3c_698771d9","line":1495,"range":{"start_line":1495,"start_character":50,"end_line":1495,"end_character":55},"updated":"2020-05-14 09:01:07.000000000","message":"which","commit_id":"6de3b4f6ee356df91058e66622e50ee36744e4fa"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"680d34771192f13778a695874534974f9d612653","unresolved":false,"context_lines":[{"line_number":1492,"context_line":"_`master_lb_allowed_cidrs`"},{"line_number":1493,"context_line":"  A CIDR list which can be used to control the access for the load balancer of"},{"line_number":1494,"context_line":"  master nodes. The input format is comma delimited list. For example,"},{"line_number":1495,"context_line":"  192.168.0.0/16,10.0.0.0/24. Default value is \"\" wihch means opening to"},{"line_number":1496,"context_line":"  0.0.0.0/0."},{"line_number":1497,"context_line":""},{"line_number":1498,"context_line":"_`auto_healing_enabled`"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ff570b3c_0d8e612d","line":1495,"range":{"start_line":1495,"start_character":50,"end_line":1495,"end_character":55},"in_reply_to":"ff570b3c_698771d9","updated":"2020-05-14 09:17:47.000000000","message":"Done","commit_id":"6de3b4f6ee356df91058e66622e50ee36744e4fa"}],"magnum/drivers/common/templates/lb_api.yaml":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"8e69194f61d0241f08577ba8937569ca4b4c4d27","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: 2014-10-16"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"parameters:"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_c64ef06d","line":1,"updated":"2020-03-30 01:34:43.000000000","message":"@Spyros, the `allowed_cidrs` is a new feature in Octavia stable/train and the supported has been merged in Heat master branch and I\u0027m trying to cherrypick it to Heat stable/train. My question is how can we manage to support it in Magnum, thoughts?","commit_id":"d3e8af1deffd0d8dc8870b2c06e3334b4e427b4e"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"bca51b4ab646f78d3db796947e8379e42b5e2c3b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      loadbalancer: {get_resource: loadbalancer}"},{"line_number":44,"context_line":"      protocol: {get_param: protocol}"},{"line_number":45,"context_line":"      protocol_port: {get_param: port}"},{"line_number":46,"context_line":"      allowed_cidrs: {get_param: allowed_cidrs}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  pool:"},{"line_number":49,"context_line":"    type: Magnum::Optional::Neutron::LBaaS::Pool"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f493fa4_3890794a","line":46,"range":{"start_line":46,"start_character":6,"end_line":46,"end_character":19},"updated":"2020-05-08 07:19:27.000000000","message":"how did you make it work without Train heat?","commit_id":"63dd481ff146af602c67eba13c52e8d9865738e0"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"19ce624688d6bd723d1e492ccb1211b913ce0021","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    properties:"},{"line_number":31,"context_line":"      vip_subnet: {get_param: fixed_subnet}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  listener:"},{"line_number":34,"context_line":"    type: Magnum::Optional::Neutron::LBaaS::Listener"},{"line_number":35,"context_line":"    properties:"},{"line_number":36,"context_line":"      loadbalancer: {get_resource: loadbalancer}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f493fa4_2f9016ed","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":10},"updated":"2020-04-29 07:31:29.000000000","message":"why we removed condition for these two resources? It make sense to me to not build resources when we don\u0027t need it as condition allows","commit_id":"4c222c10f43134ba7171da31e5035004abef1267"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"3212b6ebf55e582d708b50a00c25356cbfe3939e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: queens"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"conditions:"},{"line_number":4,"context_line":"  allowed_cidrs_enabled:"},{"line_number":5,"context_line":"    not:"},{"line_number":6,"context_line":"      equals:"},{"line_number":7,"context_line":"      - get_param: allowed_cidrs"},{"line_number":8,"context_line":"      - []"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  allowed_cidrs_disabled:"},{"line_number":11,"context_line":"      equals:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_feb4b4f4","line":8,"range":{"start_line":4,"start_character":0,"end_line":8,"end_character":10},"updated":"2020-05-05 07:59:20.000000000","message":"I think this can be:\n   allowed_cidrs_enabled:\n     not:\n       allowed_cidrs_disabled","commit_id":"fd4282be57e5fcee46f9c24b3ffce2e862e8140a"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"f41414a8d3055376319a2776ac976422af02ee3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: queens"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"conditions:"},{"line_number":4,"context_line":"  allowed_cidrs_enabled:"},{"line_number":5,"context_line":"    not:"},{"line_number":6,"context_line":"      equals:"},{"line_number":7,"context_line":"      - get_param: allowed_cidrs"},{"line_number":8,"context_line":"      - []"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  allowed_cidrs_disabled:"},{"line_number":11,"context_line":"      equals:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_b691759c","line":8,"range":{"start_line":4,"start_character":0,"end_line":8,"end_character":10},"in_reply_to":"1f493fa4_feb4b4f4","updated":"2020-05-07 23:54:17.000000000","message":"No problem. Will do.","commit_id":"fd4282be57e5fcee46f9c24b3ffce2e862e8140a"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"3212b6ebf55e582d708b50a00c25356cbfe3939e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      loadbalancer: {get_resource: loadbalancer}"},{"line_number":55,"context_line":"      protocol: {get_param: protocol}"},{"line_number":56,"context_line":"      protocol_port: {get_param: port}"},{"line_number":57,"context_line":"      allowed_cidrs: {get_param: allowed_cidrs}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  pool:"},{"line_number":60,"context_line":"    type: Magnum::Optional::Neutron::LBaaS::Pool"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_3e7c5c1f","line":57,"updated":"2020-05-05 07:59:20.000000000","message":"if the private network is using this cidr: 10.0.0.0/16\nAnd for allowed_cidrs I specify 192.168.0.0/16, it means the worker nodes won\u0027t have access to the API?","commit_id":"fd4282be57e5fcee46f9c24b3ffce2e862e8140a"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"77b2626435b2a88fa9d376eaeb1888915fd1b4d6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      loadbalancer: {get_resource: loadbalancer}"},{"line_number":55,"context_line":"      protocol: {get_param: protocol}"},{"line_number":56,"context_line":"      protocol_port: {get_param: port}"},{"line_number":57,"context_line":"      allowed_cidrs: {get_param: allowed_cidrs}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  pool:"},{"line_number":60,"context_line":"    type: Magnum::Optional::Neutron::LBaaS::Pool"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_79f87ec3","line":57,"in_reply_to":"1f493fa4_36cc45bb","updated":"2020-05-08 02:48:12.000000000","message":"I think you\u0027re right. I will propose a new patch set to cover this.","commit_id":"fd4282be57e5fcee46f9c24b3ffce2e862e8140a"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"f41414a8d3055376319a2776ac976422af02ee3e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      loadbalancer: {get_resource: loadbalancer}"},{"line_number":55,"context_line":"      protocol: {get_param: protocol}"},{"line_number":56,"context_line":"      protocol_port: {get_param: port}"},{"line_number":57,"context_line":"      allowed_cidrs: {get_param: allowed_cidrs}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  pool:"},{"line_number":60,"context_line":"    type: Magnum::Optional::Neutron::LBaaS::Pool"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_36cc45bb","line":57,"in_reply_to":"1f493fa4_3e7c5c1f","updated":"2020-05-07 23:54:17.000000000","message":"I\u0027m not sure if I fully understand this question. This security group only applies to the loadbalancer and the worker nodes are talking to master nodes via the fixed IP instead of the LB VIP. So there is no impact for worker nodes.","commit_id":"fd4282be57e5fcee46f9c24b3ffce2e862e8140a"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"918861f1f2fa950522436217eff8e64a82b51309","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      loadbalancer: {get_resource: loadbalancer}"},{"line_number":55,"context_line":"      protocol: {get_param: protocol}"},{"line_number":56,"context_line":"      protocol_port: {get_param: port}"},{"line_number":57,"context_line":"      allowed_cidrs: {get_param: allowed_cidrs}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  pool:"},{"line_number":60,"context_line":"    type: Magnum::Optional::Neutron::LBaaS::Pool"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_be04ec7f","line":57,"in_reply_to":"1f493fa4_3e7c5c1f","updated":"2020-05-05 08:10:02.000000000","message":"This option doesn\u0027t seem to be documented.\n\nhttps://docs.openstack.org/heat/rocky/template_guide/openstack.html#OS::Octavia::Listener\n\nI will test it.","commit_id":"fd4282be57e5fcee46f9c24b3ffce2e862e8140a"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"f41414a8d3055376319a2776ac976422af02ee3e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      loadbalancer: {get_resource: loadbalancer}"},{"line_number":55,"context_line":"      protocol: {get_param: protocol}"},{"line_number":56,"context_line":"      protocol_port: {get_param: port}"},{"line_number":57,"context_line":"      allowed_cidrs: {get_param: allowed_cidrs}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  pool:"},{"line_number":60,"context_line":"    type: Magnum::Optional::Neutron::LBaaS::Pool"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_96ba7907","line":57,"in_reply_to":"1f493fa4_be04ec7f","updated":"2020-05-07 23:54:17.000000000","message":"This attribute was supported in Octavia since Rocky but in Heat since Ussuri, see https://docs.openstack.org/heat/ussuri/template_guide/openstack.html#OS::Octavia::Listener","commit_id":"fd4282be57e5fcee46f9c24b3ffce2e862e8140a"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"6b6b1a68d2e37f4c23119b53d23adbee76b8b523","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: queens"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"conditions:"},{"line_number":4,"context_line":"  allowed_cidrs_enabled:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ff570b3c_ed920d9e","line":1,"range":{"start_line":1,"start_character":23,"end_line":1,"end_character":29},"updated":"2020-05-14 09:04:55.000000000","message":"I dont understand how it works even though the heat_template_version is queens but it seems to work... Does that mean heat template version just a noop metadata? I always thought it meant that features available in Ussuri would not be available in a heat_template_version: queens.","commit_id":"6de3b4f6ee356df91058e66622e50ee36744e4fa"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"1a51bb224ad6e1fec490460d6d85060b796bd03c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: queens"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"conditions:"},{"line_number":4,"context_line":"  allowed_cidrs_enabled:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ff570b3c_6dd27dd4","line":1,"range":{"start_line":1,"start_character":23,"end_line":1,"end_character":29},"in_reply_to":"ff570b3c_0dbca1b9","updated":"2020-05-14 09:27:06.000000000","message":"Ah okay that makes sense in that case.","commit_id":"6de3b4f6ee356df91058e66622e50ee36744e4fa"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"680d34771192f13778a695874534974f9d612653","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: queens"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"conditions:"},{"line_number":4,"context_line":"  allowed_cidrs_enabled:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ff570b3c_0dbca1b9","line":1,"range":{"start_line":1,"start_character":23,"end_line":1,"end_character":29},"in_reply_to":"ff570b3c_ed920d9e","updated":"2020-05-14 09:17:47.000000000","message":"The version here means the minimum version needed for this template.","commit_id":"6de3b4f6ee356df91058e66622e50ee36744e4fa"}],"magnum/drivers/common/templates/lb_etcd.yaml":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"3212b6ebf55e582d708b50a00c25356cbfe3939e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    not:"},{"line_number":7,"context_line":"      equals:"},{"line_number":8,"context_line":"      - get_param: allowed_cidrs"},{"line_number":9,"context_line":"      - []"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  allowed_cidrs_disabled:"},{"line_number":12,"context_line":"      equals:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_3ece1c83","line":9,"updated":"2020-05-05 07:59:20.000000000","message":"ditto","commit_id":"fd4282be57e5fcee46f9c24b3ffce2e862e8140a"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"f41414a8d3055376319a2776ac976422af02ee3e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    not:"},{"line_number":7,"context_line":"      equals:"},{"line_number":8,"context_line":"      - get_param: allowed_cidrs"},{"line_number":9,"context_line":"      - []"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  allowed_cidrs_disabled:"},{"line_number":12,"context_line":"      equals:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_968c3980","line":9,"in_reply_to":"1f493fa4_3ece1c83","updated":"2020-05-07 23:54:17.000000000","message":"Done","commit_id":"fd4282be57e5fcee46f9c24b3ffce2e862e8140a"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"bca51b4ab646f78d3db796947e8379e42b5e2c3b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# etcd service load balancer doesn\u0027t have floating IP associated."},{"line_number":2,"context_line":"heat_template_version: queens"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"conditions:"},{"line_number":5,"context_line":"  allowed_cidrs_enabled:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1f493fa4_cff3c49d","line":2,"range":{"start_line":2,"start_character":21,"end_line":2,"end_character":22},"updated":"2020-05-08 07:19:27.000000000","message":"Is it fine to leave this as queens even though the heat template is using a feature only available from ussuri?","commit_id":"4fbedec7269daaaeec6b529d4941cf0e4935d792"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"46fa5364a881114bda10e52823c268eac8ad0e3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# etcd service load balancer doesn\u0027t have floating IP associated."},{"line_number":2,"context_line":"heat_template_version: queens"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"conditions:"},{"line_number":5,"context_line":"  allowed_cidrs_enabled:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1f493fa4_0a2e3a42","line":2,"range":{"start_line":2,"start_character":21,"end_line":2,"end_character":22},"in_reply_to":"1f493fa4_cff3c49d","updated":"2020-05-08 08:19:30.000000000","message":"Yes, because now with the condition, it won\u0027t break any function if user are still running on the lower Heat versions.","commit_id":"4fbedec7269daaaeec6b529d4941cf0e4935d792"}],"magnum/drivers/heat/k8s_template_def.py":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"782a9666cf879e3b3359b1bc46fb962c55000af6","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def _set_master_lb_allowed_cidrs(self, context, cluster, extra_params):"},{"line_number":274,"context_line":"        if extra_params.get(\"master_lb_allowed_cidrs\"):"},{"line_number":275,"context_line":"            subnet_cidr \u003d \"10.0.0.0/24\""},{"line_number":276,"context_line":"            if extra_params.get(\"fixed_subnet\"):"},{"line_number":277,"context_line":"                subnet_cidr \u003d neutron.get_subnet(context,"},{"line_number":278,"context_line":"                                                 extra_params[\"fixed_subnet\"],"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_a9e473ad","line":275,"range":{"start_line":275,"start_character":26,"end_line":275,"end_character":39},"updated":"2020-05-08 11:04:40.000000000","message":"why is this hard coded here? there is a parameter called fixed_network_cidr which could be reused.","commit_id":"4fbedec7269daaaeec6b529d4941cf0e4935d792"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"f787439067cb1ce06eea2aa1512bd24b8403336d","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def _set_master_lb_allowed_cidrs(self, context, cluster, extra_params):"},{"line_number":274,"context_line":"        if extra_params.get(\"master_lb_allowed_cidrs\"):"},{"line_number":275,"context_line":"            subnet_cidr \u003d \"10.0.0.0/24\""},{"line_number":276,"context_line":"            if extra_params.get(\"fixed_subnet\"):"},{"line_number":277,"context_line":"                subnet_cidr \u003d neutron.get_subnet(context,"},{"line_number":278,"context_line":"                                                 extra_params[\"fixed_subnet\"],"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_bdcf0b56","line":275,"range":{"start_line":275,"start_character":26,"end_line":275,"end_character":39},"in_reply_to":"1f493fa4_a9e473ad","updated":"2020-05-08 20:18:31.000000000","message":"Good point. We should try to get the \u0027fixed_network_cidr\u0027 first, and if it\u0027s not set. We need to use the default value here.","commit_id":"4fbedec7269daaaeec6b529d4941cf0e4935d792"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"782a9666cf879e3b3359b1bc46fb962c55000af6","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                subnet_cidr \u003d neutron.get_subnet(context,"},{"line_number":278,"context_line":"                                                 extra_params[\"fixed_subnet\"],"},{"line_number":279,"context_line":"                                                 \"id\", \"cidr\")"},{"line_number":280,"context_line":"            extra_params[\"master_lb_allowed_cidrs\"] +\u003d subnet_cidr"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def get_scale_params(self, context, cluster, scale_manager\u003dNone,"},{"line_number":283,"context_line":"                         nodes_to_remove\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_c9c0dfe3","line":280,"range":{"start_line":280,"start_character":12,"end_line":280,"end_character":66},"updated":"2020-05-08 11:04:40.000000000","message":"This does not work! i  tried passing in master_lb_allowed_cidr as \"172.24.4.0/24\" and also \"[172.24.4.0/24]\" but I get these errors:\n\nError validating value \u0027[172.24.4.0/24]10.0.0.0/24\u0027: Invalid net cidr invalid IPNetwork 172.24.4.0/2410.0.0.0/24 \"\n\nError validating value \u0027[172.24.4.0/24]10.0.0.0/24\u0027: Invalid net cidr invalid IPNetwork [172.24.4.0/24]10.0.0.0/24 \"\n\nIs this missing a comma or something? An example input needs to be documented. The example of \"[]\" seems to imply that the input is a list which is not the case and we are not parsing this string into a list anywhere.\n\nPlease test this first locally before requesting review.","commit_id":"4fbedec7269daaaeec6b529d4941cf0e4935d792"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"f787439067cb1ce06eea2aa1512bd24b8403336d","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                subnet_cidr \u003d neutron.get_subnet(context,"},{"line_number":278,"context_line":"                                                 extra_params[\"fixed_subnet\"],"},{"line_number":279,"context_line":"                                                 \"id\", \"cidr\")"},{"line_number":280,"context_line":"            extra_params[\"master_lb_allowed_cidrs\"] +\u003d subnet_cidr"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def get_scale_params(self, context, cluster, scale_manager\u003dNone,"},{"line_number":283,"context_line":"                         nodes_to_remove\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_5db6afdb","line":280,"range":{"start_line":280,"start_character":12,"end_line":280,"end_character":66},"in_reply_to":"1f493fa4_49716fde","updated":"2020-05-08 20:18:31.000000000","message":"Oops, I missed a \u0027,\u0027 here. I will fix it in next PS.","commit_id":"4fbedec7269daaaeec6b529d4941cf0e4935d792"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"b7971f8793283807dc5208ef4a162cb397247cae","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                subnet_cidr \u003d neutron.get_subnet(context,"},{"line_number":278,"context_line":"                                                 extra_params[\"fixed_subnet\"],"},{"line_number":279,"context_line":"                                                 \"id\", \"cidr\")"},{"line_number":280,"context_line":"            extra_params[\"master_lb_allowed_cidrs\"] +\u003d subnet_cidr"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def get_scale_params(self, context, cluster, scale_manager\u003dNone,"},{"line_number":283,"context_line":"                         nodes_to_remove\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_49716fde","line":280,"range":{"start_line":280,"start_character":12,"end_line":280,"end_character":66},"in_reply_to":"1f493fa4_c9c0dfe3","updated":"2020-05-08 11:07:34.000000000","message":"ok if I supply the input as \"172.24.4.0/24,\" (note the comma), this works. I believe the user should be asked to provide a comma separated list as input rather than a bracket [] in the documentation.","commit_id":"4fbedec7269daaaeec6b529d4941cf0e4935d792"}],"magnum/drivers/k8s_fedora_atomic_v1/templates/kubecluster.yaml":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"21f4d9ca14f37c8ca86d52b2ee6bb43dbb44e6e6","unresolved":false,"context_lines":[{"line_number":883,"context_line":"      specific configs"},{"line_number":884,"context_line":"    default: \"\""},{"line_number":885,"context_line":""},{"line_number":886,"context_line":"  master_lb_allowed_cidrs:"},{"line_number":887,"context_line":"    type: comma_delimited_list"},{"line_number":888,"context_line":"    description: The allowed CIDR list for master load balancer"},{"line_number":889,"context_line":"    default: []"},{"line_number":890,"context_line":""},{"line_number":891,"context_line":"resources:"},{"line_number":892,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_32aa3e84","line":889,"range":{"start_line":886,"start_character":0,"end_line":889,"end_character":15},"updated":"2020-04-01 10:17:22.000000000","message":"I think we should drop support for fedora atomic template since its EOL.","commit_id":"4da4d5a014e1812c061a357fe8179b12b866f9fa"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"c93613b5d3165ab2460b84dedcf3c77d9ee3cdee","unresolved":false,"context_lines":[{"line_number":883,"context_line":"      specific configs"},{"line_number":884,"context_line":"    default: \"\""},{"line_number":885,"context_line":""},{"line_number":886,"context_line":"  master_lb_allowed_cidrs:"},{"line_number":887,"context_line":"    type: comma_delimited_list"},{"line_number":888,"context_line":"    description: The allowed CIDR list for master load balancer"},{"line_number":889,"context_line":"    default: []"},{"line_number":890,"context_line":""},{"line_number":891,"context_line":"resources:"},{"line_number":892,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_d7fc973f","line":889,"range":{"start_line":886,"start_character":0,"end_line":889,"end_character":15},"in_reply_to":"df33271e_32aa3e84","updated":"2020-04-01 16:39:19.000000000","message":"+1","commit_id":"4da4d5a014e1812c061a357fe8179b12b866f9fa"}],"releasenotes/notes/master-lb-allowed-cidrs-cc599da4eb96e983.yaml":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"d7cbfc362c6ad6cdb4544b00207f91e42fff7c24","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new lable named `master_lb_allowed_cidrs` to control the IP ranges"},{"line_number":5,"context_line":"    who can access the master load balancer."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f493fa4_a30bbe7a","line":4,"range":{"start_line":4,"start_character":14,"end_line":4,"end_character":19},"updated":"2020-04-28 09:25:32.000000000","message":"label","commit_id":"4a468b4515583b9912eff43594a0ff5fc45b604b"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"d7cbfc362c6ad6cdb4544b00207f91e42fff7c24","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new lable named `master_lb_allowed_cidrs` to control the IP ranges"},{"line_number":5,"context_line":"    who can access the master load balancer."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f493fa4_c3536a6a","line":5,"range":{"start_line":5,"start_character":35,"end_line":5,"end_character":43},"updated":"2020-04-28 09:25:32.000000000","message":"technically we have two, but this is fine. Same for docs, it is fine.","commit_id":"4a468b4515583b9912eff43594a0ff5fc45b604b"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"d7cbfc362c6ad6cdb4544b00207f91e42fff7c24","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new lable named `master_lb_allowed_cidrs` to control the IP ranges"},{"line_number":5,"context_line":"    who can access the master load balancer."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f493fa4_a359fe8e","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":7},"updated":"2020-04-28 09:25:32.000000000","message":"which","commit_id":"4a468b4515583b9912eff43594a0ff5fc45b604b"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"6b6b1a68d2e37f4c23119b53d23adbee76b8b523","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new label named `master_lb_allowed_cidrs` to control the IP ranges"},{"line_number":5,"context_line":"    which can access the k8s API and etcd load balancers of master."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ff570b3c_ede7ad3f","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":67},"updated":"2020-05-14 09:04:55.000000000","message":"Can we add a note here that to use this feature, the minimum version of heat and octavia that is required?","commit_id":"6de3b4f6ee356df91058e66622e50ee36744e4fa"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"680d34771192f13778a695874534974f9d612653","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new label named `master_lb_allowed_cidrs` to control the IP ranges"},{"line_number":5,"context_line":"    which can access the k8s API and etcd load balancers of master."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ff570b3c_2d908543","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":67},"in_reply_to":"ff570b3c_ede7ad3f","updated":"2020-05-14 09:17:47.000000000","message":"Sure, will do.","commit_id":"6de3b4f6ee356df91058e66622e50ee36744e4fa"}]}