)]}'
{"magnum/drivers/common/templates/kubernetes/fragments/core-dns-service.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"3fc99d2b4b769f4124f6319dc9c12cd533983c01","unresolved":false,"context_lines":[{"line_number":110,"context_line":"      priorityClassName: system-cluster-critical"},{"line_number":111,"context_line":"      serviceAccountName: coredns"},{"line_number":112,"context_line":"      tolerations:"},{"line_number":113,"context_line":"        # Make sure the pod can be scheduled on master kubelet."},{"line_number":114,"context_line":"        - effect: NoSchedule"},{"line_number":115,"context_line":"          operator: Exists"},{"line_number":116,"context_line":"        # Mark the pod as a critical add-on for rescheduling."},{"line_number":117,"context_line":"        - key: CriticalAddonsOnly"},{"line_number":118,"context_line":"          operator: Exists"},{"line_number":119,"context_line":"        - effect: NoExecute"},{"line_number":120,"context_line":"          operator: Exists"},{"line_number":121,"context_line":"      nodeSelector:"},{"line_number":122,"context_line":"        beta.kubernetes.io/os: linux"},{"line_number":123,"context_line":"      containers:"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df33271e_1caacd6f","line":120,"range":{"start_line":113,"start_character":0,"end_line":120,"end_character":26},"updated":"2020-03-31 08:48:46.000000000","message":"if we are enabling coredns pod on master, we should also open port 53 to enable DNS as @spyros pointed out.","commit_id":"2d4e61dcc2250114722c9279b396fe194b8f4d37"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"4d32f874c6d1c57f059e01ee0f080c9a18338d8a","unresolved":false,"context_lines":[{"line_number":110,"context_line":"      priorityClassName: system-cluster-critical"},{"line_number":111,"context_line":"      serviceAccountName: coredns"},{"line_number":112,"context_line":"      tolerations:"},{"line_number":113,"context_line":"        # Make sure the pod can be scheduled on master kubelet."},{"line_number":114,"context_line":"        - effect: NoSchedule"},{"line_number":115,"context_line":"          operator: Exists"},{"line_number":116,"context_line":"        # Mark the pod as a critical add-on for rescheduling."},{"line_number":117,"context_line":"        - key: CriticalAddonsOnly"},{"line_number":118,"context_line":"          operator: Exists"},{"line_number":119,"context_line":"        - effect: NoExecute"},{"line_number":120,"context_line":"          operator: Exists"},{"line_number":121,"context_line":"      nodeSelector:"},{"line_number":122,"context_line":"        beta.kubernetes.io/os: linux"},{"line_number":123,"context_line":"      containers:"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df33271e_0fcd5f65","line":120,"range":{"start_line":113,"start_character":0,"end_line":120,"end_character":26},"in_reply_to":"df33271e_1caacd6f","updated":"2020-03-31 17:59:40.000000000","message":"Sure will do.","commit_id":"2d4e61dcc2250114722c9279b396fe194b8f4d37"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"891122cb257da0115c73b2a9fcc861bfb08a78e4","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        - effect: NoExecute"},{"line_number":120,"context_line":"          operator: Exists"},{"line_number":121,"context_line":"      nodeSelector:"},{"line_number":122,"context_line":"        beta.kubernetes.io/os: linux"},{"line_number":123,"context_line":"      containers:"},{"line_number":124,"context_line":"      - name: coredns"},{"line_number":125,"context_line":"        image: ${_dns_prefix}coredns:${COREDNS_TAG}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df33271e_d9019208","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":36},"updated":"2020-03-31 12:08:18.000000000","message":"Can you also update this to use the non deprecated labels?\nkubernetes.io/os: linux\n\nCheck: https://review.opendev.org/#/c/704315/1/magnum/drivers/common/templates/kubernetes/fragments/core-dns-service.sh","commit_id":"2d4e61dcc2250114722c9279b396fe194b8f4d37"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"4d32f874c6d1c57f059e01ee0f080c9a18338d8a","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        - effect: NoExecute"},{"line_number":120,"context_line":"          operator: Exists"},{"line_number":121,"context_line":"      nodeSelector:"},{"line_number":122,"context_line":"        beta.kubernetes.io/os: linux"},{"line_number":123,"context_line":"      containers:"},{"line_number":124,"context_line":"      - name: coredns"},{"line_number":125,"context_line":"        image: ${_dns_prefix}coredns:${COREDNS_TAG}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df33271e_cfaff77a","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":36},"in_reply_to":"df33271e_d9019208","updated":"2020-03-31 17:59:40.000000000","message":"Nice catch. Will do.","commit_id":"2d4e61dcc2250114722c9279b396fe194b8f4d37"}]}