)]}'
{"magnum/drivers/common/templates/kubernetes/fragments/calico-service-v3-3-x.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"78c35f679d8b230b5057ed781b77688a529c8931","unresolved":false,"context_lines":[{"line_number":403,"context_line":"            - name: CALICO_IPV4POOL_CIDR"},{"line_number":404,"context_line":"              value: ${CALICO_IPV4POOL}"},{"line_number":405,"context_line":"            - name: CALICO_IPV4POOL_IPIP"},{"line_number":406,"context_line":"              value: ${CALICO_IPV4POOL_IPIP}"},{"line_number":407,"context_line":"            - name: CALICO_IPV4POOL_NAT_OUTGOING"},{"line_number":408,"context_line":"              value: \"true\""},{"line_number":409,"context_line":"            # Set noderef for node controller."}],"source_content_type":"text/x-sh","patch_set":3,"id":"df33271e_23d620f3","line":406,"range":{"start_line":406,"start_character":21,"end_line":406,"end_character":44},"updated":"2020-04-04 17:16:58.000000000","message":"self-note add quotes","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"d62b3979900fe54968d19967e6e7605a745bf522","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        scheduler.alpha.kubernetes.io/critical-pod: \u0027\u0027"},{"line_number":347,"context_line":"    spec:"},{"line_number":348,"context_line":"      nodeSelector:"},{"line_number":349,"context_line":"        beta.kubernetes.io/os: linux"},{"line_number":350,"context_line":"      hostNetwork: true"},{"line_number":351,"context_line":"      tolerations:"},{"line_number":352,"context_line":"        # Make sure calico-node gets scheduled on all nodes."}],"source_content_type":"text/x-sh","patch_set":6,"id":"df33271e_9062b9d7","line":349,"range":{"start_line":349,"start_character":8,"end_line":349,"end_character":13},"updated":"2020-04-06 13:28:56.000000000","message":"is this still needed btw?","commit_id":"dd4b79263f37deaa56d551b1daaa82ab19867fd4"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"dac1a231a993c26ac372b207d617481d66625db4","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        scheduler.alpha.kubernetes.io/critical-pod: \u0027\u0027"},{"line_number":347,"context_line":"    spec:"},{"line_number":348,"context_line":"      nodeSelector:"},{"line_number":349,"context_line":"        beta.kubernetes.io/os: linux"},{"line_number":350,"context_line":"      hostNetwork: true"},{"line_number":351,"context_line":"      tolerations:"},{"line_number":352,"context_line":"        # Make sure calico-node gets scheduled on all nodes."}],"source_content_type":"text/x-sh","patch_set":6,"id":"df33271e_cbd64ff2","line":349,"range":{"start_line":349,"start_character":8,"end_line":349,"end_character":13},"in_reply_to":"df33271e_0bbcb7b9","updated":"2020-04-06 14:58:33.000000000","message":"Also it is better if the file contents are identical. (minus the step variable at the top)","commit_id":"dd4b79263f37deaa56d551b1daaa82ab19867fd4"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"c88c724474a5f5293ab0a3b5a7925d1184d2fb30","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        scheduler.alpha.kubernetes.io/critical-pod: \u0027\u0027"},{"line_number":347,"context_line":"    spec:"},{"line_number":348,"context_line":"      nodeSelector:"},{"line_number":349,"context_line":"        beta.kubernetes.io/os: linux"},{"line_number":350,"context_line":"      hostNetwork: true"},{"line_number":351,"context_line":"      tolerations:"},{"line_number":352,"context_line":"        # Make sure calico-node gets scheduled on all nodes."}],"source_content_type":"text/x-sh","patch_set":6,"id":"df33271e_0bbcb7b9","line":349,"range":{"start_line":349,"start_character":8,"end_line":349,"end_character":13},"in_reply_to":"df33271e_9062b9d7","updated":"2020-04-06 14:57:33.000000000","message":"I don\u0027t think so, but this manifest is here just to be backwards compatible. I don\u0027t think it is necessary to bring it up to date.","commit_id":"dd4b79263f37deaa56d551b1daaa82ab19867fd4"}],"magnum/drivers/k8s_fedora_atomic_v1/templates/kubecluster.yaml":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"a675c18c1eb3db61445d2138ab2e5a78e1c852f0","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"                - \"\""},{"line_number":1247,"context_line":"            - if:"},{"line_number":1248,"context_line":"                - default_calico"},{"line_number":1249,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1250,"context_line":"                - \"\""},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_8a446f76","line":1249,"range":{"start_line":1249,"start_character":72,"end_line":1249,"end_character":94},"updated":"2020-04-04 06:56:08.000000000","message":"lets leave this as calico-service.sh","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"273bf1748e5a925573ec1df12e6ec7db3aed8068","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"                - \"\""},{"line_number":1247,"context_line":"            - if:"},{"line_number":1248,"context_line":"                - default_calico"},{"line_number":1249,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1250,"context_line":"                - \"\""},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_52ff9e33","line":1249,"range":{"start_line":1249,"start_character":72,"end_line":1249,"end_character":94},"in_reply_to":"df33271e_43235606","updated":"2020-04-06 08:38:55.000000000","message":"\u003e If we don\u0027t rename, I will keep only one if state.\n+1 ok lets not rename and keep one if statement only.","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4b7d6c610607c32b1bae7ff7d265d00e32453fa3","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"                - \"\""},{"line_number":1247,"context_line":"            - if:"},{"line_number":1248,"context_line":"                - default_calico"},{"line_number":1249,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1250,"context_line":"                - \"\""},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_dc12a009","line":1249,"range":{"start_line":1249,"start_character":72,"end_line":1249,"end_character":94},"in_reply_to":"df33271e_52ff9e33","updated":"2020-04-06 10:24:59.000000000","message":"-1 to the change. But i\u0027m doing it anyway.","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"8f589f4031d831f0ebc7322a4b6171323c0731d3","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"                - \"\""},{"line_number":1247,"context_line":"            - if:"},{"line_number":1248,"context_line":"                - default_calico"},{"line_number":1249,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1250,"context_line":"                - \"\""},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_43235606","line":1249,"range":{"start_line":1249,"start_character":72,"end_line":1249,"end_character":94},"in_reply_to":"df33271e_639e68b9","updated":"2020-04-05 20:24:47.000000000","message":"If we don\u0027t rename, I will keep only one if statement.\n\nNote that with this change, only one file will be passed to heat.","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"78c35f679d8b230b5057ed781b77688a529c8931","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"                - \"\""},{"line_number":1247,"context_line":"            - if:"},{"line_number":1248,"context_line":"                - default_calico"},{"line_number":1249,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1250,"context_line":"                - \"\""},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_639e68b9","line":1249,"range":{"start_line":1249,"start_character":72,"end_line":1249,"end_character":94},"in_reply_to":"df33271e_8a446f76","updated":"2020-04-04 17:16:58.000000000","message":"My arguments in changing the name (I don\u0027t like renames of files in git):\nWhen the calico team breaks the configuration again we will have to change it, maybe like recently where we needed to change: 78% of each lines (663/851). 78% files change is like a new file, keeping the same name adds little value.\n\nSince we don\u0027t break things, I will keep it to move forward, although I still think it is better to change. Feilong, reneme or keep calici-service.sh \n\nself note: Change in coreos too.","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"}],"magnum/drivers/k8s_fedora_coreos_v1/templates/kubecluster.yaml":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"665e321c4f7833b8e5d21f498d2423b84b2085d9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    - is_worker"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  calico_v3_3:"},{"line_number":40,"context_line":"    contains:"},{"line_number":41,"context_line":"    - \u0027v3.3\u0027"},{"line_number":42,"context_line":"    - get_param: calico_tag"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_3269508b","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":12},"updated":"2020-04-04 07:08:38.000000000","message":"Can this be something more specific like startswith if that is a thing?","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"78c35f679d8b230b5057ed781b77688a529c8931","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    - is_worker"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  calico_v3_3:"},{"line_number":40,"context_line":"    contains:"},{"line_number":41,"context_line":"    - \u0027v3.3\u0027"},{"line_number":42,"context_line":"    - get_param: calico_tag"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_a344f01c","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":12},"in_reply_to":"df33271e_3269508b","updated":"2020-04-04 17:16:58.000000000","message":"Can you check here [0] if something satisfies you more than \u0027contains\u0027? There is no startswith.\n\n[0] https://docs.openstack.org/heat/train/template_guide/hot_spec.html#intrinsic-functions","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"273bf1748e5a925573ec1df12e6ec7db3aed8068","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    - is_worker"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  calico_v3_3:"},{"line_number":40,"context_line":"    contains:"},{"line_number":41,"context_line":"    - \u0027v3.3\u0027"},{"line_number":42,"context_line":"    - get_param: calico_tag"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_d28d6e32","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":12},"in_reply_to":"df33271e_a344f01c","updated":"2020-04-06 08:38:55.000000000","message":"The yaql condition (available since Pike) permits startWith: https://yaql.readthedocs.io/en/latest/standard_library.html#startswith","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4b7d6c610607c32b1bae7ff7d265d00e32453fa3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    - is_worker"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  calico_v3_3:"},{"line_number":40,"context_line":"    contains:"},{"line_number":41,"context_line":"    - \u0027v3.3\u0027"},{"line_number":42,"context_line":"    - get_param: calico_tag"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_7cbef4ff","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":12},"in_reply_to":"df33271e_d28d6e32","updated":"2020-04-06 10:24:59.000000000","message":"all:\nhttps://paste.centos.org/view/d9ff23ea\n\ncontains:\nhttps://paste.centos.org/view/8af272a5\n\nstartsWith:\nhttps://paste.centos.org/view/075237eb\n\nNo such case at the moment.\n\nI added it.","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"665e321c4f7833b8e5d21f498d2423b84b2085d9","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  calico_v3_3:"},{"line_number":40,"context_line":"    contains:"},{"line_number":41,"context_line":"    - \u0027v3.3\u0027"},{"line_number":42,"context_line":"    - get_param: calico_tag"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  default_calico:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_f26ec894","line":41,"range":{"start_line":41,"start_character":10,"end_line":41,"end_character":11},"updated":"2020-04-04 07:08:38.000000000","message":"Should be v3.3.","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"273bf1748e5a925573ec1df12e6ec7db3aed8068","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  calico_v3_3:"},{"line_number":40,"context_line":"    contains:"},{"line_number":41,"context_line":"    - \u0027v3.3\u0027"},{"line_number":42,"context_line":"    - get_param: calico_tag"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  default_calico:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_d2bbaec1","line":41,"range":{"start_line":41,"start_character":10,"end_line":41,"end_character":11},"in_reply_to":"df33271e_2350e0d4","updated":"2020-04-06 08:38:55.000000000","message":"Yes :) given that we just jumped from 3.13-3.3\u003d0.10 and 3.30-3.13\u003d0.17 which is  in the same order of magnitude.","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4b7d6c610607c32b1bae7ff7d265d00e32453fa3","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  calico_v3_3:"},{"line_number":40,"context_line":"    contains:"},{"line_number":41,"context_line":"    - \u0027v3.3\u0027"},{"line_number":42,"context_line":"    - get_param: calico_tag"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  default_calico:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_bc5ebce6","line":41,"range":{"start_line":41,"start_character":10,"end_line":41,"end_character":11},"in_reply_to":"df33271e_d2bbaec1","updated":"2020-04-06 10:24:59.000000000","message":"ok","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"78c35f679d8b230b5057ed781b77688a529c8931","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  calico_v3_3:"},{"line_number":40,"context_line":"    contains:"},{"line_number":41,"context_line":"    - \u0027v3.3\u0027"},{"line_number":42,"context_line":"    - get_param: calico_tag"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  default_calico:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_2350e0d4","line":41,"range":{"start_line":41,"start_character":10,"end_line":41,"end_character":11},"in_reply_to":"df33271e_f26ec894","updated":"2020-04-04 17:16:58.000000000","message":"v3.3 works, Do you propose v3.3. to be safe against v3.X where X \u003e\u003d30 ?","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"78c35f679d8b230b5057ed781b77688a529c8931","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    - get_param: calico_tag"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  default_calico:"},{"line_number":45,"context_line":"    not: calico_v3_3"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"parameters:"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_a387d00f","line":45,"updated":"2020-04-04 17:16:58.000000000","message":"In case we don\u0027t add any other calico version this will continue to work.\n\nIn case we add one more file, we can expand this condition with an OR.","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4b7d6c610607c32b1bae7ff7d265d00e32453fa3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    - get_param: calico_tag"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  default_calico:"},{"line_number":45,"context_line":"    not: calico_v3_3"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"parameters:"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_dc03c072","line":45,"in_reply_to":"df33271e_a387d00f","updated":"2020-04-06 10:24:59.000000000","message":"dropping","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"273bf1748e5a925573ec1df12e6ec7db3aed8068","unresolved":false,"context_lines":[{"line_number":1253,"context_line":"            - if:"},{"line_number":1254,"context_line":"                - calico_v3_3"},{"line_number":1255,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1256,"context_line":"                - \"\""},{"line_number":1257,"context_line":"            - if:"},{"line_number":1258,"context_line":"                - default_calico"},{"line_number":1259,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_32e65aea","line":1256,"range":{"start_line":1256,"start_character":18,"end_line":1256,"end_character":20},"updated":"2020-04-06 08:38:55.000000000","message":"what is the reason for not putting ` get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh` here?","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4b7d6c610607c32b1bae7ff7d265d00e32453fa3","unresolved":false,"context_lines":[{"line_number":1253,"context_line":"            - if:"},{"line_number":1254,"context_line":"                - calico_v3_3"},{"line_number":1255,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1256,"context_line":"                - \"\""},{"line_number":1257,"context_line":"            - if:"},{"line_number":1258,"context_line":"                - default_calico"},{"line_number":1259,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_9c63f8b1","line":1256,"range":{"start_line":1256,"start_character":18,"end_line":1256,"end_character":20},"in_reply_to":"df33271e_32e65aea","updated":"2020-04-06 10:24:59.000000000","message":"To make room for the future.","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"812d47b2256248ac512fb4bf64e5c3963d3d66cc","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"          -"},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/kube-apiserver-to-kubelet-role.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/core-dns-service.sh"},{"line_number":1253,"context_line":"            - if:"},{"line_number":1254,"context_line":"                - calico_v3_3"},{"line_number":1255,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1256,"context_line":"                - \"\""},{"line_number":1257,"context_line":"            - if:"},{"line_number":1258,"context_line":"                - default_calico"},{"line_number":1259,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1260,"context_line":"                - \"\""},{"line_number":1261,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1262,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"},{"line_number":1263,"context_line":"            - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_12eee320","line":1260,"range":{"start_line":1253,"start_character":0,"end_line":1260,"end_character":20},"updated":"2020-04-03 07:58:31.000000000","message":"This structure is waiting for calico v3.14.x or v4.x.y.","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"bf9b9f0edd4db556d7bbffce29866bb31da466ab","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"          -"},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/kube-apiserver-to-kubelet-role.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/core-dns-service.sh"},{"line_number":1253,"context_line":"            - if:"},{"line_number":1254,"context_line":"                - calico_v3_3"},{"line_number":1255,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1256,"context_line":"                - \"\""},{"line_number":1257,"context_line":"            - if:"},{"line_number":1258,"context_line":"                - default_calico"},{"line_number":1259,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1260,"context_line":"                - \"\""},{"line_number":1261,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1262,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"},{"line_number":1263,"context_line":"            - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_e633bdf4","line":1260,"range":{"start_line":1253,"start_character":0,"end_line":1260,"end_character":20},"in_reply_to":"df33271e_10941b36","updated":"2020-04-03 10:47:28.000000000","message":"\u003e If the user has not specified calico version in the cluster\n \u003e template, then the cluster will still default to v3.13.1 even if\n \u003e they try and create the cluster the next week after upgrade to\n \u003e Ussuri right?\n\nYes.\n\nBut, if the user has his own CT with calico_tag because, he created in train. It won\u0027t work. \n\nFor clusters that have already been created, calico\n \u003e v3.3.x has already been deployed on the cluster so they will\n \u003e continue to work.\n\nI never said that running clusters are the issue. But these clusters have this label set. This indicates that something defined that label at deployment time. Terraform, a bash script, a private CT, a public CT that is still referenced (so cannot be deleted and even if hidden it can be used).\n\nIs there a compelling feature in v.3.3.x and not\n \u003e available in v3.13.1 that we should should continue to support it\n \u003e even if they contain security vulnurabilities, e.g.\n \u003e https://www.projectcalico.org/security-bulletins/#TTA-2019-002,\n \u003e https://www.projectcalico.org/security-bulletins/#TTA-2019-003?\n\nThe compeling feature is: Do not break something that used to work even if it has vulnerabilities. Users should be able to change to the the secure version at their own pace not enforced by the upstream magnum developers. The cloud operator and the magnum team should promptly make the patched versions available (some times make them default). The cloud operator should inform the users that they are outdated and have vulnerabilities.\n\nWhat do you think?\nShall I abandon this patch?\nWhat do you propose (Support only one calico manifest?)?","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"4b7d6c610607c32b1bae7ff7d265d00e32453fa3","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"          -"},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/kube-apiserver-to-kubelet-role.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/core-dns-service.sh"},{"line_number":1253,"context_line":"            - if:"},{"line_number":1254,"context_line":"                - calico_v3_3"},{"line_number":1255,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1256,"context_line":"                - \"\""},{"line_number":1257,"context_line":"            - if:"},{"line_number":1258,"context_line":"                - default_calico"},{"line_number":1259,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1260,"context_line":"                - \"\""},{"line_number":1261,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1262,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"},{"line_number":1263,"context_line":"            - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_7c6c349c","line":1260,"range":{"start_line":1253,"start_character":0,"end_line":1260,"end_character":20},"in_reply_to":"df33271e_12607632","updated":"2020-04-06 10:24:59.000000000","message":"ok","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"223c99a8d94db356924aa44645d8bfb5e79529b6","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"          -"},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/kube-apiserver-to-kubelet-role.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/core-dns-service.sh"},{"line_number":1253,"context_line":"            - if:"},{"line_number":1254,"context_line":"                - calico_v3_3"},{"line_number":1255,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1256,"context_line":"                - \"\""},{"line_number":1257,"context_line":"            - if:"},{"line_number":1258,"context_line":"                - default_calico"},{"line_number":1259,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1260,"context_line":"                - \"\""},{"line_number":1261,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1262,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"},{"line_number":1263,"context_line":"            - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_15652db5","line":1260,"range":{"start_line":1253,"start_character":0,"end_line":1260,"end_character":20},"in_reply_to":"df33271e_12eee320","updated":"2020-04-03 08:47:51.000000000","message":"What happens to all the calico 3.4.x, 3.5.x... 3.11.x, 3.12.x?  Where is the actual threshold for this control flow? e.g. does 3.11.x and 3.12.x still work with default calico template? I think we should drop support for older version personally otherwise it becomes an ever growing maintenance burden.","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"aedf1958576c9f71ce2af947f6bfc4c3dce5a7d0","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"          -"},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/kube-apiserver-to-kubelet-role.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/core-dns-service.sh"},{"line_number":1253,"context_line":"            - if:"},{"line_number":1254,"context_line":"                - calico_v3_3"},{"line_number":1255,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1256,"context_line":"                - \"\""},{"line_number":1257,"context_line":"            - if:"},{"line_number":1258,"context_line":"                - default_calico"},{"line_number":1259,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1260,"context_line":"                - \"\""},{"line_number":1261,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1262,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"},{"line_number":1263,"context_line":"            - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_b0756f66","line":1260,"range":{"start_line":1253,"start_character":0,"end_line":1260,"end_character":20},"in_reply_to":"df33271e_15652db5","updated":"2020-04-03 09:17:13.000000000","message":"Shall I abandon this patch?\nWhat do you propose (Support only one calico manifest?)?\nI don\u0027t mind stop supporting v3.3.6 upstream.\n\n* The current master branch state is: use templates that are tested for calico v3.13.x (anything else we don\u0027t know if it will work).\n\n* This patch adds the proven to be working (anda ctual working state in train) manifests for calico v3.3.6\n\n* At the moment, what happens to all calico versions you mention? 3.4.x, 3.5.x... v3.11.x, 3.12.x\n\n\n* What happens in Ussuri upgrade, if the user the week before the upgrade created a CT with calico v3.3.6 and the week after the upgrade creates a cluster? Will it work? What we should do as operatos for the users that have already cluster with v3.3.x and are happy, force them to change?","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"78c35f679d8b230b5057ed781b77688a529c8931","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"          -"},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/kube-apiserver-to-kubelet-role.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/core-dns-service.sh"},{"line_number":1253,"context_line":"            - if:"},{"line_number":1254,"context_line":"                - calico_v3_3"},{"line_number":1255,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1256,"context_line":"                - \"\""},{"line_number":1257,"context_line":"            - if:"},{"line_number":1258,"context_line":"                - default_calico"},{"line_number":1259,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1260,"context_line":"                - \"\""},{"line_number":1261,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1262,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"},{"line_number":1263,"context_line":"            - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_83ba8cde","line":1260,"range":{"start_line":1253,"start_character":0,"end_line":1260,"end_character":20},"in_reply_to":"df33271e_7573d0b2","updated":"2020-04-04 17:16:58.000000000","message":"\u003e I am okay to take this patch as long as we can revert it on a\n\u003e subsequent release.\n\nI\u0027m ok to drop it in V or Y.\n\nJust to mention, when OpenStack was dominating the cloud community as trying to commit in not breaking things (API mostly but functionallity in general) for two releases. On the other hand, AWS does not break APIs (I\u0027m not aware for other functionality), ever.\n\n \u003e I am uncomfortable about adding branching logic\n \u003e like this indefinitely for the sake of backward compatibility\n\nThis proposal is not something that I like, is something I propose to respect our users (not only users in my org) effort and not force them to change things when the magnum team decides to.\n\n \u003e but I\n \u003e see your point that it might be disruptive for *some* users between\n \u003e release cycles. However most users I am aware of do not care too\n \u003e much about the version of network plugin they are using as long as\n \u003e it works but this might be different in your organisation.\n\nIn my organization, users absolutely don\u0027t care about the version of the network plugin (I can\u0027t stress this enough, how much they don\u0027t care and dont\u0027 want to stay in an old version) and they want the latest (and CVE free) as you and me want. It is unfair to say/imply that me and users in my organization hold the project behind or making it complicated because we want to stick in old versions of different components.\n\nWhat this change tries to do is remove a very real path that can break cluster creations in *any* organization. Since my organization is affected and there is not way to go around it other than patching magnum, I proposed this change. If it was possible to work around it with a configuration change, I would be very happy to not take this patch. (Changing labels in the db is a solution but it is also a no-go. If needed, I can explain why changing db entries directly is a bad idea.)","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"273bf1748e5a925573ec1df12e6ec7db3aed8068","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"          -"},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/kube-apiserver-to-kubelet-role.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/core-dns-service.sh"},{"line_number":1253,"context_line":"            - if:"},{"line_number":1254,"context_line":"                - calico_v3_3"},{"line_number":1255,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1256,"context_line":"                - \"\""},{"line_number":1257,"context_line":"            - if:"},{"line_number":1258,"context_line":"                - default_calico"},{"line_number":1259,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1260,"context_line":"                - \"\""},{"line_number":1261,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1262,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"},{"line_number":1263,"context_line":"            - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_12607632","line":1260,"range":{"start_line":1253,"start_character":0,"end_line":1260,"end_character":20},"in_reply_to":"df33271e_83ba8cde","updated":"2020-04-06 08:38:55.000000000","message":"I did not mean to even remotely imply that your organisation holds the project behind/makes the project more complex, sorry if it came across like that via text communication. I was merely coming around to the point about minimising disruption for users.","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"51aaaed99a1dcfe2acc14a51bf351ff4f5c3d5d1","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"          -"},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/kube-apiserver-to-kubelet-role.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/core-dns-service.sh"},{"line_number":1253,"context_line":"            - if:"},{"line_number":1254,"context_line":"                - calico_v3_3"},{"line_number":1255,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1256,"context_line":"                - \"\""},{"line_number":1257,"context_line":"            - if:"},{"line_number":1258,"context_line":"                - default_calico"},{"line_number":1259,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1260,"context_line":"                - \"\""},{"line_number":1261,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1262,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"},{"line_number":1263,"context_line":"            - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_e7071b18","line":1260,"range":{"start_line":1253,"start_character":0,"end_line":1260,"end_character":20},"in_reply_to":"df33271e_83ba8cde","updated":"2020-04-05 01:13:28.000000000","message":"Thanks for the very detailed explanation. Personally, I\u0027m OK with this patch and I will test it tomorrow. Thanks.","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"f30724ba0f54aa63d89e8ab996249893f9bba08e","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"          -"},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/kube-apiserver-to-kubelet-role.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/core-dns-service.sh"},{"line_number":1253,"context_line":"            - if:"},{"line_number":1254,"context_line":"                - calico_v3_3"},{"line_number":1255,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1256,"context_line":"                - \"\""},{"line_number":1257,"context_line":"            - if:"},{"line_number":1258,"context_line":"                - default_calico"},{"line_number":1259,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1260,"context_line":"                - \"\""},{"line_number":1261,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1262,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"},{"line_number":1263,"context_line":"            - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_10941b36","line":1260,"range":{"start_line":1253,"start_character":0,"end_line":1260,"end_character":20},"in_reply_to":"df33271e_b0756f66","updated":"2020-04-03 10:34:06.000000000","message":"If the user has not specified calico version in the cluster template, then the cluster will still default to v3.13.1 even if they try and create the cluster the next week after upgrade to Ussuri right? For clusters that have already been created, calico v3.3.x has already been deployed on the cluster so they will continue to work.Is there a compelling feature in v.3.3.x and not available in v3.13.1 that we should should continue to support it even if they contain security vulnurabilities, e.g. https://www.projectcalico.org/security-bulletins/#TTA-2019-002, https://www.projectcalico.org/security-bulletins/#TTA-2019-003?","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"78c35f679d8b230b5057ed781b77688a529c8931","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"          -"},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/kube-apiserver-to-kubelet-role.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/core-dns-service.sh"},{"line_number":1253,"context_line":"            - if:"},{"line_number":1254,"context_line":"                - calico_v3_3"},{"line_number":1255,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1256,"context_line":"                - \"\""},{"line_number":1257,"context_line":"            - if:"},{"line_number":1258,"context_line":"                - default_calico"},{"line_number":1259,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1260,"context_line":"                - \"\""},{"line_number":1261,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1262,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"},{"line_number":1263,"context_line":"            - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_2369008b","line":1260,"range":{"start_line":1253,"start_character":0,"end_line":1260,"end_character":20},"in_reply_to":"df33271e_d43bb5c5","updated":"2020-04-04 17:16:58.000000000","message":"\u003e I agree with Spyros here. We don\u0027t have to manage all the addon\n \u003e versions, but it would be nice if you can keep the backward\n \u003e compatibility for the default versions.\n \u003e \n \u003e That said, when we add a new version support of calico in V cycle,\n \u003e e.g. v3.16.3, we can drop the support of v3.3.6, but keep the\n \u003e support for the v3.13.1.\n \u003e \n \u003e @Spyros, does that make sense for you?\n\nI don\u0027t see why we (or me personally?) have to commit *now* to keep two files maximum. If calico does move to completely incompatible manifests we will have to act then. I (me personally) will avoid to propose a new file.","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"fb9e2e48c0d8ae3c886008d145fa7273b44f7c5e","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"          -"},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/kube-apiserver-to-kubelet-role.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/core-dns-service.sh"},{"line_number":1253,"context_line":"            - if:"},{"line_number":1254,"context_line":"                - calico_v3_3"},{"line_number":1255,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1256,"context_line":"                - \"\""},{"line_number":1257,"context_line":"            - if:"},{"line_number":1258,"context_line":"                - default_calico"},{"line_number":1259,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1260,"context_line":"                - \"\""},{"line_number":1261,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1262,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"},{"line_number":1263,"context_line":"            - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_d43bb5c5","line":1260,"range":{"start_line":1253,"start_character":0,"end_line":1260,"end_character":20},"in_reply_to":"df33271e_e633bdf4","updated":"2020-04-03 23:03:23.000000000","message":"I agree with Spyros here. We don\u0027t have to manage all the addon versions, but it would be nice if you can keep the backward compatibility for the default versions.\n\nThat said, when we add a new version support of calico in V cycle, e.g. v3.16.3, we can drop the support of v3.3.6, but keep the support for the v3.13.1.\n\n@Spyros, does that make sense for you?","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"a675c18c1eb3db61445d2138ab2e5a78e1c852f0","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"          -"},{"line_number":1251,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/kube-apiserver-to-kubelet-role.sh"},{"line_number":1252,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/core-dns-service.sh"},{"line_number":1253,"context_line":"            - if:"},{"line_number":1254,"context_line":"                - calico_v3_3"},{"line_number":1255,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-3-x.sh"},{"line_number":1256,"context_line":"                - \"\""},{"line_number":1257,"context_line":"            - if:"},{"line_number":1258,"context_line":"                - default_calico"},{"line_number":1259,"context_line":"                - get_file: ../../common/templates/kubernetes/fragments/calico-service-v3-13-x.sh"},{"line_number":1260,"context_line":"                - \"\""},{"line_number":1261,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/flannel-service.sh"},{"line_number":1262,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/enable-helm-tiller.sh"},{"line_number":1263,"context_line":"            - str_replace:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_7573d0b2","line":1260,"range":{"start_line":1253,"start_character":0,"end_line":1260,"end_character":20},"in_reply_to":"df33271e_e633bdf4","updated":"2020-04-04 06:56:08.000000000","message":"I am okay to take this patch as long as we can revert it on a subsequent release. I am uncomfortable about adding branching logic like this indefinitely for the sake of backward compatibility but I see your point that it might be disruptive for *some* users between release cycles. However most users I am aware of do not care too much about the version of network plugin they are using as long as it works but this might be different in your organisation.","commit_id":"600cce7300091f06d8779bbe997095ca0accbc22"}]}