)]}'
{"doc/source/user/index.rst":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"a1803158dd091c30dfab058614e81b12600ff650","unresolved":false,"context_lines":[{"line_number":1115,"context_line":"  default is \u0027devicemapper\u0027. Refer to the `Storage`_ section for more"},{"line_number":1116,"context_line":"  details."},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":"  **NOTE:** For Fedora CoreOS driver, only overlay2 is the supported docker"},{"line_number":1119,"context_line":"  storage driver."},{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"Image (image)"},{"line_number":1122,"context_line":"  Specified in the ClusterTemplate to indicate the image to boot the servers."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1f493fa4_03c0b229","line":1119,"range":{"start_line":1118,"start_character":38,"end_line":1119,"end_character":17},"updated":"2020-04-28 09:15:42.000000000","message":"devicemapper is not supported.","commit_id":"0fea7445b3aa68948ce990e0198f2879c8fe1f3a"}],"magnum/drivers/common/templates/fragments/configure_docker_storage_driver_fedora_coreos.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"5de0148e63dac1c09255cf051b7a9017dad5f59e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"clear_docker_storage () {"},{"line_number":4,"context_line":"    # stop docker"},{"line_number":5,"context_line":"    $ssh_cmd systemctl stop docker"},{"line_number":6,"context_line":"    # clear storage graph"},{"line_number":7,"context_line":"    $ssh_cmd rm -rf /var/lib/docker/*"},{"line_number":8,"context_line":"    $ssh_cmd mkdir -p /var/lib/docker"},{"line_number":9,"context_line":"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Configure generic docker storage driver."},{"line_number":12,"context_line":"configure_storage_driver_generic() {"},{"line_number":13,"context_line":"    clear_docker_storage"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    if [ -n \"$DOCKER_VOLUME_SIZE\" ] \u0026\u0026 [ \"$DOCKER_VOLUME_SIZE\" -gt 0 ]; then"},{"line_number":16,"context_line":"        $ssh_cmd mkfs.xfs -f ${device_path}"},{"line_number":17,"context_line":"        echo \"${device_path} /var/lib/docker xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":18,"context_line":"        $ssh_cmd mount -a"},{"line_number":19,"context_line":"        $ssh_cmd restorecon -R /var/lib/docker"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"configure_devicemapper () {"},{"line_number":24,"context_line":"    configure_storage_driver_generic"},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f4c43b2_6d690c24","line":23,"range":{"start_line":3,"start_character":0,"end_line":23,"end_character":27},"updated":"2020-04-15 08:41:10.000000000","message":"this change looks like more than just removing /dev/vdb. Is there any downside to removing the systemd unit file? what is the reason for this change? I agree it looks simpler. Also uses xfs instead of ext4 by default. We should capture all these in the commit message/reno and why.","commit_id":"19bc7299acf2a2850dec42e53a6bbb22a2cb1ad0"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"55632e7f5ae56d3841919315801b3a281ab49ae2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"clear_docker_storage () {"},{"line_number":4,"context_line":"    # stop docker"},{"line_number":5,"context_line":"    $ssh_cmd systemctl stop docker"},{"line_number":6,"context_line":"    # clear storage graph"},{"line_number":7,"context_line":"    $ssh_cmd rm -rf /var/lib/docker/*"},{"line_number":8,"context_line":"    $ssh_cmd mkdir -p /var/lib/docker"},{"line_number":9,"context_line":"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Configure generic docker storage driver."},{"line_number":12,"context_line":"configure_storage_driver_generic() {"},{"line_number":13,"context_line":"    clear_docker_storage"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    if [ -n \"$DOCKER_VOLUME_SIZE\" ] \u0026\u0026 [ \"$DOCKER_VOLUME_SIZE\" -gt 0 ]; then"},{"line_number":16,"context_line":"        $ssh_cmd mkfs.xfs -f ${device_path}"},{"line_number":17,"context_line":"        echo \"${device_path} /var/lib/docker xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":18,"context_line":"        $ssh_cmd mount -a"},{"line_number":19,"context_line":"        $ssh_cmd restorecon -R /var/lib/docker"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"configure_devicemapper () {"},{"line_number":24,"context_line":"    configure_storage_driver_generic"},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f4c43b2_0acc9c5f","line":23,"range":{"start_line":3,"start_character":0,"end_line":23,"end_character":27},"in_reply_to":"3f4c43b2_0acbfc71","updated":"2020-04-16 00:31:27.000000000","message":"Hmm if thats the case, why are some of the elements in this page omitted? https://github.com/openstack/magnum/blob/master/magnum/drivers/common/templates/fragments/configure_docker_storage_driver_atomic.sh Also if both are identical, do we really need one config for coreos and another for atomic?","commit_id":"19bc7299acf2a2850dec42e53a6bbb22a2cb1ad0"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"c54decf55e1b2df55929cd6d7eb5969e4f521e41","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"clear_docker_storage () {"},{"line_number":4,"context_line":"    # stop docker"},{"line_number":5,"context_line":"    $ssh_cmd systemctl stop docker"},{"line_number":6,"context_line":"    # clear storage graph"},{"line_number":7,"context_line":"    $ssh_cmd rm -rf /var/lib/docker/*"},{"line_number":8,"context_line":"    $ssh_cmd mkdir -p /var/lib/docker"},{"line_number":9,"context_line":"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Configure generic docker storage driver."},{"line_number":12,"context_line":"configure_storage_driver_generic() {"},{"line_number":13,"context_line":"    clear_docker_storage"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    if [ -n \"$DOCKER_VOLUME_SIZE\" ] \u0026\u0026 [ \"$DOCKER_VOLUME_SIZE\" -gt 0 ]; then"},{"line_number":16,"context_line":"        $ssh_cmd mkfs.xfs -f ${device_path}"},{"line_number":17,"context_line":"        echo \"${device_path} /var/lib/docker xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":18,"context_line":"        $ssh_cmd mount -a"},{"line_number":19,"context_line":"        $ssh_cmd restorecon -R /var/lib/docker"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"configure_devicemapper () {"},{"line_number":24,"context_line":"    configure_storage_driver_generic"},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f4c43b2_654bd158","line":23,"range":{"start_line":3,"start_character":0,"end_line":23,"end_character":27},"in_reply_to":"3f4c43b2_0acc9c5f","updated":"2020-04-16 01:25:03.000000000","message":"That\u0027s a very good point, Bharat. I will test this again and if the devicemapper also works for Fedora CoreOS, I\u0027m happy to rename the atomic one and use it for Fedora CoreOS.","commit_id":"19bc7299acf2a2850dec42e53a6bbb22a2cb1ad0"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"6486af5720c6ada9b60ea19f17530104cac656e7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"clear_docker_storage () {"},{"line_number":4,"context_line":"    # stop docker"},{"line_number":5,"context_line":"    $ssh_cmd systemctl stop docker"},{"line_number":6,"context_line":"    # clear storage graph"},{"line_number":7,"context_line":"    $ssh_cmd rm -rf /var/lib/docker/*"},{"line_number":8,"context_line":"    $ssh_cmd mkdir -p /var/lib/docker"},{"line_number":9,"context_line":"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Configure generic docker storage driver."},{"line_number":12,"context_line":"configure_storage_driver_generic() {"},{"line_number":13,"context_line":"    clear_docker_storage"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    if [ -n \"$DOCKER_VOLUME_SIZE\" ] \u0026\u0026 [ \"$DOCKER_VOLUME_SIZE\" -gt 0 ]; then"},{"line_number":16,"context_line":"        $ssh_cmd mkfs.xfs -f ${device_path}"},{"line_number":17,"context_line":"        echo \"${device_path} /var/lib/docker xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":18,"context_line":"        $ssh_cmd mount -a"},{"line_number":19,"context_line":"        $ssh_cmd restorecon -R /var/lib/docker"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"configure_devicemapper () {"},{"line_number":24,"context_line":"    configure_storage_driver_generic"},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f4c43b2_25226953","line":23,"range":{"start_line":3,"start_character":0,"end_line":23,"end_character":27},"in_reply_to":"3f4c43b2_654bd158","updated":"2020-04-16 02:19:58.000000000","message":"I reviewed/tested the code again and I remember now. There is no docker-storage-setup service on Fedora CoreOS as it\u0027s running on Fedora Atomic. So we can\u0027t get the two scripts identical.\n\nAs for the devicemapper support, I don\u0027t think we really need to support it because it has been deprecated https://docs.docker.com/engine/deprecated/#device-mapper-storage-driver","commit_id":"19bc7299acf2a2850dec42e53a6bbb22a2cb1ad0"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"d2cf7f24951db1cb141910e029f09b4e81f52e01","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"clear_docker_storage () {"},{"line_number":4,"context_line":"    # stop docker"},{"line_number":5,"context_line":"    $ssh_cmd systemctl stop docker"},{"line_number":6,"context_line":"    # clear storage graph"},{"line_number":7,"context_line":"    $ssh_cmd rm -rf /var/lib/docker/*"},{"line_number":8,"context_line":"    $ssh_cmd mkdir -p /var/lib/docker"},{"line_number":9,"context_line":"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Configure generic docker storage driver."},{"line_number":12,"context_line":"configure_storage_driver_generic() {"},{"line_number":13,"context_line":"    clear_docker_storage"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    if [ -n \"$DOCKER_VOLUME_SIZE\" ] \u0026\u0026 [ \"$DOCKER_VOLUME_SIZE\" -gt 0 ]; then"},{"line_number":16,"context_line":"        $ssh_cmd mkfs.xfs -f ${device_path}"},{"line_number":17,"context_line":"        echo \"${device_path} /var/lib/docker xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":18,"context_line":"        $ssh_cmd mount -a"},{"line_number":19,"context_line":"        $ssh_cmd restorecon -R /var/lib/docker"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"configure_devicemapper () {"},{"line_number":24,"context_line":"    configure_storage_driver_generic"},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f4c43b2_0acbfc71","line":23,"range":{"start_line":3,"start_character":0,"end_line":23,"end_character":27},"in_reply_to":"3f4c43b2_6d690c24","updated":"2020-04-16 00:14:56.000000000","message":"TBH, I\u0027m not sure if it\u0027s a bug caused by other changes. But in my testing, I think the current systemd unit is not really working. So instead of using the CoreOS way, I\u0027m copying the way we\u0027re using for Fedora Atomic driver. And as you can see it\u0027s simpler and more solid. I will update the commit message. Thanks.","commit_id":"19bc7299acf2a2850dec42e53a6bbb22a2cb1ad0"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"a147761c5fae30d9b5a48d92343939421c4f57b3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"clear_docker_storage() {"},{"line_number":4,"context_line":"    # stop docker"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f493fa4_2049768a","line":1,"updated":"2020-04-27 15:22:09.000000000","message":"What if we use the same script as atomic then? This is almost the same.\n\nWe can disallow devicemapper in the heat-template.","commit_id":"6ca38d65b442a9a181eb6f5adb52c0a1b43bb2f4"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"220bfae0795040bbde931af104d465223c998193","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"clear_docker_storage() {"},{"line_number":4,"context_line":"    # stop docker"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f493fa4_5c3902f0","line":1,"in_reply_to":"1f493fa4_2049768a","updated":"2020-04-27 21:07:26.000000000","message":"Hi Spyros, there is no docker-storage-setup service on Fedora CoreOS as it\u0027s running on Fedora Atomic. So we can\u0027t get the two scripts identical.","commit_id":"6ca38d65b442a9a181eb6f5adb52c0a1b43bb2f4"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"3cfaa717d1d1fc194f54224b1f5f4ebac717a602","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"clear_docker_storage() {"},{"line_number":4,"context_line":"    # stop docker"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f493fa4_d83cf5c9","line":1,"in_reply_to":"1f493fa4_5c3902f0","updated":"2020-04-28 07:58:10.000000000","message":"The only diff is [0], which is ok. it checks if the file exists.\n\nI think we could do for the docker-storage-driver systemd unit.\n\n[0] https://github.com/openstack/magnum/blob/master/magnum/drivers/common/templates/fragments/configure_docker_storage_driver_atomic.sh#L16\n\nrestorecon should exists in atomic, I have to check.\n\n\nBut anyway, if you want to use a second file. I can live with it.","commit_id":"6ca38d65b442a9a181eb6f5adb52c0a1b43bb2f4"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"9bebdd24af4754c510a826f613b2be493a1a584a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"clear_docker_storage () {"},{"line_number":4,"context_line":"    # stop docker"},{"line_number":5,"context_line":"    $ssh_cmd systemctl stop docker"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_37acd1eb","line":2,"updated":"2020-04-30 07:35:14.000000000","message":"Can you add?\n\n if [ ${CONTAINER_RUNTIME} \u003d \"containerd\"  ] ; then\n     state_dir\u003d\"/var/lib/containerd\"\n else\n     state_dir\u003d\"/var/lib/docker\"\n fi","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a04775e1dd4c82df353c31354e45b47f39c64573","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"clear_docker_storage () {"},{"line_number":4,"context_line":"    # stop docker"},{"line_number":5,"context_line":"    $ssh_cmd systemctl stop docker"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_7244a747","line":2,"in_reply_to":"1f493fa4_37acd1eb","updated":"2020-04-30 08:01:42.000000000","message":"I can add this. Bharat, are you ok with this?","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"905c91fb6537a6eb325ca5343eb6ae978c392a56","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"clear_docker_storage () {"},{"line_number":4,"context_line":"    # stop docker"},{"line_number":5,"context_line":"    $ssh_cmd systemctl stop docker"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_9665de20","line":2,"in_reply_to":"1f493fa4_4d1bc971","updated":"2020-04-30 14:51:31.000000000","message":"rename file + functions too, since it is currently called clear_docker_storage?","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"d31817109e823b4447b59fb466a6950aefeec9bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"clear_docker_storage () {"},{"line_number":4,"context_line":"    # stop docker"},{"line_number":5,"context_line":"    $ssh_cmd systemctl stop docker"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_8a1c9778","line":2,"in_reply_to":"1f493fa4_7244a747","updated":"2020-04-30 13:16:18.000000000","message":"yes no problem","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"bd577793855f11302091d3c4fc3d56a34d4b7c7b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"clear_docker_storage () {"},{"line_number":4,"context_line":"    # stop docker"},{"line_number":5,"context_line":"    $ssh_cmd systemctl stop docker"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_4d1bc971","line":2,"in_reply_to":"1f493fa4_8a1c9778","updated":"2020-04-30 13:18:56.000000000","message":"Thank you Bharat!\n\nBut, shall we rename the file though, since it is says docker_storage and containerd is not docker?","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"905c91fb6537a6eb325ca5343eb6ae978c392a56","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"clear_docker_storage () {"},{"line_number":4,"context_line":"    # stop docker"},{"line_number":5,"context_line":"    $ssh_cmd systemctl stop docker"},{"line_number":6,"context_line":"    # clear storage graph"},{"line_number":7,"context_line":"    $ssh_cmd rm -rf /var/lib/docker/*"},{"line_number":8,"context_line":"    $ssh_cmd mkdir -p /var/lib/docker"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_b66e1afd","line":5,"range":{"start_line":5,"start_character":28,"end_line":5,"end_character":34},"updated":"2020-04-30 14:51:31.000000000","message":"is docker the right thing to stop if CONTAINER_RUNTIME is containerd?","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"28cac88751d8a35b42b38caf482e156fd2e18129","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"clear_docker_storage () {"},{"line_number":4,"context_line":"    # stop docker"},{"line_number":5,"context_line":"    $ssh_cmd systemctl stop docker"},{"line_number":6,"context_line":"    # clear storage graph"},{"line_number":7,"context_line":"    $ssh_cmd rm -rf /var/lib/docker/*"},{"line_number":8,"context_line":"    $ssh_cmd mkdir -p /var/lib/docker"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_7a2d8cfc","line":5,"range":{"start_line":5,"start_character":28,"end_line":5,"end_character":34},"in_reply_to":"1f493fa4_b66e1afd","updated":"2020-04-30 21:39:11.000000000","message":"Good catch, i think it should be replaced with ${CONTAINER_RUNTIME}. Will fix it in next ps.","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"9bebdd24af4754c510a826f613b2be493a1a584a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    # stop docker"},{"line_number":5,"context_line":"    $ssh_cmd systemctl stop docker"},{"line_number":6,"context_line":"    # clear storage graph"},{"line_number":7,"context_line":"    $ssh_cmd rm -rf /var/lib/docker/*"},{"line_number":8,"context_line":"    $ssh_cmd mkdir -p /var/lib/docker"},{"line_number":9,"context_line":"}"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_d7ebed0f","line":7,"range":{"start_line":7,"start_character":20,"end_line":7,"end_character":35},"updated":"2020-04-30 07:35:14.000000000","message":"${state_dir}","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"9bebdd24af4754c510a826f613b2be493a1a584a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    $ssh_cmd systemctl stop docker"},{"line_number":6,"context_line":"    # clear storage graph"},{"line_number":7,"context_line":"    $ssh_cmd rm -rf /var/lib/docker/*"},{"line_number":8,"context_line":"    $ssh_cmd mkdir -p /var/lib/docker"},{"line_number":9,"context_line":"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Configure generic docker storage driver."}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_b7ee211f","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":37},"updated":"2020-04-30 07:35:14.000000000","message":"${state_dir}","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"9bebdd24af4754c510a826f613b2be493a1a584a","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    if [ -n \"$DOCKER_VOLUME_SIZE\" ] \u0026\u0026 [ \"$DOCKER_VOLUME_SIZE\" -gt 0 ]; then"},{"line_number":16,"context_line":"        $ssh_cmd mkfs.xfs -f ${device_path}"},{"line_number":17,"context_line":"        echo \"${device_path} /var/lib/docker xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":18,"context_line":"        $ssh_cmd mount -a"},{"line_number":19,"context_line":"        $ssh_cmd restorecon -R /var/lib/docker"},{"line_number":20,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_57dfdd67","line":17,"range":{"start_line":17,"start_character":29,"end_line":17,"end_character":44},"updated":"2020-04-30 07:35:14.000000000","message":"${state_dir}","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"9bebdd24af4754c510a826f613b2be493a1a584a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        $ssh_cmd mkfs.xfs -f ${device_path}"},{"line_number":17,"context_line":"        echo \"${device_path} /var/lib/docker xfs defaults 0 0\" \u003e\u003e /etc/fstab"},{"line_number":18,"context_line":"        $ssh_cmd mount -a"},{"line_number":19,"context_line":"        $ssh_cmd restorecon -R /var/lib/docker"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"    if [[ ! -e /etc/docker/daemon.json ]]; then"},{"line_number":22,"context_line":"        $ssh_cmd mkdir /etc/docker"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_17f27506","line":19,"range":{"start_line":19,"start_character":31,"end_line":19,"end_character":46},"updated":"2020-04-30 07:35:14.000000000","message":"${state_dir}","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"9bebdd24af4754c510a826f613b2be493a1a584a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        $ssh_cmd mount -a"},{"line_number":19,"context_line":"        $ssh_cmd restorecon -R /var/lib/docker"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"    if [[ ! -e /etc/docker/daemon.json ]]; then"},{"line_number":22,"context_line":"        $ssh_cmd mkdir /etc/docker"},{"line_number":23,"context_line":"        echo \"{\\\"storage-driver\\\": \\\"$1\\\"}\" \u003e /etc/docker/daemon.json"},{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"configure_devicemapper() {"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_54799bc5","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":6},"updated":"2020-04-30 07:35:14.000000000","message":"Maybe this:\n\n/usr/bin/dockerd --help | grep storage-driver\n  -s, --storage-driver string                   Storage driver to use\n\n\n sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--storage-driver\u003d$1 /\u0027 /etc/sysconfig/docker\n\n\n/etc/sysconfig/docker is sources and used elsewhere as well.","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"bf6f39415b82030602b19ba53231f8da952dbc10","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        $ssh_cmd mount -a"},{"line_number":19,"context_line":"        $ssh_cmd restorecon -R /var/lib/docker"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"    if [[ ! -e /etc/docker/daemon.json ]]; then"},{"line_number":22,"context_line":"        $ssh_cmd mkdir /etc/docker"},{"line_number":23,"context_line":"        echo \"{\\\"storage-driver\\\": \\\"$1\\\"}\" \u003e /etc/docker/daemon.json"},{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"configure_devicemapper() {"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_ed429a0e","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":6},"in_reply_to":"1f493fa4_5206cb53","updated":"2020-04-30 08:46:43.000000000","message":"It is not a matter of preference! It is wrong to have two configuration files. Either we use /etc/sysconfig/docker or /etc/docker/daemon.json. We must pick one.\n\n\nIf both of you *prefer* daemon.json we can refactor the docker config.\n\nWe need to replace all /etc/sysconfig/docker occurences and port all options to daemon.json and update the systemd unit.\n\nInstead of sed command we can write in one place only the config file. I really don\u0027t see the difference between editing with bash and sed a json or a config file. Editing/writing a single config file in one place can help.\n\n\n\n\n\nFedora 32:\n Fedora CoreOS 32.20200416.1.0\n Tracker: https://github.com/coreos/fedora-coreos-tracker\n Discuss: https://discussion.fedoraproject.org/c/server/coreos/\n \n Last login: Thu Apr 30 08:33:59 2020 from 137.138.44.88\n [root@strigazi-fcos32-01 ~]# cat /etc/sysconfig/docker \n # /etc/sysconfig/docker\n \n # Modify these options if you want to change the way the docker daemon runs\n OPTIONS\u003d\"--selinux-enabled \\\n   --log-driver\u003djournald \\\n   --live-restore \\\n   --default-ulimit nofile\u003d1024:1024 \\\n   --init-path /usr/libexec/docker/docker-init \\\n   --userland-proxy-path /usr/libexec/docker/docker-proxy \\\n \"\n [root@strigazi-fcos32-01 ~]# systemctl cat docker\n # /usr/lib/systemd/system/docker.service\n [Unit]\n Description\u003dDocker Application Container Engine\n Documentation\u003dhttps://docs.docker.com\n After\u003ddocker.socket network-online.target firewalld.service\n Requires\u003ddocker.socket\n Wants\u003dnetwork-online.target\n \n [Service]\n Type\u003dnotify\n EnvironmentFile\u003d-/etc/sysconfig/docker\n # the default is not to use systemd for cgroups because the delegate issues still\n # exists and systemd currently does not support the cgroup feature set required\n # for containers run by docker\n ExecStart\u003d/usr/bin/dockerd \\\n           --host\u003dfd:// \\\n           --exec-opt native.cgroupdriver\u003dsystemd \\\n           $OPTIONS\n ExecReload\u003d/bin/kill -s HUP $MAINPID\n # Having non-zero Limit*s causes performance problems due to accounting overhead\n # in the kernel. We recommend using cgroups to do container-local accounting.\n LimitNOFILE\u003dinfinity\n LimitNPROC\u003dinfinity\n LimitCORE\u003dinfinity\n # Uncomment TasksMax if your systemd version supports it.\n # Only systemd 226 and above support this version.\n #TasksMax\u003dinfinity\n TimeoutStartSec\u003d0\n # set delegate yes so that systemd does not reset the cgroups of docker containers\n #Delegate\u003dyes\n # kill only the docker process, not all processes in the cgroup\n KillMode\u003dprocess\n # restart the docker process if it exits prematurely\n Restart\u003don-failure\n StartLimitBurst\u003d3\n StartLimitInterval\u003d60s\n \n [Install]\n WantedBy\u003dmulti-user.target","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a04775e1dd4c82df353c31354e45b47f39c64573","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        $ssh_cmd mount -a"},{"line_number":19,"context_line":"        $ssh_cmd restorecon -R /var/lib/docker"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"    if [[ ! -e /etc/docker/daemon.json ]]; then"},{"line_number":22,"context_line":"        $ssh_cmd mkdir /etc/docker"},{"line_number":23,"context_line":"        echo \"{\\\"storage-driver\\\": \\\"$1\\\"}\" \u003e /etc/docker/daemon.json"},{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"configure_devicemapper() {"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_9234d3df","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":6},"in_reply_to":"1f493fa4_54799bc5","updated":"2020-04-30 08:01:42.000000000","message":"There is no /etc/sysconfig/docker on Fedora CoreOS. And based on https://docs.docker.com/engine/reference/commandline/dockerd/ Docker team is recommending using /etc/docker/daemon.json","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"0ddccdb83e642624e570e7e4bc5b0970fe3874b1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        $ssh_cmd mount -a"},{"line_number":19,"context_line":"        $ssh_cmd restorecon -R /var/lib/docker"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"    if [[ ! -e /etc/docker/daemon.json ]]; then"},{"line_number":22,"context_line":"        $ssh_cmd mkdir /etc/docker"},{"line_number":23,"context_line":"        echo \"{\\\"storage-driver\\\": \\\"$1\\\"}\" \u003e /etc/docker/daemon.json"},{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"configure_devicemapper() {"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_5206cb53","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":6},"in_reply_to":"1f493fa4_72982774","updated":"2020-04-30 08:19:32.000000000","message":"Sorry, yes. I can see it in Fedora CoreOS 31. But is it really a problem where we set the driver. For me, it\u0027s far more clear to set it via the daemon.json instead of setting the option by sed. Thoughts?","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"3f912c2aef2457159c895562dc90246e978d1604","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        $ssh_cmd mount -a"},{"line_number":19,"context_line":"        $ssh_cmd restorecon -R /var/lib/docker"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"    if [[ ! -e /etc/docker/daemon.json ]]; then"},{"line_number":22,"context_line":"        $ssh_cmd mkdir /etc/docker"},{"line_number":23,"context_line":"        echo \"{\\\"storage-driver\\\": \\\"$1\\\"}\" \u003e /etc/docker/daemon.json"},{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"configure_devicemapper() {"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_72982774","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":6},"in_reply_to":"1f493fa4_9234d3df","updated":"2020-04-30 08:13:40.000000000","message":"In my current f31 is does. Booting the latest to check.\n\nCan you show me where you checked about it?\n\nMy current vm:\n Fedora CoreOS 31.20200113.3.1\n Tracker: https://github.com/coreos/fedora-coreos-tracker\n\n Last login: Thu Apr 30 07:17:50 2020 from 137.138.150.191\n [core@str-18-containerd-04-rb4sv56lx5zx-master-0 ~]$ sudo \n cat /etc/sysconfig/docker \n # /etc/sysconfig/docker\n\n # Modify these options if you want to change the way the \n docker daemon runs\n OPTIONS\u003d\"--log-driver\u003djson-file --log-opt max-size\u003d10m -- log-opt max-file\u003d5 --selinux-enabled \\\n   \\\n  --live-restore \\\n  --default-ulimit nofile\u003d1024:1024 \\\n  --init-path /usr/libexec/docker/docker-init \\\n  --userland-proxy-path /usr/libexec/docker/docker-proxy \\\n \"","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"083dda8a797d42e26c51eb672438857e107a8131","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        $ssh_cmd mount -a"},{"line_number":19,"context_line":"        $ssh_cmd restorecon -R /var/lib/docker"},{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":"    if [[ ! -e /etc/docker/daemon.json ]]; then"},{"line_number":22,"context_line":"        $ssh_cmd mkdir /etc/docker"},{"line_number":23,"context_line":"        echo \"{\\\"storage-driver\\\": \\\"$1\\\"}\" \u003e /etc/docker/daemon.json"},{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"configure_devicemapper() {"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_2d7be227","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":6},"in_reply_to":"1f493fa4_ed429a0e","updated":"2020-04-30 08:51:35.000000000","message":"tl;dr two config files is bad. Let\u0027s pick one.","commit_id":"599dfdca2fb9f83993e3b908b0a4ca0186fec2a2"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"047348d73d1fba1eaf8d106def312e115b130f5b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"clear_docker_storage () {"},{"line_number":10,"context_line":"    # stop docker"},{"line_number":11,"context_line":"    $ssh_cmd systemctl stop docker"},{"line_number":12,"context_line":"    # clear storage graph"},{"line_number":13,"context_line":"    $ssh_cmd rm -rf ${storage_dir}"},{"line_number":14,"context_line":"    $ssh_cmd mkdir -p ${storage_dir}"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f493fa4_3a2dc4a7","line":11,"updated":"2020-04-30 21:58:55.000000000","message":"@Spyros, I need to replace the \u0027docker\u0027 here to ${CONTAINER_RUNTIME}, right? just double check","commit_id":"b0922f07d4c5ddb85fbac329d2a4bbd8691e57f2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"1afadcc5ecd6ec881b01dd6c3964557bc4e5d77c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"clear_docker_storage () {"},{"line_number":10,"context_line":"    # stop docker"},{"line_number":11,"context_line":"    $ssh_cmd systemctl stop docker"},{"line_number":12,"context_line":"    # clear storage graph"},{"line_number":13,"context_line":"    $ssh_cmd rm -rf ${storage_dir}"},{"line_number":14,"context_line":"    $ssh_cmd mkdir -p ${storage_dir}"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f493fa4_bfcc2189","line":11,"in_reply_to":"1f493fa4_3a2dc4a7","updated":"2020-05-01 04:46:02.000000000","message":"i think default CONTAINER_RUNTIME value is host-docker (https://github.com/openstack/magnum/blob/master/magnum/drivers/k8s_fedora_atomic_v1/templates/kubecluster.yaml#L878) so we need to do make this conditional using an if clause","commit_id":"b0922f07d4c5ddb85fbac329d2a4bbd8691e57f2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"8b4461a06367e3bfb03e36de4d22b76a58dbb9f1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"clear_docker_storage () {"},{"line_number":10,"context_line":"    # stop docker"},{"line_number":11,"context_line":"    $ssh_cmd systemctl stop docker"},{"line_number":12,"context_line":"    # clear storage graph"},{"line_number":13,"context_line":"    $ssh_cmd rm -rf ${storage_dir}"},{"line_number":14,"context_line":"    $ssh_cmd mkdir -p ${storage_dir}"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f493fa4_4fba7de1","line":11,"in_reply_to":"1f493fa4_4fd1dd2f","updated":"2020-05-02 12:09:24.000000000","message":"I see, in the next PS you did smth else. My comment is invalid.","commit_id":"b0922f07d4c5ddb85fbac329d2a4bbd8691e57f2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"c7248784cfa95254302f8dd8b41b5aa3a0aa7143","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"clear_docker_storage () {"},{"line_number":10,"context_line":"    # stop docker"},{"line_number":11,"context_line":"    $ssh_cmd systemctl stop docker"},{"line_number":12,"context_line":"    # clear storage graph"},{"line_number":13,"context_line":"    $ssh_cmd rm -rf ${storage_dir}"},{"line_number":14,"context_line":"    $ssh_cmd mkdir -p ${storage_dir}"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f493fa4_4fd1dd2f","line":11,"in_reply_to":"1f493fa4_bfcc2189","updated":"2020-05-02 11:59:49.000000000","message":"needs an if","commit_id":"b0922f07d4c5ddb85fbac329d2a4bbd8691e57f2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"46e4726c11599adce0faf56e861da4eb4ec83888","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        $ssh_cmd restorecon -R ${storage_dir}"},{"line_number":26,"context_line":"    fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--storage-driver\u003d\u0027$1\u0027 /\u0027 /etc/sysconfig/docker"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"configure_devicemapper() {"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f493fa4_cdca399f","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":92},"updated":"2020-04-30 13:28:36.000000000","message":"is this ok Bharat or you want to refactor to daemon.json?","commit_id":"b0922f07d4c5ddb85fbac329d2a4bbd8691e57f2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"f17f664b03ffff3a5c62548182904aed1940a6f2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        $ssh_cmd restorecon -R ${storage_dir}"},{"line_number":26,"context_line":"    fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--storage-driver\u003d\u0027$1\u0027 /\u0027 /etc/sysconfig/docker"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"configure_devicemapper() {"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f493fa4_569196f0","line":28,"range":{"start_line":28,"start_character":71,"end_line":28,"end_character":92},"updated":"2020-04-30 14:49:54.000000000","message":"what happens here if CONTAINER_RUNTIME is containerd?","commit_id":"b0922f07d4c5ddb85fbac329d2a4bbd8691e57f2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"c83efb819e53434585dc7fb36967bef922c4f89b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        $ssh_cmd restorecon -R ${storage_dir}"},{"line_number":26,"context_line":"    fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--storage-driver\u003d\u0027$1\u0027 /\u0027 /etc/sysconfig/docker"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"configure_devicemapper() {"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f493fa4_7ac90c24","line":28,"range":{"start_line":28,"start_character":71,"end_line":28,"end_character":92},"in_reply_to":"1f493fa4_3a4784be","updated":"2020-04-30 21:53:07.000000000","message":"isn\u0027t it obvious to everyone that nothing happens?","commit_id":"b0922f07d4c5ddb85fbac329d2a4bbd8691e57f2"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"28cac88751d8a35b42b38caf482e156fd2e18129","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        $ssh_cmd restorecon -R ${storage_dir}"},{"line_number":26,"context_line":"    fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--storage-driver\u003d\u0027$1\u0027 /\u0027 /etc/sysconfig/docker"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"configure_devicemapper() {"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f493fa4_3a4784be","line":28,"range":{"start_line":28,"start_character":71,"end_line":28,"end_character":92},"in_reply_to":"1f493fa4_569196f0","updated":"2020-04-30 21:39:11.000000000","message":"I think it\u0027s OK, because docker is installed by default or we can put this line into a check.","commit_id":"b0922f07d4c5ddb85fbac329d2a4bbd8691e57f2"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"047348d73d1fba1eaf8d106def312e115b130f5b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        $ssh_cmd restorecon -R ${storage_dir}"},{"line_number":26,"context_line":"    fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--storage-driver\u003d\u0027$1\u0027 /\u0027 /etc/sysconfig/docker"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"configure_devicemapper() {"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f493fa4_950aeb1c","line":28,"range":{"start_line":28,"start_character":71,"end_line":28,"end_character":92},"in_reply_to":"1f493fa4_7ac90c24","updated":"2020-04-30 21:58:55.000000000","message":"Not nothing happened but add a check would be better.","commit_id":"b0922f07d4c5ddb85fbac329d2a4bbd8691e57f2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"d0090df856de47eb5e818fda0eb8260866280570","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        $ssh_cmd restorecon -R ${storage_dir}"},{"line_number":26,"context_line":"    fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--storage-driver\u003d\u0027$1\u0027 /\u0027 /etc/sysconfig/docker"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"configure_devicemapper() {"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f493fa4_ed15633e","line":28,"range":{"start_line":28,"start_character":71,"end_line":28,"end_character":92},"in_reply_to":"1f493fa4_950aeb1c","updated":"2020-05-01 10:20:51.000000000","message":"Feilong, thats for your patience. Just tested this and works great with both host-docker and containerd. It appears that at present, we dont have a way to configure storage_driver for containerd but I am happy to leave that for another patch in the future.","commit_id":"b0922f07d4c5ddb85fbac329d2a4bbd8691e57f2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"f17f664b03ffff3a5c62548182904aed1940a6f2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        $ssh_cmd restorecon -R ${storage_dir}"},{"line_number":26,"context_line":"    fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    sed -i -E \u0027s/^OPTIONS\u003d(\"|\u0027\"\u0027\"\u0027)/OPTIONS\u003d\\1--storage-driver\u003d\u0027$1\u0027 /\u0027 /etc/sysconfig/docker"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"configure_devicemapper() {"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1f493fa4_b6ebba75","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":92},"in_reply_to":"1f493fa4_cdca399f","updated":"2020-04-30 14:49:54.000000000","message":"this is fine! if daemon.json provides features we cannot provide via OPTIONS, we can switch in a future patch.","commit_id":"b0922f07d4c5ddb85fbac329d2a4bbd8691e57f2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"8b4461a06367e3bfb03e36de4d22b76a58dbb9f1","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"runtime\u003d${CONTAINER_RUNTIME}"},{"line_number":4,"context_line":"if [ ${CONTAINER_RUNTIME} \u003d \"containerd\"  ] ; then"},{"line_number":5,"context_line":"    storage_dir\u003d\"/var/lib/containerd\""},{"line_number":6,"context_line":"else"},{"line_number":7,"context_line":"    storage_dir\u003d\"/var/lib/docker\""},{"line_number":8,"context_line":"    runtime\u003d\"docker\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"1f493fa4_afe181ff","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":15},"updated":"2020-05-02 12:09:24.000000000","message":"this is a state directory, not a storage only directory.\nPlease update per my recommendation.\n\nYou can investigate how docker works if you don\u0027t believe me.\n # ls /var/lib/docker/\n builder  buildkit  containers  image  network  overlay2  plugins  runtimes  swarm  tmp  trust  volumes","commit_id":"c2439ca10aed0dbfa25a7e613a8105d93536db87"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"a391d679b8c38bbbebf2ab9cc15cca60be5e4246","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"runtime\u003d${CONTAINER_RUNTIME}"},{"line_number":4,"context_line":"if [ ${CONTAINER_RUNTIME} \u003d \"containerd\"  ] ; then"},{"line_number":5,"context_line":"    storage_dir\u003d\"/var/lib/containerd\""},{"line_number":6,"context_line":"else"},{"line_number":7,"context_line":"    storage_dir\u003d\"/var/lib/docker\""},{"line_number":8,"context_line":"    runtime\u003d\"docker\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"1f493fa4_aa368fe6","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":15},"in_reply_to":"1f493fa4_4f18bd83","updated":"2020-05-02 13:17:32.000000000","message":"1. Dont\u0027 ignore my comments, address all my questions and argue against my proposals of you don\u0027t like them. \n2. You commented under it https://review.opendev.org/#/c/718296/9/magnum/drivers/common/templates/fragments/configure_docker_storage_driver_fedora_coreos.sh@2","commit_id":"c2439ca10aed0dbfa25a7e613a8105d93536db87"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"d35582513f92d014b5b1dd1725fb1bcd0144f680","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"runtime\u003d${CONTAINER_RUNTIME}"},{"line_number":4,"context_line":"if [ ${CONTAINER_RUNTIME} \u003d \"containerd\"  ] ; then"},{"line_number":5,"context_line":"    storage_dir\u003d\"/var/lib/containerd\""},{"line_number":6,"context_line":"else"},{"line_number":7,"context_line":"    storage_dir\u003d\"/var/lib/docker\""},{"line_number":8,"context_line":"    runtime\u003d\"docker\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"1f493fa4_f08c0681","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":15},"in_reply_to":"1f493fa4_55db2c20","updated":"2020-05-03 01:52:23.000000000","message":"I dont mind state_dir or storage_dir, if you have strong preference about this, lets go with state_dir.\n\n+1 to renaming methods in this patch since they now deal with containerd and docker.\n\n+1 to renaming docker_* fields to container_* or equivalent but in a separate patch, and only supporting the default containerd snapshot driver for now which I believe is overlayfs.\n\nKata works with the default containerd storage driver, I have not investigated alternatives and will not be doing this anytime soon. I have only really looked at persistent volumes for Kata, not storage drivers.","commit_id":"c2439ca10aed0dbfa25a7e613a8105d93536db87"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"c61f3744be6a8f616804a7be178e24a795f3613e","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"runtime\u003d${CONTAINER_RUNTIME}"},{"line_number":4,"context_line":"if [ ${CONTAINER_RUNTIME} \u003d \"containerd\"  ] ; then"},{"line_number":5,"context_line":"    storage_dir\u003d\"/var/lib/containerd\""},{"line_number":6,"context_line":"else"},{"line_number":7,"context_line":"    storage_dir\u003d\"/var/lib/docker\""},{"line_number":8,"context_line":"    runtime\u003d\"docker\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"1f493fa4_d0cd8a87","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":15},"in_reply_to":"1f493fa4_55db2c20","updated":"2020-05-02 20:52:03.000000000","message":"Sorry, Spyros, if my answer was not clear in my last comments. Personally, I prefer to leave the renaming to a separate patch, because if we do renaming, which means we have to rename the other two scripts about docker storage and I don\u0027t think this is the right timing given the current release is due. And we would like to cherrypick this, so it would be nice if we can keep the change in this script.\n\nAs for the name of \u0027state_dir\u0027, I understand there are other things under the /var/lib/docker, but to be honest, \u0027state_dir\u0027 is a bit weird based on my first impression. And to keep the consistency, I changed it to storage_dir. But I\u0027m happy to use \u0027state_dir\u0027 if you believe that\u0027s the best name. Do you think data_dir is another option?\n\nPlease let me know if I missed your other questions and comments. Thank you for your review.","commit_id":"c2439ca10aed0dbfa25a7e613a8105d93536db87"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"5508d1de88506087e64596591f7e4badfe08bab4","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"runtime\u003d${CONTAINER_RUNTIME}"},{"line_number":4,"context_line":"if [ ${CONTAINER_RUNTIME} \u003d \"containerd\"  ] ; then"},{"line_number":5,"context_line":"    storage_dir\u003d\"/var/lib/containerd\""},{"line_number":6,"context_line":"else"},{"line_number":7,"context_line":"    storage_dir\u003d\"/var/lib/docker\""},{"line_number":8,"context_line":"    runtime\u003d\"docker\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"1f493fa4_eaa6d753","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":15},"in_reply_to":"1f493fa4_aa368fe6","updated":"2020-05-02 15:55:16.000000000","message":"\u003e 1. Dont\u0027 ignore my comments, address all my questions and argue\n\nSorry please tell me what comment I ignored as I did not knowingly ignore anything.\n\n \u003e against my proposals of you don\u0027t like them.\n \u003e 2. You commented under it https://review.opendev.org/#/c/718296/9/magnum/drivers/common/templates/fragments/configure_docker_storage_driver_fedora_coreos.sh@2\n\nAh I see, rename storage_dir -\u003e state_dir.","commit_id":"c2439ca10aed0dbfa25a7e613a8105d93536db87"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"60551fa113fd20277be002247efeeab65f325ef6","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"runtime\u003d${CONTAINER_RUNTIME}"},{"line_number":4,"context_line":"if [ ${CONTAINER_RUNTIME} \u003d \"containerd\"  ] ; then"},{"line_number":5,"context_line":"    storage_dir\u003d\"/var/lib/containerd\""},{"line_number":6,"context_line":"else"},{"line_number":7,"context_line":"    storage_dir\u003d\"/var/lib/docker\""},{"line_number":8,"context_line":"    runtime\u003d\"docker\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"1f493fa4_4f18bd83","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":15},"in_reply_to":"1f493fa4_afe181ff","updated":"2020-05-02 13:06:57.000000000","message":"What is your recommendation?","commit_id":"c2439ca10aed0dbfa25a7e613a8105d93536db87"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"895f02353b2a3e19b836bdf7792a6c1c943daf42","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"runtime\u003d${CONTAINER_RUNTIME}"},{"line_number":4,"context_line":"if [ ${CONTAINER_RUNTIME} \u003d \"containerd\"  ] ; then"},{"line_number":5,"context_line":"    storage_dir\u003d\"/var/lib/containerd\""},{"line_number":6,"context_line":"else"},{"line_number":7,"context_line":"    storage_dir\u003d\"/var/lib/docker\""},{"line_number":8,"context_line":"    runtime\u003d\"docker\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"1f493fa4_55db2c20","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":15},"in_reply_to":"1f493fa4_eaa6d753","updated":"2020-05-02 18:33:40.000000000","message":"\u003e \u003e 1. Dont\u0027 ignore my comments, address all my questions and argue\n \u003e \n \u003e Sorry please tell me what comment I ignored as I did not knowingly\n \u003e ignore anything.\n\nstate_dir name, question about renaming all methods,files,fields to non docker_* and question about kata-containers.\n\n \u003e \n \u003e \u003e against my proposals of you don\u0027t like them.\n \u003e \u003e 2. You commented under it https://review.opendev.org/#/c/718296/9/magnum/drivers/common/templates/fragments/configure_docker_storage_driver_fedora_coreos.sh@2\n \u003e \n \u003e Ah I see, rename storage_dir -\u003e state_dir.\n\nYes. state_dir is the right thing to do.","commit_id":"c2439ca10aed0dbfa25a7e613a8105d93536db87"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"a832c563d7e904b0d2d6db0fc53826be8053bf7e","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"runtime\u003d${CONTAINER_RUNTIME}"},{"line_number":4,"context_line":"if [ ${CONTAINER_RUNTIME} \u003d \"containerd\"  ] ; then"},{"line_number":5,"context_line":"    storage_dir\u003d\"/var/lib/containerd\""},{"line_number":6,"context_line":"else"},{"line_number":7,"context_line":"    storage_dir\u003d\"/var/lib/docker\""},{"line_number":8,"context_line":"    runtime\u003d\"docker\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"1f493fa4_8d9923d2","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":15},"in_reply_to":"1f493fa4_f08c0681","updated":"2020-05-04 07:39:18.000000000","message":"You win guys. Let\u0027s do it based on preference and be strict selectively.\n\nPersistent volumes are too irrelevant to the rootfs of a container.\n\nFYI\n[0] docker ref\nhttps://docs.docker.com/engine/reference/commandline/dockerd/      --data-root string                      Root directory of persistent Docker state (default \"/var/lib/docker\")\n\n[1] /var/lib : Variable state information\nhttps://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch05s08.html","commit_id":"c2439ca10aed0dbfa25a7e613a8105d93536db87"}],"magnum/drivers/k8s_fedora_coreos_v1/templates/kubecluster.yaml":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"3cfaa717d1d1fc194f54224b1f5f4ebac717a602","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    description: docker storage driver name"},{"line_number":272,"context_line":"    default: \"overlay2\""},{"line_number":273,"context_line":"    constraints:"},{"line_number":274,"context_line":"      - allowed_values: [\"overlay2\"]"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"  cgroup_driver:"},{"line_number":277,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_78a7a10c","line":274,"range":{"start_line":274,"start_character":8,"end_line":274,"end_character":36},"updated":"2020-04-28 07:58:10.000000000","message":"-2 to this\n\nThis change invalidates patch:\nhttps://github.com/openstack/magnum/commit/28fff8006ae17d9afeee4ad409e12b6608fa26cb\n\nI proposed to disallow devicemapper not allow allow only overlay2. Not sure if it can be done with [1]. I will investigate.\n\nThe function in the script says is named\nconfigure_storage_driver_generic\n\n[1] https://docs.openstack.org/heat/latest/template_guide/hot_spec.html#allowed-pattern","commit_id":"151c1618c2b1684369d55d7f10e4fa26c384d199"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"790c499ab0f025f152ada0dab081015677ca0d67","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    description: docker storage driver name"},{"line_number":272,"context_line":"    default: \"overlay2\""},{"line_number":273,"context_line":"    constraints:"},{"line_number":274,"context_line":"      - allowed_values: [\"overlay2\"]"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"  cgroup_driver:"},{"line_number":277,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_78b4c1d1","line":274,"range":{"start_line":274,"start_character":8,"end_line":274,"end_character":36},"in_reply_to":"1f493fa4_78a7a10c","updated":"2020-04-28 08:23:29.000000000","message":"Good point. Then we can use this:\n\nconstraints:\n      - allowed_pattern: \"^(?!devicemapper$).*\"","commit_id":"151c1618c2b1684369d55d7f10e4fa26c384d199"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"791e2d5715b516d69d7f4f29fcf8e68641696330","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    description: docker storage driver name"},{"line_number":272,"context_line":"    default: \"overlay2\""},{"line_number":273,"context_line":"    constraints:"},{"line_number":274,"context_line":"      - allowed_values: [\"overlay2\"]"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"  cgroup_driver:"},{"line_number":277,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_980b8d7b","line":274,"range":{"start_line":274,"start_character":8,"end_line":274,"end_character":36},"in_reply_to":"1f493fa4_78b4c1d1","updated":"2020-04-28 08:29:35.000000000","message":"Running to quickly test this. I trust you but I must verify :)","commit_id":"151c1618c2b1684369d55d7f10e4fa26c384d199"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"3659777269f11de39d948c9d8220bfa798ec8190","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    description: docker storage driver name"},{"line_number":272,"context_line":"    default: \"overlay2\""},{"line_number":273,"context_line":"    constraints:"},{"line_number":274,"context_line":"      - allowed_pattern: \"^(?!devicemapper$).*\""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"  cgroup_driver:"},{"line_number":277,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f493fa4_c3ceca58","line":274,"updated":"2020-04-28 09:16:31.000000000","message":"works just file","commit_id":"0fea7445b3aa68948ce990e0198f2879c8fe1f3a"}],"magnum/drivers/k8s_fedora_coreos_v1/templates/kubeminion.yaml":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"77349abd723a4f92fe38d49fdd1265458ed77925","unresolved":false,"context_lines":[{"line_number":466,"context_line":"                template: {get_file: ../../common/templates/fragments/configure-docker-storage.sh}"},{"line_number":467,"context_line":"                params:"},{"line_number":468,"context_line":"                  $configure_docker_storage_driver: {get_file: ../../common/templates/fragments/configure_docker_storage_driver_fedora_coreos.sh}"},{"line_number":469,"context_line":"             - get_file: ../../common/templates/kubernetes/fragments/enable-services-minion.sh"},{"line_number":470,"context_line":"            - get_file: ../../common/templates/fragments/enable-docker-registry.sh"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"  node_config_deployment:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4c43b2_ffbe3463","line":469,"range":{"start_line":469,"start_character":12,"end_line":469,"end_character":13},"updated":"2020-04-17 09:53:22.000000000","message":"extra space","commit_id":"a0854020984262f7f5e206fe0aecb692c89aa914"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"3cfaa717d1d1fc194f54224b1f5f4ebac717a602","unresolved":false,"context_lines":[{"line_number":466,"context_line":"                template: {get_file: ../../common/templates/fragments/configure-docker-storage.sh}"},{"line_number":467,"context_line":"                params:"},{"line_number":468,"context_line":"                  $configure_docker_storage_driver: {get_file: ../../common/templates/fragments/configure_docker_storage_driver_fedora_coreos.sh}"},{"line_number":469,"context_line":"             - get_file: ../../common/templates/kubernetes/fragments/enable-services-minion.sh"},{"line_number":470,"context_line":"            - get_file: ../../common/templates/fragments/enable-docker-registry.sh"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"  node_config_deployment:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_78596133","line":469,"range":{"start_line":469,"start_character":12,"end_line":469,"end_character":13},"updated":"2020-04-28 07:58:10.000000000","message":"shouldn\u0027t be indented","commit_id":"151c1618c2b1684369d55d7f10e4fa26c384d199"}]}