)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"d5268970ef6d36dc8a7eb9dc20f11d062617a801","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[k8s] Make helm chart install jobs retry internally"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The helm chart install jobs frequently go into error state while waiting"},{"line_number":10,"context_line":"for dependent services to come up. Now, instead of failing the entire"},{"line_number":11,"context_line":"job for this reason, the chart installer simply loops and waits for the"},{"line_number":12,"context_line":"services to become available."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f4c43b2_bd52d039","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":34},"updated":"2020-04-20 10:49:38.000000000","message":"Do we know why this happens only for some deployments? Is it related to the performance of the underlying infrastructure? It would be better if we hade something more concrete here.\n\nAlso, the restars of the job are not good enough or we prefer to hide restarts to give a sense of stability with slower jobs?\n\nFinally, would this be solved if we wait for tiller to be ready? i.e. poll the tiller service on the healthCheck.\n\nIf we can\u0027t do any improvements in the commit message or checking for services. We can take this patch.","commit_id":"cbbf6fa660a9aec9bdf9be366b5ad5ee1c334bff"}],"magnum/drivers/common/templates/kubernetes/fragments/helm-installer.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"d94b7e91c0db5d9ec2f793eaffc9114b276ae807","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    i\u003d0"},{"line_number":17,"context_line":"    until ${HELM_INSTALL_COMMAND}; do"},{"line_number":18,"context_line":"        ((i\u003d\\${i}+1))"},{"line_number":19,"context_line":"        if [ \\${i} -gt 60 ]; then"},{"line_number":20,"context_line":"            echo \"ERROR Unable to install ${CHART_NAME} chart. Abort.\""},{"line_number":21,"context_line":"            exit 1"}],"source_content_type":"text/x-sh","patch_set":16,"id":"1f493fa4_19605a32","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":21},"updated":"2020-04-24 17:07:05.000000000","message":"i\u003d\\$((i+1))","commit_id":"be04eaabb8fd4cb6ff1960fe0d0d181b468670d1"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"b05a01e1c00187f7cdcd31cf8dff446b8621a491","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    helm repo update"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    if [[ \\$(helm history --namespace ${CHART_NAMESPACE} ${CHART_NAME} | grep ${CHART_NAME}) ]]; then"},{"line_number":12,"context_line":"        echo \"${CHART_NAME} already installed on server. Continue...\""},{"line_number":13,"context_line":"        exit 0"},{"line_number":14,"context_line":"    fi"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-sh","patch_set":17,"id":"1f493fa4_77450b43","line":12,"range":{"start_line":12,"start_character":14,"end_line":12,"end_character":26},"updated":"2020-04-27 10:57:33.000000000","message":"Can you also prepend a INFO here?","commit_id":"a347d7a3ac3e7c47e52293b691173546cf00d63e"}],"magnum/drivers/common/templates/kubernetes/helm/ingress-nginx.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"6989364d364134935f6563f0a9fc290b4b21ea39","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    else"},{"line_number":48,"context_line":"        until helm install stable/${CHART_NAME} --namespace kube-system --name ${CHART_NAME} --version ${NGINX_INGRESS_CONTROLLER_CHART_TAG} --values /opt/magnum/install-${CHART_NAME}-values.yaml"},{"line_number":49,"context_line":"        do"},{"line_number":50,"context_line":"            sleep 5s"},{"line_number":51,"context_line":"        done"},{"line_number":52,"context_line":"    fi"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"df33271e_9c3d3d90","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":20},"updated":"2020-04-10 10:58:18.000000000","message":"let\u0027s not loop for ever.\n\n3 or 5mins are enough, and 10 times that the job will retry.\nPlus let\u0027s log that we polling and which # loop is this.\n\nIMO it is ok to see the job fail. It means the cluster is slow or something.","commit_id":"91a51ba6ae9a9587860429f3ab5716b5994e4974"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"d5268970ef6d36dc8a7eb9dc20f11d062617a801","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            return \\$rc"},{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"        retry 60 \"helm install stable/${CHART_NAME} --namespace kube-system --name ${CHART_NAME} --version ${NGINX_INGRESS_CONTROLLER_CHART_TAG} --values /opt/magnum/install-${CHART_NAME}-values.yaml\""},{"line_number":56,"context_line":"        exit \\$?"},{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  install-${CHART_NAME}-values.yaml:  |"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3f4c43b2_981a826c","line":56,"updated":"2020-04-20 10:49:38.000000000","message":"Is there any way to reduce the number of escape backslashes?","commit_id":"cbbf6fa660a9aec9bdf9be366b5ad5ee1c334bff"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"8f0c1d826e6d69b8770da376cb7ed4a223b2b46c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            return \\$rc"},{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"        retry 60 \"helm install stable/${CHART_NAME} --namespace kube-system --name ${CHART_NAME} --version ${NGINX_INGRESS_CONTROLLER_CHART_TAG} --values /opt/magnum/install-${CHART_NAME}-values.yaml\""},{"line_number":56,"context_line":"        exit \\$?"},{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  install-${CHART_NAME}-values.yaml:  |"}],"source_content_type":"text/x-sh","patch_set":13,"id":"1f493fa4_50ab301c","line":56,"in_reply_to":"1f493fa4_e4b0cb8e","updated":"2020-04-21 11:32:37.000000000","message":"We can refactor all our charts in single meta-chart, but this is out of the scope of this patch I guess.","commit_id":"cbbf6fa660a9aec9bdf9be366b5ad5ee1c334bff"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"dc83405f0b256af1d89f189d172040f035b87978","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            return \\$rc"},{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"        retry 60 \"helm install stable/${CHART_NAME} --namespace kube-system --name ${CHART_NAME} --version ${NGINX_INGRESS_CONTROLLER_CHART_TAG} --values /opt/magnum/install-${CHART_NAME}-values.yaml\""},{"line_number":56,"context_line":"        exit \\$?"},{"line_number":57,"context_line":"    fi"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  install-${CHART_NAME}-values.yaml:  |"}],"source_content_type":"text/x-sh","patch_set":13,"id":"1f493fa4_e4b0cb8e","line":56,"in_reply_to":"3f4c43b2_981a826c","updated":"2020-04-21 00:29:37.000000000","message":"Another thing I found for our helm jobs is we are duplicating quite a lot yaml. Is it possible to merge them and share?","commit_id":"cbbf6fa660a9aec9bdf9be366b5ad5ee1c334bff"}]}