)]}'
{"dockerfiles/helm-client/Dockerfile":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"109280bb4138f93169dc16b94713b431c996a188","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ARG HELM_VERSION\u003dv2.12.0"},{"line_number":2,"context_line":"FROM debian:sid-slim"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG HELM_VERSION"}],"source_content_type":"text/x-dockerfile","patch_set":4,"id":"3f4c43b2_1820329b","side":"PARENT","line":1,"updated":"2020-04-20 10:47:15.000000000","message":"is this necessary?","commit_id":"cbbf6fa660a9aec9bdf9be366b5ad5ee1c334bff"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"109280bb4138f93169dc16b94713b431c996a188","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ARG HELM_VERSION"},{"line_number":2,"context_line":"FROM debian:sid-slim"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG HELM_VERSION"}],"source_content_type":"text/x-dockerfile","patch_set":4,"id":"3f4c43b2_d84eca6d","line":1,"updated":"2020-04-20 10:47:15.000000000","message":"If we need to update the build, better do it in another patch.","commit_id":"3fa6ee88ce9d6dd1d0568f715bd1575ff161dcab"}],"magnum/drivers/common/templates/kubernetes/fragments/helm-installer.sh":[{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"3065f7e6890f8c515ffd75a1d75a6061834968ab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"HELM_JOB_NAMESPACE\u003d${HELM_NAMESPACE}"},{"line_number":2,"context_line":"HELM_MODULE_CONFIG_FILE\u003d\"/srv/magnum/kubernetes/helm/${CHART_NAME}.yaml\""},{"line_number":3,"context_line":"HELM_INSTALL_COMMAND\u003d\"helm install ${CHART_NAME} stable/${CHART_NAME} --namespace ${CHART_NAMESPACE} --version ${CHART_TAG} --values /opt/magnum/install-${CHART_NAME}-values.yaml\""},{"line_number":4,"context_line":"HELM_INSTALL_SCRIPT\u003d$(cat \u003c\u003c EOF"},{"line_number":5,"context_line":"  install-${CHART_NAME}.sh: |"},{"line_number":6,"context_line":"    #!/bin/bash"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_348701b8","line":3,"range":{"start_line":3,"start_character":49,"end_line":3,"end_character":55},"updated":"2020-04-27 10:59:17.000000000","message":"This has to be configurable because not all jobs come from stable repository.","commit_id":"fe6b4c3a04f550d66d12b45f440796b5c4aad432"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"d14f358b1206d93ababdb348d0571b0e8cc46246","unresolved":false,"context_lines":[{"line_number":1,"context_line":"HELM_JOB_NAMESPACE\u003d${HELM_NAMESPACE}"},{"line_number":2,"context_line":"HELM_MODULE_CONFIG_FILE\u003d\"/srv/magnum/kubernetes/helm/${CHART_NAME}.yaml\""},{"line_number":3,"context_line":"HELM_INSTALL_COMMAND\u003d\"helm install ${CHART_NAME} stable/${CHART_NAME} --namespace ${CHART_NAMESPACE} --version ${CHART_TAG} --values /opt/magnum/install-${CHART_NAME}-values.yaml\""},{"line_number":4,"context_line":"HELM_INSTALL_SCRIPT\u003d$(cat \u003c\u003c EOF"},{"line_number":5,"context_line":"  install-${CHART_NAME}.sh: |"},{"line_number":6,"context_line":"    #!/bin/bash"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_96167ea7","line":3,"range":{"start_line":3,"start_character":49,"end_line":3,"end_character":55},"in_reply_to":"1f493fa4_0db1c147","updated":"2020-05-04 07:53:50.000000000","message":"Not currently no.","commit_id":"fe6b4c3a04f550d66d12b45f440796b5c4aad432"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"5b5dc0a825030817453d5fab2609da83196ce3de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"HELM_JOB_NAMESPACE\u003d${HELM_NAMESPACE}"},{"line_number":2,"context_line":"HELM_MODULE_CONFIG_FILE\u003d\"/srv/magnum/kubernetes/helm/${CHART_NAME}.yaml\""},{"line_number":3,"context_line":"HELM_INSTALL_COMMAND\u003d\"helm install ${CHART_NAME} stable/${CHART_NAME} --namespace ${CHART_NAMESPACE} --version ${CHART_TAG} --values /opt/magnum/install-${CHART_NAME}-values.yaml\""},{"line_number":4,"context_line":"HELM_INSTALL_SCRIPT\u003d$(cat \u003c\u003c EOF"},{"line_number":5,"context_line":"  install-${CHART_NAME}.sh: |"},{"line_number":6,"context_line":"    #!/bin/bash"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_0db1c147","line":3,"range":{"start_line":3,"start_character":49,"end_line":3,"end_character":55},"in_reply_to":"1f493fa4_348701b8","updated":"2020-04-30 13:26:26.000000000","message":"Do we currently have other repositories apart from stable?","commit_id":"fe6b4c3a04f550d66d12b45f440796b5c4aad432"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"3065f7e6890f8c515ffd75a1d75a6061834968ab","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  install-${CHART_NAME}.sh: |"},{"line_number":6,"context_line":"    #!/bin/bash"},{"line_number":7,"context_line":"    set -ex"},{"line_number":8,"context_line":"    helm repo add stable https://kubernetes-charts.storage.googleapis.com/"},{"line_number":9,"context_line":"    helm repo update"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    if [[ \\$(helm history --namespace ${CHART_NAMESPACE} ${CHART_NAME} | grep ${CHART_NAME}) ]]; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_7717cb46","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":74},"updated":"2020-04-27 10:59:17.000000000","message":"Maybe we can also add here an extra configuration to add the extra repositories.\n\nFor ex. HELM_EXTRA_REPOSITORIES\u003d\"\"\n\ndefaulting to empty and can be added after in the script","commit_id":"fe6b4c3a04f550d66d12b45f440796b5c4aad432"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"0e85bd98bb0371365387546a1a916f2669c50ba6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  install-${CHART_NAME}.sh: |"},{"line_number":6,"context_line":"    #!/bin/bash"},{"line_number":7,"context_line":"    set -ex"},{"line_number":8,"context_line":"    helm repo add stable https://kubernetes-charts.storage.googleapis.com/"},{"line_number":9,"context_line":"    helm repo update"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    if [[ \\$(helm history --namespace ${CHART_NAMESPACE} ${CHART_NAME} | grep ${CHART_NAME}) ]]; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_17b6478b","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":74},"in_reply_to":"1f493fa4_7717cb46","updated":"2020-04-27 11:19:46.000000000","message":"Can we do that as a follow up patch? Supporting extra helm repositories is totally out of the scope fo this patch. We did not support it before, I am working under the assumption things are the same as before.","commit_id":"fe6b4c3a04f550d66d12b45f440796b5c4aad432"}],"magnum/drivers/common/templates/kubernetes/fragments/helm-v2-installer.sh":[{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"3065f7e6890f8c515ffd75a1d75a6061834968ab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"HELM_JOB_NAMESPACE\u003d${TILLER_NAMESPACE}"},{"line_number":2,"context_line":"HELM_MODULE_CONFIG_FILE\u003d\"/srv/magnum/kubernetes/helm/${CHART_NAME}.yaml\""},{"line_number":3,"context_line":"HELM_INSTALL_COMMAND\u003d\"helm install --name ${CHART_NAME} stable/${CHART_NAME} --namespace ${CHART_NAMESPACE} --version ${CHART_TAG} --values /opt/magnum/install-${CHART_NAME}-values.yaml\""},{"line_number":4,"context_line":"HELM_INSTALL_SCRIPT\u003d$(cat \u003c\u003c EOF"},{"line_number":5,"context_line":"  install-${CHART_NAME}.sh: |"},{"line_number":6,"context_line":"    #!/bin/bash"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_97e4173e","line":3,"range":{"start_line":3,"start_character":56,"end_line":3,"end_character":62},"updated":"2020-04-27 10:59:17.000000000","message":"same things here as for v3","commit_id":"fe6b4c3a04f550d66d12b45f440796b5c4aad432"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"3065f7e6890f8c515ffd75a1d75a6061834968ab","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    until helm init --client-only --wait; do"},{"line_number":13,"context_line":"        sleep 5s"},{"line_number":14,"context_line":"    done"},{"line_number":15,"context_line":"    helm repo add stable https://kubernetes-charts.storage.googleapis.com/"},{"line_number":16,"context_line":"    helm repo update"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    if [[ \\$(helm history --namespace ${CHART_NAMESPACE} ${CHART_NAME} | grep ${CHART_NAME}) ]]; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1f493fa4_57de0f6d","line":15,"range":{"start_line":15,"start_character":18,"end_line":15,"end_character":24},"updated":"2020-04-27 10:59:17.000000000","message":"same things here","commit_id":"fe6b4c3a04f550d66d12b45f440796b5c4aad432"}],"magnum/drivers/common/templates/kubernetes/fragments/install-helm-modules.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f4e5fe4129bf798f7a3270de98ee4af5d2f79b1d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    $ssh_cmd tar xzvf /srv/magnum/helm-client.tar.gz linux-amd64/helm -O \u003e $helm_cmd"},{"line_number":61,"context_line":"    $ssh_cmd chmod +x $helm_cmd"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    helm_install_cmd\u003d\"helm install magnum . --namespace kube-system --values values.yaml\""},{"line_number":64,"context_line":"    helm_history_cmd\u003d\"$helm_cmd history magnum --namespace kube-system\""},{"line_number":65,"context_line":"    if [[ \"${HELM_CLIENT_TAG}\" \u003d\u003d v2.* ]]; then"},{"line_number":66,"context_line":"        CERTS_DIR\u003d\"/etc/kubernetes/helm/certs\""}],"source_content_type":"text/x-sh","patch_set":17,"id":"ff570b3c_4ac466f5","line":63,"updated":"2020-05-19 12:48:24.000000000","message":"https://github.com/helm/helm/pull/6512\n\nhttps://helm.sh/docs/helm/helm_install/\n\n --render-subchart-notes        if set, render subchart notes along with the parent","commit_id":"84870b646ade70c4c5bd2ab2d624e3d2009c168a"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"a27bb4aef7ecea54cb67e4d4a28926665622dc37","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    $ssh_cmd tar xzvf /srv/magnum/helm-client.tar.gz linux-amd64/helm -O \u003e $helm_cmd"},{"line_number":61,"context_line":"    $ssh_cmd chmod +x $helm_cmd"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    helm_install_cmd\u003d\"helm install magnum . --namespace kube-system --values values.yaml\""},{"line_number":64,"context_line":"    helm_history_cmd\u003d\"$helm_cmd history magnum --namespace kube-system\""},{"line_number":65,"context_line":"    if [[ \"${HELM_CLIENT_TAG}\" \u003d\u003d v2.* ]]; then"},{"line_number":66,"context_line":"        CERTS_DIR\u003d\"/etc/kubernetes/helm/certs\""}],"source_content_type":"text/x-sh","patch_set":17,"id":"ff570b3c_b21bf870","line":63,"in_reply_to":"ff570b3c_4ac466f5","updated":"2020-05-19 14:02:35.000000000","message":"Other than this, +2","commit_id":"84870b646ade70c4c5bd2ab2d624e3d2009c168a"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"2df9600b665414a37cedf3df5681edef3c3b6ce1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        until helm init --client-only --wait; do"},{"line_number":75,"context_line":"            sleep 5s"},{"line_number":76,"context_line":"        done"},{"line_number":77,"context_line":"        helm_install_cmd\u003d\"helm install --name magnum . --namespace kube-system --values values.yaml --render-subchart-notes\""},{"line_number":78,"context_line":"        helm_history_cmd\u003d\"helm history magnum\""},{"line_number":79,"context_line":"    fi"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-sh","patch_set":18,"id":"ff570b3c_d20b0c8b","line":77,"updated":"2020-05-19 14:19:48.000000000","message":"FYI this is only available after 2.13.0 https://github.com/helm/helm/pull/4088","commit_id":"e845c1731801532b723488bca9e2e020bc3c4724"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"7f3080c1bc5c8793b95d39e223cfbaa34ae4ba55","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        until helm init --client-only --wait; do"},{"line_number":75,"context_line":"            sleep 5s"},{"line_number":76,"context_line":"        done"},{"line_number":77,"context_line":"        helm_install_cmd\u003d\"helm install --name magnum . --namespace kube-system --values values.yaml --render-subchart-notes\""},{"line_number":78,"context_line":"        helm_history_cmd\u003d\"helm history magnum\""},{"line_number":79,"context_line":"    fi"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-sh","patch_set":18,"id":"ff570b3c_d29aec11","line":77,"in_reply_to":"ff570b3c_d20b0c8b","updated":"2020-05-19 14:45:10.000000000","message":"I think thats okay, the default version of tiller we use is 2.16.7","commit_id":"e845c1731801532b723488bca9e2e020bc3c4724"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"2df9600b665414a37cedf3df5681edef3c3b6ce1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    if [[ -f \"${HELM_CHART_VALUES_FILE}\" ]] \u0026\u0026 [[ -f \"${HELM_CHART_REQUIREMENTS_FILE}\" ]]; then"},{"line_number":82,"context_line":"        sed -i \u00271i dependencies:\u0027 ${HELM_CHART_REQUIREMENTS_FILE}"},{"line_number":83,"context_line":"        pushd ${HELM_CHART_DIR}"},{"line_number":84,"context_line":"        helm dep update"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        i\u003d0"},{"line_number":87,"context_line":"        until $helm_history_cmd || $helm_install_cmd; do"}],"source_content_type":"text/x-sh","patch_set":19,"id":"ff570b3c_32d088c9","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":23},"updated":"2020-05-19 14:19:48.000000000","message":"we can move this in the v2 block\n\nand for v3 do it with:\nhttps://helm.sh/docs/helm/helm_install/\n --dependency-update            run helm dependency update before installing the chart\n\nThis was we are sure that dep update worked since it is included in the 60 reties. Thoughts?","commit_id":"fca960ea60272e4ccc6a0df3d6ee561e33580eb2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"ad8b32f462713b9651a91b764f7762e7e37241e0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    if [[ -f \"${HELM_CHART_VALUES_FILE}\" ]] \u0026\u0026 [[ -f \"${HELM_CHART_REQUIREMENTS_FILE}\" ]]; then"},{"line_number":82,"context_line":"        sed -i \u00271i dependencies:\u0027 ${HELM_CHART_REQUIREMENTS_FILE}"},{"line_number":83,"context_line":"        pushd ${HELM_CHART_DIR}"},{"line_number":84,"context_line":"        helm dep update"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        i\u003d0"},{"line_number":87,"context_line":"        until $helm_history_cmd || $helm_install_cmd; do"}],"source_content_type":"text/x-sh","patch_set":19,"id":"ff570b3c_e04f3d68","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":23},"in_reply_to":"ff570b3c_32d088c9","updated":"2020-05-20 11:47:10.000000000","message":"I decided to leave `helm dep update` as a separate command so that the same can be done for helm2 and helm3.","commit_id":"fca960ea60272e4ccc6a0df3d6ee561e33580eb2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"385dff23c526e729e82a1ecbdd235ba5fbdef109","unresolved":false,"context_lines":[{"line_number":23,"context_line":"appVersion: master"},{"line_number":24,"context_line":"description: Magnum Helm Charts"},{"line_number":25,"context_line":"EOF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"${HELM_INSTALL_METRICS_SERVER}"},{"line_number":28,"context_line":"${HELM_INSTALL_PROMETHEUS_OPERATOR}"},{"line_number":29,"context_line":"${HELM_INSTALL_PROMETHEUS_ADAPTER}"}],"source_content_type":"text/x-sh","patch_set":20,"id":"ff570b3c_981535e8","line":26,"updated":"2020-05-19 15:01:24.000000000","message":"https://review.opendev.org/#/c/720234/20/magnum/drivers/common/templates/kubernetes/fragments/install-helm-modules.sh@82\n\nAdd here?\n\n cat \u003c\u003c EOF \u003e\u003e ${HELM_CHART_REQUIREMENTS_FILE}\n dependencies:\n EOF\n\nOR\n echo -n \"dependencies:\" \u003e ${HELM_CHART_REQUIREMENTS_FILE}","commit_id":"4412f483a74280417e6df8aea0c89b5bc35e7fab"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"bf3a0f0ab47260c3c574951cf2a91ffad533ad5f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    fi"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    if [[ -f \"${HELM_CHART_VALUES_FILE}\" ]] \u0026\u0026 [[ -f \"${HELM_CHART_REQUIREMENTS_FILE}\" ]]; then"},{"line_number":82,"context_line":"        sed -i \u00271i dependencies:\u0027 ${HELM_CHART_REQUIREMENTS_FILE}"},{"line_number":83,"context_line":"        pushd ${HELM_CHART_DIR}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        i\u003d0"}],"source_content_type":"text/x-sh","patch_set":20,"id":"ff570b3c_182485ae","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":65},"updated":"2020-05-19 14:53:01.000000000","message":"This is the prepend of \"dependencies:\" in the first line, right?","commit_id":"4412f483a74280417e6df8aea0c89b5bc35e7fab"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"41ebe77a412a21cf6b3d822d16c7ce4a265b6ecd","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    fi"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    if [[ -f \"${HELM_CHART_VALUES_FILE}\" ]] \u0026\u0026 [[ -f \"${HELM_CHART_REQUIREMENTS_FILE}\" ]]; then"},{"line_number":82,"context_line":"        sed -i \u00271i dependencies:\u0027 ${HELM_CHART_REQUIREMENTS_FILE}"},{"line_number":83,"context_line":"        pushd ${HELM_CHART_DIR}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        i\u003d0"}],"source_content_type":"text/x-sh","patch_set":20,"id":"ff570b3c_387d096e","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":65},"in_reply_to":"ff570b3c_182485ae","updated":"2020-05-19 14:55:50.000000000","message":"Yes, its pretty ugly right? Let me know if you can think of a better solution.","commit_id":"4412f483a74280417e6df8aea0c89b5bc35e7fab"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"800a63d2f064e68f9e98163b5673eb971570c729","unresolved":false,"context_lines":[{"line_number":24,"context_line":"description: Magnum Helm Charts"},{"line_number":25,"context_line":"EOF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"echo \u0027dependencies:\u0027 \u003e ${HELM_CHART_REQUIREMENTS_FILE}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"${HELM_INSTALL_METRICS_SERVER}"},{"line_number":30,"context_line":"${HELM_INSTALL_PROMETHEUS_OPERATOR}"}],"source_content_type":"text/x-sh","patch_set":21,"id":"ff570b3c_c4ef58ae","line":27,"updated":"2020-05-26 08:36:41.000000000","message":"This is adding a new line\n echo \u0027dependencies:\u0027\nbut this doesn\u0027t:\n echo -n \u0027dependencies:\u0027","commit_id":"1e9629f827429b84490bbbdee19e514ec275f540"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f6d94129b3832df2a09855c86d44b50e173f5535","unresolved":false,"context_lines":[{"line_number":24,"context_line":"description: Magnum Helm Charts"},{"line_number":25,"context_line":"EOF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"echo \u0027dependencies:\u0027 \u003e ${HELM_CHART_REQUIREMENTS_FILE}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"${HELM_INSTALL_METRICS_SERVER}"},{"line_number":30,"context_line":"${HELM_INSTALL_PROMETHEUS_OPERATOR}"}],"source_content_type":"text/x-sh","patch_set":21,"id":"ff570b3c_8420c0b2","line":27,"in_reply_to":"ff570b3c_04679027","updated":"2020-05-26 08:47:09.000000000","message":"yes, a new line is required","commit_id":"1e9629f827429b84490bbbdee19e514ec275f540"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"fc57289a5305e3c2616bcb1bc6317a9bcdf180c7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"description: Magnum Helm Charts"},{"line_number":25,"context_line":"EOF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"echo \u0027dependencies:\u0027 \u003e ${HELM_CHART_REQUIREMENTS_FILE}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"${HELM_INSTALL_METRICS_SERVER}"},{"line_number":30,"context_line":"${HELM_INSTALL_PROMETHEUS_OPERATOR}"}],"source_content_type":"text/x-sh","patch_set":21,"id":"ff570b3c_04679027","line":27,"in_reply_to":"ff570b3c_c4ef58ae","updated":"2020-05-26 08:40:50.000000000","message":"So it makes sense to add a new line right? Otherwise the effect of:\n\n    cat \u003e\u003e ${HELM_CHART_REQUIREMENTS_FILE} \u003c\u003c EOF\n    - req1\n    EOF\n\nwould be:\n\n    dependencies:-req1\n\nnot the following as desired:\n\n    dependencies:\n    - req1","commit_id":"1e9629f827429b84490bbbdee19e514ec275f540"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"800a63d2f064e68f9e98163b5673eb971570c729","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    $ssh_cmd tar xzvf /srv/magnum/helm-client.tar.gz linux-amd64/helm -O \u003e /srv/magnum/bin/helm"},{"line_number":37,"context_line":"    $ssh_cmd chmod +x /srv/magnum/bin/helm"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    helm_install_cmd\u003d\"helm install magnum . --namespace kube-system --values values.yaml --render-subchart-notes\""},{"line_number":40,"context_line":"    helm_history_cmd\u003d\"helm history magnum --namespace kube-system\""},{"line_number":41,"context_line":"    if [[ \"${HELM_CLIENT_TAG}\" \u003d\u003d v2.* ]]; then"},{"line_number":42,"context_line":"        CERTS_DIR\u003d\"/etc/kubernetes/helm/certs\""}],"source_content_type":"text/x-sh","patch_set":26,"id":"ff570b3c_2478d4f6","line":39,"updated":"2020-05-26 08:36:41.000000000","message":"this was fine with --dependency-update but do as you *like*. For consistency with helm v2?","commit_id":"de8ca77233f6aafe233f269b3230042000ff88b0"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"d43e403857d7fc3e0ba829030de9e6788e6cd415","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    $ssh_cmd tar xzvf /srv/magnum/helm-client.tar.gz linux-amd64/helm -O \u003e /srv/magnum/bin/helm"},{"line_number":37,"context_line":"    $ssh_cmd chmod +x /srv/magnum/bin/helm"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    helm_install_cmd\u003d\"helm install magnum . --namespace kube-system --values values.yaml --render-subchart-notes\""},{"line_number":40,"context_line":"    helm_history_cmd\u003d\"helm history magnum --namespace kube-system\""},{"line_number":41,"context_line":"    if [[ \"${HELM_CLIENT_TAG}\" \u003d\u003d v2.* ]]; then"},{"line_number":42,"context_line":"        CERTS_DIR\u003d\"/etc/kubernetes/helm/certs\""}],"source_content_type":"text/x-sh","patch_set":26,"id":"ff570b3c_7323b006","line":39,"in_reply_to":"ff570b3c_2478d4f6","updated":"2020-05-26 12:56:55.000000000","message":"Yes, thats right, then we can run helm dep update for both v2 and v3 clients.","commit_id":"de8ca77233f6aafe233f269b3230042000ff88b0"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"de20a445876561fd623cb3cabf67c6ece7e751ef","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    $ssh_cmd tar xzvf /srv/magnum/helm-client.tar.gz linux-amd64/helm -O \u003e /srv/magnum/bin/helm"},{"line_number":37,"context_line":"    $ssh_cmd chmod +x /srv/magnum/bin/helm"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    helm_install_cmd\u003d\"helm install magnum . --namespace kube-system --values values.yaml --render-subchart-notes\""},{"line_number":40,"context_line":"    helm_history_cmd\u003d\"helm history magnum --namespace kube-system\""},{"line_number":41,"context_line":"    if [[ \"${HELM_CLIENT_TAG}\" \u003d\u003d v2.* ]]; then"},{"line_number":42,"context_line":"        CERTS_DIR\u003d\"/etc/kubernetes/helm/certs\""}],"source_content_type":"text/x-sh","patch_set":26,"id":"ff570b3c_fe50270d","line":39,"in_reply_to":"ff570b3c_7323b006","updated":"2020-05-26 13:11:18.000000000","message":"ok","commit_id":"de8ca77233f6aafe233f269b3230042000ff88b0"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"800a63d2f064e68f9e98163b5673eb971570c729","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        cat \u003c\u003c EOF \u003e Chart.yaml"},{"line_number":63,"context_line":"apiVersion: v1"},{"line_number":64,"context_line":"name: magnum"},{"line_number":65,"context_line":"version: ussuri"},{"line_number":66,"context_line":"appVersion: ussuri"},{"line_number":67,"context_line":"description: Magnum Helm Charts"},{"line_number":68,"context_line":"EOF"}],"source_content_type":"text/x-sh","patch_set":26,"id":"ff570b3c_8423a005","line":65,"range":{"start_line":65,"start_character":9,"end_line":65,"end_character":15},"updated":"2020-05-26 08:36:41.000000000","message":"This is extremely wrong and not required whatsover. This chart is created dynamically. Why should we introduce the version one more time and then have to update?","commit_id":"de8ca77233f6aafe233f269b3230042000ff88b0"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"d208faa0648b67fc066802b360fc76db15a8b1c6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        cat \u003c\u003c EOF \u003e Chart.yaml"},{"line_number":63,"context_line":"apiVersion: v1"},{"line_number":64,"context_line":"name: magnum"},{"line_number":65,"context_line":"version: ussuri"},{"line_number":66,"context_line":"appVersion: ussuri"},{"line_number":67,"context_line":"description: Magnum Helm Charts"},{"line_number":68,"context_line":"EOF"}],"source_content_type":"text/x-sh","patch_set":26,"id":"ff570b3c_b3ef08af","line":65,"range":{"start_line":65,"start_character":9,"end_line":65,"end_character":15},"in_reply_to":"ff570b3c_8423a005","updated":"2020-05-26 12:55:30.000000000","message":"Version is not required? Pretty sure i saw helm client throw sn error when unspecified.","commit_id":"de8ca77233f6aafe233f269b3230042000ff88b0"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"de20a445876561fd623cb3cabf67c6ece7e751ef","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        cat \u003c\u003c EOF \u003e Chart.yaml"},{"line_number":63,"context_line":"apiVersion: v1"},{"line_number":64,"context_line":"name: magnum"},{"line_number":65,"context_line":"version: ussuri"},{"line_number":66,"context_line":"appVersion: ussuri"},{"line_number":67,"context_line":"description: Magnum Helm Charts"},{"line_number":68,"context_line":"EOF"}],"source_content_type":"text/x-sh","patch_set":26,"id":"ff570b3c_de3443e1","line":65,"range":{"start_line":65,"start_character":9,"end_line":65,"end_character":15},"in_reply_to":"ff570b3c_93548456","updated":"2020-05-26 13:11:18.000000000","message":"the version is required indeed as a field. Hard coding release versions is not required.\n\nWe can merge as is.","commit_id":"de8ca77233f6aafe233f269b3230042000ff88b0"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"6e8310c8baa569f168b9c8eb6d7773ce7009cf01","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        cat \u003c\u003c EOF \u003e Chart.yaml"},{"line_number":63,"context_line":"apiVersion: v1"},{"line_number":64,"context_line":"name: magnum"},{"line_number":65,"context_line":"version: ussuri"},{"line_number":66,"context_line":"appVersion: ussuri"},{"line_number":67,"context_line":"description: Magnum Helm Charts"},{"line_number":68,"context_line":"EOF"}],"source_content_type":"text/x-sh","patch_set":26,"id":"ff570b3c_d3755cfc","line":65,"range":{"start_line":65,"start_character":9,"end_line":65,"end_character":15},"in_reply_to":"ff570b3c_b3ef08af","updated":"2020-05-26 12:58:39.000000000","message":"```\nubuntu@devstack-master:~/magnum-terraform/magnum$ helm install . --generate-name\nError: validation: chart.metadata.version is required\n```","commit_id":"de8ca77233f6aafe233f269b3230042000ff88b0"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"8e78a402c35cbeb8142e94f734760c76eb5869b2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        cat \u003c\u003c EOF \u003e Chart.yaml"},{"line_number":63,"context_line":"apiVersion: v1"},{"line_number":64,"context_line":"name: magnum"},{"line_number":65,"context_line":"version: ussuri"},{"line_number":66,"context_line":"appVersion: ussuri"},{"line_number":67,"context_line":"description: Magnum Helm Charts"},{"line_number":68,"context_line":"EOF"}],"source_content_type":"text/x-sh","patch_set":26,"id":"ff570b3c_93548456","line":65,"range":{"start_line":65,"start_character":9,"end_line":65,"end_character":15},"in_reply_to":"ff570b3c_d3755cfc","updated":"2020-05-26 12:59:27.000000000","message":"If you would rather this was called something other than \"ussuri\", please feel free to suggest.","commit_id":"de8ca77233f6aafe233f269b3230042000ff88b0"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"ebe7bc78b950a8e60214cbec6311cfe1f6b62b6d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        cat \u003c\u003c EOF \u003e Chart.yaml"},{"line_number":63,"context_line":"apiVersion: v1"},{"line_number":64,"context_line":"name: magnum"},{"line_number":65,"context_line":"version: ussuri"},{"line_number":66,"context_line":"appVersion: ussuri"},{"line_number":67,"context_line":"description: Magnum Helm Charts"},{"line_number":68,"context_line":"EOF"}],"source_content_type":"text/x-sh","patch_set":26,"id":"ff570b3c_de53a3e1","line":65,"range":{"start_line":65,"start_character":9,"end_line":65,"end_character":15},"in_reply_to":"ff570b3c_de3443e1","updated":"2020-05-26 13:19:29.000000000","message":"No I agree with you, doesnt make sense to have something we\u0027ll need to bump up again. How about \"version: meta\"?","commit_id":"de8ca77233f6aafe233f269b3230042000ff88b0"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"6f3696366c40e30ed5d0eececf048c48e7c55c21","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        cat \u003c\u003c EOF \u003e Chart.yaml"},{"line_number":63,"context_line":"apiVersion: v1"},{"line_number":64,"context_line":"name: magnum"},{"line_number":65,"context_line":"version: ussuri"},{"line_number":66,"context_line":"appVersion: ussuri"},{"line_number":67,"context_line":"description: Magnum Helm Charts"},{"line_number":68,"context_line":"EOF"}],"source_content_type":"text/x-sh","patch_set":26,"id":"ff570b3c_59832d05","line":65,"range":{"start_line":65,"start_character":9,"end_line":65,"end_character":15},"in_reply_to":"ff570b3c_de53a3e1","updated":"2020-05-26 13:54:49.000000000","message":"meta or metachart should do it","commit_id":"de8ca77233f6aafe233f269b3230042000ff88b0"}],"magnum/drivers/common/templates/kubernetes/helm/helm-installer.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"d415117e76c5b49730a0bb4481fb0f89fa01e6aa","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      serviceAccountName: helm"},{"line_number":31,"context_line":"      containers:"},{"line_number":32,"context_line":"      - name: config-helm"},{"line_number":33,"context_line":"        image: ${CONTAINER_INFRA_PREFIX:-docker.io/brtknr/}helm-client:${HELM_CLIENT_TAG}"},{"line_number":34,"context_line":"        command:"},{"line_number":35,"context_line":"        - bash"},{"line_number":36,"context_line":"        args:"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1f493fa4_ab792cfd","line":33,"range":{"start_line":33,"start_character":51,"end_line":33,"end_character":57},"updated":"2020-04-23 15:30:47.000000000","message":"note to self, revert to openstackmagnum","commit_id":"511dd6e942a088abb5f369f129b2cfd84faf8ad9"}],"magnum/drivers/common/templates/kubernetes/helm/helm-v2-installer.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"d415117e76c5b49730a0bb4481fb0f89fa01e6aa","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      serviceAccountName: tiller"},{"line_number":38,"context_line":"      containers:"},{"line_number":39,"context_line":"      - name: config-helm"},{"line_number":40,"context_line":"        image: ${CONTAINER_INFRA_PREFIX:-docker.io/brtknr/}helm-client:${HELM_CLIENT_TAG}"},{"line_number":41,"context_line":"        command:"},{"line_number":42,"context_line":"        - bash"},{"line_number":43,"context_line":"        args:"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1f493fa4_cb8638dc","line":40,"range":{"start_line":40,"start_character":51,"end_line":40,"end_character":57},"updated":"2020-04-23 15:30:47.000000000","message":"notetoself: revert to openstackmagnum","commit_id":"511dd6e942a088abb5f369f129b2cfd84faf8ad9"}],"magnum/drivers/common/templates/kubernetes/helm/ingress-nginx.sh":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dcfaec21fde831fd03615c79b777c68a1fd6d174","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ff570b3c_592186fb","line":168,"updated":"2020-05-11 18:20:43.000000000","message":"pep8: E040 Syntax error: syntax error: unexpected end of file","commit_id":"60387a40df7ccff8e4327ea92cf83ea643d77246"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"b44fdae8828be6168a32cf13ea3692d2d1dbb745","unresolved":false,"context_lines":[{"line_number":127,"context_line":"      serviceMonitor:"},{"line_number":128,"context_line":"        enabled: ${MONITORING_ENABLED}"},{"line_number":129,"context_line":"        additionalLabels:"},{"line_number":130,"context_line":"          release: prometheus-operator"},{"line_number":131,"context_line":"        namespace: kube-system"},{"line_number":132,"context_line":"    lifecycle: {}"},{"line_number":133,"context_line":"    priorityClassName: \"system-node-critical\""}],"source_content_type":"text/x-sh","patch_set":25,"id":"ff570b3c_e4af2329","line":130,"range":{"start_line":130,"start_character":19,"end_line":130,"end_character":38},"updated":"2020-05-22 10:41:40.000000000","message":"I think this is stoped working because you merged all the components in a super chart with a release named magnum.","commit_id":"5b7751d9a6452706017aaa7306b0ff5bfdf7ee26"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"a0b74ae8070111e901f1a10eeb93a8d9cbda7e89","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        type: ClusterIP"},{"line_number":127,"context_line":"      serviceMonitor:"},{"line_number":128,"context_line":"        enabled: ${MONITORING_ENABLED}"},{"line_number":129,"context_line":"        additionalLabels:"},{"line_number":130,"context_line":"          release: prometheus-operator"},{"line_number":131,"context_line":"        namespace: kube-system"},{"line_number":132,"context_line":"    lifecycle: {}"},{"line_number":133,"context_line":"    priorityClassName: \"system-node-critical\""}],"source_content_type":"text/x-sh","patch_set":25,"id":"ff570b3c_c52e40f9","line":130,"range":{"start_line":129,"start_character":8,"end_line":130,"end_character":38},"updated":"2020-05-25 11:47:12.000000000","message":"is\n        additionalLabels:\n          release: prometheus-operator\nneeded?\n\nThe selector is configured by default.\nhttps://github.com/helm/charts/blob/master/stable/nginx-ingress/templates/controller-servicemonitor.yaml#L33","commit_id":"5b7751d9a6452706017aaa7306b0ff5bfdf7ee26"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"a821d01baaf9f51fd7dae87a511d9433170197b9","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        type: ClusterIP"},{"line_number":127,"context_line":"      serviceMonitor:"},{"line_number":128,"context_line":"        enabled: ${MONITORING_ENABLED}"},{"line_number":129,"context_line":"        additionalLabels:"},{"line_number":130,"context_line":"          release: prometheus-operator"},{"line_number":131,"context_line":"        namespace: kube-system"},{"line_number":132,"context_line":"    lifecycle: {}"},{"line_number":133,"context_line":"    priorityClassName: \"system-node-critical\""}],"source_content_type":"text/x-sh","patch_set":25,"id":"ff570b3c_10ba38dd","line":130,"range":{"start_line":129,"start_character":8,"end_line":130,"end_character":38},"in_reply_to":"ff570b3c_c52e40f9","updated":"2020-05-25 13:04:20.000000000","message":"Ok, so drop \nadditionalLabels:\n  release:prometheus-operator","commit_id":"5b7751d9a6452706017aaa7306b0ff5bfdf7ee26"}],"magnum/drivers/common/templates/kubernetes/helm/metrics-server.sh":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dcfaec21fde831fd03615c79b777c68a1fd6d174","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ff570b3c_99783ef9","line":20,"updated":"2020-05-11 18:20:43.000000000","message":"pep8: E040 Syntax error: syntax error: unexpected end of file","commit_id":"60387a40df7ccff8e4327ea92cf83ea643d77246"}],"magnum/drivers/common/templates/kubernetes/helm/prometheus-adapter.sh":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dcfaec21fde831fd03615c79b777c68a1fd6d174","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ff570b3c_391e52ba","line":41,"updated":"2020-05-11 18:20:43.000000000","message":"pep8: E040 Syntax error: syntax error: unexpected end of file","commit_id":"60387a40df7ccff8e4327ea92cf83ea643d77246"}],"magnum/drivers/common/templates/kubernetes/helm/prometheus-operator.sh":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dcfaec21fde831fd03615c79b777c68a1fd6d174","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ff570b3c_f9233a04","line":168,"updated":"2020-05-11 18:20:43.000000000","message":"pep8: E040 Syntax error: syntax error: unexpected end of file","commit_id":"60387a40df7ccff8e4327ea92cf83ea643d77246"}]}