)]}'
{"magnum/drivers/common/templates/kubernetes/helm/prometheus-operator.sh":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"e1de15d77b14ae06be673b24684c7af4e42a6248","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        PROTOCOL\u003d\"http\""},{"line_number":27,"context_line":"        INSECURE_SKIP_VERIFY\u003d\"True\""},{"line_number":28,"context_line":"    fi"},{"line_number":29,"context_line":"    # FIXME: Force protocol to http as we don\u0027t want to use the cluster certs"},{"line_number":30,"context_line":"    USE_HTTPS\u003d\"False\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    if [ \"$(echo ${VERIFY_CA} | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d\u003d \"false\" ]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff570b3c_ed7586fb","line":29,"updated":"2020-05-19 21:11:31.000000000","message":"Could I get more background why we have to use HTTP here? Thanks.","commit_id":"6f7c72f90abbc467d4d7d1570a78abe5b767763e"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"8a7dab712e5f3c4bd4e4520cea3a4c1a3b4a6151","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        PROTOCOL\u003d\"http\""},{"line_number":27,"context_line":"        INSECURE_SKIP_VERIFY\u003d\"True\""},{"line_number":28,"context_line":"    fi"},{"line_number":29,"context_line":"    # FIXME: Force protocol to http as we don\u0027t want to use the cluster certs"},{"line_number":30,"context_line":"    USE_HTTPS\u003d\"False\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    if [ \"$(echo ${VERIFY_CA} | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d\u003d \"false\" ]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff570b3c_b58c6c36","line":29,"in_reply_to":"ff570b3c_ed7586fb","updated":"2020-05-20 09:05:50.000000000","message":"To use HTTPS here we need to expose to the prometheus-server the kubelet certificates as secrets. The kubelet certificates at this time are the same as the cluster certificates.\n\nAt the time, me and @spyros talked and we wanted to properly generate the certificates for the k8s components (ence the HTTPS\u003dFalse)\n\nThinking on switching to encrypted connection i already added a skeleton for the transition (most of the commented lines).\n\nWe can add HTTPS capability on other commit when we can have different certs for the components, or and this is a better option, we move the configuration of the k8s components to be deployed with helm.","commit_id":"6f7c72f90abbc467d4d7d1570a78abe5b767763e"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"ad2a755868552a6597bf4c1abef4a4ed33f88d46","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        - --collector.filesystem.ignored-mount-points\u003d^/(dev|proc|sys|var/lib/docker/.+)($|/)"},{"line_number":238,"context_line":"        - --collector.filesystem.ignored-fs-types\u003d^(autofs|binfmt_misc|cgroup|configfs|debugfs|devpts|devtmpfs|fusectl|hugetlbfs|mqueue|overlay|proc|procfs|pstore|rpc_pipefs|securityfs|sysfs|tracefs)$"},{"line_number":239,"context_line":"      sidecars: []"},{"line_number":240,"context_line":"      ##  - name: nvidia-dcgm-exporter"},{"line_number":241,"context_line":"      ##    image: nvidia/dcgm-exporter:1.4.3"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    prometheusOperator:"},{"line_number":244,"context_line":"      priorityClassName: \"system-cluster-critical\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff570b3c_35d33c06","line":241,"range":{"start_line":240,"start_character":0,"end_line":241,"end_character":45},"updated":"2020-05-20 09:11:35.000000000","message":"neat, i also looking to deploy this, have you had much luck?","commit_id":"6f7c72f90abbc467d4d7d1570a78abe5b767763e"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"7607b8dede9186cdb767cfbeb88dfe7ccc2f937d","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        - --collector.filesystem.ignored-mount-points\u003d^/(dev|proc|sys|var/lib/docker/.+)($|/)"},{"line_number":238,"context_line":"        - --collector.filesystem.ignored-fs-types\u003d^(autofs|binfmt_misc|cgroup|configfs|debugfs|devpts|devtmpfs|fusectl|hugetlbfs|mqueue|overlay|proc|procfs|pstore|rpc_pipefs|securityfs|sysfs|tracefs)$"},{"line_number":239,"context_line":"      sidecars: []"},{"line_number":240,"context_line":"      ##  - name: nvidia-dcgm-exporter"},{"line_number":241,"context_line":"      ##    image: nvidia/dcgm-exporter:1.4.3"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    prometheusOperator:"},{"line_number":244,"context_line":"      priorityClassName: \"system-cluster-critical\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff570b3c_757f74aa","line":241,"range":{"start_line":240,"start_character":0,"end_line":241,"end_character":45},"in_reply_to":"ff570b3c_15af182a","updated":"2020-05-20 09:23:10.000000000","message":"We have access to some Tesla P100s I can test this against if you like :)","commit_id":"6f7c72f90abbc467d4d7d1570a78abe5b767763e"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"b3c8183eedb6bfc08391b0b7a48d3f49b48e5f5b","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        - --collector.filesystem.ignored-mount-points\u003d^/(dev|proc|sys|var/lib/docker/.+)($|/)"},{"line_number":238,"context_line":"        - --collector.filesystem.ignored-fs-types\u003d^(autofs|binfmt_misc|cgroup|configfs|debugfs|devpts|devtmpfs|fusectl|hugetlbfs|mqueue|overlay|proc|procfs|pstore|rpc_pipefs|securityfs|sysfs|tracefs)$"},{"line_number":239,"context_line":"      sidecars: []"},{"line_number":240,"context_line":"      ##  - name: nvidia-dcgm-exporter"},{"line_number":241,"context_line":"      ##    image: nvidia/dcgm-exporter:1.4.3"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    prometheusOperator:"},{"line_number":244,"context_line":"      priorityClassName: \"system-cluster-critical\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff570b3c_15af182a","line":241,"range":{"start_line":240,"start_character":0,"end_line":241,"end_character":45},"in_reply_to":"ff570b3c_35d33c06","updated":"2020-05-20 09:21:04.000000000","message":"We have some internal stuff, but i still didn\u0027t manage to test it because i have no GPU card yet","commit_id":"6f7c72f90abbc467d4d7d1570a78abe5b767763e"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"254dfbb4edfa48129154961d745642fd5c70691c","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        - --collector.filesystem.ignored-mount-points\u003d^/(dev|proc|sys|var/lib/docker/.+)($|/)"},{"line_number":238,"context_line":"        - --collector.filesystem.ignored-fs-types\u003d^(autofs|binfmt_misc|cgroup|configfs|debugfs|devpts|devtmpfs|fusectl|hugetlbfs|mqueue|overlay|proc|procfs|pstore|rpc_pipefs|securityfs|sysfs|tracefs)$"},{"line_number":239,"context_line":"      sidecars: []"},{"line_number":240,"context_line":"      ##  - name: nvidia-dcgm-exporter"},{"line_number":241,"context_line":"      ##    image: nvidia/dcgm-exporter:1.4.3"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    prometheusOperator:"},{"line_number":244,"context_line":"      priorityClassName: \"system-cluster-critical\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff570b3c_070b6b23","line":241,"range":{"start_line":240,"start_character":0,"end_line":241,"end_character":45},"in_reply_to":"ff570b3c_757f74aa","updated":"2020-05-20 09:29:11.000000000","message":"thanks, will keep that in mind. I might bother you soon :)","commit_id":"6f7c72f90abbc467d4d7d1570a78abe5b767763e"}]}