)]}'
{"magnum/api/controllers/v1/certificate.py":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"53384d17d132dc77eb9fb25f1e0c48fb0bbb1a8c","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        if cluster.cluster_template.tls_disabled:"},{"line_number":192,"context_line":"            raise exception.NotSupported(\"Rotating the CA certificate on a \""},{"line_number":193,"context_line":"                                         \"non-TLS cluster is not supported\")"},{"line_number":194,"context_line":"        if cluster.cluster_template.cluster_distro \u003d\u003d \"fedora-atomic\":"},{"line_number":195,"context_line":"            raise exception.NotSupported(\"Rotating the CA certificate on a \""},{"line_number":196,"context_line":"                                         \"cluster based on Fedora Atomic \""},{"line_number":197,"context_line":"                                         \"is not supported\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_1ab970e8","line":194,"range":{"start_line":194,"start_character":51,"end_line":194,"end_character":69},"updated":"2020-08-19 09:13:49.000000000","message":"I am okay to support fedora-coreos only here. However, can we make this generic and instead raise an exception if cluster_distro not in [\"fedora-coreos\"]? I suppose the driver is also a consideration, eg. only k8s is supported.","commit_id":"ba346d3ea9075054bf4b66d4eef321e4fa8c73ff"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"18b867acafea4e25d70322c6ebcfdb239ddeaa14","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        if cluster.cluster_template.tls_disabled:"},{"line_number":192,"context_line":"            raise exception.NotSupported(\"Rotating the CA certificate on a \""},{"line_number":193,"context_line":"                                         \"non-TLS cluster is not supported\")"},{"line_number":194,"context_line":"        if cluster.cluster_template.cluster_distro \u003d\u003d \"fedora-atomic\":"},{"line_number":195,"context_line":"            raise exception.NotSupported(\"Rotating the CA certificate on a \""},{"line_number":196,"context_line":"                                         \"cluster based on Fedora Atomic \""},{"line_number":197,"context_line":"                                         \"is not supported\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_fa8e3c25","line":194,"range":{"start_line":194,"start_character":51,"end_line":194,"end_character":69},"in_reply_to":"9f560f44_1ab970e8","updated":"2020-08-19 09:18:22.000000000","message":"Very good point. Will do.","commit_id":"ba346d3ea9075054bf4b66d4eef321e4fa8c73ff"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"abdea2efe7f1cdfaa0f953ae97a1c4d9961dd7dc","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        if cluster.cluster_template.tls_disabled:"},{"line_number":192,"context_line":"            raise exception.NotSupported(\"Rotating the CA certificate on a \""},{"line_number":193,"context_line":"                                         \"non-TLS cluster is not supported\")"},{"line_number":194,"context_line":"        if cluster.cluster_template.cluster_distro not in [\"fedora-coreos\"]:"},{"line_number":195,"context_line":"            raise exception.NotSupported(\"Rotating the CA certificate is \""},{"line_number":196,"context_line":"                                         \"not supported.\")"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9f560f44_6e13655d","line":194,"updated":"2020-08-21 09:50:12.000000000","message":"sorry for coming late, this would not let us create a new driver without changing the API (eg a fedora-coreos-kubeadm or fedora-coreos-v2). Why not let this to the conductor for now? OR dynamically check if the driver supports CA rotate? We can also take this and improve later. I just wanted to mention that this check is inline with the (loose) design of drivers.\n\nI will +2 to not block it, can you both ACK this comment before merging?","commit_id":"b6cc22504349f01830b4ca21bdde860ae08f08fa"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"e001925b93cb08feb4e56ebe43e6487f9692f6ca","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        if cluster.cluster_template.tls_disabled:"},{"line_number":192,"context_line":"            raise exception.NotSupported(\"Rotating the CA certificate on a \""},{"line_number":193,"context_line":"                                         \"non-TLS cluster is not supported\")"},{"line_number":194,"context_line":"        if cluster.cluster_template.cluster_distro not in [\"fedora-coreos\"]:"},{"line_number":195,"context_line":"            raise exception.NotSupported(\"Rotating the CA certificate is \""},{"line_number":196,"context_line":"                                         \"not supported.\")"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9f560f44_c63b70ce","line":194,"in_reply_to":"9f560f44_0ea7490d","updated":"2020-08-21 19:18:29.000000000","message":"I agree with you guys. I was just too lazy and keen to get a patchset posted, so I change it here. I will move this to the driver layer. A patchset will be proposed soon. Thank you very much.","commit_id":"b6cc22504349f01830b4ca21bdde860ae08f08fa"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"03a92a534c431dad140b618ad796392b1fbf7c37","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        if cluster.cluster_template.tls_disabled:"},{"line_number":192,"context_line":"            raise exception.NotSupported(\"Rotating the CA certificate on a \""},{"line_number":193,"context_line":"                                         \"non-TLS cluster is not supported\")"},{"line_number":194,"context_line":"        if cluster.cluster_template.cluster_distro not in [\"fedora-coreos\"]:"},{"line_number":195,"context_line":"            raise exception.NotSupported(\"Rotating the CA certificate is \""},{"line_number":196,"context_line":"                                         \"not supported.\")"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9f560f44_0ea7490d","line":194,"in_reply_to":"9f560f44_6e13655d","updated":"2020-08-21 10:02:21.000000000","message":"i agree that it would be much cleaner to raise the exception in the conductor.","commit_id":"b6cc22504349f01830b4ca21bdde860ae08f08fa"}],"magnum/conductor/handlers/ca_conductor.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b4e7b114d79d646d1c41ad375f3f3a7bf8603ac4","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            conductor_utils.notify_about_cluster_operation("},{"line_number":79,"context_line":"                context, taxonomy.ACTION_UPDATE, taxonomy.OUTCOME_FAILURE,"},{"line_number":80,"context_line":"                cluster)"},{"line_number":81,"context_line":"            operation \u003d _(\u0027Updating a cluster when status is \u0027"},{"line_number":82,"context_line":"                          \u0027\"%s\"\u0027) % cluster.status"},{"line_number":83,"context_line":"            raise exception.NotSupported(operation\u003doperation)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_34d86b1c","line":81,"updated":"2020-04-29 05:23:07.000000000","message":"pep8: M340: Found use of _() without explicit import of _ !","commit_id":"f9d22b4d5cb7d6218a7d7e1fdf05e9b011dfc0f2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"e2f460d9c6b53864bfe4885fc3df87f2cd55b708","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        return certificate"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def rotate_ca_certificate(self, context, cluster):"},{"line_number":66,"context_line":"        LOG.debug(\u0027start rotate_ca_certificate\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        allow_update_status \u003d ("},{"line_number":69,"context_line":"            fields.ClusterStatus.CREATE_COMPLETE,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_72853c08","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":17},"updated":"2020-05-14 08:53:23.000000000","message":"Lets log this to info and also add cluster ID here because its a big deal :)","commit_id":"7a3d9f6a5520d70e2adb569ff1027298df870415"}],"magnum/drivers/common/templates/kubernetes/fragments/rotate-kubernetes-ca-certs-client.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"e2f460d9c6b53864bfe4885fc3df87f2cd55b708","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"echo \"START: rotate CA certs on client\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set +x"},{"line_number":20,"context_line":". /etc/sysconfig/heat-params"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ff570b3c_3215849d","line":17,"range":{"start_line":17,"start_character":32,"end_line":17,"end_character":38},"updated":"2020-05-14 08:53:23.000000000","message":"s/client/worker (also in the file name).","commit_id":"7a3d9f6a5520d70e2adb569ff1027298df870415"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"e2f460d9c6b53864bfe4885fc3df87f2cd55b708","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    done"},{"line_number":160,"context_line":"fi"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"echo \"END: rotate CA certs on client\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"ff570b3c_5239183f","line":162,"range":{"start_line":162,"start_character":30,"end_line":162,"end_character":36},"updated":"2020-05-14 08:53:23.000000000","message":"s/client/worker","commit_id":"7a3d9f6a5520d70e2adb569ff1027298df870415"}],"magnum/drivers/common/templates/kubernetes/fragments/rotate-kubernetes-ca-certs-master.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"ca55e792e7a4a89b77cbc32a21d11a0ca18ce0cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"echo \"START: rotate CA certs on master\""},{"line_number":4,"context_line":""}],"source_content_type":"text/x-sh","patch_set":11,"id":"bf51134e_9540130a","line":1,"updated":"2020-06-15 09:05:34.000000000","message":"i think if these files are dropped and we just use the make-cert scripts, it should work, no?","commit_id":"f911f824ab6ecb55216749aa06673fc24adcbab4"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"47e1003c78ae933da04869d9c854720b5fe3da68","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"echo \"START: rotate CA certs on master\""},{"line_number":4,"context_line":""}],"source_content_type":"text/x-sh","patch_set":11,"id":"bf51134e_950db392","line":1,"in_reply_to":"bf51134e_15ac038b","updated":"2020-06-15 09:16:55.000000000","message":"As far as I see it, only the usermod cmd is problematic. I have tried running this script multiple times, it is very stable.\n\nThe restart services part should be a separate script.","commit_id":"f911f824ab6ecb55216749aa06673fc24adcbab4"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"b847a40f8245c56b58bc27cdcc2dae57937983d4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"echo \"START: rotate CA certs on master\""},{"line_number":4,"context_line":""}],"source_content_type":"text/x-sh","patch_set":11,"id":"bf51134e_15ac038b","line":1,"in_reply_to":"bf51134e_9540130a","updated":"2020-06-15 09:12:02.000000000","message":"Unfortunately, it didn\u0027t work for me because of some small things. e.g. restart services and create group, usermod, etc\n\nI think there could be solutions to merge these scripts, but I don\u0027t want to do big change now for those two make-certs avoid introduce regression issues.","commit_id":"f911f824ab6ecb55216749aa06673fc24adcbab4"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"32db27c734286e696f78e7e6ef915489e9271fd1","unresolved":false,"context_lines":[{"line_number":4,"context_line":". /etc/sysconfig/heat-params"},{"line_number":5,"context_line":"set -x"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set -o errexit"},{"line_number":8,"context_line":"set -o nounset"},{"line_number":9,"context_line":"set -o pipefail"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":12,"context_line":""}],"source_content_type":"text/x-sh","patch_set":14,"id":"bf51134e_87580231","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":15},"updated":"2020-08-17 10:28:10.000000000","message":"nit: set -eu -o pipefail also works btw.","commit_id":"b40f45dfba9ff4cb0e174c06d2500e328fd5d9d7"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"6e8241d9f3f05750e5c38bd9c26f2e24b135f121","unresolved":false,"context_lines":[{"line_number":4,"context_line":". /etc/sysconfig/heat-params"},{"line_number":5,"context_line":"set -x"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set -o errexit"},{"line_number":8,"context_line":"set -o nounset"},{"line_number":9,"context_line":"set -o pipefail"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":12,"context_line":""}],"source_content_type":"text/x-sh","patch_set":14,"id":"9f560f44_9183c204","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":15},"in_reply_to":"bf51134e_87580231","updated":"2020-08-17 22:26:39.000000000","message":"Will do.","commit_id":"b40f45dfba9ff4cb0e174c06d2500e328fd5d9d7"}],"magnum/drivers/common/templates/kubernetes/fragments/upgrade-kubernetes.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"e2f460d9c6b53864bfe4885fc3df87f2cd55b708","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set +x"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"echo \"START: Upgrade k8s and base operating system\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":". /etc/sysconfig/heat-params"},{"line_number":8,"context_line":"set -x"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ff570b3c_529d9857","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":14},"updated":"2020-05-14 08:53:23.000000000","message":"small case","commit_id":"7a3d9f6a5520d70e2adb569ff1027298df870415"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"e2f460d9c6b53864bfe4885fc3df87f2cd55b708","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    shutdown --reboot --no-wall -t 1"},{"line_number":150,"context_line":"fi"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"echo \"END: Upgrade k8s and base operating system\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"ff570b3c_b2a3549e","line":152,"range":{"start_line":152,"start_character":11,"end_line":152,"end_character":12},"updated":"2020-05-14 08:53:23.000000000","message":"nit: small case","commit_id":"7a3d9f6a5520d70e2adb569ff1027298df870415"}],"magnum/drivers/heat/driver.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a57edac22dcbb2a25a2569862e2cba636f9733a4","unresolved":false,"context_lines":[{"line_number":456,"context_line":"        osc \u003d clients.OpenStackClients(context)"},{"line_number":457,"context_line":"        heat_params \u003d {}"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        csr_keys \u003d x509.generate_csr_and_key(u\"Kubernetes Service Account\")"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        heat_params[\u0027kube_service_account_key\u0027] \u003d \\"},{"line_number":462,"context_line":"            csr_keys[\"public_key\"].replace(\"\\n\", \"\\\\n\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_03053b46","line":459,"updated":"2020-04-29 01:55:02.000000000","message":"pep8: F821 undefined name \u0027x509\u0027","commit_id":"9edc3b367f044031f7bf4afe16eece6475391c54"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a57edac22dcbb2a25a2569862e2cba636f9733a4","unresolved":false,"context_lines":[{"line_number":466,"context_line":"        fields \u003d {"},{"line_number":467,"context_line":"            \u0027existing\u0027: True,"},{"line_number":468,"context_line":"            \u0027parameters\u0027: heat_params,"},{"line_number":469,"context_line":"            \u0027disable_rollback\u0027: not rollback"},{"line_number":470,"context_line":"        }"},{"line_number":471,"context_line":"        osc.heat().stacks.update(stack_id, **fields)"},{"line_number":472,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_e3012f3a","line":469,"updated":"2020-04-29 01:55:02.000000000","message":"pep8: F821 undefined name \u0027rollback\u0027","commit_id":"9edc3b367f044031f7bf4afe16eece6475391c54"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a57edac22dcbb2a25a2569862e2cba636f9733a4","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            \u0027parameters\u0027: heat_params,"},{"line_number":469,"context_line":"            \u0027disable_rollback\u0027: not rollback"},{"line_number":470,"context_line":"        }"},{"line_number":471,"context_line":"        osc.heat().stacks.update(stack_id, **fields)"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"class HeatPoller(object):"},{"line_number":474,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_43fbc345","line":471,"updated":"2020-04-29 01:55:02.000000000","message":"pep8: F821 undefined name \u0027stack_id\u0027","commit_id":"9edc3b367f044031f7bf4afe16eece6475391c54"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"a57edac22dcbb2a25a2569862e2cba636f9733a4","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        }"},{"line_number":471,"context_line":"        osc.heat().stacks.update(stack_id, **fields)"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"class HeatPoller(object):"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    def __init__(self, openstack_client, context, cluster, cluster_driver):"},{"line_number":476,"context_line":"        self.openstack_client \u003d openstack_client"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_23f83747","line":473,"updated":"2020-04-29 01:55:02.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"9edc3b367f044031f7bf4afe16eece6475391c54"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"03a92a534c431dad140b618ad796392b1fbf7c37","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        }"},{"line_number":447,"context_line":"        return extra_params"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    def rotate_ca_certificate(self, context, cluster):"},{"line_number":450,"context_line":"        osc \u003d clients.OpenStackClients(context)"},{"line_number":451,"context_line":"        rollback \u003d True"},{"line_number":452,"context_line":"        heat_params \u003d {}"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f560f44_cea0b1f7","line":449,"range":{"start_line":449,"start_character":8,"end_line":449,"end_character":54},"updated":"2020-08-21 10:02:21.000000000","message":"does that mean the exception needs to be raised here?","commit_id":"b6cc22504349f01830b4ca21bdde860ae08f08fa"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"59fc6c3ac285817fa969c5552f8c73145fb16744","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                                                                     cluster)"},{"line_number":452,"context_line":"        if cluster_template.cluster_distro not in [\"fedora-coreos\"]:"},{"line_number":453,"context_line":"            raise exception.NotSupported(\"Rotating the CA certificate is \""},{"line_number":454,"context_line":"                                         \"not supported.\")"},{"line_number":455,"context_line":"        osc \u003d clients.OpenStackClients(context)"},{"line_number":456,"context_line":"        rollback \u003d True"},{"line_number":457,"context_line":"        heat_params \u003d {}"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_09e3b935","line":454,"updated":"2020-08-21 20:56:04.000000000","message":"can we phrase it something like f\"Rotating the CA certificate is not supported for {cluster_template.cluster_distro}\". I just tried it in the CLI and it gives the impression it is not supported at all. This said, we should also mention something about this restriction in the existing ca rotate docs.","commit_id":"3d6433b559da08d6c104e6beb3b8ec69b7b6df43"}],"magnum/drivers/k8s_fedora_coreos_v1/templates/kubeminion.yaml":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"6ac4fc39714f623de9782ed7fce743e5e752fcb8","unresolved":false,"context_lines":[{"line_number":600,"context_line":"          -"},{"line_number":601,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/upgrade-kubernetes.sh"},{"line_number":602,"context_line":"            - get_file: ../../common/templates/kubernetes/fragments/rotate-kubernetes-ca-certs-client.sh"},{"line_number":603,"context_line":"  "},{"line_number":604,"context_line":"  upgrade_kubernetes_deployment:"},{"line_number":605,"context_line":"    type: OS::Heat::SoftwareDeployment"},{"line_number":606,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_64de1a40","line":603,"range":{"start_line":603,"start_character":0,"end_line":603,"end_character":2},"updated":"2020-05-14 08:33:03.000000000","message":"delete","commit_id":"7a3d9f6a5520d70e2adb569ff1027298df870415"}],"magnum/tests/unit/api/controllers/v1/test_certificate.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"cacefde1de73f554ba565be4efe2a85956bdd85c","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":""},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"class TestCertPolicyEnforcement(api_base.FunctionalTest):"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def _common_policy_check(self, rule, func, *arg, **kwarg):"},{"line_number":287,"context_line":"        self.policy.set_rules({rule: \"project_id:non_fake\"})"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_371626a9","line":284,"updated":"2020-08-18 02:33:42.000000000","message":"pep8: E303 too many blank lines (3)","commit_id":"d0d570a3f6196d468e66e4eaf1250a7e1823342a"}],"magnum/tests/unit/drivers/test_k8s_fedora_atomic_v1_driver.py":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"59fc6c3ac285817fa969c5552f8c73145fb16744","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    @patch(\u0027magnum.common.keystone.KeystoneClientV3\u0027)"},{"line_number":145,"context_line":"    @patch(\u0027magnum.common.clients.OpenStackClients\u0027)"},{"line_number":146,"context_line":"    def test_ca_rotate_not_supported(self, mock_osc, mock_keystone):"},{"line_number":147,"context_line":"        self.cluster_template.cluster_distro \u003d \u0027fedora_atomic\u0027"},{"line_number":148,"context_line":"        self.cluster_template.save()"},{"line_number":149,"context_line":"        mock_keystone.is_octavia_enabled.return_value \u003d False"},{"line_number":150,"context_line":"        self.assertRaises(exception.NotSupported,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f560f44_c9970190","line":147,"range":{"start_line":147,"start_character":48,"end_line":147,"end_character":61},"updated":"2020-08-21 20:56:04.000000000","message":"nit: its fedora-atomic with a hyphen correct?","commit_id":"3d6433b559da08d6c104e6beb3b8ec69b7b6df43"}],"releasenotes/notes/support-rotate-ca-certs-913a6ef1b571733c.yaml":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"e2f460d9c6b53864bfe4885fc3df87f2cd55b708","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Now k8s cluster owner can do CA cert rotate to re-generate CA of"},{"line_number":5,"context_line":"    the cluster, service account keys and the certs of all nodes will"},{"line_number":6,"context_line":"    be regenerated as well. Cluster user needs to get a new kubeconfig"},{"line_number":7,"context_line":"    to access kubernetes API. This function is only supported by"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_f2c66c48","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":29},"updated":"2020-05-14 08:53:23.000000000","message":"Kubernetes cluster owner can now","commit_id":"7a3d9f6a5520d70e2adb569ff1027298df870415"}]}