)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"c45cb916f5e3bb280945be8331d2b446f1cc6f8a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adding the master_lb_enabled option when creating a cluster,"},{"line_number":10,"context_line":"which will benefit both the cloud provider side and the end"},{"line_number":11,"context_line":"user side. For cloud prodiver, they don\u0027t have to maintain"},{"line_number":12,"context_line":"separated cluster templates with or w/o master_lb_enabled enabled."},{"line_number":13,"context_line":"For end user, they can easily use one single template to create"},{"line_number":14,"context_line":"different clusters with different configs."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bf51134e_265e11e6","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":9},"updated":"2020-07-03 09:10:28.000000000","message":"separate","commit_id":"66aa4dba5ffdc0db537d8dd5a22661607d543722"}],"contrib/drivers/heat/dcos_centos_template_def.py":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"2c29ce2b9d3bb3d202f632c685558b6823b0ab82","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        env_files \u003d []"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        template_def.add_priv_net_env_file(env_files, cluster)"},{"line_number":160,"context_line":"        template_def.add_lb_env_file(env_files, cluster_template, cluster)"},{"line_number":161,"context_line":"        template_def.add_fip_env_file(env_files, cluster_template, cluster)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        return env_files"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_6b65f7b4","line":160,"range":{"start_line":160,"start_character":48,"end_line":160,"end_character":74},"updated":"2020-07-15 09:22:22.000000000","message":"remove cluster_template","commit_id":"887a2059bf6eb2aa8d3c69be4cb0523c329ccb36"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"2c29ce2b9d3bb3d202f632c685558b6823b0ab82","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        template_def.add_priv_net_env_file(env_files, cluster)"},{"line_number":160,"context_line":"        template_def.add_lb_env_file(env_files, cluster_template, cluster)"},{"line_number":161,"context_line":"        template_def.add_fip_env_file(env_files, cluster_template, cluster)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        return env_files"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_cb56c3ce","line":161,"range":{"start_line":161,"start_character":49,"end_line":161,"end_character":65},"updated":"2020-07-15 09:22:22.000000000","message":"remove cluster_template","commit_id":"887a2059bf6eb2aa8d3c69be4cb0523c329ccb36"}],"magnum/drivers/heat/template_def.py":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"30d9d0611725111348de6ec2717f4ff6c091f4fe","unresolved":false,"context_lines":[{"line_number":534,"context_line":"        return dict()"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"def add_lb_env_file(env_files, cluster_template, cluster):"},{"line_number":538,"context_line":"    if cluster.master_lb_enabled:"},{"line_number":539,"context_line":"        if keystone.is_octavia_enabled():"},{"line_number":540,"context_line":"            env_files.append(COMMON_ENV_PATH + \u0027with_master_lb_octavia.yaml\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_46f22508","line":537,"range":{"start_line":537,"start_character":31,"end_line":537,"end_character":47},"updated":"2020-07-03 09:05:11.000000000","message":"cluster_template is no longer used in this function, why dont we just rename this to cluster?","commit_id":"66aa4dba5ffdc0db537d8dd5a22661607d543722"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"1c3d7f9e839c0945b601304126fb7e95d2d715da","unresolved":false,"context_lines":[{"line_number":534,"context_line":"        return dict()"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"def add_lb_env_file(env_files, cluster_template, cluster):"},{"line_number":538,"context_line":"    if cluster.master_lb_enabled:"},{"line_number":539,"context_line":"        if keystone.is_octavia_enabled():"},{"line_number":540,"context_line":"            env_files.append(COMMON_ENV_PATH + \u0027with_master_lb_octavia.yaml\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_720423c7","line":537,"range":{"start_line":537,"start_character":31,"end_line":537,"end_character":47},"in_reply_to":"bf51134e_46f22508","updated":"2020-07-06 22:30:45.000000000","message":"Because we may need it later though it may be not best practice in other languages, which will avoid changing several places again. But I agree we shouldn\u0027t leave the unused parameter there. I will fix it in the next ps.","commit_id":"66aa4dba5ffdc0db537d8dd5a22661607d543722"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"dd7813ef29932f246b053de86df26da7829a054b","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        env_files.append(COMMON_ENV_PATH + \u0027with_etcd_volume.yaml\u0027)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"def add_fip_env_file(env_files, cluster_template, cluster):"},{"line_number":566,"context_line":"    lb_fip_enabled \u003d cluster.labels.get(\"master_lb_floating_ip_enabled\")"},{"line_number":567,"context_line":"    master_lb_fip_enabled \u003d (strutils.bool_from_string(lb_fip_enabled) or"},{"line_number":568,"context_line":"                             cluster.floating_ip_enabled)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_a6bb410c","line":565,"range":{"start_line":565,"start_character":32,"end_line":565,"end_character":48},"updated":"2020-07-03 09:09:23.000000000","message":"hmm cluster_template is not used in this function either.","commit_id":"66aa4dba5ffdc0db537d8dd5a22661607d543722"}],"releasenotes/notes/add-master_lb_enabled-to-cluster-c773fac9086b2531.yaml":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"dd7813ef29932f246b053de86df26da7829a054b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    User can select enabled or disable master_lb_enabled when creating"},{"line_number":5,"context_line":"    a cluster."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_a65061d6","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":8},"updated":"2020-07-03 09:09:23.000000000","message":"Users","commit_id":"66aa4dba5ffdc0db537d8dd5a22661607d543722"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"dd7813ef29932f246b053de86df26da7829a054b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    User can select enabled or disable master_lb_enabled when creating"},{"line_number":5,"context_line":"    a cluster."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf51134e_66464924","line":4,"range":{"start_line":4,"start_character":13,"end_line":4,"end_character":19},"updated":"2020-07-03 09:09:23.000000000","message":"delete","commit_id":"66aa4dba5ffdc0db537d8dd5a22661607d543722"}]}