)]}'
{"magnum/drivers/common/templates/kubernetes/fragments/upgrade-kubernetes.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"1e6b346dad762a8373e2d6cf189520bdb51a75b5","unresolved":false,"context_lines":[{"line_number":128,"context_line":"remote_list\u003d`${ssh_cmd} ostree remote list`"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# NOTE(flwang): This part is only applicable for fedora atomic"},{"line_number":131,"context_line":"if [[ $current_ostree_remote \u003d\u003d *\"fedora-atomic\"* ]]; then"},{"line_number":132,"context_line":"    # Fedora Atomic 29 will be the last release before migrating to Fedora CoreOS, so we\u0027re OK to add 28 and 29 remotes directly"},{"line_number":133,"context_line":"    if [[ ! \" ${remote_list[@]} \" \u003d~ \"fedora-atomic-28\" ]]; then"},{"line_number":134,"context_line":"        ${ssh_cmd} ostree remote add --set\u003dgpgkeypath\u003d/etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-28-primary --contenturl\u003dmirrorlist\u003dhttps://ostree.fedoraproject.org/mirrorlist fedora-atomic-28 https://kojipkgs.fedoraproject.org/atomic/repo/"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ff570b3c_6d1fda5a","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":58},"updated":"2020-05-18 14:43:49.000000000","message":"looks like there is no need for this additional check because all the if statements are comparing against fedora-atomic-28, fedora-atomic-29 or fedora-atomic.","commit_id":"4085b87714b5bab5f799d6a39ab8ac2c630c796d"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"78a87e188017c18ce62d382a166f7b9bf2da40c2","unresolved":false,"context_lines":[{"line_number":128,"context_line":"remote_list\u003d`${ssh_cmd} ostree remote list`"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# NOTE(flwang): This part is only applicable for fedora atomic"},{"line_number":131,"context_line":"if [[ $current_ostree_remote \u003d\u003d *\"fedora-atomic\"* ]]; then"},{"line_number":132,"context_line":"    # Fedora Atomic 29 will be the last release before migrating to Fedora CoreOS, so we\u0027re OK to add 28 and 29 remotes directly"},{"line_number":133,"context_line":"    if [[ ! \" ${remote_list[@]} \" \u003d~ \"fedora-atomic-28\" ]]; then"},{"line_number":134,"context_line":"        ${ssh_cmd} ostree remote add --set\u003dgpgkeypath\u003d/etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-28-primary --contenturl\u003dmirrorlist\u003dhttps://ostree.fedoraproject.org/mirrorlist fedora-atomic-28 https://kojipkgs.fedoraproject.org/atomic/repo/"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ff570b3c_5e2ef091","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":58},"in_reply_to":"ff570b3c_6d1fda5a","updated":"2020-05-19 08:48:30.000000000","message":"Ah gotcha!","commit_id":"4085b87714b5bab5f799d6a39ab8ac2c630c796d"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"aa8c0fb009f75e282eafce28b0916196cd5ca563","unresolved":false,"context_lines":[{"line_number":128,"context_line":"remote_list\u003d`${ssh_cmd} ostree remote list`"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# NOTE(flwang): This part is only applicable for fedora atomic"},{"line_number":131,"context_line":"if [[ $current_ostree_remote \u003d\u003d *\"fedora-atomic\"* ]]; then"},{"line_number":132,"context_line":"    # Fedora Atomic 29 will be the last release before migrating to Fedora CoreOS, so we\u0027re OK to add 28 and 29 remotes directly"},{"line_number":133,"context_line":"    if [[ ! \" ${remote_list[@]} \" \u003d~ \"fedora-atomic-28\" ]]; then"},{"line_number":134,"context_line":"        ${ssh_cmd} ostree remote add --set\u003dgpgkeypath\u003d/etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-28-primary --contenturl\u003dmirrorlist\u003dhttps://ostree.fedoraproject.org/mirrorlist fedora-atomic-28 https://kojipkgs.fedoraproject.org/atomic/repo/"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ff570b3c_e3f76e8a","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":58},"in_reply_to":"ff570b3c_6d1fda5a","updated":"2020-05-19 04:18:56.000000000","message":"The \"if\" statements will check if the fedora atomic 28 or 29 is already in the remote list. So on Fedora CoreOS, the fedora atomic 28 and 29 remote info will be added, which are not suitable for Fedora CoreOS.","commit_id":"4085b87714b5bab5f799d6a39ab8ac2c630c796d"}]}