)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"e67ed4c92a12c03516f70dca86cef62767540604","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When resizing a NG we should strictly send the"},{"line_number":10,"context_line":"desired node_count and the nodes_to_remove."},{"line_number":11,"context_line":"Otherwise the stack update operation may replace/rebuild"},{"line_number":12,"context_line":"nodes or other resources."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This was the functionality with:"},{"line_number":15,"context_line":"Id84e5d878b21c908021e631514c2c58b3fe8b8b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_3f561608","line":12,"range":{"start_line":11,"start_character":37,"end_line":12,"end_character":25},"updated":"2020-05-26 16:54:39.000000000","message":"I chose to phrase the commit message like this because the issue we had, doesn\u0027t happen anymore.\n\nTo have peace of mind though, it is better to not send more parameters than the required ones.","commit_id":"5966accefeb6ff9245f6319dcda6b9ccede300c2"}],"magnum/drivers/heat/driver.py":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"808f29bdb9584de206ff2af9b448f1801541c078","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                                      resolve_outputs\u003dTrue)"},{"line_number":277,"context_line":"        stack_params \u003d stack.parameters"},{"line_number":278,"context_line":"        definition.add_nodegroup_params(cluster, nodegroups\u003d[nodegroup])"},{"line_number":279,"context_line":"        heat_params \u003d definition.get_stack_diff(context, stack_params, cluster)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        scale_params \u003d definition.get_scale_params(context,"},{"line_number":282,"context_line":"                                                   cluster,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_84b0b58d","side":"PARENT","line":279,"range":{"start_line":279,"start_character":8,"end_line":279,"end_character":79},"updated":"2020-05-26 16:47:46.000000000","message":"I don\u0027t think you need to reproduce, \n_resize_stack is meant to change the size of OS::Heat::ResourceGroup and nothing more, fetching a diff is not relevant here.","commit_id":"7ab504d1e2a0bf06d49d51bbef8853fd3f013743"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"569bad293b7435fd9a429ff8f4c7c98b283be4f2","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            cluster,"},{"line_number":271,"context_line":"            nodegroup.node_count,"},{"line_number":272,"context_line":"            resize_manager,"},{"line_number":273,"context_line":"            nodes_to_remove\u003dNone)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        fields \u003d {"},{"line_number":276,"context_line":"            \u0027parameters\u0027: scale_params,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_94632042","line":273,"range":{"start_line":273,"start_character":27,"end_line":273,"end_character":32},"updated":"2020-06-04 20:06:23.000000000","message":"this is wrong","commit_id":"e4e00442bf58f4b37472e3bb88ac89cfca7cce9b"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"885c1683f99891fa04f9f9c671b169366352e102","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            cluster,"},{"line_number":271,"context_line":"            nodegroup.node_count,"},{"line_number":272,"context_line":"            resize_manager,"},{"line_number":273,"context_line":"            nodes_to_remove\u003dNone)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        fields \u003d {"},{"line_number":276,"context_line":"            \u0027parameters\u0027: scale_params,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_78859a59","line":273,"range":{"start_line":273,"start_character":27,"end_line":273,"end_character":32},"in_reply_to":"ff570b3c_17d27200","updated":"2020-06-05 07:28:16.000000000","message":"yeap","commit_id":"e4e00442bf58f4b37472e3bb88ac89cfca7cce9b"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"da8e11418c668d317897a63a41d73615e869709e","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            cluster,"},{"line_number":271,"context_line":"            nodegroup.node_count,"},{"line_number":272,"context_line":"            resize_manager,"},{"line_number":273,"context_line":"            nodes_to_remove\u003dNone)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        fields \u003d {"},{"line_number":276,"context_line":"            \u0027parameters\u0027: scale_params,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_17d27200","line":273,"range":{"start_line":273,"start_character":27,"end_line":273,"end_character":32},"in_reply_to":"ff570b3c_94632042","updated":"2020-06-04 21:00:50.000000000","message":"This should get the value from line 265, is it?","commit_id":"e4e00442bf58f4b37472e3bb88ac89cfca7cce9b"}],"magnum/tests/unit/drivers/test_template_definition.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e7e88895286f878899e05196c0b81d68743cd6d8","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                                                   node_count,"},{"line_number":423,"context_line":"                                                   mock_scale_manager)"},{"line_number":424,"context_line":"        expected_scale_params \u003d {\u0027minions_to_remove\u0027: [\u0027node1\u0027, \u0027node2\u0027],"},{"line_number":425,"context_line":"                \u0027number_of_minions\u0027: 5}"},{"line_number":426,"context_line":"        self.assertEqual(scale_params, expected_scale_params)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    @mock.patch(\u0027magnum.drivers.heat.k8s_template_def.K8sTemplateDefinition\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_3ff29607","line":425,"updated":"2020-05-26 16:59:00.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"5966accefeb6ff9245f6319dcda6b9ccede300c2"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e7e88895286f878899e05196c0b81d68743cd6d8","unresolved":false,"context_lines":[{"line_number":2143,"context_line":"        mesos_def \u003d mesos_tdef.UbuntuMesosTemplateDefinition()"},{"line_number":2144,"context_line":""},{"line_number":2145,"context_line":"        scale_params \u003d mesos_def.get_scale_params(mock_context, mock_cluster,"},{"line_number":2146,"context_line":"                                                  node_count, mock_scale_manager)"},{"line_number":2147,"context_line":"        expected_scale_params \u003d {\u0027slaves_to_remove\u0027: [\u0027node1\u0027, \u0027node2\u0027],"},{"line_number":2148,"context_line":"                                 \u0027number_of_slaves\u0027: 7}"},{"line_number":2149,"context_line":"        self.assertEqual(scale_params, expected_scale_params)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_1ff7d2f7","line":2146,"updated":"2020-05-26 16:59:00.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"5966accefeb6ff9245f6319dcda6b9ccede300c2"}]}