)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"b6c27a363692f998807b8f07a5b7164780eaadfd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Feilong Wang \u003cflwang@catalyst.net.nz\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-03 23:25:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix label fixed_network_cidr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now the label `fixed_network_cidr` is not handled correctly, no matter"},{"line_number":10,"context_line":"if the label is set, the default value \u002710.0.0.0/24\u0027 is used for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ff570b3c_a359a85c","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":28},"updated":"2020-06-08 08:52:47.000000000","message":"fixed_subnet_cidr","commit_id":"2fcf844fd7de9ba44f7dee7d1b791cec14ebcc01"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"99cc8730dece2042437381cb7a9450273c5a99f3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Feilong Wang \u003cflwang@catalyst.net.nz\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-03 23:25:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix label fixed_network_cidr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now the label `fixed_network_cidr` is not handled correctly, no matter"},{"line_number":10,"context_line":"if the label is set, the default value \u002710.0.0.0/24\u0027 is used for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ff570b3c_ae806148","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":28},"in_reply_to":"ff570b3c_a359a85c","updated":"2020-06-08 21:37:47.000000000","message":"It\u0027s intentional because the current label name is \"fixed_network_cidr\" and we would like to fix it by this patch. So I think the title matches we\u0027re doing now :)","commit_id":"2fcf844fd7de9ba44f7dee7d1b791cec14ebcc01"}],"doc/source/user/index.rst":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"f5091a5b00e96104e017de7589cd950a6c89ae60","unresolved":false,"context_lines":[{"line_number":1637,"context_line":"  new fixed network/subnet for the cluster. If it is not"},{"line_number":1638,"context_line":"  set but a fixed subnet is passed in by user, then this label will be"},{"line_number":1639,"context_line":"  set with the CIDR of the passed in fixed subnet. If there is no fixed"},{"line_number":1640,"context_line":"  subnet passed in and this label is not set as well, then the default value"},{"line_number":1641,"context_line":"  will be set as \u002710.0.0.0/24\u0027 at the Heat template level."},{"line_number":1642,"context_line":""},{"line_number":1643,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"ff570b3c_ad67a7ea","line":1640,"range":{"start_line":1640,"start_character":45,"end_line":1640,"end_character":53},"updated":"2020-06-10 09:37:44.000000000","message":"nit: either","commit_id":"2fcf844fd7de9ba44f7dee7d1b791cec14ebcc01"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"f5091a5b00e96104e017de7589cd950a6c89ae60","unresolved":false,"context_lines":[{"line_number":1638,"context_line":"  set but a fixed subnet is passed in by user, then this label will be"},{"line_number":1639,"context_line":"  set with the CIDR of the passed in fixed subnet. If there is no fixed"},{"line_number":1640,"context_line":"  subnet passed in and this label is not set as well, then the default value"},{"line_number":1641,"context_line":"  will be set as \u002710.0.0.0/24\u0027 at the Heat template level."},{"line_number":1642,"context_line":""},{"line_number":1643,"context_line":""},{"line_number":1644,"context_line":"External load balancer for services"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ff570b3c_2d99d7cf","line":1641,"range":{"start_line":1641,"start_character":30,"end_line":1641,"end_character":57},"updated":"2020-06-10 09:37:44.000000000","message":"nit: unnecessary detail and this is not true either because we set \u002710.0.0.0/24\u0027 in template def level, the default set at heat template level is redundant :)","commit_id":"2fcf844fd7de9ba44f7dee7d1b791cec14ebcc01"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"25acbc2d3a10721876b3e5ec1c5cb28822f48382","unresolved":false,"context_lines":[{"line_number":1638,"context_line":"  set but a fixed subnet is passed in by user, then this label will be"},{"line_number":1639,"context_line":"  set with the CIDR of the passed in fixed subnet. If there is no fixed"},{"line_number":1640,"context_line":"  subnet passed in and this label is not set as well, then the default value"},{"line_number":1641,"context_line":"  will be set as \u002710.0.0.0/24\u0027 at the Heat template level."},{"line_number":1642,"context_line":""},{"line_number":1643,"context_line":""},{"line_number":1644,"context_line":"External load balancer for services"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ff570b3c_cd165bf2","line":1641,"range":{"start_line":1641,"start_character":30,"end_line":1641,"end_character":57},"in_reply_to":"ff570b3c_2d99d7cf","updated":"2020-06-10 09:44:34.000000000","message":"Should I remove the whole sentence?","commit_id":"2fcf844fd7de9ba44f7dee7d1b791cec14ebcc01"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"e34db79e1c34e7a1c9dd254943850ae7b0f99f6e","unresolved":false,"context_lines":[{"line_number":1638,"context_line":"  set but a fixed subnet is passed in by user, then this label will be"},{"line_number":1639,"context_line":"  set with the CIDR of the passed in fixed subnet. If there is no fixed"},{"line_number":1640,"context_line":"  subnet passed in and this label is not set as well, then the default value"},{"line_number":1641,"context_line":"  will be set as \u002710.0.0.0/24\u0027 at the Heat template level."},{"line_number":1642,"context_line":""},{"line_number":1643,"context_line":""},{"line_number":1644,"context_line":"External load balancer for services"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ff570b3c_ada04793","line":1641,"range":{"start_line":1641,"start_character":30,"end_line":1641,"end_character":57},"in_reply_to":"ff570b3c_cd165bf2","updated":"2020-06-10 09:51:27.000000000","message":"I prefer short and sweet documentation. Something like this would be sufficient.\n\nCIDR of the fixed subnet created by Magnum when a user has not specified an existing fixed_subnet during cluster creation.\nDefault: 10.0.0.0/24","commit_id":"2fcf844fd7de9ba44f7dee7d1b791cec14ebcc01"}]}