)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"2a21c4a8ee2b3226ece48dec34041982a0016d8a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"1.18.x (e.g. ussuri-dev) fail because they do not have the correct"},{"line_number":11,"context_line":"KUBECONFIG in the environment."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also unset options set in the script at the end of the script."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Task: 39938"},{"line_number":16,"context_line":"Story: 2007591"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_d893e25b","line":13,"updated":"2020-06-15 09:52:16.000000000","message":"Could we do that in another patch?\n\nKeep this patch only for the shebang?","commit_id":"fd178a1d315351e138f32f9ef282c853cdea5dfa"}],"magnum/drivers/common/templates/kubernetes/fragments/add-proxy.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"36268f73d0e41eb9d95b653f9f5e30a9da202ff7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"step\u003d\"add-proxy\""},{"line_number":2,"context_line":"printf \"Starting to run ${step}\\n\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":". /etc/sysconfig/heat-params"},{"line_number":5,"context_line":"set -x"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":8,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff570b3c_c59da0bc","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":6},"updated":"2020-06-09 15:08:11.000000000","message":"why not wrapping all set cmds around heat params?","commit_id":"fd178a1d315351e138f32f9ef282c853cdea5dfa"}],"magnum/drivers/common/templates/kubernetes/fragments/calico-service-v3-3-x.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"04b41709ad5ffe6991cbb24fdb669ac4fc2492da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"step\u003d\"calico-service-v3-3-x\""},{"line_number":4,"context_line":"printf \"Starting to run ${step}\\n\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff570b3c_c3164356","line":1,"updated":"2020-06-09 15:06:19.000000000","message":"this will stay here for atomic?","commit_id":"fd178a1d315351e138f32f9ef282c853cdea5dfa"}],"magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-master.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"a730f8e3a6465b10e6a0ab877089df484835a88b","unresolved":false,"context_lines":[{"line_number":403,"context_line":"echo \"export KUBECONFIG\u003d${ADMIN_KUBECONFIG}\" \u003e\u003e /etc/bashrc"},{"line_number":404,"context_line":"chown root:root ${ADMIN_KUBECONFIG}"},{"line_number":405,"context_line":"chmod 600 ${ADMIN_KUBECONFIG}"},{"line_number":406,"context_line":"export KUBECONFIG\u003d${ADMIN_KUBECONFIG}"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"# Add controller manager args"},{"line_number":409,"context_line":"KUBE_CONTROLLER_MANAGER_ARGS\u003d\"--leader-elect\u003dtrue\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"bf51134e_8df8e0c4","line":406,"updated":"2020-06-17 11:00:31.000000000","message":"is this required?","commit_id":"799563eb613855c340727c6b87c2e1ddd490aae3"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"4be4f888875c7ce1636ccb3a337fc3bf286113e3","unresolved":false,"context_lines":[{"line_number":403,"context_line":"echo \"export KUBECONFIG\u003d${ADMIN_KUBECONFIG}\" \u003e\u003e /etc/bashrc"},{"line_number":404,"context_line":"chown root:root ${ADMIN_KUBECONFIG}"},{"line_number":405,"context_line":"chmod 600 ${ADMIN_KUBECONFIG}"},{"line_number":406,"context_line":"export KUBECONFIG\u003d${ADMIN_KUBECONFIG}"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"# Add controller manager args"},{"line_number":409,"context_line":"KUBE_CONTROLLER_MANAGER_ARGS\u003d\"--leader-elect\u003dtrue\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"bf51134e_9012b357","line":406,"in_reply_to":"bf51134e_4dea4875","updated":"2020-06-17 11:36:59.000000000","message":"Yes, its the kubectl command to label master node which fails.","commit_id":"799563eb613855c340727c6b87c2e1ddd490aae3"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"60b49ccece312949d44a75a4ee9e44d00b2e2176","unresolved":false,"context_lines":[{"line_number":403,"context_line":"echo \"export KUBECONFIG\u003d${ADMIN_KUBECONFIG}\" \u003e\u003e /etc/bashrc"},{"line_number":404,"context_line":"chown root:root ${ADMIN_KUBECONFIG}"},{"line_number":405,"context_line":"chmod 600 ${ADMIN_KUBECONFIG}"},{"line_number":406,"context_line":"export KUBECONFIG\u003d${ADMIN_KUBECONFIG}"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"# Add controller manager args"},{"line_number":409,"context_line":"KUBE_CONTROLLER_MANAGER_ARGS\u003d\"--leader-elect\u003dtrue\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"bf51134e_ad732415","line":406,"in_reply_to":"bf51134e_8df8e0c4","updated":"2020-06-17 11:19:47.000000000","message":"With train-stable-3/ussuri-stable-1/victoria-dev tags no because they default to using kubectl 1.15 installed in the HCA container. With ussuri-dev, yes which defaults to using kubectl 1.18.","commit_id":"799563eb613855c340727c6b87c2e1ddd490aae3"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"e9a0f6189676b10279f425ce0c6e7288e73f59b5","unresolved":false,"context_lines":[{"line_number":403,"context_line":"echo \"export KUBECONFIG\u003d${ADMIN_KUBECONFIG}\" \u003e\u003e /etc/bashrc"},{"line_number":404,"context_line":"chown root:root ${ADMIN_KUBECONFIG}"},{"line_number":405,"context_line":"chmod 600 ${ADMIN_KUBECONFIG}"},{"line_number":406,"context_line":"export KUBECONFIG\u003d${ADMIN_KUBECONFIG}"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"# Add controller manager args"},{"line_number":409,"context_line":"KUBE_CONTROLLER_MANAGER_ARGS\u003d\"--leader-elect\u003dtrue\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"bf51134e_4dea4875","line":406,"in_reply_to":"bf51134e_ad732415","updated":"2020-06-17 11:23:22.000000000","message":"I guess https://review.opendev.org/#/c/732524/8/magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-master.sh@403\n\nis not exported on time","commit_id":"799563eb613855c340727c6b87c2e1ddd490aae3"}],"magnum/drivers/common/templates/kubernetes/fragments/enable-cert-api-manager.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"e0e2bc0d89b57365be7bad76a702eb967febcb3a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"step\u003d\"enable-cert-api-manager\""},{"line_number":2,"context_line":"printf \"Starting to run ${step}\\n\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":". /etc/sysconfig/heat-params"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [ \"$(echo \"${CERT_MANAGER_API}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff570b3c_85456846","line":3,"updated":"2020-06-09 15:06:46.000000000","message":"set is missing here","commit_id":"fd178a1d315351e138f32f9ef282c853cdea5dfa"}]}