)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"2e17628cc7974cf67a68ba64faca805b55affb4e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"NO_PROXY list."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Task: 39916"},{"line_number":19,"context_line":"Story: 2006459"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I4dba79e04abe38b9806e847348d3dd77ef96bee5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff570b3c_14d457e8","line":19,"updated":"2020-06-03 08:06:45.000000000","message":"why this story?\n\nmakes little sense this is part from proxy and security group adventures.","commit_id":"3da87308b5585f475f0722b787d4525aa5663202"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"071cc0ce18b34de1d7c01c7a3c552294525e84bf","unresolved":false,"context_lines":[{"line_number":16,"context_line":"NO_PROXY list."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Task: 39916"},{"line_number":19,"context_line":"Story: 2006459"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I4dba79e04abe38b9806e847348d3dd77ef96bee5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff570b3c_d43bff34","line":19,"in_reply_to":"ff570b3c_14d457e8","updated":"2020-06-03 08:10:28.000000000","message":"Wrong one. I want to use the podman story, because the proxy worked for atomic but not fedora coreOS with podman. I will update it in next ps.","commit_id":"3da87308b5585f475f0722b787d4525aa5663202"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"468146d4e747716213f474a510579e8bb4bf2428","unresolved":false,"context_lines":[{"line_number":16,"context_line":"NO_PROXY list."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Task: 39916"},{"line_number":19,"context_line":"Story: 2006459"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I4dba79e04abe38b9806e847348d3dd77ef96bee5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff570b3c_945d077b","line":19,"in_reply_to":"ff570b3c_d43bff34","updated":"2020-06-03 08:17:44.000000000","message":"Checked again. I think this is the story I\u0027d like to use initially because it\u0027s caused by the upgrading to podman. If you prefer to track with a separate one, I\u0027m happy to create a new one.","commit_id":"3da87308b5585f475f0722b787d4525aa5663202"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"ae37d50e0d081cd419cd7d01e519a508f0cffcee","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix proxy issue for etcd and k8s"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the cloud behind a proxy, podman needs to access the dockerhub"},{"line_number":10,"context_line":"via proxy to pull the image, so the proxy settings need to be export"},{"line_number":11,"context_line":"to etcd systemd file as well. We\u0027re setting the heat-params as"},{"line_number":12,"context_line":"environment file for k8s components already."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ff570b3c_d006cb21","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":14},"updated":"2020-06-12 08:41:15.000000000","message":"When the cloud is","commit_id":"88bd9105a7a30784e34bd336b7b493c19bdd48ea"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"ae37d50e0d081cd419cd7d01e519a508f0cffcee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix proxy issue for etcd and k8s"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the cloud behind a proxy, podman needs to access the dockerhub"},{"line_number":10,"context_line":"via proxy to pull the image, so the proxy settings need to be export"},{"line_number":11,"context_line":"to etcd systemd file as well. We\u0027re setting the heat-params as"},{"line_number":12,"context_line":"environment file for k8s components already."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ff570b3c_10016307","line":10,"range":{"start_line":10,"start_character":62,"end_line":10,"end_character":68},"updated":"2020-06-12 08:41:15.000000000","message":"exported","commit_id":"88bd9105a7a30784e34bd336b7b493c19bdd48ea"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"ae37d50e0d081cd419cd7d01e519a508f0cffcee","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to etcd systemd file as well. We\u0027re setting the heat-params as"},{"line_number":12,"context_line":"environment file for k8s components already."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Besides, because CIDR of fixed subnet are vary for different clusters,"},{"line_number":15,"context_line":"so the subnet CIDR should be added into NO_PROXY list. Otherwise,"},{"line_number":16,"context_line":"it will affect the communication between etcd members and also the"},{"line_number":17,"context_line":"communication between k8s components."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ff570b3c_4b004c01","line":14,"range":{"start_line":14,"start_character":38,"end_line":14,"end_character":41},"updated":"2020-06-12 08:41:15.000000000","message":"delete","commit_id":"88bd9105a7a30784e34bd336b7b493c19bdd48ea"}],"magnum/drivers/heat/k8s_template_def.py":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"a073aeda964da74d8dc9d68ffc23087ee6bd14ab","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                context, subnet_id, \"id\", \"cidr\")"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        extra_noproxy \u003d (self.default_subnet_cidr if not"},{"line_number":210,"context_line":"                         extra_params.get(\u0027fixed_network_cidr\u0027) else"},{"line_number":211,"context_line":"                         extra_params.get(\u0027fixed_network_cidr\u0027))"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        if cluster_template.no_proxy:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_51d7014c","line":210,"range":{"start_line":210,"start_character":43,"end_line":210,"end_character":61},"updated":"2020-06-03 05:53:42.000000000","message":"Subnet","commit_id":"3da87308b5585f475f0722b787d4525aa5663202"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"b9168f2d29ca8daaa90e69e4d23d70827eb7bc5f","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                context, subnet_id, \"id\", \"cidr\")"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        extra_noproxy \u003d (self.default_subnet_cidr if not"},{"line_number":210,"context_line":"                         extra_params.get(\u0027fixed_network_cidr\u0027) else"},{"line_number":211,"context_line":"                         extra_params.get(\u0027fixed_network_cidr\u0027))"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        if cluster_template.no_proxy:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_d4d93f83","line":210,"range":{"start_line":210,"start_character":43,"end_line":210,"end_character":61},"in_reply_to":"ff570b3c_51d7014c","updated":"2020-06-03 07:44:56.000000000","message":"Will fix it in next ps :)","commit_id":"3da87308b5585f475f0722b787d4525aa5663202"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"133b4357c9a160d0ee419e2e8464881c2a64e220","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            extra_params[\u0027fixed_subnet_cidr\u0027] \u003d neutron.get_subnet("},{"line_number":207,"context_line":"                context, subnet_id, \"id\", \"cidr\")"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        extra_noproxy \u003d (self.default_subnet_cidr if not"},{"line_number":210,"context_line":"                         extra_params.get(\u0027fixed_subnet_cidr\u0027) else"},{"line_number":211,"context_line":"                         extra_params.get(\u0027fixed_subnet_cidr\u0027))"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        if cluster_template.no_proxy:"},{"line_number":214,"context_line":"            extra_params[\"no_proxy\"] \u003d (cluster_template.no_proxy + \",\" +"},{"line_number":215,"context_line":"                                        extra_noproxy)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        return extra_params"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_efd0ecf9","line":215,"range":{"start_line":209,"start_character":0,"end_line":215,"end_character":54},"updated":"2020-06-03 08:54:01.000000000","message":"are these changes related to podman?","commit_id":"e33cb1f865479a1e204f25d8947da8a43fcadd5b"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"32e011ca2fdb609cd9a19115cb557d1bc40fe3fc","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            extra_params[\u0027fixed_subnet_cidr\u0027] \u003d neutron.get_subnet("},{"line_number":207,"context_line":"                context, subnet_id, \"id\", \"cidr\")"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        extra_noproxy \u003d (self.default_subnet_cidr if not"},{"line_number":210,"context_line":"                         extra_params.get(\u0027fixed_subnet_cidr\u0027) else"},{"line_number":211,"context_line":"                         extra_params.get(\u0027fixed_subnet_cidr\u0027))"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        if cluster_template.no_proxy:"},{"line_number":214,"context_line":"            extra_params[\"no_proxy\"] \u003d (cluster_template.no_proxy + \",\" +"},{"line_number":215,"context_line":"                                        extra_noproxy)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        return extra_params"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_8ab95e7a","line":215,"range":{"start_line":209,"start_character":0,"end_line":215,"end_character":54},"in_reply_to":"ff570b3c_efd0ecf9","updated":"2020-06-03 10:01:01.000000000","message":"No, they\u0027re only related to proxy. But it is because of the upgrade from atomic system container to podman.","commit_id":"e33cb1f865479a1e204f25d8947da8a43fcadd5b"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"b5e495bb601954d0e28518285dbe36f5215391f0","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            # setting."},{"line_number":206,"context_line":"            extra_params[\u0027fixed_subnet_cidr\u0027] \u003d neutron.get_subnet("},{"line_number":207,"context_line":"                context, subnet_id, \"id\", \"cidr\")"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        extra_noproxy \u003d (self.default_subnet_cidr if not"},{"line_number":210,"context_line":"                         extra_params.get(\u0027fixed_subnet_cidr\u0027) else"},{"line_number":211,"context_line":"                         extra_params.get(\u0027fixed_subnet_cidr\u0027))"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        if cluster_template.no_proxy:"},{"line_number":214,"context_line":"            extra_params[\"no_proxy\"] \u003d (cluster_template.no_proxy + \",\" +"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_10284395","line":211,"range":{"start_line":208,"start_character":0,"end_line":211,"end_character":63},"updated":"2020-06-12 08:38:38.000000000","message":"delete. why compute extra_noproxy even when cluster_template.no_proxy is undefined?","commit_id":"88bd9105a7a30784e34bd336b7b493c19bdd48ea"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"b5e495bb601954d0e28518285dbe36f5215391f0","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                         extra_params.get(\u0027fixed_subnet_cidr\u0027))"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        if cluster_template.no_proxy:"},{"line_number":214,"context_line":"            extra_params[\"no_proxy\"] \u003d (cluster_template.no_proxy + \",\" +"},{"line_number":215,"context_line":"                                        extra_noproxy)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        return extra_params"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_d01d2b78","line":215,"range":{"start_line":214,"start_character":0,"end_line":215,"end_character":54},"updated":"2020-06-12 08:38:38.000000000","message":"extra_params[\"no_proxy\"] \u003d (cluster_template.no_proxy + \",\" +\n                                        extra_params.get(\u0027fixed_subnet_cidr\u0027) if\n                         extra_params.get(\u0027fixed_subnet_cidr\u0027) else\n                         self.default_subnet_cidr)","commit_id":"88bd9105a7a30784e34bd336b7b493c19bdd48ea"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c70dd088f8912cf8874cb94254aa3fade73f63f3","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        if cluster_template.no_proxy:"},{"line_number":210,"context_line":"            extra_params[\"no_proxy\"] \u003d ("},{"line_number":211,"context_line":"                cluster_template.no_proxy + \",\" + (self.default_subnet_cidr"},{"line_number":212,"context_line":"                if not extra_params.get(\u0027fixed_subnet_cidr\u0027) else"},{"line_number":213,"context_line":"                extra_params.get(\u0027fixed_subnet_cidr\u0027)))"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        return extra_params"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf51134e_ad235505","line":212,"updated":"2020-06-15 05:06:16.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"c5da7de1323ca1261b927749a7b05f84cbb49809"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c70dd088f8912cf8874cb94254aa3fade73f63f3","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            extra_params[\"no_proxy\"] \u003d ("},{"line_number":211,"context_line":"                cluster_template.no_proxy + \",\" + (self.default_subnet_cidr"},{"line_number":212,"context_line":"                if not extra_params.get(\u0027fixed_subnet_cidr\u0027) else"},{"line_number":213,"context_line":"                extra_params.get(\u0027fixed_subnet_cidr\u0027)))"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        return extra_params"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bf51134e_0d21a1fc","line":213,"updated":"2020-06-15 05:06:16.000000000","message":"pep8: E122 continuation line missing indentation or outdented","commit_id":"c5da7de1323ca1261b927749a7b05f84cbb49809"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"d7c8e7300a6d328931280f4bf755d0fa670859fb","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        if cluster_template.no_proxy:"},{"line_number":210,"context_line":"            extra_params[\"no_proxy\"] \u003d ("},{"line_number":211,"context_line":"                cluster_template.no_proxy + \",\" + ("},{"line_number":212,"context_line":"                    self.default_subnet_cidr if not"},{"line_number":213,"context_line":"                    extra_params.get(\u0027fixed_subnet_cidr\u0027) else"},{"line_number":214,"context_line":"                    extra_params.get(\u0027fixed_subnet_cidr\u0027)))"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        return extra_params"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bf51134e_57f82ac3","line":214,"range":{"start_line":212,"start_character":20,"end_line":214,"end_character":59},"updated":"2020-06-16 10:50:30.000000000","message":"This should be enough here:\n\n    (extra_params.get(\u0027fixed_subnet_cidr\u0027) or self.default_subnet_cidr)","commit_id":"15d15e98f4cae29ae2a81e178fe2f6c2e7a0d158"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"ff171dd4896df7973cfd21a4eb1924feb4fa5efb","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        if cluster_template.no_proxy:"},{"line_number":210,"context_line":"            extra_params[\"no_proxy\"] \u003d ("},{"line_number":211,"context_line":"                cluster_template.no_proxy + \",\" + ("},{"line_number":212,"context_line":"                    self.default_subnet_cidr if not"},{"line_number":213,"context_line":"                    extra_params.get(\u0027fixed_subnet_cidr\u0027) else"},{"line_number":214,"context_line":"                    extra_params.get(\u0027fixed_subnet_cidr\u0027)))"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        return extra_params"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bf51134e_ed887c72","line":214,"range":{"start_line":212,"start_character":20,"end_line":214,"end_character":59},"in_reply_to":"bf51134e_57f82ac3","updated":"2020-06-17 10:53:04.000000000","message":"omg python. Both syntaxes make me cry","commit_id":"15d15e98f4cae29ae2a81e178fe2f6c2e7a0d158"}]}