)]}'
{"magnum/api/controllers/v1/cluster.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"bd3b28ef47fd87fcbbaa91adf261d9b8257dae29","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        # which includes non-default nodegroups. However cluster_update expects"},{"line_number":635,"context_line":"        # node_count to be the size of the default_ng_worker therefore return"},{"line_number":636,"context_line":"        # this value unless the patch object says otherwise."},{"line_number":637,"context_line":"        node_count \u003d cluster.default_ng_worker.node_count"},{"line_number":638,"context_line":"        for p in patch:"},{"line_number":639,"context_line":"            if p[\u0027path\u0027] \u003d\u003d \u0027/node_count\u0027:"},{"line_number":640,"context_line":"                node_count \u003d p.get(\u0027value\u0027) or new_cluster.node_count"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_d128f4e2","line":637,"updated":"2020-06-05 20:31:22.000000000","message":"Could you please add a test case?","commit_id":"7c56d9b2528f5acf445a685434536ac8c79c6a4c"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"e4b4ededcb66abd3ca07f1791b1a61da8d3a2e72","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        # which includes non-default nodegroups. However cluster_update expects"},{"line_number":635,"context_line":"        # node_count to be the size of the default_ng_worker therefore return"},{"line_number":636,"context_line":"        # this value unless the patch object says otherwise."},{"line_number":637,"context_line":"        node_count \u003d cluster.default_ng_worker.node_count"},{"line_number":638,"context_line":"        for p in patch:"},{"line_number":639,"context_line":"            if p[\u0027path\u0027] \u003d\u003d \u0027/node_count\u0027:"},{"line_number":640,"context_line":"                node_count \u003d p.get(\u0027value\u0027) or new_cluster.node_count"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_e6a3b941","line":637,"in_reply_to":"ff570b3c_d128f4e2","updated":"2020-06-06 03:16:55.000000000","message":"I understand it sounds like wasting time to add a test for this. But my point is as long as it\u0027s supported, we need to make sure it works. And it would be nice if you can add a document somewhere to clarify that the node count update will only affect the default-worker node group. Thanks.","commit_id":"7c56d9b2528f5acf445a685434536ac8c79c6a4c"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"b6d20146c9b0b91b7163f6d87a16892931014197","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        # which includes non-default nodegroups. However cluster_update expects"},{"line_number":635,"context_line":"        # node_count to be the size of the default_ng_worker therefore return"},{"line_number":636,"context_line":"        # this value unless the patch object says otherwise."},{"line_number":637,"context_line":"        node_count \u003d cluster.default_ng_worker.node_count"},{"line_number":638,"context_line":"        for p in patch:"},{"line_number":639,"context_line":"            if p[\u0027path\u0027] \u003d\u003d \u0027/node_count\u0027:"},{"line_number":640,"context_line":"                node_count \u003d p.get(\u0027value\u0027) or new_cluster.node_count"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_a3c9a87a","line":637,"in_reply_to":"ff570b3c_e6a3b941","updated":"2020-06-08 08:20:19.000000000","message":"Done","commit_id":"7c56d9b2528f5acf445a685434536ac8c79c6a4c"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"bd3b28ef47fd87fcbbaa91adf261d9b8257dae29","unresolved":false,"context_lines":[{"line_number":639,"context_line":"            if p[\u0027path\u0027] \u003d\u003d \u0027/node_count\u0027:"},{"line_number":640,"context_line":"                node_count \u003d p.get(\u0027value\u0027) or new_cluster.node_count"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        return (cluster, node_count,"},{"line_number":643,"context_line":"                new_cluster.health_status, new_cluster.health_status_reason)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    @expose.expose(None, types.uuid_or_name, status_code\u003d204)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_312fb0f6","line":642,"updated":"2020-06-05 20:31:22.000000000","message":"If I understand correctly, we can\u0027t support nodegroup for node_count update via the update API, but only update the default-worker. If that\u0027s the case, after this one in. I\u0027d like to deprecate the node_count update soon. Because now this API doesn\u0027t make much sense anymore. I will add a deprecation note in V and remove this support after 2 cycles. Thoughts?","commit_id":"7c56d9b2528f5acf445a685434536ac8c79c6a4c"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"b6d20146c9b0b91b7163f6d87a16892931014197","unresolved":false,"context_lines":[{"line_number":639,"context_line":"            if p[\u0027path\u0027] \u003d\u003d \u0027/node_count\u0027:"},{"line_number":640,"context_line":"                node_count \u003d p.get(\u0027value\u0027) or new_cluster.node_count"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        return (cluster, node_count,"},{"line_number":643,"context_line":"                new_cluster.health_status, new_cluster.health_status_reason)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    @expose.expose(None, types.uuid_or_name, status_code\u003d204)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_c3cc9c8c","line":642,"in_reply_to":"ff570b3c_312fb0f6","updated":"2020-06-08 08:20:19.000000000","message":"Done","commit_id":"7c56d9b2528f5acf445a685434536ac8c79c6a4c"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"9ccbdd1bf3b1a4771afafac30d659be6daa1c15f","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        # which includes non-default nodegroups. However cluster_update expects"},{"line_number":635,"context_line":"        # node_count to be the size of the default_ng_worker therefore return"},{"line_number":636,"context_line":"        # this value unless the patch object says otherwise."},{"line_number":637,"context_line":"        node_count \u003d cluster.default_ng_worker.node_count"},{"line_number":638,"context_line":"        for p in patch:"},{"line_number":639,"context_line":"            if p[\u0027path\u0027] \u003d\u003d \u0027/node_count\u0027:"},{"line_number":640,"context_line":"                node_count \u003d p.get(\u0027value\u0027) or new_cluster.node_count"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_8c645023","line":637,"updated":"2020-06-11 09:55:53.000000000","message":"Shall we return 401 if the cluster has more than the default ng?","commit_id":"0bb6c232188d95a0175557b779a0ad69051a4fad"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"44654cbec65bcab0ed0752522e396ae8e9390622","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        # which includes non-default nodegroups. However cluster_update expects"},{"line_number":635,"context_line":"        # node_count to be the size of the default_ng_worker therefore return"},{"line_number":636,"context_line":"        # this value unless the patch object says otherwise."},{"line_number":637,"context_line":"        node_count \u003d cluster.default_ng_worker.node_count"},{"line_number":638,"context_line":"        for p in patch:"},{"line_number":639,"context_line":"            if p[\u0027path\u0027] \u003d\u003d \u0027/node_count\u0027:"},{"line_number":640,"context_line":"                node_count \u003d p.get(\u0027value\u0027) or new_cluster.node_count"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_bf105802","line":637,"in_reply_to":"ff570b3c_1fad04ea","updated":"2020-06-11 10:24:04.000000000","message":"Hmm let me think about this. Doesn\u0027t that break the API? We have a number of other things where default-worker is the default target.","commit_id":"0bb6c232188d95a0175557b779a0ad69051a4fad"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"790eda392ee8458461d09e221df341763c385f92","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        # which includes non-default nodegroups. However cluster_update expects"},{"line_number":635,"context_line":"        # node_count to be the size of the default_ng_worker therefore return"},{"line_number":636,"context_line":"        # this value unless the patch object says otherwise."},{"line_number":637,"context_line":"        node_count \u003d cluster.default_ng_worker.node_count"},{"line_number":638,"context_line":"        for p in patch:"},{"line_number":639,"context_line":"            if p[\u0027path\u0027] \u003d\u003d \u0027/node_count\u0027:"},{"line_number":640,"context_line":"                node_count \u003d p.get(\u0027value\u0027) or new_cluster.node_count"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_bf7178ab","line":637,"in_reply_to":"ff570b3c_8c645023","updated":"2020-06-11 10:06:32.000000000","message":"Hmm return 401 even for health updates?","commit_id":"0bb6c232188d95a0175557b779a0ad69051a4fad"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"2e400cb5a1c05df446799be64c0028bd7d173adf","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        # which includes non-default nodegroups. However cluster_update expects"},{"line_number":635,"context_line":"        # node_count to be the size of the default_ng_worker therefore return"},{"line_number":636,"context_line":"        # this value unless the patch object says otherwise."},{"line_number":637,"context_line":"        node_count \u003d cluster.default_ng_worker.node_count"},{"line_number":638,"context_line":"        for p in patch:"},{"line_number":639,"context_line":"            if p[\u0027path\u0027] \u003d\u003d \u0027/node_count\u0027:"},{"line_number":640,"context_line":"                node_count \u003d p.get(\u0027value\u0027) or new_cluster.node_count"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_9fbab4de","line":637,"in_reply_to":"ff570b3c_bf105802","updated":"2020-06-11 10:28:46.000000000","message":"ok, doesn\u0027t matter, let\u0027s merge with reno.","commit_id":"0bb6c232188d95a0175557b779a0ad69051a4fad"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"803b6eb0ac995c32dfe0d8a2a08777da6c6d873a","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        # which includes non-default nodegroups. However cluster_update expects"},{"line_number":635,"context_line":"        # node_count to be the size of the default_ng_worker therefore return"},{"line_number":636,"context_line":"        # this value unless the patch object says otherwise."},{"line_number":637,"context_line":"        node_count \u003d cluster.default_ng_worker.node_count"},{"line_number":638,"context_line":"        for p in patch:"},{"line_number":639,"context_line":"            if p[\u0027path\u0027] \u003d\u003d \u0027/node_count\u0027:"},{"line_number":640,"context_line":"                node_count \u003d p.get(\u0027value\u0027) or new_cluster.node_count"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_1fad04ea","line":637,"in_reply_to":"ff570b3c_bf7178ab","updated":"2020-06-11 10:07:54.000000000","message":"No. For Updating node_count when the cluster has additional NGs.","commit_id":"0bb6c232188d95a0175557b779a0ad69051a4fad"}]}