)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"0fd33d703d37ec1b81bccacd6d11531b2d2a0d60","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are two issues with current k8s admission controller list:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1. The default existing list are not concistent when user passing"},{"line_number":12,"context_line":"in extra controller or not"},{"line_number":13,"context_line":"2. The existing list is out of date."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_b13aa230","line":11,"range":{"start_line":11,"start_character":37,"end_line":11,"end_character":47},"updated":"2020-09-01 11:40:04.000000000","message":"consistent","commit_id":"d31b81b3a0b7eac6e6f71718a9b2f71ebd0c3286"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"f8540008c582fc10f4c3c6e687bb8b5107491b84","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are two issues with current k8s admission controller list:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1. The default existing list are not consistent when user passing"},{"line_number":12,"context_line":"in extra controller or not"},{"line_number":13,"context_line":"2. The existing list is out of date."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_464ad726","line":11,"range":{"start_line":11,"start_character":29,"end_line":11,"end_character":32},"updated":"2020-09-07 05:44:14.000000000","message":"is","commit_id":"1b533ce2eaa3631afb45c0a9b2008bf4e6d4d665"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"f8540008c582fc10f4c3c6e687bb8b5107491b84","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are two issues with current k8s admission controller list:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1. The default existing list are not consistent when user passing"},{"line_number":12,"context_line":"in extra controller or not"},{"line_number":13,"context_line":"2. The existing list is out of date."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_2647e31f","line":11,"range":{"start_line":11,"start_character":58,"end_line":11,"end_character":65},"updated":"2020-09-07 05:44:14.000000000","message":"passes","commit_id":"1b533ce2eaa3631afb45c0a9b2008bf4e6d4d665"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"f8540008c582fc10f4c3c6e687bb8b5107491b84","unresolved":false,"context_lines":[{"line_number":13,"context_line":"2. The existing list is out of date."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The new list are based on below consideration:"},{"line_number":16,"context_line":"1. Got the default list based on k8s v1.16.x because it\u0027s the"},{"line_number":17,"context_line":"supported oldest version."},{"line_number":18,"context_line":"2. Keep it consistent when user passing in extra controllers or not"},{"line_number":19,"context_line":"3. Keep all the admission controllers we has been used in the code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_063d7f8d","line":16,"range":{"start_line":16,"start_character":3,"end_line":16,"end_character":6},"updated":"2020-09-07 05:44:14.000000000","message":"Get","commit_id":"1b533ce2eaa3631afb45c0a9b2008bf4e6d4d665"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"f8540008c582fc10f4c3c6e687bb8b5107491b84","unresolved":false,"context_lines":[{"line_number":13,"context_line":"2. The existing list is out of date."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The new list are based on below consideration:"},{"line_number":16,"context_line":"1. Got the default list based on k8s v1.16.x because it\u0027s the"},{"line_number":17,"context_line":"supported oldest version."},{"line_number":18,"context_line":"2. Keep it consistent when user passing in extra controllers or not"},{"line_number":19,"context_line":"3. Keep all the admission controllers we has been used in the code"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_46c5b78d","line":17,"range":{"start_line":16,"start_character":3,"end_line":17,"end_character":25},"updated":"2020-09-07 05:44:14.000000000","message":"can you reference the source?","commit_id":"1b533ce2eaa3631afb45c0a9b2008bf4e6d4d665"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"f8540008c582fc10f4c3c6e687bb8b5107491b84","unresolved":false,"context_lines":[{"line_number":15,"context_line":"The new list are based on below consideration:"},{"line_number":16,"context_line":"1. Got the default list based on k8s v1.16.x because it\u0027s the"},{"line_number":17,"context_line":"supported oldest version."},{"line_number":18,"context_line":"2. Keep it consistent when user passing in extra controllers or not"},{"line_number":19,"context_line":"3. Keep all the admission controllers we has been used in the code"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Task: 40767"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_a63bf399","line":18,"range":{"start_line":18,"start_character":32,"end_line":18,"end_character":39},"updated":"2020-09-07 05:44:14.000000000","message":"passes","commit_id":"1b533ce2eaa3631afb45c0a9b2008bf4e6d4d665"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"f8540008c582fc10f4c3c6e687bb8b5107491b84","unresolved":false,"context_lines":[{"line_number":16,"context_line":"1. Got the default list based on k8s v1.16.x because it\u0027s the"},{"line_number":17,"context_line":"supported oldest version."},{"line_number":18,"context_line":"2. Keep it consistent when user passing in extra controllers or not"},{"line_number":19,"context_line":"3. Keep all the admission controllers we has been used in the code"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Task: 40767"},{"line_number":22,"context_line":"Story: 2008076"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_66b8bb10","line":19,"range":{"start_line":19,"start_character":41,"end_line":19,"end_character":49},"updated":"2020-09-07 05:44:14.000000000","message":"have","commit_id":"1b533ce2eaa3631afb45c0a9b2008bf4e6d4d665"}],"magnum/drivers/common/templates/kubernetes/fragments/configure-kubernetes-master.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"3277182db27f7f99f284d2d509bc5f9679d72556","unresolved":false,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":"KUBE_ADMISSION_CONTROL\u003d\"\""},{"line_number":333,"context_line":"if [ -n \"${ADMISSION_CONTROL_LIST}\" ] \u0026\u0026 [ \"${TLS_DISABLED}\" \u003d\u003d \"False\" ]; then"},{"line_number":334,"context_line":"    KUBE_ADMISSION_CONTROL\u003d\"--admission-control\u003dNodeRestriction,NamespaceLifecycle,LimitRanger,SecurityContextDeny,ServiceAccount,ResourceQuota,TaintNodesByCondition,Priority,DefaultTolerationSeconds,DefaultStorageClass,StorageObjectInUseProtection,PersistentVolumeClaimResize,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,RuntimeClass,${ADMISSION_CONTROL_LIST}\""},{"line_number":335,"context_line":"fi"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"if [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9f560f44_5dee078b","line":334,"updated":"2020-09-23 07:49:14.000000000","message":"Why not do it here?\n\nhttps://review.opendev.org/gitweb?p\u003dopenstack/magnum.git;a\u003dblob;f\u003dmagnum/drivers/k8s_fedora_coreos_v1/templates/kubecluster.yaml;h\u003d490688e8279cf7217053124871de3b2862aec361;hb\u003drefs/changes/89/748389/3#l225","commit_id":"9154a562f21b6259c14f2f7ca5dc52b27638abf6"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"f23800e221895399406f65785a8b6445c8e56b90","unresolved":false,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":"KUBE_ADMISSION_CONTROL\u003d\"\""},{"line_number":333,"context_line":"if [ -n \"${ADMISSION_CONTROL_LIST}\" ] \u0026\u0026 [ \"${TLS_DISABLED}\" \u003d\u003d \"False\" ]; then"},{"line_number":334,"context_line":"    KUBE_ADMISSION_CONTROL\u003d\"--admission-control\u003dNodeRestriction,NamespaceLifecycle,LimitRanger,SecurityContextDeny,ServiceAccount,ResourceQuota,TaintNodesByCondition,Priority,DefaultTolerationSeconds,DefaultStorageClass,StorageObjectInUseProtection,PersistentVolumeClaimResize,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,RuntimeClass,${ADMISSION_CONTROL_LIST}\""},{"line_number":335,"context_line":"fi"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"if [ \"$(echo \"${CLOUD_PROVIDER_ENABLED}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)\" \u003d \"true\" ]; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9f560f44_3802410a","line":334,"in_reply_to":"9f560f44_5dee078b","updated":"2020-09-23 08:01:10.000000000","message":"That\u0027s a very good point. I will test and propose a new patch set. Thank you.","commit_id":"9154a562f21b6259c14f2f7ca5dc52b27638abf6"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"c90dc66979cf4f9e40fb3853510ca2eddbe7d078","unresolved":false,"context_lines":[{"line_number":60,"context_line":"KUBE_API_ADDRESS\u003d\"--insecure-bind-address\u003d127.0.0.1\""},{"line_number":61,"context_line":"KUBE_ETCD_SERVERS\u003d\"--etcd-servers\u003dhttp://127.0.0.1:2379,http://127.0.0.1:4001\""},{"line_number":62,"context_line":"KUBE_SERVICE_ADDRESSES\u003d\"--service-cluster-ip-range\u003d10.254.0.0/16\""},{"line_number":63,"context_line":"KUBE_ADMISSION_CONTROL\u003d\"--admission-control\u003dNodeRestriction,NamespaceLifecycle,LimitRanger,SecurityContextDeny,ServiceAccount,ResourceQuota,TaintNodesByCondition,Priority,DefaultTolerationSeconds,DefaultStorageClass,StorageObjectInUseProtection,PersistentVolumeClaimResize,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,RuntimeClass\""},{"line_number":64,"context_line":"KUBE_API_ARGS\u003d\"\""},{"line_number":65,"context_line":"EOF"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"9f560f44_19b2ac06","line":63,"range":{"start_line":63,"start_character":44,"end_line":63,"end_character":337},"updated":"2020-09-25 08:28:27.000000000","message":"cant we use the variable here?","commit_id":"4742dc6af80766fbf386cef5689e2d88346e1502"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"74187ffe40c87e11ab0218cf72051db145926dd0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"KUBE_API_ADDRESS\u003d\"--insecure-bind-address\u003d127.0.0.1\""},{"line_number":61,"context_line":"KUBE_ETCD_SERVERS\u003d\"--etcd-servers\u003dhttp://127.0.0.1:2379,http://127.0.0.1:4001\""},{"line_number":62,"context_line":"KUBE_SERVICE_ADDRESSES\u003d\"--service-cluster-ip-range\u003d10.254.0.0/16\""},{"line_number":63,"context_line":"KUBE_ADMISSION_CONTROL\u003d\"--admission-control\u003dNodeRestriction,NamespaceLifecycle,LimitRanger,SecurityContextDeny,ServiceAccount,ResourceQuota,TaintNodesByCondition,Priority,DefaultTolerationSeconds,DefaultStorageClass,StorageObjectInUseProtection,PersistentVolumeClaimResize,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,RuntimeClass\""},{"line_number":64,"context_line":"KUBE_API_ARGS\u003d\"\""},{"line_number":65,"context_line":"EOF"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"9f560f44_5da014a5","line":63,"range":{"start_line":63,"start_character":44,"end_line":63,"end_character":337},"in_reply_to":"9f560f44_19b2ac06","updated":"2020-10-04 23:42:40.000000000","message":"Good point. I will think about it.","commit_id":"4742dc6af80766fbf386cef5689e2d88346e1502"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"5cba22d6c4cea4c06336cd8cab2a8d23f7756f83","unresolved":false,"context_lines":[{"line_number":60,"context_line":"KUBE_API_ADDRESS\u003d\"--insecure-bind-address\u003d127.0.0.1\""},{"line_number":61,"context_line":"KUBE_ETCD_SERVERS\u003d\"--etcd-servers\u003dhttp://127.0.0.1:2379,http://127.0.0.1:4001\""},{"line_number":62,"context_line":"KUBE_SERVICE_ADDRESSES\u003d\"--service-cluster-ip-range\u003d10.254.0.0/16\""},{"line_number":63,"context_line":"KUBE_ADMISSION_CONTROL\u003d\"--admission-control\u003dNodeRestriction,${ADMISSION_CONTROL_LIST}\""},{"line_number":64,"context_line":"KUBE_API_ARGS\u003d\"\""},{"line_number":65,"context_line":"EOF"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"1f621f24_f12bfae7","line":63,"range":{"start_line":63,"start_character":44,"end_line":63,"end_character":59},"updated":"2020-11-05 10:27:23.000000000","message":"why is NodeRestriction hard coded?","commit_id":"a837b5c03d9aaed7861ea78eae60b7eafdd855ee"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"f0a092df02d910331742ae7b89b7b29a9904e564","unresolved":false,"context_lines":[{"line_number":60,"context_line":"KUBE_API_ADDRESS\u003d\"--insecure-bind-address\u003d127.0.0.1\""},{"line_number":61,"context_line":"KUBE_ETCD_SERVERS\u003d\"--etcd-servers\u003dhttp://127.0.0.1:2379,http://127.0.0.1:4001\""},{"line_number":62,"context_line":"KUBE_SERVICE_ADDRESSES\u003d\"--service-cluster-ip-range\u003d10.254.0.0/16\""},{"line_number":63,"context_line":"KUBE_ADMISSION_CONTROL\u003d\"--admission-control\u003dNodeRestriction,${ADMISSION_CONTROL_LIST}\""},{"line_number":64,"context_line":"KUBE_API_ARGS\u003d\"\""},{"line_number":65,"context_line":"EOF"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"1f621f24_917c46b6","line":63,"range":{"start_line":63,"start_character":44,"end_line":63,"end_character":59},"in_reply_to":"1f621f24_f12bfae7","updated":"2020-11-05 10:43:07.000000000","message":"RBAC","commit_id":"a837b5c03d9aaed7861ea78eae60b7eafdd855ee"}]}