)]}'
{"magnum/drivers/common/templates/kubernetes/fragments/install-clients.sh":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"9978d00f8890e5e6a7d8450c64c4730fe39768d7","unresolved":false,"context_lines":[{"line_number":6,"context_line":". /etc/sysconfig/heat-params"},{"line_number":7,"context_line":"set -x"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"hyperkube_image\u003d\"${CONTAINER_INFRA_PREFIX:-\"rancher/\"}hyperkube:${KUBE_TAG}\""},{"line_number":10,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":11,"context_line":"mkdir -p /srv/magnum/bin/"},{"line_number":12,"context_line":"i\u003d0"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9f560f44_d3c8b122","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":51},"updated":"2020-09-16 22:34:26.000000000","message":"kube_prefix?","commit_id":"7d48cd0485025c867d617f627eab0591aa3f75db"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"73cc3c792de0a837f7efaa04999a413199ae9031","unresolved":true,"context_lines":[{"line_number":6,"context_line":". /etc/sysconfig/heat-params"},{"line_number":7,"context_line":"set -x"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"hyperkube_image\u003d\"${CONTAINER_INFRA_PREFIX:-\"rancher/\"}hyperkube:${KUBE_TAG}\""},{"line_number":10,"context_line":"ssh_cmd\u003d\"ssh -F /srv/magnum/.ssh/config root@localhost\""},{"line_number":11,"context_line":"mkdir -p /srv/magnum/bin/"},{"line_number":12,"context_line":"i\u003d0"}],"source_content_type":"text/x-sh","patch_set":4,"id":"9aae6a1b_67d3721b","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":51},"updated":"2021-02-18 11:03:18.000000000","message":"${HYPERKUBE_PREFIX}","commit_id":"7d869cda4af8c3181b78f6cf4ba7d060346e3dc2"}],"magnum/drivers/k8s_fedora_coreos_v1/templates/kubecluster.yaml":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"47169d9dbef7bf3e029fa6cf0605ff29387d3b30","unresolved":true,"context_lines":[{"line_number":455,"context_line":"    type: string"},{"line_number":456,"context_line":"    description:"},{"line_number":457,"context_line":"      tag of the k8s containers used to provision the kubernetes cluster"},{"line_number":458,"context_line":"      https://github.com/rancher/hyperkube/releases"},{"line_number":459,"context_line":"    default: v1.20.2-rancher1"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"  master_kube_tag:"},{"line_number":462,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c73f7f04_3ff90a58","line":459,"range":{"start_line":458,"start_character":0,"end_line":459,"end_character":29},"updated":"2021-02-18 11:07:36.000000000","message":"Unrelated to the -1, but what if we didn\u0027t default to a new version and skip rancher all together? Whoever wants to use can do it.  If I was rancher, I\u0027d have questions about this.","commit_id":"7d869cda4af8c3181b78f6cf4ba7d060346e3dc2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"ea8f71bfeaa837c0bbf5848dbbfb86f4dcc47b29","unresolved":true,"context_lines":[{"line_number":455,"context_line":"    type: string"},{"line_number":456,"context_line":"    description:"},{"line_number":457,"context_line":"      tag of the k8s containers used to provision the kubernetes cluster"},{"line_number":458,"context_line":"      https://github.com/rancher/hyperkube/releases"},{"line_number":459,"context_line":"    default: v1.20.2-rancher1"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"  master_kube_tag:"},{"line_number":462,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5abe4726_a276816e","line":459,"range":{"start_line":458,"start_character":0,"end_line":459,"end_character":29},"in_reply_to":"b9c0d3ad_4212160c","updated":"2021-02-18 12:04:17.000000000","message":"Thanks Spyros, I have addressed your comment in the latest PS. And thanks for creating the mirror, and it already has the latest releases too, fantastic!","commit_id":"7d869cda4af8c3181b78f6cf4ba7d060346e3dc2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"28e3466839ff23d3558c45a81a3803daa1f2b0e2","unresolved":true,"context_lines":[{"line_number":455,"context_line":"    type: string"},{"line_number":456,"context_line":"    description:"},{"line_number":457,"context_line":"      tag of the k8s containers used to provision the kubernetes cluster"},{"line_number":458,"context_line":"      https://github.com/rancher/hyperkube/releases"},{"line_number":459,"context_line":"    default: v1.20.2-rancher1"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"  master_kube_tag:"},{"line_number":462,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1d979b96_985d4b2a","line":459,"range":{"start_line":458,"start_character":0,"end_line":459,"end_character":29},"in_reply_to":"b9c0d3ad_4212160c","updated":"2021-02-18 11:57:43.000000000","message":"yes, only if you think it is a good idea, I also added a mirror from our images here:\nhttps://github.com/orgs/openstackmagnum/packages/container/package/hyperkube source here https://gitlab.cern.ch/cloud/hyperkube","commit_id":"7d869cda4af8c3181b78f6cf4ba7d060346e3dc2"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"8e3ee1fcb57450fd4d81a3177ef52b82ae735cc3","unresolved":true,"context_lines":[{"line_number":455,"context_line":"    type: string"},{"line_number":456,"context_line":"    description:"},{"line_number":457,"context_line":"      tag of the k8s containers used to provision the kubernetes cluster"},{"line_number":458,"context_line":"      https://github.com/rancher/hyperkube/releases"},{"line_number":459,"context_line":"    default: v1.20.2-rancher1"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"  master_kube_tag:"},{"line_number":462,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b9c0d3ad_4212160c","line":459,"range":{"start_line":458,"start_character":0,"end_line":459,"end_character":29},"in_reply_to":"c73f7f04_3ff90a58","updated":"2021-02-18 11:14:18.000000000","message":"Are you suggesting we continue to use k8s.gcr.io instead and use the latest supported kube_tag? I\u0027m okay with that.","commit_id":"7d869cda4af8c3181b78f6cf4ba7d060346e3dc2"}]}
