)]}'
{"magnum/drivers/common/templates/kubernetes/fragments/enable-cinder-csi.sh":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"db972402837c0862965b0d6ab492c4b270996cc8","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        - effect: NoExecute"},{"line_number":257,"context_line":"          operator: Exists"},{"line_number":258,"context_line":"      nodeSelector:"},{"line_number":259,"context_line":"        node-role.kubernetes.io/master: \"\""},{"line_number":260,"context_line":"      containers:"},{"line_number":261,"context_line":"        - name: csi-attacher"},{"line_number":262,"context_line":"          image: ${CONTAINER_INFRA_PREFIX:-quay.io/k8scsi/}csi-attacher:${CSI_ATTACHER_TAG}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5f681702_d7f44ed2","line":259,"updated":"2020-10-19 09:14:01.000000000","message":"this is ok, but not required","commit_id":"d2512f7470cbd6340c6eb3e91b46b86496d8582d"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"db972402837c0862965b0d6ab492c4b270996cc8","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        - effect: NoExecute"},{"line_number":406,"context_line":"          operator: Exists"},{"line_number":407,"context_line":"      nodeSelector:"},{"line_number":408,"context_line":"        node-role.kubernetes.io/master: \"\""},{"line_number":409,"context_line":"      containers:"},{"line_number":410,"context_line":"        - name: node-driver-registrar"},{"line_number":411,"context_line":"          image: ${CONTAINER_INFRA_PREFIX:-quay.io/k8scsi/}csi-node-driver-registrar:${CSI_NODE_DRIVER_REGISTRAR_TAG}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5f681702_9713f60d","line":408,"updated":"2020-10-19 09:14:01.000000000","message":"this is definitely wrong, my bad","commit_id":"d2512f7470cbd6340c6eb3e91b46b86496d8582d"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"583a5bce3d11a70c6ae3b30c48966bde5abe6db1","unresolved":false,"context_lines":[{"line_number":442,"context_line":"            - /bin/cinder-csi-plugin"},{"line_number":443,"context_line":"            - \"--nodeid\u003d\\$(NODE_ID)\""},{"line_number":444,"context_line":"            - \"--endpoint\u003d\\$(CSI_ENDPOINT)\""},{"line_number":445,"context_line":"            - \"--cloud-config\u003d\\$(CLOUD_CONFIG)\""},{"line_number":446,"context_line":"          env:"},{"line_number":447,"context_line":"            - name: NODE_ID"},{"line_number":448,"context_line":"              valueFrom:"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5f681702_02915d53","line":445,"updated":"2020-10-19 14:19:09.000000000","message":"ok, then since we removed cloud-config, csi cinder can not work. If we pass the cloud config as a secret or whatever, we don\u0027t gain anything security wise (which was what https://review.opendev.org/#/c/753560 tried to do).\n\nOn a side note, I don\u0027t see why the plugin needs credentials to do a mount. The controller should mount the volume. The plugin just needs to mount the device and make the filesystem","commit_id":"d2512f7470cbd6340c6eb3e91b46b86496d8582d"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"e193c69b09efe0c44197375ebb009fde764984b2","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        # Mark the pod as a critical add-on for rescheduling."},{"line_number":254,"context_line":"        - key: CriticalAddonsOnly"},{"line_number":255,"context_line":"          operator: Exists"},{"line_number":256,"context_line":"        - effect: NoExecute"},{"line_number":257,"context_line":"          operator: Exists"},{"line_number":258,"context_line":"      nodeSelector:"},{"line_number":259,"context_line":"        node-role.kubernetes.io/master: \"\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f621f24_67fdc339","line":256,"range":{"start_line":256,"start_character":18,"end_line":256,"end_character":27},"updated":"2020-10-29 16:13:28.000000000","message":"Why is this needed?","commit_id":"3c303e25b1ca4abd5b6ad9a29f059db866569812"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"385d634ddbc56877f4ef5494e52c871c105188a5","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        # Mark the pod as a critical add-on for rescheduling."},{"line_number":254,"context_line":"        - key: CriticalAddonsOnly"},{"line_number":255,"context_line":"          operator: Exists"},{"line_number":256,"context_line":"        - effect: NoExecute"},{"line_number":257,"context_line":"          operator: Exists"},{"line_number":258,"context_line":"      nodeSelector:"},{"line_number":259,"context_line":"        node-role.kubernetes.io/master: \"\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f621f24_0b4b3184","line":256,"range":{"start_line":256,"start_character":18,"end_line":256,"end_character":27},"in_reply_to":"1f621f24_67fdc339","updated":"2020-10-30 07:08:57.000000000","message":"It\u0027s copied from another place, I will remove it.","commit_id":"3c303e25b1ca4abd5b6ad9a29f059db866569812"}],"magnum/drivers/common/templates/kubernetes/fragments/write-kube-os-config.sh":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"9e699aeae0c05ebc41bfc8fb89f418efad78149e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -x"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"$ssh_cmd mkdir -p /etc/kubernetes/"},{"line_number":6,"context_line":"$ssh_cmd cp /etc/pki/tls/certs/ca-bundle.crt /etc/kubernetes/ca-bundle.crt"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"if [ -n \"${TRUST_ID}\" ]; then"},{"line_number":9,"context_line":"    KUBE_OS_CLOUD_CONFIG\u003d/etc/kubernetes/cloud-config"}],"source_content_type":"text/x-sh","patch_set":6,"id":"1f621f24_f1ddba14","side":"PARENT","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":74},"updated":"2020-11-05 10:24:46.000000000","message":"this is going to break fedora atomic right? do we not care about that anymore?","commit_id":"f5cf6b958c20e560d2baff3fb21adcb4ce4a3aa4"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"a4bbfd461de51c7ef18ab321ead869e7cd6689a8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -x"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"$ssh_cmd mkdir -p /etc/kubernetes/"},{"line_number":6,"context_line":"$ssh_cmd cp /etc/pki/tls/certs/ca-bundle.crt /etc/kubernetes/ca-bundle.crt"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"if [ -n \"${TRUST_ID}\" ]; then"},{"line_number":9,"context_line":"    KUBE_OS_CLOUD_CONFIG\u003d/etc/kubernetes/cloud-config"}],"source_content_type":"text/x-sh","patch_set":6,"id":"1f621f24_f163fa18","side":"PARENT","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":74},"in_reply_to":"1f621f24_f1ddba14","updated":"2020-11-05 10:42:28.000000000","message":"it will. We don\u0027t.","commit_id":"f5cf6b958c20e560d2baff3fb21adcb4ce4a3aa4"}],"magnum/drivers/k8s_fedora_coreos_v1/templates/fcct-config.yaml":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"dee2618c4609cdf759c5e03533b43e466d141507","unresolved":false,"context_lines":[{"line_number":112,"context_line":"          done"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"          /usr/bin/update-ca-trust"},{"line_number":115,"context_line":"          cp /etc/pki/tls/certs/ca-bundle.crt /etc/kubernetes/ca-bundle.crt"},{"line_number":116,"context_line":" "},{"line_number":117,"context_line":"          HTTP_PROXY\u003d\"__HTTP_PROXY__\""},{"line_number":118,"context_line":"          HTTPS_PROXY\u003d\"__HTTPS_PROXY__\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f621f24_2788ebc4","line":115,"range":{"start_line":115,"start_character":64,"end_line":115,"end_character":65},"updated":"2020-10-29 16:15:01.000000000","message":"Isn’t this repeated in the shell script on master nodes?","commit_id":"3c303e25b1ca4abd5b6ad9a29f059db866569812"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"385d634ddbc56877f4ef5494e52c871c105188a5","unresolved":false,"context_lines":[{"line_number":112,"context_line":"          done"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"          /usr/bin/update-ca-trust"},{"line_number":115,"context_line":"          cp /etc/pki/tls/certs/ca-bundle.crt /etc/kubernetes/ca-bundle.crt"},{"line_number":116,"context_line":" "},{"line_number":117,"context_line":"          HTTP_PROXY\u003d\"__HTTP_PROXY__\""},{"line_number":118,"context_line":"          HTTPS_PROXY\u003d\"__HTTPS_PROXY__\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f621f24_eb30750a","line":115,"range":{"start_line":115,"start_character":64,"end_line":115,"end_character":65},"in_reply_to":"1f621f24_2788ebc4","updated":"2020-10-30 07:08:57.000000000","message":"It is. We need to get it run on worker nodes as you know, we can remove it from https://github.com/openstack/magnum/blob/master/magnum/drivers/common/templates/kubernetes/fragments/write-kube-os-config.sh#L6 to avoid duplication.","commit_id":"3c303e25b1ca4abd5b6ad9a29f059db866569812"}],"magnum/drivers/k8s_fedora_coreos_v1/templates/user_data.json":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"4cf0cd16c885b1930cd1b4d3a98c5105d87062b1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"ignition\": {"},{"line_number":3,"context_line":"    \"version\": \"3.0.0\""},{"line_number":4,"context_line":"  },"}],"source_content_type":"application/json","patch_set":4,"id":"3f65232a_cba59906","line":1,"updated":"2020-10-27 00:12:32.000000000","message":"This is generated based on podman:\n\nVersion:      2.1.1\nAPI Version:  2.0.0\nGo Version:   go1.15.2\nBuilt:        Thu Jan  1 12:00:00 1970\nOS/Arch:      linux/amd64","commit_id":"3c303e25b1ca4abd5b6ad9a29f059db866569812"}]}