)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"c709a1dfb67fcfa51170e40000f63f1567922d41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f5278e5_e166d0bf","updated":"2021-11-25 12:43:41.000000000","message":"Hey John: are you planning to push some more work on this or has other things came up on the list? 😎","commit_id":"5408054cc63c10e27c27b0d701ccac9ce4bbee92"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"89adda6c9f5c91071d8c31eb76ac1e15cf4208e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"003d0111_8d7cd834","updated":"2023-08-21 02:08:21.000000000","message":"I think this is good. except for some suggestion to naming consistency.\n\nI would also like your comments on the feature gate Change Iff8a96af8f454a396f055ad0830bdab020a13c71 to be after this.\n\nPlease review that and we should be able to get to get both of these merged and work our way up from there.","commit_id":"16462e6ad9afc87c621c115005191bf70be2f594"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"ad435cbe8c639865fbd37a0bb899b316b66947e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d6a2793d_96a50a02","updated":"2023-08-23 11:55:47.000000000","message":"withdrawing the -1 for naming","commit_id":"16462e6ad9afc87c621c115005191bf70be2f594"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"391a2ba26090d012aea22e08ebf2c6a1b95d3cf9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"24182c2d_b09778b4","updated":"2023-09-12 17:43:34.000000000","message":"Sorry, I didn\u0027t see we had reviews... I must work out where all my Gerrit emails are going :/\n\nAs we have missed feature freeze, I am trying to progress this downstream, so we can get this safely into our customers that are looking to pay for this work:\nhttps://github.com/stackhpc/magnum-capi-helm\n\nHopefully next cycle we can refresh the effort, if the upstream community are still keen to look at getting this merged. A few interesting things that probably would need some high bandwidth discussions to resolve.","commit_id":"0e4e3298615c23c1d58fc146555d3f0b7a47bcdf"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"946f25d47fa7b266c559e40c0cdf585694287c08","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"482fddfa_963668f1","in_reply_to":"24182c2d_b09778b4","updated":"2023-09-14 01:27:02.000000000","message":"Hi John, great to hear from you again! :) \n\nWe\u0027ve been having discussions about this. Michael can probably fill you in the details. The short version is\n\n- Magnum project will try to find a way for different drivers to co-exist.\n- Hopefully, StackHPC and VEXXHOST will work together to build 1 good reference CAPI driver.\n\nWe can continue the effort here, so we can get it merged early next cycle. Please join us for the meetings or vPTG. Which reminds me I should get onto to it.","commit_id":"0e4e3298615c23c1d58fc146555d3f0b7a47bcdf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"473b4425b242bf21fd6304d4ce90d65f17819956","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"93f57b5d_45fc69a5","in_reply_to":"482fddfa_963668f1","updated":"2023-09-16 11:04:51.000000000","message":"I am happy to attend the weekly meetings, I tried to attend back in June and August when I was doing the bulk of this work, and assumed they were no longer happening. Sorry I didn\u0027t discover they were back till this week. Sorry, I have been far too distracted with other things to reach out and check again :(\n\nFor me the key sticking point we raised and discussed at the last PTG. It is that the helm charts are useful inside and outside of Magnum, and we use that via Azimuth (and trying to get ArgoCD/Flux to work too). So Magnum is just one of the users for the helm charts (which I would like to get into the OpenStack or K8s namespace so others can more easily contribute). And I believe VEXXHOST said at the time they did not want to adopt helm as there were already in production. Already having the helm charts in production (for 18 months or so) is also another reason why we don\u0027t want to drop the helm charts at this point. My personal preference is to make the helm charts able to emit the exact same K8s resources the exiting VEXXHOST driver does, as a configuration option, or at least some comprise that doesn\u0027t break upgrades. There are differences on how we handle add-ons and how we haven\u0027t yet adopted cluster class, and most likely those changes would need some discussion.\n\nEven if we don\u0027t resolve that difference, most of the rest of the code could be very similar, and could be upstream. We discussed in Vancouver the idea of moving code from the two drivers into magnum common, so both can share even more code.\n\nAnyways, looking forward to discussing this more. In the mean time, we need to get this deployed with our customers, so I have pulled that into a downstream repository. In part, as a week ago we finally got the funding confirmed for this work (maybe around 12-18months later than I would have liked!!), it was done \"at risk\" before that point, to try and keep things moving, with limited success.","commit_id":"0e4e3298615c23c1d58fc146555d3f0b7a47bcdf"}],"magnum/drivers/cluster_api/driver.py":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"89adda6c9f5c91071d8c31eb76ac1e15cf4208e7","unresolved":true,"context_lines":[{"line_number":23,"context_line":"        return ["},{"line_number":24,"context_line":"            {"},{"line_number":25,"context_line":"                \"server_type\": \"vm\","},{"line_number":26,"context_line":"                # TODO(johngarbutt) OS list should probably come from config?"},{"line_number":27,"context_line":"                \"os\": \"ubuntu\","},{"line_number":28,"context_line":"                \"coe\": \"kubernetes\","},{"line_number":29,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":13,"id":"4e40ff42_cc1a0da4","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":77},"updated":"2023-08-21 02:08:21.000000000","message":"will probably need a decent refactoring for this so can remove for now","commit_id":"16462e6ad9afc87c621c115005191bf70be2f594"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"526d4b9f0a3c5ab491c113dec490aa73df016a01","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        return ["},{"line_number":24,"context_line":"            {"},{"line_number":25,"context_line":"                \"server_type\": \"vm\","},{"line_number":26,"context_line":"                # TODO(johngarbutt) OS list should probably come from config?"},{"line_number":27,"context_line":"                \"os\": \"ubuntu\","},{"line_number":28,"context_line":"                \"coe\": \"kubernetes\","},{"line_number":29,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":13,"id":"1907a2df_e0274611","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":77},"in_reply_to":"4e40ff42_cc1a0da4","updated":"2023-09-16 11:26:20.000000000","message":"Done","commit_id":"16462e6ad9afc87c621c115005191bf70be2f594"}],"magnum/drivers/k8s_capi_helm_v1/driver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"94ccbcf702de83075df84d7e0e9f38c2e43ffdca","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                \"server_type\": \"vm\","},{"line_number":26,"context_line":"                # NOTE(johngarbutt) we don\u0027t depend on a specific OS,"},{"line_number":27,"context_line":"                # we depend on kubeadm images with cloud-init"},{"line_number":28,"context_line":"                \"os\": \"capi-kubeadm-cloudinit\","},{"line_number":29,"context_line":"                \"coe\": \"kubernetes\","},{"line_number":30,"context_line":"            },"},{"line_number":31,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":15,"id":"0191d744_a0659d74","line":28,"updated":"2023-09-18 09:29:36.000000000","message":"Note the change made here.","commit_id":"c64d45c18fa76a8702154b79e6210178a26a5f19"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"aa15a4365b0a11329d97906465d89874ac92d360","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                \"server_type\": \"vm\","},{"line_number":26,"context_line":"                # NOTE(johngarbutt) we don\u0027t depend on a specific OS,"},{"line_number":27,"context_line":"                # we depend on kubeadm images with cloud-init"},{"line_number":28,"context_line":"                \"os\": \"capi-kubeadm-cloudinit\","},{"line_number":29,"context_line":"                \"coe\": \"kubernetes\","},{"line_number":30,"context_line":"            },"},{"line_number":31,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":15,"id":"a0e5402a_86cce4f9","line":28,"in_reply_to":"0191d744_a0659d74","updated":"2023-09-18 09:54:38.000000000","message":"We have discussed this method, but dalees pointed out os_distro is a glance property at https://docs.openstack.org/glance/latest/admin/useful-image-properties.html.\n\nLet\u0027s discuss whether it is ok to use this in our meeting.","commit_id":"c64d45c18fa76a8702154b79e6210178a26a5f19"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"431f39633afcf2682250c1ceb80534c9fec1043a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                \"server_type\": \"vm\","},{"line_number":26,"context_line":"                # NOTE(johngarbutt) we don\u0027t depend on a specific OS,"},{"line_number":27,"context_line":"                # we depend on kubeadm images with cloud-init"},{"line_number":28,"context_line":"                \"os\": \"capi-kubeadm-cloudinit\","},{"line_number":29,"context_line":"                \"coe\": \"kubernetes\","},{"line_number":30,"context_line":"            },"},{"line_number":31,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":15,"id":"8cd170a3_b6b1697c","line":28,"in_reply_to":"a0e5402a_86cce4f9","updated":"2023-09-18 10:23:20.000000000","message":"So os_distro\u003d\"ubuntu\" is not a valid value, as I understand it. In particular, in reference to this spec:\nhttps://specs.openstack.org/openstack/nova-specs/specs/liberty/approved/libvirt-hardware-policy-from-libosinfo.html\n\nMy preference would be making the template always pick the driver, explicitly, but that is a big change. This seems to remove the conflict, while we decide a better way forward.","commit_id":"c64d45c18fa76a8702154b79e6210178a26a5f19"}],"setup.cfg":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"ad435cbe8c639865fbd37a0bb899b316b66947e5","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    swarm_fedora_atomic_v1 \u003d magnum.drivers.swarm_fedora_atomic_v1.driver:Driver"},{"line_number":56,"context_line":"    swarm_fedora_atomic_v2 \u003d magnum.drivers.swarm_fedora_atomic_v2.driver:Driver"},{"line_number":57,"context_line":"    k8s_fedora_ironic_v1 \u003d magnum.drivers.k8s_fedora_ironic_v1.driver:Driver"},{"line_number":58,"context_line":"    k8s_cluster_api_v1 \u003d magnum.drivers.cluster_api.driver:Driver"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"magnum.database.migration_backend \u003d"},{"line_number":61,"context_line":"    sqlalchemy \u003d magnum.db.sqlalchemy.migration"}],"source_content_type":"text/x-ttcn-cfg","patch_set":13,"id":"65f14fbb_0c08c1c2","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":22},"updated":"2023-08-23 11:55:47.000000000","message":"k8s_capi_v1 \u003d magnum.drivers.capi.driver:Driver","commit_id":"16462e6ad9afc87c621c115005191bf70be2f594"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"89adda6c9f5c91071d8c31eb76ac1e15cf4208e7","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    swarm_fedora_atomic_v1 \u003d magnum.drivers.swarm_fedora_atomic_v1.driver:Driver"},{"line_number":56,"context_line":"    swarm_fedora_atomic_v2 \u003d magnum.drivers.swarm_fedora_atomic_v2.driver:Driver"},{"line_number":57,"context_line":"    k8s_fedora_ironic_v1 \u003d magnum.drivers.k8s_fedora_ironic_v1.driver:Driver"},{"line_number":58,"context_line":"    k8s_cluster_api_v1 \u003d magnum.drivers.cluster_api.driver:Driver"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"magnum.database.migration_backend \u003d"},{"line_number":61,"context_line":"    sqlalchemy \u003d magnum.db.sqlalchemy.migration"}],"source_content_type":"text/x-ttcn-cfg","patch_set":13,"id":"720369e1_66429f1d","line":58,"range":{"start_line":58,"start_character":40,"end_line":58,"end_character":51},"updated":"2023-08-21 02:08:21.000000000","message":"shall we name this k8s_cluster_api_v1 to keep naming scheme?","commit_id":"16462e6ad9afc87c621c115005191bf70be2f594"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"526d4b9f0a3c5ab491c113dec490aa73df016a01","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    swarm_fedora_atomic_v1 \u003d magnum.drivers.swarm_fedora_atomic_v1.driver:Driver"},{"line_number":56,"context_line":"    swarm_fedora_atomic_v2 \u003d magnum.drivers.swarm_fedora_atomic_v2.driver:Driver"},{"line_number":57,"context_line":"    k8s_fedora_ironic_v1 \u003d magnum.drivers.k8s_fedora_ironic_v1.driver:Driver"},{"line_number":58,"context_line":"    k8s_cluster_api_v1 \u003d magnum.drivers.cluster_api.driver:Driver"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"magnum.database.migration_backend \u003d"},{"line_number":61,"context_line":"    sqlalchemy \u003d magnum.db.sqlalchemy.migration"}],"source_content_type":"text/x-ttcn-cfg","patch_set":13,"id":"99575d3e_0424527d","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":22},"in_reply_to":"65f14fbb_0c08c1c2","updated":"2023-09-16 11:26:20.000000000","message":"Done","commit_id":"16462e6ad9afc87c621c115005191bf70be2f594"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a73aaba0bb8ac2176319c35872c2d5f98a2c0602","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    swarm_fedora_atomic_v1 \u003d magnum.drivers.swarm_fedora_atomic_v1.driver:Driver"},{"line_number":56,"context_line":"    swarm_fedora_atomic_v2 \u003d magnum.drivers.swarm_fedora_atomic_v2.driver:Driver"},{"line_number":57,"context_line":"    k8s_fedora_ironic_v1 \u003d magnum.drivers.k8s_fedora_ironic_v1.driver:Driver"},{"line_number":58,"context_line":"    k8s_cluster_api_v1 \u003d magnum.drivers.cluster_api.driver:Driver"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"magnum.database.migration_backend \u003d"},{"line_number":61,"context_line":"    sqlalchemy \u003d magnum.db.sqlalchemy.migration"}],"source_content_type":"text/x-ttcn-cfg","patch_set":13,"id":"8f419c68_9f58e12d","line":58,"range":{"start_line":58,"start_character":40,"end_line":58,"end_character":51},"in_reply_to":"720369e1_66429f1d","updated":"2023-10-06 15:22:11.000000000","message":"Done, ish. Went for capi_helm to be different from the current vexhost out of tree driver.","commit_id":"16462e6ad9afc87c621c115005191bf70be2f594"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b812b72cb2d18d0cb8890fedfad020511459aca2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    swarm_fedora_atomic_v1 \u003d magnum.drivers.swarm_fedora_atomic_v1.driver:Driver"},{"line_number":56,"context_line":"    swarm_fedora_atomic_v2 \u003d magnum.drivers.swarm_fedora_atomic_v2.driver:Driver"},{"line_number":57,"context_line":"    k8s_fedora_ironic_v1 \u003d magnum.drivers.k8s_fedora_ironic_v1.driver:Driver"},{"line_number":58,"context_line":"    k8s_cluster_api_v1 \u003d magnum.drivers.cluster_api.driver:Driver"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"magnum.database.migration_backend \u003d"},{"line_number":61,"context_line":"    sqlalchemy \u003d magnum.db.sqlalchemy.migration"}],"source_content_type":"text/x-ttcn-cfg","patch_set":13,"id":"e4046d35_8df17f72","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":22},"in_reply_to":"8f46ce6b_66a2aa46","updated":"2023-09-18 09:29:10.000000000","message":"To be clear, this change stops that conflict with the Vexhost driver, by tweaking the required os_distro flag for this driver, given we don\u0027t really depend on Ubuntu, and Nova doesn\u0027t really use os_distro for anything useful in this format, anyways.\n\nI have a bunch of refactoring downstream I am updating here I am attempting to re-apply the downstream repo into this patches, so we can try to keep the in sync with all the downstream fixes.\n\nI am hoping we could get the tempest tests we had passing working again in the gate too. It sounds like some other work was done on that too that I should chase down and understand.\n\nIs the meeting planned to happen this Wednesday? If so I can try and re-arrange my on-site client work to make that, assuming cluster api is on the agenda?","commit_id":"16462e6ad9afc87c621c115005191bf70be2f594"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"c6804f360dfb861e7960e9afc477d315aec98a6c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    swarm_fedora_atomic_v1 \u003d magnum.drivers.swarm_fedora_atomic_v1.driver:Driver"},{"line_number":56,"context_line":"    swarm_fedora_atomic_v2 \u003d magnum.drivers.swarm_fedora_atomic_v2.driver:Driver"},{"line_number":57,"context_line":"    k8s_fedora_ironic_v1 \u003d magnum.drivers.k8s_fedora_ironic_v1.driver:Driver"},{"line_number":58,"context_line":"    k8s_cluster_api_v1 \u003d magnum.drivers.cluster_api.driver:Driver"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"magnum.database.migration_backend \u003d"},{"line_number":61,"context_line":"    sqlalchemy \u003d magnum.db.sqlalchemy.migration"}],"source_content_type":"text/x-ttcn-cfg","patch_set":13,"id":"8f46ce6b_66a2aa46","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":22},"in_reply_to":"99575d3e_0424527d","updated":"2023-09-17 09:19:47.000000000","message":"Thanks John! Before you spent too much time on it, I have tested working CAPI at https://review.opendev.org/c/openstack/magnum/+/892854.\nThis incorporates all your patches so far, + a feature gate + a rename. Can you take a look and let me know your opinions?\n\nAnyway this is not the most priority now. We now need to work on a way to ensure this driver doesn\u0027t conflict with VEXXHOST when merged. Let\u0027s chat more about this on next Wed meeting to decide on a course of action?","commit_id":"16462e6ad9afc87c621c115005191bf70be2f594"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8740314dd416bc24c4c2ab8f8570656d332734d9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    swarm_fedora_atomic_v1 \u003d magnum.drivers.swarm_fedora_atomic_v1.driver:Driver"},{"line_number":56,"context_line":"    swarm_fedora_atomic_v2 \u003d magnum.drivers.swarm_fedora_atomic_v2.driver:Driver"},{"line_number":57,"context_line":"    k8s_fedora_ironic_v1 \u003d magnum.drivers.k8s_fedora_ironic_v1.driver:Driver"},{"line_number":58,"context_line":"    k8s_cluster_api_v1 \u003d magnum.drivers.cluster_api.driver:Driver"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"magnum.database.migration_backend \u003d"},{"line_number":61,"context_line":"    sqlalchemy \u003d magnum.db.sqlalchemy.migration"}],"source_content_type":"text/x-ttcn-cfg","patch_set":13,"id":"403cf98a_f9bb2b00","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":22},"in_reply_to":"b5661c95_0ac3a799","updated":"2023-09-18 10:24:36.000000000","message":"OK, I wll do what I can to attend this week.","commit_id":"16462e6ad9afc87c621c115005191bf70be2f594"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"aa15a4365b0a11329d97906465d89874ac92d360","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    swarm_fedora_atomic_v1 \u003d magnum.drivers.swarm_fedora_atomic_v1.driver:Driver"},{"line_number":56,"context_line":"    swarm_fedora_atomic_v2 \u003d magnum.drivers.swarm_fedora_atomic_v2.driver:Driver"},{"line_number":57,"context_line":"    k8s_fedora_ironic_v1 \u003d magnum.drivers.k8s_fedora_ironic_v1.driver:Driver"},{"line_number":58,"context_line":"    k8s_cluster_api_v1 \u003d magnum.drivers.cluster_api.driver:Driver"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"magnum.database.migration_backend \u003d"},{"line_number":61,"context_line":"    sqlalchemy \u003d magnum.db.sqlalchemy.migration"}],"source_content_type":"text/x-ttcn-cfg","patch_set":13,"id":"b5661c95_0ac3a799","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":22},"in_reply_to":"e4046d35_8df17f72","updated":"2023-09-18 09:54:38.000000000","message":"Yes I will be there.","commit_id":"16462e6ad9afc87c621c115005191bf70be2f594"}]}