)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34973,"name":"Andrew Ruthven","email":"andrew.ruthven@catalystcloud.nz"},"change_message_id":"6589f51478f0408740f15a6b541ee15a24e781ce","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e5cf2f1d_b8988626","updated":"2022-06-08 00:50:25.000000000","message":"Adding a -1 as this change introduces a security concern by adding the ETCD keys to the worker nodes as that is where Prometheus is running. This change shouldn\u0027t be merged until it is reworked.","commit_id":"aa573839851890b7337f40fdcb82126158da3eba"},{"author":{"_account_id":33822,"name":"Qiannan Lyu","email":"qiannan.lyu@hotmail.com","username":"qiannan"},"change_message_id":"a65b2981d51f51018beb3b4f54b1e6c7ff0405ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cdca8985_aaa31ae1","updated":"2022-03-07 22:33:42.000000000","message":"Can you please take a look?","commit_id":"aa573839851890b7337f40fdcb82126158da3eba"},{"author":{"_account_id":33822,"name":"Qiannan Lyu","email":"qiannan.lyu@hotmail.com","username":"qiannan"},"change_message_id":"a2a917b129d3da520aa5138d1a7e5444e3018e6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2633aaac_06f91080","updated":"2022-01-31 03:29:29.000000000","message":"Hi Feilong, can you please take a look?\n\nCheers,\nQiannan","commit_id":"aa573839851890b7337f40fdcb82126158da3eba"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"79928a73331dcf3b3c6921a9c71f80786d68de14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2d3f9b67_b82da146","updated":"2022-06-28 16:30:30.000000000","message":"I would prefer that etcd changes to be separate from the image fix.","commit_id":"aa573839851890b7337f40fdcb82126158da3eba"},{"author":{"_account_id":33822,"name":"Qiannan Lyu","email":"qiannan.lyu@hotmail.com","username":"qiannan"},"change_message_id":"99499276c24f6fc03ac81207f7380583475f424a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d2d9fb58_05ddec17","updated":"2022-02-04 03:37:21.000000000","message":"recheck","commit_id":"aa573839851890b7337f40fdcb82126158da3eba"}],"magnum/drivers/common/templates/kubernetes/fragments/create-etcd-cert-secrets.sh":[{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"79928a73331dcf3b3c6921a9c71f80786d68de14","unresolved":true,"context_lines":[{"line_number":1,"context_line":"step\u003d\"create-etcd-cert-secrets.sh\""},{"line_number":2,"context_line":"printf \"Starting to run ${step}\\n\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":". /etc/sysconfig/heat-params"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"echo \"Waiting for Kubernetes API...\""},{"line_number":7,"context_line":"until  [ \"ok\" \u003d \"$(kubectl get --raw\u003d\u0027/healthz\u0027)\" ]; do"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3daa3647_28946f51","line":4,"updated":"2022-06-28 16:30:30.000000000","message":"typo?","commit_id":"aa573839851890b7337f40fdcb82126158da3eba"}],"magnum/drivers/common/templates/kubernetes/helm/prometheus-operator.sh":[{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"79928a73331dcf3b3c6921a9c71f80786d68de14","unresolved":true,"context_lines":[{"line_number":132,"context_line":"    #enabled: ${ENABLE_GRAFANA}"},{"line_number":133,"context_line":"    sidecar:"},{"line_number":134,"context_line":"      image:"},{"line_number":135,"context_line":"        repository: ${CONTAINER_INFRA_PREFIX:-kiwigrid/}k8s-sidecar"},{"line_number":136,"context_line":"        tag: 0.1.99"},{"line_number":137,"context_line":"    resources:"},{"line_number":138,"context_line":"      requests:"}],"source_content_type":"text/x-sh","patch_set":1,"id":"90d99dea_57c3d6e2","line":135,"updated":"2022-06-28 16:30:30.000000000","message":"Can you split this fix from etcd\u0027s?","commit_id":"aa573839851890b7337f40fdcb82126158da3eba"},{"author":{"_account_id":34973,"name":"Andrew Ruthven","email":"andrew.ruthven@catalystcloud.nz"},"change_message_id":"733c83138de4be349749a941d90d04d41314008c","unresolved":true,"context_lines":[{"line_number":132,"context_line":"    #enabled: ${ENABLE_GRAFANA}"},{"line_number":133,"context_line":"    sidecar:"},{"line_number":134,"context_line":"      image:"},{"line_number":135,"context_line":"        repository: ${CONTAINER_INFRA_PREFIX:-kiwigrid/}k8s-sidecar"},{"line_number":136,"context_line":"        tag: 0.1.99"},{"line_number":137,"context_line":"    resources:"},{"line_number":138,"context_line":"      requests:"}],"source_content_type":"text/x-sh","patch_set":1,"id":"89b67c14_45e5dc7e","line":135,"in_reply_to":"90d99dea_57c3d6e2","updated":"2022-07-18 00:35:57.000000000","message":"This has already been fixed in master - https://review.opendev.org/c/openstack/magnum/+/764105 - and backported to Victoria and Ussuri.\n\nOur next attempt at this still exclude this change.","commit_id":"aa573839851890b7337f40fdcb82126158da3eba"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"79928a73331dcf3b3c6921a9c71f80786d68de14","unresolved":true,"context_lines":[{"line_number":133,"context_line":"    sidecar:"},{"line_number":134,"context_line":"      image:"},{"line_number":135,"context_line":"        repository: ${CONTAINER_INFRA_PREFIX:-kiwigrid/}k8s-sidecar"},{"line_number":136,"context_line":"        tag: 0.1.99"},{"line_number":137,"context_line":"    resources:"},{"line_number":138,"context_line":"      requests:"},{"line_number":139,"context_line":"        cpu: 100m"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ed7a6a79_786da67b","line":136,"updated":"2022-06-28 16:30:30.000000000","message":"Also, just drop the tag. Tag should be relavive to helm chart or otherwise configured by user.","commit_id":"aa573839851890b7337f40fdcb82126158da3eba"}]}