)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"1bf2603eabcafa31f7cf6b9effdc409cbef12455","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0893c195_da52b53f","updated":"2022-05-17 10:50:08.000000000","message":"WIP need reno","commit_id":"abbe1f59f129a69c5c389f9822653b30666d3f31"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"17648587345cf5b9732592291a2ccc15f6698a75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1a110ae2_479adfc6","updated":"2023-02-02 09:53:30.000000000","message":"Some comments on the patch.\n\nAs I mentioned in the story, I am wondering why FCOS chooses to use `/usr/libexec/cni` instead of the default `/opt/cni/bin`? Please update the story if anyone has more information.","commit_id":"ae3ad917f035492d954c1dbbac9694e44b365b9a"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"bd1932f08a7a94779176681157131e2c0e84be67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"883549e9_f1856910","updated":"2023-02-13 04:12:45.000000000","message":"Yeap all good, needs another pair of +2 eyes on it.\n\nFYI, I was thinking we can do reno for \"Support FCOS 37\" in a separate change since there is another patch that needed.","commit_id":"fbfd3ce9a30fed291c96179f409821b7e016d2ba"}],"magnum/drivers/common/templates/kubernetes/fragments/install-cri.sh":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"17648587345cf5b9732592291a2ccc15f6698a75","unresolved":true,"context_lines":[{"line_number":10,"context_line":"if [ \"${CONTAINER_RUNTIME}\" \u003d \"containerd\"  ] ; then"},{"line_number":11,"context_line":"    $ssh_cmd systemctl disable docker.service docker.socket"},{"line_number":12,"context_line":"    $ssh_cmd systemctl stop docker.service docker.socket"},{"line_number":13,"context_line":"    if $ssh_cmd [ -f /etc/containerd/config.toml ] ; then"},{"line_number":14,"context_line":"        $ssh_cmd sed -i \u0027s/bin_dir.*$/bin_dir\\ \u003d\\ \\\"\"\\/opt\\/cni\\/bin\\/\"\\\"/\u0027 /etc/containerd/config.toml"},{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"    if [ -z \"${CONTAINERD_TARBALL_URL}\"  ] ; then"},{"line_number":17,"context_line":"        CONTAINERD_TARBALL_URL\u003d\"https://github.com/containerd/containerd/releases/download/v${CONTAINERD_VERSION}/cri-containerd-cni-${CONTAINERD_VERSION}-linux-amd64.tar.gz\""},{"line_number":18,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"42067dc7_ae60f442","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":6},"updated":"2023-02-02 09:53:30.000000000","message":"It may be better to move this later , until tarball installation is completed","commit_id":"ae3ad917f035492d954c1dbbac9694e44b365b9a"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"bd1932f08a7a94779176681157131e2c0e84be67","unresolved":false,"context_lines":[{"line_number":10,"context_line":"if [ \"${CONTAINER_RUNTIME}\" \u003d \"containerd\"  ] ; then"},{"line_number":11,"context_line":"    $ssh_cmd systemctl disable docker.service docker.socket"},{"line_number":12,"context_line":"    $ssh_cmd systemctl stop docker.service docker.socket"},{"line_number":13,"context_line":"    if $ssh_cmd [ -f /etc/containerd/config.toml ] ; then"},{"line_number":14,"context_line":"        $ssh_cmd sed -i \u0027s/bin_dir.*$/bin_dir\\ \u003d\\ \\\"\"\\/opt\\/cni\\/bin\\/\"\\\"/\u0027 /etc/containerd/config.toml"},{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"    if [ -z \"${CONTAINERD_TARBALL_URL}\"  ] ; then"},{"line_number":17,"context_line":"        CONTAINERD_TARBALL_URL\u003d\"https://github.com/containerd/containerd/releases/download/v${CONTAINERD_VERSION}/cri-containerd-cni-${CONTAINERD_VERSION}-linux-amd64.tar.gz\""},{"line_number":18,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"eaa381f9_58ca9799","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":6},"in_reply_to":"014e24bd_a41bb7f3","updated":"2023-02-13 04:12:45.000000000","message":"Ack","commit_id":"ae3ad917f035492d954c1dbbac9694e44b365b9a"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"1202f997a8fbe0d98f067f7122fa995c202f1bab","unresolved":true,"context_lines":[{"line_number":10,"context_line":"if [ \"${CONTAINER_RUNTIME}\" \u003d \"containerd\"  ] ; then"},{"line_number":11,"context_line":"    $ssh_cmd systemctl disable docker.service docker.socket"},{"line_number":12,"context_line":"    $ssh_cmd systemctl stop docker.service docker.socket"},{"line_number":13,"context_line":"    if $ssh_cmd [ -f /etc/containerd/config.toml ] ; then"},{"line_number":14,"context_line":"        $ssh_cmd sed -i \u0027s/bin_dir.*$/bin_dir\\ \u003d\\ \\\"\"\\/opt\\/cni\\/bin\\/\"\\\"/\u0027 /etc/containerd/config.toml"},{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"    if [ -z \"${CONTAINERD_TARBALL_URL}\"  ] ; then"},{"line_number":17,"context_line":"        CONTAINERD_TARBALL_URL\u003d\"https://github.com/containerd/containerd/releases/download/v${CONTAINERD_VERSION}/cri-containerd-cni-${CONTAINERD_VERSION}-linux-amd64.tar.gz\""},{"line_number":18,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"014e24bd_a41bb7f3","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":6},"in_reply_to":"42067dc7_ae60f442","updated":"2023-02-13 03:54:19.000000000","message":"+1 I agree, though the **current** cri-containerd-cni tarball does not package the file /etc/containerd/confirm.toml.","commit_id":"ae3ad917f035492d954c1dbbac9694e44b365b9a"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"17648587345cf5b9732592291a2ccc15f6698a75","unresolved":true,"context_lines":[{"line_number":29,"context_line":"        exit 1"},{"line_number":30,"context_line":"    fi"},{"line_number":31,"context_line":"    $ssh_cmd tar xzvf /srv/magnum/cri-containerd.tar.gz -C / --no-same-owner --touch --no-same-permissions"},{"line_number":32,"context_line":"    $ssh_cmd systemctl daemon-reload"},{"line_number":33,"context_line":"    $ssh_cmd systemctl enable containerd"},{"line_number":34,"context_line":"    $ssh_cmd systemctl start containerd"},{"line_number":35,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":3,"id":"c9b43bd9_628c4965","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":2},"updated":"2023-02-02 09:53:30.000000000","message":"this may be a good place to do the sed","commit_id":"ae3ad917f035492d954c1dbbac9694e44b365b9a"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"17648587345cf5b9732592291a2ccc15f6698a75","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    $ssh_cmd tar xzvf /srv/magnum/cri-containerd.tar.gz -C / --no-same-owner --touch --no-same-permissions"},{"line_number":32,"context_line":"    $ssh_cmd systemctl daemon-reload"},{"line_number":33,"context_line":"    $ssh_cmd systemctl enable containerd"},{"line_number":34,"context_line":"    $ssh_cmd systemctl start containerd"},{"line_number":35,"context_line":"else"},{"line_number":36,"context_line":"    # CONTAINER_RUNTIME\u003dhost-docker"},{"line_number":37,"context_line":"    $ssh_cmd systemctl disable docker"}],"source_content_type":"text/x-sh","patch_set":3,"id":"963f8e44_06730f2d","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":28},"updated":"2023-02-02 09:53:30.000000000","message":"do we need to restart containerd when config.toml changes?","commit_id":"ae3ad917f035492d954c1dbbac9694e44b365b9a"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"1202f997a8fbe0d98f067f7122fa995c202f1bab","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    $ssh_cmd tar xzvf /srv/magnum/cri-containerd.tar.gz -C / --no-same-owner --touch --no-same-permissions"},{"line_number":32,"context_line":"    $ssh_cmd systemctl daemon-reload"},{"line_number":33,"context_line":"    $ssh_cmd systemctl enable containerd"},{"line_number":34,"context_line":"    $ssh_cmd systemctl start containerd"},{"line_number":35,"context_line":"else"},{"line_number":36,"context_line":"    # CONTAINER_RUNTIME\u003dhost-docker"},{"line_number":37,"context_line":"    $ssh_cmd systemctl disable docker"}],"source_content_type":"text/x-sh","patch_set":3,"id":"f84c541e_02b82b3b","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":28},"in_reply_to":"963f8e44_06730f2d","updated":"2023-02-13 03:54:19.000000000","message":"At this point in the instance startup, with Fedora CoreOS 37(and below) containerd is not running.\n\nSo leaving it as `start` is acceptable and performs the correct action.\n\nI\u0027d changed it to \u0027restart\u0027 in my patchset[1] to be explicit, as it **does** require a restart after a config.toml change, if already running.\n\n\n[1] https://review.opendev.org/c/openstack/magnum/+/870473","commit_id":"ae3ad917f035492d954c1dbbac9694e44b365b9a"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"bd1932f08a7a94779176681157131e2c0e84be67","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    $ssh_cmd tar xzvf /srv/magnum/cri-containerd.tar.gz -C / --no-same-owner --touch --no-same-permissions"},{"line_number":32,"context_line":"    $ssh_cmd systemctl daemon-reload"},{"line_number":33,"context_line":"    $ssh_cmd systemctl enable containerd"},{"line_number":34,"context_line":"    $ssh_cmd systemctl start containerd"},{"line_number":35,"context_line":"else"},{"line_number":36,"context_line":"    # CONTAINER_RUNTIME\u003dhost-docker"},{"line_number":37,"context_line":"    $ssh_cmd systemctl disable docker"}],"source_content_type":"text/x-sh","patch_set":3,"id":"f3db319d_bb4d92d3","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":28},"in_reply_to":"f84c541e_02b82b3b","updated":"2023-02-13 04:12:45.000000000","message":"Ack","commit_id":"ae3ad917f035492d954c1dbbac9694e44b365b9a"}]}