)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0e08eeb0b95d6659d4b3a816909fd60b5e64b037","unresolved":true,"context_lines":[{"line_number":14,"context_line":"New labels added:"},{"line_number":15,"context_line":" - master_volume_size"},{"line_number":16,"context_line":" - master_volume_type"},{"line_number":17,"context_line":" - minion_volume_size"},{"line_number":18,"context_line":" - minion_volume_type"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I02c6ec6944cf9d1e3c4cdc589785c05d84421a65"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"0510f944_152063d3","line":17,"range":{"start_line":17,"start_character":3,"end_line":17,"end_character":9},"updated":"2022-07-18 10:55:11.000000000","message":"worker?","commit_id":"a84980b794dab6a2efcb643df3e23a0ccfbbec00"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"318212e0ee1a2ad7fe07e541558c5e04ddad57e8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"New labels added:"},{"line_number":15,"context_line":" - master_volume_size"},{"line_number":16,"context_line":" - master_volume_type"},{"line_number":17,"context_line":" - minion_volume_size"},{"line_number":18,"context_line":" - minion_volume_type"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I02c6ec6944cf9d1e3c4cdc589785c05d84421a65"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"658323e5_9f76e523","line":17,"range":{"start_line":17,"start_character":3,"end_line":17,"end_character":9},"in_reply_to":"0510f944_152063d3","updated":"2022-11-21 13:01:30.000000000","message":"Done","commit_id":"a84980b794dab6a2efcb643df3e23a0ccfbbec00"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"ff4572dd4d2ae8c68bf93a69667912a2ea4fa735","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"ddc54c81_14a8f38b","updated":"2022-07-15 09:59:22.000000000","message":"I fixed the points we\u0027ve been talking about, I think it should be fine now :)\n","commit_id":"832f75e461a068786e6f766854a9bc0daf5e9bab"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1d7707c1ea014f3f0c08c005dea9bfcca2591263","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"6e91c14c_5962c2a5","updated":"2022-07-18 09:27:54.000000000","message":"Looking much cleaner now.","commit_id":"31223f85fadd67d7a6478b48b00a145e00584354"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"93373375e3346fcbb299ccca76aeee442e812db1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"eade1ef6_81c452bb","updated":"2022-07-18 13:09:20.000000000","message":"Rebased on WebTest fix","commit_id":"1ae1fb5d416817e9ab1beb6a291949e556046c9b"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"52fdbaa5e8c64dbfff9903e01f8c6e404bc8b564","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"ac38d37d_a6146a30","updated":"2022-11-22 09:52:07.000000000","message":"Can you create a story and we discuss use case in there please?\n\nI may be working on something related.","commit_id":"49333a88770f2155f95ca41b1d3e84f9cb98972c"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"953e5ec9bcf349e7471d8eed161ce0b7ce734303","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"4abc8ad5_c11adfa1","updated":"2022-11-09 11:30:56.000000000","message":"There is a few things we may be able to improve, but I think there is a bigger question I have.\n\nI recently worked on this part of the code due to another bug. I find the logic here really complicated and I\u0027m not sure if adding more complexity to this is a good idea.\n\nIs this really important for your organisation, or can we hold off this in light of the ClusterAPI work? I rather not add more complexity to this if possible. If this is really important I might have to refactor the logic here. Please let me know, thanks!","commit_id":"49333a88770f2155f95ca41b1d3e84f9cb98972c"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"318212e0ee1a2ad7fe07e541558c5e04ddad57e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"baa5bcdc_d8d84fb1","in_reply_to":"4abc8ad5_c11adfa1","updated":"2022-11-21 13:01:30.000000000","message":"I agree the logic could use some simplification - took me a bit to wrap my head around it when I started working on this. To simplify things at least a bit I removed boot_volume_(size|type) from the nodes yamls completely as suggested by mark@stackhpc.com.\n\nThis feature however is a bit important, it allows us to use different pools for master/workers which was an enforced requirement.","commit_id":"49333a88770f2155f95ca41b1d3e84f9cb98972c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"81475ce0d875d6adcb3b77a1e3e059d70428b710","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":24,"id":"fe3246b8_6b6e6ee1","in_reply_to":"9537fceb_9a6df72f","updated":"2023-03-20 10:24:56.000000000","message":"Please add it to the commit message (https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references)","commit_id":"49333a88770f2155f95ca41b1d3e84f9cb98972c"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"b856a9f4318a81363ca7d7ed5e93a0dd4344c08a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"9537fceb_9a6df72f","in_reply_to":"ac38d37d_a6146a30","updated":"2023-02-28 16:41:10.000000000","message":"I opened a story here:\nhttps://storyboard.openstack.org/#!/story/2010622","commit_id":"49333a88770f2155f95ca41b1d3e84f9cb98972c"}],"doc/source/user/index.rst":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2b5fa34b74869fcd1d75543e2ced8b3174954e78","unresolved":true,"context_lines":[{"line_number":1171,"context_line":"  The default value corresponds to the one recommended in this doc"},{"line_number":1172,"context_line":"  for our current Kubernetes version."},{"line_number":1173,"context_line":""},{"line_number":1174,"context_line":"_`boot_volume_size`"},{"line_number":1175,"context_line":"  This label overrides the default_boot_volume_size of instances which is"},{"line_number":1176,"context_line":"  useful if your flavors are boot from volume only. The default value is 0,"},{"line_number":1177,"context_line":"  meaning that cluster instances will not boot from volume unless"},{"line_number":1178,"context_line":"  master_volume_size or minion_volume_size is defined. This label has"},{"line_number":1179,"context_line":"  lower priority than abovementioned and can be overridden by them."},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"_`boot_volume_type`"},{"line_number":1182,"context_line":"  This label overrides the default_boot_volume_type of instances which is"}],"source_content_type":"text/x-rst","patch_set":12,"id":"f2353e4a_b8318154","line":1179,"range":{"start_line":1174,"start_character":0,"end_line":1179,"end_character":67},"updated":"2022-07-05 08:30:24.000000000","message":"It seems more complicated than this, because of the new config values (default_master_volume_type etc). I think the precedence is now:\n\nmaster_volume_X, default_master_volume_X, boot_volume_X, default_boot_volume_X\n\nIs that how you want it to work?","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"ff4572dd4d2ae8c68bf93a69667912a2ea4fa735","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"  The default value corresponds to the one recommended in this doc"},{"line_number":1172,"context_line":"  for our current Kubernetes version."},{"line_number":1173,"context_line":""},{"line_number":1174,"context_line":"_`boot_volume_size`"},{"line_number":1175,"context_line":"  This label overrides the default_boot_volume_size of instances which is"},{"line_number":1176,"context_line":"  useful if your flavors are boot from volume only. The default value is 0,"},{"line_number":1177,"context_line":"  meaning that cluster instances will not boot from volume unless"},{"line_number":1178,"context_line":"  master_volume_size or minion_volume_size is defined. This label has"},{"line_number":1179,"context_line":"  lower priority than abovementioned and can be overridden by them."},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"_`boot_volume_type`"},{"line_number":1182,"context_line":"  This label overrides the default_boot_volume_type of instances which is"}],"source_content_type":"text/x-rst","patch_set":12,"id":"71fb0111_0ff64d39","line":1179,"range":{"start_line":1174,"start_character":0,"end_line":1179,"end_character":67},"in_reply_to":"58f1b55e_ec61f49a","updated":"2022-07-15 09:59:22.000000000","message":"I removed default master and minion volume sizes - in case they\u0027re missing they fall back straight to boot volume size. Updating docs accordingly.","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9cb0547d2ab7ff8745a7ab7afbb7d5082e6bfcb9","unresolved":true,"context_lines":[{"line_number":1171,"context_line":"  The default value corresponds to the one recommended in this doc"},{"line_number":1172,"context_line":"  for our current Kubernetes version."},{"line_number":1173,"context_line":""},{"line_number":1174,"context_line":"_`boot_volume_size`"},{"line_number":1175,"context_line":"  This label overrides the default_boot_volume_size of instances which is"},{"line_number":1176,"context_line":"  useful if your flavors are boot from volume only. The default value is 0,"},{"line_number":1177,"context_line":"  meaning that cluster instances will not boot from volume unless"},{"line_number":1178,"context_line":"  master_volume_size or minion_volume_size is defined. This label has"},{"line_number":1179,"context_line":"  lower priority than abovementioned and can be overridden by them."},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"_`boot_volume_type`"},{"line_number":1182,"context_line":"  This label overrides the default_boot_volume_type of instances which is"}],"source_content_type":"text/x-rst","patch_set":12,"id":"58f1b55e_ec61f49a","line":1179,"range":{"start_line":1174,"start_character":0,"end_line":1179,"end_character":67},"in_reply_to":"c6c40b0e_7bac2963","updated":"2022-07-05 12:37:03.000000000","message":"Ok. That precedence at least needs to be documented, since the docs don\u0027t mention the new default_master_volume_X config options.","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"327ef165dad1eda91a0499b295e705f97727bfa3","unresolved":true,"context_lines":[{"line_number":1171,"context_line":"  The default value corresponds to the one recommended in this doc"},{"line_number":1172,"context_line":"  for our current Kubernetes version."},{"line_number":1173,"context_line":""},{"line_number":1174,"context_line":"_`boot_volume_size`"},{"line_number":1175,"context_line":"  This label overrides the default_boot_volume_size of instances which is"},{"line_number":1176,"context_line":"  useful if your flavors are boot from volume only. The default value is 0,"},{"line_number":1177,"context_line":"  meaning that cluster instances will not boot from volume unless"},{"line_number":1178,"context_line":"  master_volume_size or minion_volume_size is defined. This label has"},{"line_number":1179,"context_line":"  lower priority than abovementioned and can be overridden by them."},{"line_number":1180,"context_line":""},{"line_number":1181,"context_line":"_`boot_volume_type`"},{"line_number":1182,"context_line":"  This label overrides the default_boot_volume_type of instances which is"}],"source_content_type":"text/x-rst","patch_set":12,"id":"c6c40b0e_7bac2963","line":1179,"range":{"start_line":1174,"start_character":0,"end_line":1179,"end_character":67},"in_reply_to":"f2353e4a_b8318154","updated":"2022-07-05 12:20:57.000000000","message":"Yes that was the idea from the beginning - to use (master|minion)_volume_ vars if we want to override specific type of node, fallback to boot_volume if absent.","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"}],"magnum/drivers/heat/k8s_fedora_template_def.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2b5fa34b74869fcd1d75543e2ced8b3174954e78","unresolved":true,"context_lines":[{"line_number":247,"context_line":"        if int(master_volume_size) \u003e 0 or int(boot_volume_size) \u003e 0:"},{"line_number":248,"context_line":"            master_volume_type \u003d cluster.labels.get("},{"line_number":249,"context_line":"                \u0027master_volume_type\u0027,"},{"line_number":250,"context_line":"                cinder.get_default_master_volume_type(context))"},{"line_number":251,"context_line":"        else:"},{"line_number":252,"context_line":"            master_volume_type \u003d \u0027\u0027"},{"line_number":253,"context_line":"        extra_params[\u0027master_volume_type\u0027] \u003d master_volume_type"}],"source_content_type":"text/x-python","patch_set":12,"id":"e2889161_49414a59","line":250,"range":{"start_line":250,"start_character":16,"end_line":250,"end_character":62},"updated":"2022-07-05 08:30:24.000000000","message":"This will always be defined, because it falls back to a random type.","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"ff4572dd4d2ae8c68bf93a69667912a2ea4fa735","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        if int(master_volume_size) \u003e 0 or int(boot_volume_size) \u003e 0:"},{"line_number":248,"context_line":"            master_volume_type \u003d cluster.labels.get("},{"line_number":249,"context_line":"                \u0027master_volume_type\u0027,"},{"line_number":250,"context_line":"                cinder.get_default_master_volume_type(context))"},{"line_number":251,"context_line":"        else:"},{"line_number":252,"context_line":"            master_volume_type \u003d \u0027\u0027"},{"line_number":253,"context_line":"        extra_params[\u0027master_volume_type\u0027] \u003d master_volume_type"}],"source_content_type":"text/x-python","patch_set":12,"id":"424bb878_544e8576","line":250,"range":{"start_line":250,"start_character":16,"end_line":250,"end_character":62},"in_reply_to":"363197ba_71687990","updated":"2022-07-15 09:59:22.000000000","message":"Fixed that, now master and minion volume types no longer use \"random\" configuration if missing - they just take the value from boot_volume_type instead.","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9cb0547d2ab7ff8745a7ab7afbb7d5082e6bfcb9","unresolved":true,"context_lines":[{"line_number":247,"context_line":"        if int(master_volume_size) \u003e 0 or int(boot_volume_size) \u003e 0:"},{"line_number":248,"context_line":"            master_volume_type \u003d cluster.labels.get("},{"line_number":249,"context_line":"                \u0027master_volume_type\u0027,"},{"line_number":250,"context_line":"                cinder.get_default_master_volume_type(context))"},{"line_number":251,"context_line":"        else:"},{"line_number":252,"context_line":"            master_volume_type \u003d \u0027\u0027"},{"line_number":253,"context_line":"        extra_params[\u0027master_volume_type\u0027] \u003d master_volume_type"}],"source_content_type":"text/x-python","patch_set":12,"id":"363197ba_71687990","line":250,"range":{"start_line":250,"start_character":16,"end_line":250,"end_character":62},"in_reply_to":"8ad96e26_d1217ac2","updated":"2022-07-05 12:37:03.000000000","message":"ok, concrete example.\n\nmaster_volume_type unset\ndefault_master_volume_type unset\nboot_volume_type \u003d foo\nboot_volume_size \u003d 1\n\nIn this case, we would pass in master_volume_type as a random volume type. In the template, that random volume type would override the requested boot_volume_type of foo.\n\nThe fix is to never return a random type from get_default_master_volume_type.","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"327ef165dad1eda91a0499b295e705f97727bfa3","unresolved":true,"context_lines":[{"line_number":247,"context_line":"        if int(master_volume_size) \u003e 0 or int(boot_volume_size) \u003e 0:"},{"line_number":248,"context_line":"            master_volume_type \u003d cluster.labels.get("},{"line_number":249,"context_line":"                \u0027master_volume_type\u0027,"},{"line_number":250,"context_line":"                cinder.get_default_master_volume_type(context))"},{"line_number":251,"context_line":"        else:"},{"line_number":252,"context_line":"            master_volume_type \u003d \u0027\u0027"},{"line_number":253,"context_line":"        extra_params[\u0027master_volume_type\u0027] \u003d master_volume_type"}],"source_content_type":"text/x-python","patch_set":12,"id":"8ad96e26_d1217ac2","line":250,"range":{"start_line":250,"start_character":16,"end_line":250,"end_character":62},"in_reply_to":"e2889161_49414a59","updated":"2022-07-05 12:20:57.000000000","message":"Do you mean master_volume_type? It will fall back to random type by cluster.labels.get() if master_volume_type missing from labels, unless (master|boot)_volume_size in line 247 equals 0 (default when not defined) then it sets master_volume_type to empty string in 252. \n\nThis again, is used inside heat templates, in conditions - copying logical solution from original boot_volume_type label.\n\nSo basically if volume size is set (which is evaluated in heat template conditional to recognize if instance will be image or volume based) then we care about master volume type. Disregard otherwise.\n\nThis follows the original behaviour of boot_volume_type. Or am I missing something?","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2b5fa34b74869fcd1d75543e2ced8b3174954e78","unresolved":true,"context_lines":[{"line_number":256,"context_line":"        if int(minion_volume_size) \u003e 0 or int(boot_volume_size) \u003e 0:"},{"line_number":257,"context_line":"            minion_volume_type \u003d cluster.labels.get("},{"line_number":258,"context_line":"                \u0027minion_volume_type\u0027,"},{"line_number":259,"context_line":"                cinder.get_default_minion_volume_type(context))"},{"line_number":260,"context_line":"        else:"},{"line_number":261,"context_line":"            minion_volume_type \u003d \u0027\u0027"},{"line_number":262,"context_line":"        extra_params[\u0027minion_volume_type\u0027] \u003d minion_volume_type"}],"source_content_type":"text/x-python","patch_set":12,"id":"045e8ec0_e03cc81d","line":259,"range":{"start_line":259,"start_character":16,"end_line":259,"end_character":63},"updated":"2022-07-05 08:30:24.000000000","message":"ditto","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"ff4572dd4d2ae8c68bf93a69667912a2ea4fa735","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        if int(minion_volume_size) \u003e 0 or int(boot_volume_size) \u003e 0:"},{"line_number":257,"context_line":"            minion_volume_type \u003d cluster.labels.get("},{"line_number":258,"context_line":"                \u0027minion_volume_type\u0027,"},{"line_number":259,"context_line":"                cinder.get_default_minion_volume_type(context))"},{"line_number":260,"context_line":"        else:"},{"line_number":261,"context_line":"            minion_volume_type \u003d \u0027\u0027"},{"line_number":262,"context_line":"        extra_params[\u0027minion_volume_type\u0027] \u003d minion_volume_type"}],"source_content_type":"text/x-python","patch_set":12,"id":"0641b1bb_3f9186e2","line":259,"range":{"start_line":259,"start_character":16,"end_line":259,"end_character":63},"in_reply_to":"045e8ec0_e03cc81d","updated":"2022-07-15 09:59:22.000000000","message":"Done","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1d7707c1ea014f3f0c08c005dea9bfcca2591263","unresolved":true,"context_lines":[{"line_number":240,"context_line":"        boot_volume_type \u003d (cluster.labels.get("},{"line_number":241,"context_line":"            \u0027boot_volume_type\u0027,"},{"line_number":242,"context_line":"            cinder.get_default_boot_volume_type(context))"},{"line_number":243,"context_line":"            if (int(boot_volume_size) or"},{"line_number":244,"context_line":"                int(master_volume_size) or"},{"line_number":245,"context_line":"                int(minion_volume_size)) \u003e 0 else \u0027\u0027)"},{"line_number":246,"context_line":"        extra_params[\u0027boot_volume_type\u0027] \u003d boot_volume_type"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # set master_volume_type"}],"source_content_type":"text/x-python","patch_set":17,"id":"3965a02e_5c3493cd","line":245,"range":{"start_line":243,"start_character":0,"end_line":245,"end_character":53},"updated":"2022-07-18 09:27:54.000000000","message":"I think this condition will be covered by L249 and L255, so could be removed.","commit_id":"31223f85fadd67d7a6478b48b00a145e00584354"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"318212e0ee1a2ad7fe07e541558c5e04ddad57e8","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        boot_volume_type \u003d (cluster.labels.get("},{"line_number":241,"context_line":"            \u0027boot_volume_type\u0027,"},{"line_number":242,"context_line":"            cinder.get_default_boot_volume_type(context))"},{"line_number":243,"context_line":"            if (int(boot_volume_size) or"},{"line_number":244,"context_line":"                int(master_volume_size) or"},{"line_number":245,"context_line":"                int(minion_volume_size)) \u003e 0 else \u0027\u0027)"},{"line_number":246,"context_line":"        extra_params[\u0027boot_volume_type\u0027] \u003d boot_volume_type"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # set master_volume_type"}],"source_content_type":"text/x-python","patch_set":17,"id":"64713159_69bd3356","line":245,"range":{"start_line":243,"start_character":0,"end_line":245,"end_character":53},"in_reply_to":"3965a02e_5c3493cd","updated":"2022-11-21 13:01:30.000000000","message":"With boot_volume_size not set, master_volume_size and boot_volume_type present in the labels, this would cause boot_volume_type to be set wrong to \u0027\u0027 in L245. With master_volume_type not set it would be expected to fallback to boot_volume_type in L250. We need to set boot_volume_type if master/worker_volume_size is used, even if boot_volume_size is not used - to allow for using boot_volume_type+master_volume_size+minion_volume_size combo.","commit_id":"31223f85fadd67d7a6478b48b00a145e00584354"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1d7707c1ea014f3f0c08c005dea9bfcca2591263","unresolved":true,"context_lines":[{"line_number":243,"context_line":"            if (int(boot_volume_size) or"},{"line_number":244,"context_line":"                int(master_volume_size) or"},{"line_number":245,"context_line":"                int(minion_volume_size)) \u003e 0 else \u0027\u0027)"},{"line_number":246,"context_line":"        extra_params[\u0027boot_volume_type\u0027] \u003d boot_volume_type"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # set master_volume_type"},{"line_number":249,"context_line":"        if int(master_volume_size) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":17,"id":"b6824f76_b730f6f8","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":59},"updated":"2022-07-18 09:27:54.000000000","message":"This will never get used. If boot_volume_size is set, master_volume_size will default to it. That means on L249 we will specify master_volume_type.\n\nBetter to just remove the original boot_* parameters from the template?\n\n(same with L227)","commit_id":"31223f85fadd67d7a6478b48b00a145e00584354"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"4d7bf4f327e187db80e6ee06eaf92bd43b3aae73","unresolved":true,"context_lines":[{"line_number":243,"context_line":"            if (int(boot_volume_size) or"},{"line_number":244,"context_line":"                int(master_volume_size) or"},{"line_number":245,"context_line":"                int(minion_volume_size)) \u003e 0 else \u0027\u0027)"},{"line_number":246,"context_line":"        extra_params[\u0027boot_volume_type\u0027] \u003d boot_volume_type"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # set master_volume_type"},{"line_number":249,"context_line":"        if int(master_volume_size) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":17,"id":"3d2e11c1_e59d4731","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":59},"in_reply_to":"b4abce84_3a6b636c","updated":"2022-11-21 14:41:14.000000000","message":"Since, in the templates we no longer use boot_volume_type maybe we can drop this completely? (and pass only master/worker_volume_type)","commit_id":"31223f85fadd67d7a6478b48b00a145e00584354"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8238ffd73665f7ed94bf69717d98c07564f3b144","unresolved":true,"context_lines":[{"line_number":243,"context_line":"            if (int(boot_volume_size) or"},{"line_number":244,"context_line":"                int(master_volume_size) or"},{"line_number":245,"context_line":"                int(minion_volume_size)) \u003e 0 else \u0027\u0027)"},{"line_number":246,"context_line":"        extra_params[\u0027boot_volume_type\u0027] \u003d boot_volume_type"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # set master_volume_type"},{"line_number":249,"context_line":"        if int(master_volume_size) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":17,"id":"b4abce84_3a6b636c","line":246,"range":{"start_line":246,"start_character":8,"end_line":246,"end_character":59},"in_reply_to":"b6824f76_b730f6f8","updated":"2022-11-21 13:17:26.000000000","message":"Still needs fixing","commit_id":"31223f85fadd67d7a6478b48b00a145e00584354"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1d7707c1ea014f3f0c08c005dea9bfcca2591263","unresolved":true,"context_lines":[{"line_number":246,"context_line":"        extra_params[\u0027boot_volume_type\u0027] \u003d boot_volume_type"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # set master_volume_type"},{"line_number":249,"context_line":"        if int(master_volume_size) \u003e 0:"},{"line_number":250,"context_line":"            master_volume_type \u003d cluster.labels.get("},{"line_number":251,"context_line":"                \u0027master_volume_type\u0027, boot_volume_type)"},{"line_number":252,"context_line":"            extra_params[\u0027master_volume_type\u0027] \u003d master_volume_type"}],"source_content_type":"text/x-python","patch_set":17,"id":"21d82deb_bd86e2a4","line":249,"range":{"start_line":249,"start_character":8,"end_line":249,"end_character":39},"updated":"2022-07-18 09:27:54.000000000","message":"There\u0027s no default value for these parameters in the template. Won\u0027t that be a problem if we are conditionally passing them in?","commit_id":"31223f85fadd67d7a6478b48b00a145e00584354"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"318212e0ee1a2ad7fe07e541558c5e04ddad57e8","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        extra_params[\u0027boot_volume_type\u0027] \u003d boot_volume_type"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # set master_volume_type"},{"line_number":249,"context_line":"        if int(master_volume_size) \u003e 0:"},{"line_number":250,"context_line":"            master_volume_type \u003d cluster.labels.get("},{"line_number":251,"context_line":"                \u0027master_volume_type\u0027, boot_volume_type)"},{"line_number":252,"context_line":"            extra_params[\u0027master_volume_type\u0027] \u003d master_volume_type"}],"source_content_type":"text/x-python","patch_set":17,"id":"e697928e_3d1281ac","line":249,"range":{"start_line":249,"start_character":8,"end_line":249,"end_character":39},"in_reply_to":"21d82deb_bd86e2a4","updated":"2022-11-21 13:01:30.000000000","message":"I don\u0027t think so - in L230 we set it to boot_volume_size if master_volume_size is not present. So master/worker_volume_size will always be set to \u0027some\u0027 value.","commit_id":"31223f85fadd67d7a6478b48b00a145e00584354"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8238ffd73665f7ed94bf69717d98c07564f3b144","unresolved":true,"context_lines":[{"line_number":222,"context_line":"            if int(etcd_volume_size) \u003e 0 else \u0027\u0027)"},{"line_number":223,"context_line":"        extra_params[\u0027etcd_volume_type\u0027] \u003d etcd_volume_type"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        # set boot_volume_size"},{"line_number":226,"context_line":"        boot_volume_size \u003d cluster.labels.get("},{"line_number":227,"context_line":"            \u0027boot_volume_size\u0027, CONF.cinder.default_boot_volume_size)"},{"line_number":228,"context_line":"        extra_params[\u0027boot_volume_size\u0027] \u003d boot_volume_size"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        # set master_volume_size"},{"line_number":231,"context_line":"        master_volume_size \u003d cluster.labels.get("}],"source_content_type":"text/x-python","patch_set":24,"id":"f629914d_9bdf6db6","line":228,"range":{"start_line":225,"start_character":0,"end_line":228,"end_character":59},"updated":"2022-11-21 13:17:26.000000000","message":"No need to provide this","commit_id":"49333a88770f2155f95ca41b1d3e84f9cb98972c"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"4d7bf4f327e187db80e6ee06eaf92bd43b3aae73","unresolved":true,"context_lines":[{"line_number":222,"context_line":"            if int(etcd_volume_size) \u003e 0 else \u0027\u0027)"},{"line_number":223,"context_line":"        extra_params[\u0027etcd_volume_type\u0027] \u003d etcd_volume_type"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        # set boot_volume_size"},{"line_number":226,"context_line":"        boot_volume_size \u003d cluster.labels.get("},{"line_number":227,"context_line":"            \u0027boot_volume_size\u0027, CONF.cinder.default_boot_volume_size)"},{"line_number":228,"context_line":"        extra_params[\u0027boot_volume_size\u0027] \u003d boot_volume_size"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        # set master_volume_size"},{"line_number":231,"context_line":"        master_volume_size \u003d cluster.labels.get("}],"source_content_type":"text/x-python","patch_set":24,"id":"c6b5fb85_8ddf62fc","line":228,"range":{"start_line":225,"start_character":0,"end_line":228,"end_character":59},"in_reply_to":"f629914d_9bdf6db6","updated":"2022-11-21 14:41:14.000000000","message":"Makes sense, I\u0027ll remove that.","commit_id":"49333a88770f2155f95ca41b1d3e84f9cb98972c"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"953e5ec9bcf349e7471d8eed161ce0b7ce734303","unresolved":true,"context_lines":[{"line_number":247,"context_line":"        extra_params[\u0027boot_volume_type\u0027] \u003d boot_volume_type"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # set master_volume_type"},{"line_number":250,"context_line":"        if int(master_volume_size) \u003e 0:"},{"line_number":251,"context_line":"            master_volume_type \u003d cluster.labels.get("},{"line_number":252,"context_line":"                \u0027master_volume_type\u0027, boot_volume_type)"},{"line_number":253,"context_line":"            extra_params[\u0027master_volume_type\u0027] \u003d master_volume_type"}],"source_content_type":"text/x-python","patch_set":24,"id":"44649077_c290c5bf","line":250,"range":{"start_line":250,"start_character":0,"end_line":250,"end_character":39},"updated":"2022-11-09 11:30:56.000000000","message":"I think we do not need this check if you are not doing `cinder.get_default_boot_volume()` or similar calls. Setting a type do not any harm if size\u003d0?","commit_id":"49333a88770f2155f95ca41b1d3e84f9cb98972c"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"318212e0ee1a2ad7fe07e541558c5e04ddad57e8","unresolved":true,"context_lines":[{"line_number":247,"context_line":"        extra_params[\u0027boot_volume_type\u0027] \u003d boot_volume_type"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # set master_volume_type"},{"line_number":250,"context_line":"        if int(master_volume_size) \u003e 0:"},{"line_number":251,"context_line":"            master_volume_type \u003d cluster.labels.get("},{"line_number":252,"context_line":"                \u0027master_volume_type\u0027, boot_volume_type)"},{"line_number":253,"context_line":"            extra_params[\u0027master_volume_type\u0027] \u003d master_volume_type"}],"source_content_type":"text/x-python","patch_set":24,"id":"778fc083_bedaef15","line":250,"range":{"start_line":250,"start_character":0,"end_line":250,"end_character":39},"in_reply_to":"44649077_c290c5bf","updated":"2022-11-21 13:01:30.000000000","message":"Indeed, it looks like this conditional could be dropped. In kubemaster/mimion yaml we use _volume_size in conditional so setting (master|worker)_volume_type should not interfere.\n\nI would like to test if it wouldn\u0027t fail in case of image based nodes.","commit_id":"49333a88770f2155f95ca41b1d3e84f9cb98972c"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"953e5ec9bcf349e7471d8eed161ce0b7ce734303","unresolved":true,"context_lines":[{"line_number":253,"context_line":"            extra_params[\u0027master_volume_type\u0027] \u003d master_volume_type"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        # set worker_volume_type"},{"line_number":256,"context_line":"        if int(worker_volume_size) \u003e 0:"},{"line_number":257,"context_line":"            worker_volume_type \u003d cluster.labels.get("},{"line_number":258,"context_line":"                \u0027worker_volume_type\u0027, boot_volume_type)"},{"line_number":259,"context_line":"            extra_params[\u0027worker_volume_type\u0027] \u003d worker_volume_type"}],"source_content_type":"text/x-python","patch_set":24,"id":"1106f787_8e5e0d39","line":256,"range":{"start_line":256,"start_character":0,"end_line":256,"end_character":39},"updated":"2022-11-09 11:30:56.000000000","message":"similar to the above","commit_id":"49333a88770f2155f95ca41b1d3e84f9cb98972c"}],"magnum/drivers/k8s_fedora_coreos_v1/templates/kubecluster.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2b5fa34b74869fcd1d75543e2ced8b3174954e78","unresolved":true,"context_lines":[{"line_number":236,"context_line":"    constraints:"},{"line_number":237,"context_line":"      - allowed_values: [\"true\", \"false\"]"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"  boot_volume_size:"},{"line_number":240,"context_line":"    type: number"},{"line_number":241,"context_line":"    description: \u003e"},{"line_number":242,"context_line":"      size of the cinder boot volume for nodes root volume"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"  boot_volume_type:"},{"line_number":245,"context_line":"    type: string"},{"line_number":246,"context_line":"    description: \u003e"},{"line_number":247,"context_line":"      type of the cinder boot volume for nodes root volume"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"  master_volume_size:"},{"line_number":250,"context_line":"    type: number"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"26f48f48_5f9329fa","line":247,"range":{"start_line":239,"start_character":0,"end_line":247,"end_character":58},"updated":"2022-07-05 08:30:24.000000000","message":"I would suggest removing these parameters, and performing the logic in Python where life is sane.\n\nIf you do that, you would not need to change kubemaster.yaml and kubeminion.yaml.","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"327ef165dad1eda91a0499b295e705f97727bfa3","unresolved":true,"context_lines":[{"line_number":236,"context_line":"    constraints:"},{"line_number":237,"context_line":"      - allowed_values: [\"true\", \"false\"]"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"  boot_volume_size:"},{"line_number":240,"context_line":"    type: number"},{"line_number":241,"context_line":"    description: \u003e"},{"line_number":242,"context_line":"      size of the cinder boot volume for nodes root volume"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"  boot_volume_type:"},{"line_number":245,"context_line":"    type: string"},{"line_number":246,"context_line":"    description: \u003e"},{"line_number":247,"context_line":"      type of the cinder boot volume for nodes root volume"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"  master_volume_size:"},{"line_number":250,"context_line":"    type: number"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"e00708ea_906f69c6","line":247,"range":{"start_line":239,"start_character":0,"end_line":247,"end_character":58},"in_reply_to":"26f48f48_5f9329fa","updated":"2022-07-05 12:20:57.000000000","message":"I wanted to avoid tinkering with original boot_volume_(size_type) labels, as there are people out there using them and just needed to add labels allowing for separate values for master and minion for my use case. As nice as it would be to move logic off heat templates (which are driving me mad a bit) I had to consider it as out of scope of the current work I was doing.","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"ff4572dd4d2ae8c68bf93a69667912a2ea4fa735","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    constraints:"},{"line_number":237,"context_line":"      - allowed_values: [\"true\", \"false\"]"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"  boot_volume_size:"},{"line_number":240,"context_line":"    type: number"},{"line_number":241,"context_line":"    description: \u003e"},{"line_number":242,"context_line":"      size of the cinder boot volume for nodes root volume"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"  boot_volume_type:"},{"line_number":245,"context_line":"    type: string"},{"line_number":246,"context_line":"    description: \u003e"},{"line_number":247,"context_line":"      type of the cinder boot volume for nodes root volume"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"  master_volume_size:"},{"line_number":250,"context_line":"    type: number"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"66f209ef_689c9caf","line":247,"range":{"start_line":239,"start_character":0,"end_line":247,"end_character":58},"in_reply_to":"6a5352ee_3cf787ce","updated":"2022-07-15 09:59:22.000000000","message":"Removed boot volume size from templates, now master and minion volume sizes are always set on python size - using boot_volume_size if either of them is missing.\nI didn\u0027t want to \"quietly\" map boot_volume_size to master_volume_size as while indeed a nice solution I feel it would take away from readability.","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9cb0547d2ab7ff8745a7ab7afbb7d5082e6bfcb9","unresolved":true,"context_lines":[{"line_number":236,"context_line":"    constraints:"},{"line_number":237,"context_line":"      - allowed_values: [\"true\", \"false\"]"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"  boot_volume_size:"},{"line_number":240,"context_line":"    type: number"},{"line_number":241,"context_line":"    description: \u003e"},{"line_number":242,"context_line":"      size of the cinder boot volume for nodes root volume"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"  boot_volume_type:"},{"line_number":245,"context_line":"    type: string"},{"line_number":246,"context_line":"    description: \u003e"},{"line_number":247,"context_line":"      type of the cinder boot volume for nodes root volume"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"  master_volume_size:"},{"line_number":250,"context_line":"    type: number"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"6a5352ee_3cf787ce","line":247,"range":{"start_line":239,"start_character":0,"end_line":247,"end_character":58},"in_reply_to":"e00708ea_906f69c6","updated":"2022-07-05 12:37:03.000000000","message":"I agree it\u0027s important to maintain backwards compatibility with the old labels.\n\nI\u0027m only suggesting to remove the parameters in the cluster template. They would still be handled as labels by the Python code. But the template only needs to know the final value of size \u0026 type for the master \u0026 minions.\n\nIf it helps, try to consider these parameters as separate from the labels.","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2b5fa34b74869fcd1d75543e2ced8b3174954e78","unresolved":true,"context_lines":[{"line_number":1286,"context_line":"          kube_allow_priv: {get_param: kube_allow_priv}"},{"line_number":1287,"context_line":"          boot_volume_size: {get_param: boot_volume_size}"},{"line_number":1288,"context_line":"          boot_volume_type: {get_param: boot_volume_type}"},{"line_number":1289,"context_line":"          master_volume_size: {get_param: master_volume_size}"},{"line_number":1290,"context_line":"          master_volume_type: {get_param: master_volume_type}"},{"line_number":1291,"context_line":"          etcd_volume_size: {get_param: etcd_volume_size}"},{"line_number":1292,"context_line":"          etcd_volume_type: {get_param: etcd_volume_type}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"f0bdec91_a1b9f57b","line":1289,"range":{"start_line":1289,"start_character":10,"end_line":1289,"end_character":61},"updated":"2022-07-05 08:30:24.000000000","message":"This would be boot_volume_size: {get_param: master_volume_size}","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"ff4572dd4d2ae8c68bf93a69667912a2ea4fa735","unresolved":false,"context_lines":[{"line_number":1286,"context_line":"          kube_allow_priv: {get_param: kube_allow_priv}"},{"line_number":1287,"context_line":"          boot_volume_size: {get_param: boot_volume_size}"},{"line_number":1288,"context_line":"          boot_volume_type: {get_param: boot_volume_type}"},{"line_number":1289,"context_line":"          master_volume_size: {get_param: master_volume_size}"},{"line_number":1290,"context_line":"          master_volume_type: {get_param: master_volume_type}"},{"line_number":1291,"context_line":"          etcd_volume_size: {get_param: etcd_volume_size}"},{"line_number":1292,"context_line":"          etcd_volume_type: {get_param: etcd_volume_type}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"21eeb5a9_7e66bec6","line":1289,"range":{"start_line":1289,"start_character":10,"end_line":1289,"end_character":61},"in_reply_to":"f0bdec91_a1b9f57b","updated":"2022-07-15 09:59:22.000000000","message":"Ack","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8238ffd73665f7ed94bf69717d98c07564f3b144","unresolved":true,"context_lines":[{"line_number":236,"context_line":"    constraints:"},{"line_number":237,"context_line":"      - allowed_values: [\"true\", \"false\"]"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"  boot_volume_size:"},{"line_number":240,"context_line":"    type: number"},{"line_number":241,"context_line":"    description: \u003e"},{"line_number":242,"context_line":"      size of the cinder boot volume for nodes root volume"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"  boot_volume_type:"},{"line_number":245,"context_line":"    type: string"},{"line_number":246,"context_line":"    description: \u003e"},{"line_number":247,"context_line":"      type of the cinder boot volume for nodes root volume"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"  master_volume_size:"},{"line_number":250,"context_line":"    type: number"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"72ab8fd0_6d113461","line":247,"range":{"start_line":239,"start_character":0,"end_line":247,"end_character":58},"updated":"2022-11-21 13:17:26.000000000","message":"These are unused in this template and should be removed.","commit_id":"49333a88770f2155f95ca41b1d3e84f9cb98972c"}],"magnum/tests/unit/conductor/handlers/test_k8s_cluster_conductor.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2b5fa34b74869fcd1d75543e2ced8b3174954e78","unresolved":true,"context_lines":[{"line_number":104,"context_line":"                       \u0027kube_dashboard_enabled\u0027: \u0027True\u0027,"},{"line_number":105,"context_line":"                       \u0027docker_volume_type\u0027: \u0027lvmdriver-1\u0027,"},{"line_number":106,"context_line":"                       \u0027availability_zone\u0027: \u0027az_1\u0027,"},{"line_number":107,"context_line":"                       \u0027cert_manager_api\u0027: \u0027False\u0027,"},{"line_number":108,"context_line":"                       \u0027ingress_controller\u0027: \u0027i-controller\u0027,"},{"line_number":109,"context_line":"                       \u0027ingress_controller_role\u0027: \u0027i-controller-role\u0027,"},{"line_number":110,"context_line":"                       \u0027kubelet_options\u0027: \u0027--kubelet\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3ea7e4fe_df9177bb","line":107,"updated":"2022-07-05 08:30:24.000000000","message":"You\u0027re not really testing the new logic in here. With all the boot, master and minion fields set and set to the same value, how to we know where the results are coming from?\n\nProbably the existing tests should check the standard case when the new labels are not set (or at least set them to a different value).\n\nIt needs at least one (possibly more) new test that verifies the new logic.","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"327ef165dad1eda91a0499b295e705f97727bfa3","unresolved":true,"context_lines":[{"line_number":104,"context_line":"                       \u0027kube_dashboard_enabled\u0027: \u0027True\u0027,"},{"line_number":105,"context_line":"                       \u0027docker_volume_type\u0027: \u0027lvmdriver-1\u0027,"},{"line_number":106,"context_line":"                       \u0027availability_zone\u0027: \u0027az_1\u0027,"},{"line_number":107,"context_line":"                       \u0027cert_manager_api\u0027: \u0027False\u0027,"},{"line_number":108,"context_line":"                       \u0027ingress_controller\u0027: \u0027i-controller\u0027,"},{"line_number":109,"context_line":"                       \u0027ingress_controller_role\u0027: \u0027i-controller-role\u0027,"},{"line_number":110,"context_line":"                       \u0027kubelet_options\u0027: \u0027--kubelet\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9c0523eb_bb1573d2","line":107,"in_reply_to":"3ea7e4fe_df9177bb","updated":"2022-07-05 12:20:57.000000000","message":"This makes sense, will work on that.","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"},{"author":{"_account_id":34076,"name":"Jakub Darmach","email":"jakub@stackhpc.com","username":"darmach"},"change_message_id":"ff4572dd4d2ae8c68bf93a69667912a2ea4fa735","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                       \u0027kube_dashboard_enabled\u0027: \u0027True\u0027,"},{"line_number":105,"context_line":"                       \u0027docker_volume_type\u0027: \u0027lvmdriver-1\u0027,"},{"line_number":106,"context_line":"                       \u0027availability_zone\u0027: \u0027az_1\u0027,"},{"line_number":107,"context_line":"                       \u0027cert_manager_api\u0027: \u0027False\u0027,"},{"line_number":108,"context_line":"                       \u0027ingress_controller\u0027: \u0027i-controller\u0027,"},{"line_number":109,"context_line":"                       \u0027ingress_controller_role\u0027: \u0027i-controller-role\u0027,"},{"line_number":110,"context_line":"                       \u0027kubelet_options\u0027: \u0027--kubelet\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"871020f3_893fb196","line":107,"in_reply_to":"9c0523eb_bb1573d2","updated":"2022-07-15 09:59:22.000000000","message":"I might add new test in future patchset, for now changed to used values so we are testing:\n1. falling back to boot_volume_size with master_volume_size\n2. falling back to boot_volume_type with master_volume_type\n3. minion_volume_type using different type than boot_volume_type\n4. minion_volume_size using different size than boot_volume_size","commit_id":"82cfde4a597d234b544e27f5d161f288b9531272"}]}