)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a04f3222aa05d04b3dca4a6ab1d16a271ee54a95","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Pass additional args to helm command to set/override values yaml"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Proposed approach for passing some values into the helm install command."},{"line_number":10,"context_line":"Some OS builds and kubernetes versions require additional arguments to bootstrap properly i.e."},{"line_number":11,"context_line":"Ubuntu 22.04 with k8s v1.26.*, v1.27.*."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0d106f50_f98e9ac8","line":9,"updated":"2023-05-19 14:13:05.000000000","message":"I don\u0027t dislike this idea, helm overrides in the template.\n\nAlthough I think we need to first make the existing labels and cluster and template properties work. I fixed up ssh keys and DNS after I broken them in my refactoring work (sorry about that!).","commit_id":"d5f07b780cfe0da06737447ed886d051fcf3c229"},{"author":{"_account_id":35921,"name":"Travis Holton","email":"travisholton+ubuntuone@catalystcloud.nz","username":"travisholton"},"change_message_id":"7d792a0d35ebd42dfa5be4362653c49c89cb384c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Pass additional args to helm command to set/override values yaml"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Proposed approach for passing some values into the helm install command."},{"line_number":10,"context_line":"Some OS builds and kubernetes versions require additional arguments to bootstrap properly i.e."},{"line_number":11,"context_line":"Ubuntu 22.04 with k8s v1.26.*, v1.27.*."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a0b12959_eb652cc8","line":9,"in_reply_to":"0d106f50_f98e9ac8","updated":"2023-05-19 18:26:58.000000000","message":"No worries! \nNote that this proposal is just about the ability to override some values at a later stage. The examples I listed were needed to get my devstack cluster to start.\n\nIn the future though we will certainly need to override some settings, particularly the imageRepository (eg airgapped clusters in private clouds). Some may be better to do via config actually.","commit_id":"d5f07b780cfe0da06737447ed886d051fcf3c229"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"52da43e8cfb539c547bd7f5f037895a5a07b7ecd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Pass additional args to helm command to set/override values yaml"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Proposed approach for passing some values into the helm install command."},{"line_number":10,"context_line":"Some OS builds and kubernetes versions require additional arguments to bootstrap properly i.e."},{"line_number":11,"context_line":"Ubuntu 22.04 with k8s v1.26.*, v1.27.*."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4f522f7e_9bf41d05","line":9,"in_reply_to":"33e858fa_d7114a33","updated":"2023-05-20 09:43:11.000000000","message":"Yes, I have a preference for either config, or having a custom chart the wraps with your own defaults.\n\nWe have some CI for the chart which you should be able to run against more custom values, isolated from magnum.","commit_id":"d5f07b780cfe0da06737447ed886d051fcf3c229"},{"author":{"_account_id":35921,"name":"Travis Holton","email":"travisholton+ubuntuone@catalystcloud.nz","username":"travisholton"},"change_message_id":"4b378e9a76826fb73ca71d5ffe6b358827641e3e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Pass additional args to helm command to set/override values yaml"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Proposed approach for passing some values into the helm install command."},{"line_number":10,"context_line":"Some OS builds and kubernetes versions require additional arguments to bootstrap properly i.e."},{"line_number":11,"context_line":"Ubuntu 22.04 with k8s v1.26.*, v1.27.*."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"33e858fa_d7114a33","line":9,"in_reply_to":"a0b12959_eb652cc8","updated":"2023-05-19 21:09:00.000000000","message":"Ack","commit_id":"d5f07b780cfe0da06737447ed886d051fcf3c229"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a04f3222aa05d04b3dca4a6ab1d16a271ee54a95","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Examples:"},{"line_number":14,"context_line":"* set up the SSH key on hosts (machineSSHKeyName)"},{"line_number":15,"context_line":"* Pass DNS networking (clusterNetworking.dnsNameservers)"},{"line_number":16,"context_line":"* Pass extra arguments for kubeletExtraArgs to mitigate known issue with"},{"line_number":17,"context_line":"  systemd-resolved (see https://kubernetes.io/docs/tasks/administer-cluster/dns-debugging-resolution/#known-issues)"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7767e083_b33d8d24","line":15,"updated":"2023-05-19 14:13:05.000000000","message":"So these first two are covered in the driver now.","commit_id":"d5f07b780cfe0da06737447ed886d051fcf3c229"},{"author":{"_account_id":35921,"name":"Travis Holton","email":"travisholton+ubuntuone@catalystcloud.nz","username":"travisholton"},"change_message_id":"7d792a0d35ebd42dfa5be4362653c49c89cb384c","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Examples:"},{"line_number":14,"context_line":"* set up the SSH key on hosts (machineSSHKeyName)"},{"line_number":15,"context_line":"* Pass DNS networking (clusterNetworking.dnsNameservers)"},{"line_number":16,"context_line":"* Pass extra arguments for kubeletExtraArgs to mitigate known issue with"},{"line_number":17,"context_line":"  systemd-resolved (see https://kubernetes.io/docs/tasks/administer-cluster/dns-debugging-resolution/#known-issues)"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e57908ee_f288920b","line":15,"in_reply_to":"7767e083_b33d8d24","updated":"2023-05-19 18:26:58.000000000","message":"Ack","commit_id":"d5f07b780cfe0da06737447ed886d051fcf3c229"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a04f3222aa05d04b3dca4a6ab1d16a271ee54a95","unresolved":true,"context_lines":[{"line_number":14,"context_line":"* set up the SSH key on hosts (machineSSHKeyName)"},{"line_number":15,"context_line":"* Pass DNS networking (clusterNetworking.dnsNameservers)"},{"line_number":16,"context_line":"* Pass extra arguments for kubeletExtraArgs to mitigate known issue with"},{"line_number":17,"context_line":"  systemd-resolved (see https://kubernetes.io/docs/tasks/administer-cluster/dns-debugging-resolution/#known-issues)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Currently passing as a single comma separated string. However this will"},{"line_number":20,"context_line":"be modified in future patches to serialised json."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0ef5a80b_15bf8a13","line":17,"updated":"2023-05-19 14:13:05.000000000","message":"hmm, this is news to me @MattP did we see this yet?\n\n... I wonder if this should actually be an image property? As I guess its specific to the image you choose?","commit_id":"d5f07b780cfe0da06737447ed886d051fcf3c229"},{"author":{"_account_id":35921,"name":"Travis Holton","email":"travisholton+ubuntuone@catalystcloud.nz","username":"travisholton"},"change_message_id":"7d792a0d35ebd42dfa5be4362653c49c89cb384c","unresolved":true,"context_lines":[{"line_number":14,"context_line":"* set up the SSH key on hosts (machineSSHKeyName)"},{"line_number":15,"context_line":"* Pass DNS networking (clusterNetworking.dnsNameservers)"},{"line_number":16,"context_line":"* Pass extra arguments for kubeletExtraArgs to mitigate known issue with"},{"line_number":17,"context_line":"  systemd-resolved (see https://kubernetes.io/docs/tasks/administer-cluster/dns-debugging-resolution/#known-issues)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Currently passing as a single comma separated string. However this will"},{"line_number":20,"context_line":"be modified in future patches to serialised json."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"63c1c599_5d4dfe08","line":17,"in_reply_to":"0ef5a80b_15bf8a13","updated":"2023-05-19 18:26:58.000000000","message":"I ran into this a while ago using Ubuntu 22.04 and k8s \u003e\u003d 1.26.* so I\u0027ve been adding it as a default in my own testing. It may indeed make more sense as an image property.","commit_id":"d5f07b780cfe0da06737447ed886d051fcf3c229"},{"author":{"_account_id":35921,"name":"Travis Holton","email":"travisholton+ubuntuone@catalystcloud.nz","username":"travisholton"},"change_message_id":"116b0c8d5f7491574d07ddd0ae1a8be578f68cb7","unresolved":true,"context_lines":[{"line_number":14,"context_line":"* set up the SSH key on hosts (machineSSHKeyName)"},{"line_number":15,"context_line":"* Pass DNS networking (clusterNetworking.dnsNameservers)"},{"line_number":16,"context_line":"* Pass extra arguments for kubeletExtraArgs to mitigate known issue with"},{"line_number":17,"context_line":"  systemd-resolved (see https://kubernetes.io/docs/tasks/administer-cluster/dns-debugging-resolution/#known-issues)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Currently passing as a single comma separated string. However this will"},{"line_number":20,"context_line":"be modified in future patches to serialised json."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e959e130_67140e50","line":17,"in_reply_to":"63c1c599_5d4dfe08","updated":"2023-05-19 21:08:09.000000000","message":"I just tested ubuntu-22.04 with 1.27.1 without the resolv-conf override and didn\u0027t seem to run into the issues I had before. Maybe this was something I introduced when I built the images earlier.","commit_id":"d5f07b780cfe0da06737447ed886d051fcf3c229"},{"author":{"_account_id":35921,"name":"Travis Holton","email":"travisholton+ubuntuone@catalystcloud.nz","username":"travisholton"},"change_message_id":"4b378e9a76826fb73ca71d5ffe6b358827641e3e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"* set up the SSH key on hosts (machineSSHKeyName)"},{"line_number":15,"context_line":"* Pass DNS networking (clusterNetworking.dnsNameservers)"},{"line_number":16,"context_line":"* Pass extra arguments for kubeletExtraArgs to mitigate known issue with"},{"line_number":17,"context_line":"  systemd-resolved (see https://kubernetes.io/docs/tasks/administer-cluster/dns-debugging-resolution/#known-issues)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Currently passing as a single comma separated string. However this will"},{"line_number":20,"context_line":"be modified in future patches to serialised json."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6f8eee45_7481eb04","line":17,"in_reply_to":"e959e130_67140e50","updated":"2023-05-19 21:09:00.000000000","message":"Ack","commit_id":"d5f07b780cfe0da06737447ed886d051fcf3c229"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35921,"name":"Travis Holton","email":"travisholton+ubuntuone@catalystcloud.nz","username":"travisholton"},"change_message_id":"63509e69933b62242a8e6af9b1ba577a186c1014","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d56e7867_f5e256d8","updated":"2023-05-18 02:47:36.000000000","message":"As we discussed in IRC, I\u0027ll work on doing this with serialised JSON datastructure. Keen on any feedback regarding code and naming conventions.","commit_id":"d90eef05ad114b579cba6137f73ff3fd0cef44ca"},{"author":{"_account_id":29425,"name":"Diogo Guerra","email":"diogo.filipe.tomas.guerra@cern.ch","username":"dioguerra"},"change_message_id":"bbe15ef9b00ae040a14fa416f2372e80f04821ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d727c925_476fea7d","updated":"2023-05-22 08:24:58.000000000","message":"@Travis\n\nThere is an old MR to add requirements.yaml and values.yaml to the magnum utility (at the time this was on Helm V2)\n\nInstead of adding a label just to do this we should allow the client to get a Chart.yaml and values.yaml (for the new Helm) where we would basically pass the values base64 encoded (from yaml or json) and you would save this in the DB.\n\nHave a look into the project proposals\n\nAlso, if you do this, it would be nice if every Helm 2 compatibility was removed.","commit_id":"c6f574f7d971369dbebcb5162c1685cd8ff18e19"},{"author":{"_account_id":35921,"name":"Travis Holton","email":"travisholton+ubuntuone@catalystcloud.nz","username":"travisholton"},"change_message_id":"116b0c8d5f7491574d07ddd0ae1a8be578f68cb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"77e97749_915b0e9b","updated":"2023-05-19 21:08:09.000000000","message":"following up review comments","commit_id":"c6f574f7d971369dbebcb5162c1685cd8ff18e19"}],"magnum/drivers/cluster_api/driver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a04f3222aa05d04b3dca4a6ab1d16a271ee54a95","unresolved":true,"context_lines":[{"line_number":394,"context_line":"                for ng in nodegroups"},{"line_number":395,"context_line":"                if ng.role !\u003d NODE_GROUP_ROLE_CONTROLER"},{"line_number":396,"context_line":"            ],"},{"line_number":397,"context_line":"        }"},{"line_number":398,"context_line":"        self._helm_client.install_or_upgrade("},{"line_number":399,"context_line":"            self._sanitised_name(cluster.name),"},{"line_number":400,"context_line":"            MAGNUM_HELM_CHART_NAME,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a725a18f_23dfe26f","line":397,"updated":"2023-05-19 14:13:05.000000000","message":"I would rather we actually merge the values in here, making sure they don\u0027t override any keys we have already set from \"more important\" places.","commit_id":"d5f07b780cfe0da06737447ed886d051fcf3c229"},{"author":{"_account_id":35921,"name":"Travis Holton","email":"travisholton+ubuntuone@catalystcloud.nz","username":"travisholton"},"change_message_id":"7d792a0d35ebd42dfa5be4362653c49c89cb384c","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                for ng in nodegroups"},{"line_number":395,"context_line":"                if ng.role !\u003d NODE_GROUP_ROLE_CONTROLER"},{"line_number":396,"context_line":"            ],"},{"line_number":397,"context_line":"        }"},{"line_number":398,"context_line":"        self._helm_client.install_or_upgrade("},{"line_number":399,"context_line":"            self._sanitised_name(cluster.name),"},{"line_number":400,"context_line":"            MAGNUM_HELM_CHART_NAME,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9acf120b_861c8904","line":397,"in_reply_to":"a725a18f_23dfe26f","updated":"2023-05-19 18:26:58.000000000","message":"Ack","commit_id":"d5f07b780cfe0da06737447ed886d051fcf3c229"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a04f3222aa05d04b3dca4a6ab1d16a271ee54a95","unresolved":true,"context_lines":[{"line_number":402,"context_line":"            repo\u003dMAGNUM_HELM_CHART_REPO,"},{"line_number":403,"context_line":"            version\u003dMAGNUM_HELM_CHART_VERSION,"},{"line_number":404,"context_line":"            namespace\u003dself._namespace(cluster),"},{"line_number":405,"context_line":"            helm_extra_args\u003dself._label(cluster, \"helm_extra_args\", \"\"),"},{"line_number":406,"context_line":"        )"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    def _k8s_resource_labels(self, cluster):"}],"source_content_type":"text/x-python","patch_set":2,"id":"20c820cb_0701aae4","line":405,"updated":"2023-05-19 14:13:05.000000000","message":"This is user supplied input, that we are sending to a privileged shell environment we will need some careful validation of that here.","commit_id":"d5f07b780cfe0da06737447ed886d051fcf3c229"},{"author":{"_account_id":35921,"name":"Travis Holton","email":"travisholton+ubuntuone@catalystcloud.nz","username":"travisholton"},"change_message_id":"7d792a0d35ebd42dfa5be4362653c49c89cb384c","unresolved":false,"context_lines":[{"line_number":402,"context_line":"            repo\u003dMAGNUM_HELM_CHART_REPO,"},{"line_number":403,"context_line":"            version\u003dMAGNUM_HELM_CHART_VERSION,"},{"line_number":404,"context_line":"            namespace\u003dself._namespace(cluster),"},{"line_number":405,"context_line":"            helm_extra_args\u003dself._label(cluster, \"helm_extra_args\", \"\"),"},{"line_number":406,"context_line":"        )"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    def _k8s_resource_labels(self, cluster):"}],"source_content_type":"text/x-python","patch_set":2,"id":"975f5be7_38443a44","line":405,"in_reply_to":"20c820cb_0701aae4","updated":"2023-05-19 18:26:58.000000000","message":"Ack","commit_id":"d5f07b780cfe0da06737447ed886d051fcf3c229"}]}