)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"7399f478917f602fcc152c1482dbc99a6d8f6d6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5346f522_830758e0","updated":"2024-04-15 20:09:07.000000000","message":"I would like to see this merged so I can stop patching our local install :)  I\u0027m happy to split this into two patches if core would prefer a distinct patch for the misnamed variable fix.","commit_id":"f02c10c9897eaaefa386a5ab20701a18a174df44"},{"author":{"_account_id":36095,"name":"Vivian Rook","display_name":"Vivian Rook","email":"vrook@wikimedia.org","username":"vrook"},"change_message_id":"57243d330078ebc4517d81617a97c0135b69c11b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"68981f2b_1cafd274","updated":"2024-04-15 20:32:29.000000000","message":"I don\u0027t believe this is necessary any longer, a fcos upgrade on my part seems to have things in working order.","commit_id":"0df3e8aa0aaa8eaf887bbd95e073e6bf29e0e529"}],"magnum/drivers/common/templates/kubernetes/fragments/start-container-agent.sh":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f8dab0d33b74ac724857aee013b7c2a2fc10059d","unresolved":true,"context_lines":[{"line_number":58,"context_line":"# Maximum size of log files (in bytes)"},{"line_number":59,"context_line":"# -1 is unlimited"},{"line_number":60,"context_line":"# 50m"},{"line_number":61,"context_line":"log_size_max \u003d 52428800"},{"line_number":62,"context_line":"EOF"},{"line_number":63,"context_line":"    cat \u003e /etc/systemd/system/heat-container-agent.service \u003c\u003cEOF"},{"line_number":64,"context_line":"[Unit]"}],"source_content_type":"text/x-sh","patch_set":1,"id":"6dee7dde_7e4889ab","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":12},"updated":"2023-06-20 09:03:47.000000000","message":"has the variable name changed?","commit_id":"f02c10c9897eaaefa386a5ab20701a18a174df44"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"7399f478917f602fcc152c1482dbc99a6d8f6d6c","unresolved":true,"context_lines":[{"line_number":58,"context_line":"# Maximum size of log files (in bytes)"},{"line_number":59,"context_line":"# -1 is unlimited"},{"line_number":60,"context_line":"# 50m"},{"line_number":61,"context_line":"log_size_max \u003d 52428800"},{"line_number":62,"context_line":"EOF"},{"line_number":63,"context_line":"    cat \u003e /etc/systemd/system/heat-container-agent.service \u003c\u003cEOF"},{"line_number":64,"context_line":"[Unit]"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3b2d6ade_cd549ae1","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":12},"in_reply_to":"20a91383_bdab278c","updated":"2024-04-15 20:09:07.000000000","message":"I\u0027ve been googling and don\u0027t see any evidence that there was ever a variable called max_log_size. Likely this was a mistake in the original code that was never noticed.","commit_id":"f02c10c9897eaaefa386a5ab20701a18a174df44"},{"author":{"_account_id":36095,"name":"Vivian Rook","display_name":"Vivian Rook","email":"vrook@wikimedia.org","username":"vrook"},"change_message_id":"b9d196d94a35e85a03bc6a683ab9f74ca17df2ac","unresolved":true,"context_lines":[{"line_number":58,"context_line":"# Maximum size of log files (in bytes)"},{"line_number":59,"context_line":"# -1 is unlimited"},{"line_number":60,"context_line":"# 50m"},{"line_number":61,"context_line":"log_size_max \u003d 52428800"},{"line_number":62,"context_line":"EOF"},{"line_number":63,"context_line":"    cat \u003e /etc/systemd/system/heat-container-agent.service \u003c\u003cEOF"},{"line_number":64,"context_line":"[Unit]"}],"source_content_type":"text/x-sh","patch_set":1,"id":"20a91383_bdab278c","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":12},"in_reply_to":"6dee7dde_7e4889ab","updated":"2023-06-20 12:08:01.000000000","message":"Apparently? Or perhaps it was always \"log_size_max\"? I first found it:\nhttps://www.suse.com/support/kb/doc/?id\u003d000019954\nThough other places mention the same\nhttps://github.com/unifi-utilities/unifios-utilities/issues/100\nhttps://github.com/containers/common/blob/main/docs/containers.conf.5.md\n\nI tested it by updating the control node (that was deployed by magnum) and restarting it. It seemed to work. Though I agree, it seems odd that the variable name would change.","commit_id":"f02c10c9897eaaefa386a5ab20701a18a174df44"}]}