)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"407b52b96728571552b3db45497888652d8ecd4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7784339f_bd67beca","updated":"2023-08-25 04:31:24.000000000","message":"Hi Jake, I\u0027m happy enough with this method and have a couple of minor implementation comments. It\u0027ll help us merge the CAPI driver while we work on it for stability and removing from beta status.\n\nThere is a (I suspect rarely used) CLI tool for Magnum called `magnum-driver-manage` that returns a list of drivers and details of them (using `magnum-driver-manage list-drivers --details --paths`). Adding a Beta column to this may be a good idea as this will become a relevant attribute of drivers.\n\nI\u0027ve got a patchset that will fix the tool for the CAPI driver, and add the Beta column. I\u0027ll rebase onto this, and push it shortly.","commit_id":"ffe7ce9eb63126e261f0bbb49ec74cdfc502b232"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"c54f908222e3671a5fc29d7b7b3054477c876b26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f38789fb_1a38acea","updated":"2023-08-18 23:36:37.000000000","message":"Hi all, I\u0027m keen to get the capi driver in if we can mark it as beta for users.\nPlease see if this method is ok.\nWe can sort out patch order if the method is ok.","commit_id":"ffe7ce9eb63126e261f0bbb49ec74cdfc502b232"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"1550ab24570384b4ff532266ad9259ce4ee1b700","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a9b76d52_c5ff5d63","updated":"2023-08-25 04:59:10.000000000","message":"I\u0027ve created two `magnum-driver-manage` related changesets:\n1. Add beta property to magnum-driver-manage, rebased onto this patchset. https://review.opendev.org/c/openstack/magnum/+/892729\n2. A fix for magnum-driver-manage for use with the CAPI driver. It does not require CAPI driver, so is rebased directly on master. https://review.opendev.org/c/openstack/magnum/+/892728","commit_id":"ffe7ce9eb63126e261f0bbb49ec74cdfc502b232"}],"magnum/conf/drivers.py":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3398eaf4e40465fe8f903571e6e760d0c82c47bf","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    cfg.ListOpt(\u0027enabled_beta_drivers\u0027,"},{"line_number":40,"context_line":"                default\u003d[],"},{"line_number":41,"context_line":"                help\u003d\u0027List of beta drivers to enable. Beta drivers are not \u0027"},{"line_number":42,"context_line":"                     \u0027 intended for produciton. Defaults to []. \u0027"},{"line_number":43,"context_line":"                ),"},{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6d767ddf_498d6e34","line":42,"range":{"start_line":42,"start_character":36,"end_line":42,"end_character":46},"updated":"2023-08-22 08:59:30.000000000","message":"production","commit_id":"ffe7ce9eb63126e261f0bbb49ec74cdfc502b232"}],"magnum/drivers/common/driver.py":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"407b52b96728571552b3db45497888652d8ecd4b","unresolved":true,"context_lines":[{"line_number":134,"context_line":"                coe\u003dcoe)"},{"line_number":135,"context_line":"        driver_info \u003d definition_map[cluster_type]"},{"line_number":136,"context_line":"        driver_name \u003d driver_info[\u0027entry_point_name\u0027]"},{"line_number":137,"context_line":"        beta \u003d driver_info[\u0027beta\u0027]"},{"line_number":138,"context_line":"        if (beta and"},{"line_number":139,"context_line":"                driver_name not in CONF.drivers.enabled_beta_drivers):"},{"line_number":140,"context_line":"            LOG.debug(f\"Driver {driver_name} is beta \""}],"source_content_type":"text/x-python","patch_set":1,"id":"f95537a0_dc5b89c9","line":137,"updated":"2023-08-25 04:31:24.000000000","message":"This line could become:\n   `beta \u003d driver_info[\u0027class\u0027].beta`\n\nAnd then the line 88 would not be required. Using a class variable shouldn\u0027t require instantiation of the class before use, so no need for `()` as in L88.","commit_id":"ffe7ce9eb63126e261f0bbb49ec74cdfc502b232"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"407b52b96728571552b3db45497888652d8ecd4b","unresolved":true,"context_lines":[{"line_number":137,"context_line":"        beta \u003d driver_info[\u0027beta\u0027]"},{"line_number":138,"context_line":"        if (beta and"},{"line_number":139,"context_line":"                driver_name not in CONF.drivers.enabled_beta_drivers):"},{"line_number":140,"context_line":"            LOG.debug(f\"Driver {driver_name} is beta \""},{"line_number":141,"context_line":"                      \"and needs to be explicitly enabled with \""},{"line_number":142,"context_line":"                      \"[drivers]/enabled_beta_drivers.\")"},{"line_number":143,"context_line":"            raise exception.ClusterTypeNotSupported("}],"source_content_type":"text/x-python","patch_set":1,"id":"7917c6f4_cf065bff","line":140,"updated":"2023-08-25 04:31:24.000000000","message":"Raising this to `info` logging may be helpful to understanding the failure in some environments. I agree that exposing this to the user isn\u0027t the right way (as they aren\u0027t exposed to internal driver names), so logging the information is good.","commit_id":"ffe7ce9eb63126e261f0bbb49ec74cdfc502b232"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f8e4a08c3ec6c5c1aae58d1fe2a61fa5aac16122","unresolved":true,"context_lines":[{"line_number":137,"context_line":"        beta \u003d driver_info[\u0027beta\u0027]"},{"line_number":138,"context_line":"        if (beta and"},{"line_number":139,"context_line":"                driver_name not in CONF.drivers.enabled_beta_drivers):"},{"line_number":140,"context_line":"            LOG.debug(f\"Driver {driver_name} is beta \""},{"line_number":141,"context_line":"                      \"and needs to be explicitly enabled with \""},{"line_number":142,"context_line":"                      \"[drivers]/enabled_beta_drivers.\")"},{"line_number":143,"context_line":"            raise exception.ClusterTypeNotSupported("}],"source_content_type":"text/x-python","patch_set":1,"id":"670f972e_33e8df2e","line":140,"in_reply_to":"7917c6f4_cf065bff","updated":"2023-08-30 08:38:12.000000000","message":"+1 I would be tempted by having it as a warning?","commit_id":"ffe7ce9eb63126e261f0bbb49ec74cdfc502b232"}]}