)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"8b4855b19813ebebc7acb75bcb367ee05a6f6c7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eaef8ab5_0ae04d19","updated":"2023-09-20 21:35:47.000000000","message":"The CLI output from this change is:\n```\n$ openstack coe cluster upgrade a0d4dcb6-b34e-474b-92f3-22e98eb23076 kubernetes-v1.26.9-prod-20230914\nThe Heat driver does not implement in-place upgrades (HTTP 500) (Request-ID: req-b021da42-a804-43a5-81e6-e664a8821d9b)\n```\n\nAnd the Horizon dashboard has the (less helpful) message: \"ERROR: Unable to perform rolling upgrade.\"","commit_id":"d8c200d622da0acc50079b1a9e57b46d4ea3874f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1f072e8796c428e0c51636945adea6d95b9880cd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4edd9b26_8ee12e18","updated":"2023-09-21 06:12:56.000000000","message":"What about magnum-ui? Should we drop the upgrade button?","commit_id":"d8c200d622da0acc50079b1a9e57b46d4ea3874f"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"8d7e25e0043fc5196aad2e1d90b7efefe0cc2cb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7b36dbf5_8709a158","updated":"2023-09-21 00:20:30.000000000","message":"looks good! we also need a reno please.\n(-1 for visibility)","commit_id":"d8c200d622da0acc50079b1a9e57b46d4ea3874f"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"e30650810de67cd43bcf6a6adbbfe947343e826c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8ad1216c_4e9038a6","in_reply_to":"4edd9b26_8ee12e18","updated":"2023-10-03 01:47:28.000000000","message":"Not entirely - because this change is driver specific and CAPI will soon provide the upgrade functionality.\n\nIt would be nice to surface a better message than ERROR, however - or remove the button when the driver doesn\u0027t support it.\n\nAs a separate piece of work, I was considering implementing a new endpoint in magnum-api that lists templates that are upgrade candidates for a given cluster. This would a) prevent implementing this logic in two places as it has been done, and b) allow Heat driver to provide no upgrade candidates.","commit_id":"d8c200d622da0acc50079b1a9e57b46d4ea3874f"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"473732276297a6864f8a11f415a82a22808404a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fd72ada0_a8e4ddc3","in_reply_to":"8ad1216c_4e9038a6","updated":"2023-10-10 06:24:05.000000000","message":"Done","commit_id":"d8c200d622da0acc50079b1a9e57b46d4ea3874f"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"3d72c8a7f1fef80189305ca00dd2b6a783ab0203","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"490a659f_6b522cce","updated":"2023-10-19 15:25:54.000000000","message":"apologies for late reply","commit_id":"1c63e1e6e8abfab8a823ede93c22b32ed89111b2"}],"magnum/drivers/heat/driver.py":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1f072e8796c428e0c51636945adea6d95b9880cd","unresolved":true,"context_lines":[{"line_number":388,"context_line":"        # - Cluster API drivers, that leverage kubeadm and upgrades with node"},{"line_number":389,"context_line":"        #   replacement."},{"line_number":390,"context_line":"        # See also: https://vexxhost.com/blog/cluster-api-driver-openstack-magnum/"},{"line_number":391,"context_line":"        raise NotImplementedError(\"The Heat driver does not implement in-place\""},{"line_number":392,"context_line":"                                  \" upgrades.\")"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def get_nodegroup_extra_params(self, cluster, osc):"}],"source_content_type":"text/x-python","patch_set":1,"id":"38fbf5d7_3bdd9e12","line":391,"range":{"start_line":391,"start_character":70,"end_line":391,"end_character":78},"updated":"2023-09-21 06:12:56.000000000","message":"maybe just upgrades instead of in-place upgrades?","commit_id":"d8c200d622da0acc50079b1a9e57b46d4ea3874f"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"e30650810de67cd43bcf6a6adbbfe947343e826c","unresolved":true,"context_lines":[{"line_number":388,"context_line":"        # - Cluster API drivers, that leverage kubeadm and upgrades with node"},{"line_number":389,"context_line":"        #   replacement."},{"line_number":390,"context_line":"        # See also: https://vexxhost.com/blog/cluster-api-driver-openstack-magnum/"},{"line_number":391,"context_line":"        raise NotImplementedError(\"The Heat driver does not implement in-place\""},{"line_number":392,"context_line":"                                  \" upgrades.\")"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def get_nodegroup_extra_params(self, cluster, osc):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3d10617b_3623a9d4","line":391,"range":{"start_line":391,"start_character":70,"end_line":391,"end_character":78},"in_reply_to":"38fbf5d7_3bdd9e12","updated":"2023-10-03 01:47:28.000000000","message":"good point, that\u0027s more consistent terminology. I will update","commit_id":"d8c200d622da0acc50079b1a9e57b46d4ea3874f"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"34ab04bd4924763382287654a4081155e6c70269","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        # - Cluster API drivers, that leverage kubeadm and upgrades with node"},{"line_number":389,"context_line":"        #   replacement."},{"line_number":390,"context_line":"        # See also: https://vexxhost.com/blog/cluster-api-driver-openstack-magnum/"},{"line_number":391,"context_line":"        raise NotImplementedError(\"The Heat driver does not implement in-place\""},{"line_number":392,"context_line":"                                  \" upgrades.\")"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def get_nodegroup_extra_params(self, cluster, osc):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d902d453_31df8fb2","line":391,"range":{"start_line":391,"start_character":70,"end_line":391,"end_character":78},"in_reply_to":"3d10617b_3623a9d4","updated":"2023-10-10 06:23:31.000000000","message":"Done","commit_id":"d8c200d622da0acc50079b1a9e57b46d4ea3874f"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"3d72c8a7f1fef80189305ca00dd2b6a783ab0203","unresolved":true,"context_lines":[{"line_number":330,"context_line":"        # - Blue-green deployments, by creating a new cluster."},{"line_number":331,"context_line":"        # - Cluster API drivers, that leverage kubeadm and upgrades with node"},{"line_number":332,"context_line":"        #   replacement."},{"line_number":333,"context_line":"        raise NotImplementedError(\"The Heat driver does not implement \""},{"line_number":334,"context_line":"                                  \"cluster upgrades.\")"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def get_nodegroup_extra_params(self, cluster, osc):"}],"source_content_type":"text/x-python","patch_set":4,"id":"e73b6c6a_4bc4c66d","line":333,"range":{"start_line":333,"start_character":14,"end_line":333,"end_character":33},"updated":"2023-10-19 15:25:54.000000000","message":"I think using exception.NotSupported here may be more appropriate","commit_id":"1c63e1e6e8abfab8a823ede93c22b32ed89111b2"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"61a860f197b9b578929aadf2b0689c96a49cd6be","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        # - Blue-green deployments, by creating a new cluster."},{"line_number":331,"context_line":"        # - Cluster API drivers, that leverage kubeadm and upgrades with node"},{"line_number":332,"context_line":"        #   replacement."},{"line_number":333,"context_line":"        raise NotImplementedError(\"The Heat driver does not implement \""},{"line_number":334,"context_line":"                                  \"cluster upgrades.\")"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def get_nodegroup_extra_params(self, cluster, osc):"}],"source_content_type":"text/x-python","patch_set":4,"id":"26e5102b_5ee48d99","line":333,"range":{"start_line":333,"start_character":14,"end_line":333,"end_character":33},"in_reply_to":"e73b6c6a_4bc4c66d","updated":"2023-12-20 04:38:20.000000000","message":"Done\n\nCLI upgrade message is now: `Upgrading a cluster that uses the Magnum Heat driver is not supported (HTTP 400) (Request-ID: req-9ae9d059-1f74-4389-966e-9f8207d9f6b8)`","commit_id":"1c63e1e6e8abfab8a823ede93c22b32ed89111b2"}]}