)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"8e109c31f3a930d392ccba1e5da68de474067cd0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0e3b4e5a_2296df46","updated":"2024-01-09 21:53:04.000000000","message":"Hi Oleksandr, can you explain more about the motivation for this?\n\nHow does this patchset improve the user experience when selecting a driver with an unsupported network driver? Doesn\u0027t it already produce an error when a cluster is attempted to be created, or does this change produce an error earlier on cluster template creation?\n\nI\u0027m not keen on the current tuple matching for driver, and adding more things to this already bulky set adds to that complexity.\n\nI wonder if we can achieve a similar goal with something that will cover many more situations.","commit_id":"626504e18916e702c16e40b83b584182a80c5300"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"fd2e494fd477a6ce4648d578e9aaa398cbdd0294","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"385bb5cf_16d000da","in_reply_to":"0e3b4e5a_2296df46","updated":"2024-01-10 15:30:19.000000000","message":"The reason for this is that we need to be able to support Cilium, because we support that in the Cluster API driver for Magnum.","commit_id":"626504e18916e702c16e40b83b584182a80c5300"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"85c038611d45b63d0909f7e889bec190fa1fc434","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9b2ee33b_e12ec0a4","in_reply_to":"2f6ba621_a9e8ad36","updated":"2024-01-15 21:55:43.000000000","message":"Thanks for the alternative patchset. I agree it\u0027s not perfect but we can make it less error-prone for users I think, and then we should be okay.\n\nIt\u0027d be better to delegate all validation to the driver interface and then Magnum doesn\u0027t need to be updated for the next network driver either. I\u0027ll be working on some related specs like this soon, I\u0027ll keep this particular one in mind, but happy for some help here.","commit_id":"626504e18916e702c16e40b83b584182a80c5300"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"743f69effd9d29659dde2d4fdf32d211408acc48","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6133bba8_d817334d","in_reply_to":"385bb5cf_16d000da","updated":"2024-01-10 15:30:42.000000000","message":"NOTE: https://github.com/vexxhost/magnum-cluster-api/pull/287","commit_id":"626504e18916e702c16e40b83b584182a80c5300"},{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"00b9f9f094e01be66d9dfa2f3a3b31ee743491b1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2f6ba621_a9e8ad36","in_reply_to":"6133bba8_d817334d","updated":"2024-01-12 10:00:58.000000000","message":"Hi Dale. It is what Mohammed mentioned already.\nOur goal is to implement cilium as network driver in the magnum-cluster-api driver. But because of the hard-coded supported_network_driver in magnum api validation code, it is not feasible.\nI created another patch to add cilium in the supported network driver list as hard-coded simply in parallel https://review.opendev.org/c/openstack/magnum/+/905427.\nBut I think it is not perfect because magnum upstream drivers don\u0027t support cilium.\nAs the another workaround, i thought to define `kubernetes_supported_network_drivers` as configuration parameter as the allowed list at the first time but the implementation of network drivers is done inside the cluster drivers so I made this patch.","commit_id":"626504e18916e702c16e40b83b584182a80c5300"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"bd552f5a06a90aa0d57e7132ad3692922e2f6e88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b09bb080_710d182b","updated":"2024-02-07 21:28:24.000000000","message":"-2 on this patchset, in favour of the alternative to allow cilium in https://review.opendev.org/c/openstack/magnum/+/905427","commit_id":"89f0023f9ab3a8269e6a370f058c15a2dd2a6098"}]}